[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to Master|RESOLVED --- Comment #11 from Nick Clemens --- Enhancement, skipping for stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 Katrin Fischer changed: What|Removed |Added Attachment #72640|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 73270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73270&action=edit Bug 19708: Improve code for printing the cart in OPAC This removes a lot of useless code relating to the print function from opac-basket.tt, opac-basket.pl and opac/basket.js. It also fixes the CSS so that no extra blank page is printed. To test: 0) Add an item to your cart 1) Print your basket Note the appearance of the page. There will be an extra blank page. 2) Apply patch 3) Reload basket 4) Print your basket The appearce should be identical. The extra blank page is gone. This only affects the OPAC. Signed-off-by: Tomás Cohen Arazi Signed-off-by: claude Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 --- Comment #8 from sandbo...@biblibre.com --- Created attachment 72640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72640&action=edit Bug 19708 - Remove useless code from opac-basket This removes a lot of useless code relating to the print function from opac-basket.tt, opac-basket.pl and opac/basket.js. It also fixes the CSS so that no extra blank page is printed. To test: 0) Add an item to your cart 1) Print your basket Note the appearance of the page. There will be an extra blank page. 2) Apply patch 3) Reload basket 4) Print your basket The appearce should be identical. The extra blank page is gone. This only affects the OPAC. Signed-off-by: Tomás Cohen Arazi Signed-off-by: Tomás Cohen Arazi Signed-off-by: Tomas Cohen Arazi Signed-off-by: claude -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 sandbo...@biblibre.com changed: What|Removed |Added Attachment #72613|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #7 from sandbo...@biblibre.com --- Patch tested with a sandbox, by claude -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 Maksim Sen changed: What|Removed |Added Attachment #69433|0 |1 is obsolete|| --- Comment #6 from Maksim Sen --- Created attachment 72613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72613&action=edit Bug 19708 - Remove useless code from opac-basket This removes a lot of useless code relating to the print function from opac-basket.tt, opac-basket.pl and opac/basket.js. It also fixes the CSS so that no extra blank page is printed. To test: 0) Add an item to your cart 1) Print your basket Note the appearance of the page. There will be an extra blank page. 2) Apply patch 3) Reload basket 4) Print your basket The appearce should be identical. The extra blank page is gone. This only affects the OPAC. Signed-off-by: Tomás Cohen Arazi Signed-off-by: Tomás Cohen Arazi Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 Maksim Sen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 --- Comment #5 from sandbo...@biblibre.com --- Created attachment 69433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69433&action=edit Bug 19708 - Remove useless code from opac-basket This removes a lot of useless code relating to the print function from opac-basket.tt, opac-basket.pl and opac/basket.js. It also fixes the CSS so that no extra blank page is printed. To test: 0) Add an item to your cart 1) Print your basket Note the appearance of the page. There will be an extra blank page. 2) Apply patch 3) Reload basket 4) Print your basket The appearce should be identical. The extra blank page is gone. This only affects the OPAC. Signed-off-by: Tomás Cohen Arazi Signed-off-by: Tomás Cohen Arazi Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 sandbo...@biblibre.com changed: What|Removed |Added Attachment #69432|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 --- Comment #4 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 --- Comment #3 from sandbo...@biblibre.com --- Created attachment 69432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69432&action=edit Bug 19708 - Remove useless code from opac-basket This removes a lot of useless code relating to the print function from opac-basket.tt, opac-basket.pl and opac/basket.js. It also fixes the CSS so that no extra blank page is printed. To test: 0) Add an item to your cart 1) Print your basket Note the appearance of the page. There will be an extra blank page. 2) Apply patch 3) Reload basket 4) Print your basket The appearce should be identical. The extra blank page is gone. This only affects the OPAC. Signed-off-by: Tomás Cohen Arazi Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 sandbo...@biblibre.com changed: What|Removed |Added Attachment #69417|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 sandbo...@biblibre.com changed: What|Removed |Added CC||sandbo...@biblibre.com Status|Needs Signoff |Signed Off --- Comment #2 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 Katrin Fischer changed: What|Removed |Added Keywords||Academy CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 David Bourgault changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 David Bourgault changed: What|Removed |Added CC||david.bourga...@inlibro.com ||, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 --- Comment #1 from David Bourgault --- Created attachment 69417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69417&action=edit Bug 19708 - Remove useless code from opac-basket This removes a lot of useless code relating to the print function from opac-basket.tt, opac-basket.pl and opac/basket.js. It also fixes the CSS so that no extra blank page is printed. To test: 0) Add an item to your cart 1) Print your basket Note the appearance of the page. There will be an extra blank page. 2) Apply patch 3) Reload basket 4) Print your basket The appearce should be identical. The extra blank page is gone. This only affects the OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
