[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Resolution|--- |FIXED
 Status|Pushed to Stable|RESOLVED

--- Comment #34 from Fridolin SOMERS  ---
Bug 17829 not in 17.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Nick Clemens  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||n...@bywatersolutions.com

--- Comment #33 from Nick Clemens  ---
All but last patch (translation) have been pushed to stable for 17.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #32 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #29 from Kyle M Hall  ---
Created attachment 69991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69991=edit
Bug 19808: Handle deleted reviewers gracefully - opac-showreview

Test plan:
- Create reviews
- Delete some reviewers
- Enable OpacShowRecentComments
- Go to opac/opac-showreviews.pl
- Go to opac-showreviews.pl?format=rss

Signed-off-by: Jon Knight 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #69934|0   |1
is obsolete||
  Attachment #69935|0   |1
is obsolete||
  Attachment #69936|0   |1
is obsolete||
  Attachment #69937|0   |1
is obsolete||
  Attachment #69938|0   |1
is obsolete||

--- Comment #27 from Kyle M Hall  ---
Created attachment 69989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69989=edit
Bug 19808: Handle deleted reviewers gracefully - opac-detail

And other display issues when the patron was NULL.
Which allows to keep the review even if it has no patron.
Because it might be useful.

For example when disconnected, the borrowernumber is null. So the
comments from deleted patrons were displayed as if the disconnected
user wrote them. So it had the edit button...

And fix borrowernumber not being passed to the template when
OpacStarRatings was false.

Test plan
1. Log in as a patron
2. Leave a comment/review on a record
3. Librarian: approve this comment
4. Delete the borrower
5. See the record
(opac:/cgi-bin/koha/opac-detail.pl?biblionumber=RELEVANT_BIB_NUMBER)
6. Then you should see an error
7. Apply this patch
8. Refresh the page
9. Then you should see the record page with the comment

Signed-off-by: Mark Tompsett 

Signed-off-by: Jon Knight 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #28 from Kyle M Hall  ---
Created attachment 69990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69990=edit
Bug 19808: (follow-up) Handle deleted reviewers gracefully - opac-detail

Make the tests easier to read

Signed-off-by: Jon Knight 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #30 from Kyle M Hall  ---
Created attachment 69992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69992=edit
Bug 19808: Handle deleted reviewers gracefully - reviews/reviewswaiting.pl

Test plan:
- Create reviews
- Delete some reviewers
- Go to Home › Tools › Comments › Comments awaiting moderation

Signed-off-by: Jon Knight 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #31 from Kyle M Hall  ---
Created attachment 69993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69993=edit
Bug 19808: Do not display 'Added' alone

It seems that reviews.datereviewed ends with NULL in DB.
It is caused by another issue that will be fixed on another bug report.

Signed-off-by: Jon Knight 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #25 from Jon Knight  ---
Created attachment 69937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69937=edit
[SIGNED-OFF] Bug 19808: Handle deleted reviewers gracefully -
reviews/reviewswaiting.pl

Test plan:
- Create reviews
- Delete some reviewers
- Go to Home › Tools › Comments › Comments awaiting moderation

Signed-off-by: Jon Knight 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #23 from Jon Knight  ---
Created attachment 69935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69935=edit
[SIGNED-OFF] Bug 19808: (follow-up) Handle deleted reviewers gracefully -
opac-detail

Make the tests easier to read

Signed-off-by: Jon Knight 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #26 from Jon Knight  ---
Created attachment 69938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69938=edit
[SIGNED-OFF] Bug 19808: Do not display 'Added' alone

It seems that reviews.datereviewed ends with NULL in DB.
It is caused by another issue that will be fixed on another bug report.

Signed-off-by: Jon Knight 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #24 from Jon Knight  ---
Created attachment 69936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69936=edit
[SIGNED-OFF] Bug 19808: Handle deleted reviewers gracefully - opac-showreview

Test plan:
- Create reviews
- Delete some reviewers
- Enable OpacShowRecentComments
- Go to opac/opac-showreviews.pl
- Go to opac-showreviews.pl?format=rss

Signed-off-by: Jon Knight 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jon Knight  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jon Knight  changed:

   What|Removed |Added

  Attachment #69853|0   |1
is obsolete||
  Attachment #69854|0   |1
is obsolete||
  Attachment #69855|0   |1
is obsolete||
  Attachment #69856|0   |1
is obsolete||
  Attachment #69926|0   |1
is obsolete||

--- Comment #22 from Jon Knight  ---
Created attachment 69934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69934=edit
[SIGNED-OFF] Bug 19808: Handle deleted reviewers gracefully - opac-detail

And other display issues when the patron was NULL.
Which allows to keep the review even if it has no patron.
Because it might be useful.

For example when disconnected, the borrowernumber is null. So the
comments from deleted patrons were displayed as if the disconnected
user wrote them. So it had the edit button...

And fix borrowernumber not being passed to the template when
OpacStarRatings was false.

Test plan
1. Log in as a patron
2. Leave a comment/review on a record
3. Librarian: approve this comment
4. Delete the borrower
5. See the record
(opac:/cgi-bin/koha/opac-detail.pl?biblionumber=RELEVANT_BIB_NUMBER)
6. Then you should see an error
7. Apply this patch
8. Refresh the page
9. Then you should see the record page with the comment

Signed-off-by: Mark Tompsett 

Signed-off-by: Jon Knight 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15839

--- Comment #21 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #20)
> Created attachment 69926 [details] [review]
> Bug 19808: Do not display 'Added' alone
> 
> It seems that reviews.datereviewed ends with NULL in DB.
> It is caused by another issue that will be fixed on another bug report.

See bug 15839

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #20 from Jonathan Druart  
---
Created attachment 69926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69926=edit
Bug 19808: Do not display 'Added' alone

It seems that reviews.datereviewed ends with NULL in DB.
It is caused by another issue that will be fixed on another bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #19 from Jonathan Druart  
---
16:15 < oleonard> greenjimll: I was just testing that too but got interrupted.
Looks okay to me except that in the OPAC the comment labels don't look right
when there is no patron
16:15 < oleonard> Instead of "Added 2016-12-19 by John Smith" it says "Added"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||15839

--- Comment #18 from Jonathan Druart  
---
Koha::Reviews is used since bug 15839 (in 16.11.x), but the patron's info are
still retrieved from GetMember.
Since bug 17829 (17.11) they are using Koha::Patrons (which means we cannot
call a method on an undefined object)


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839
[Bug 15839] Move the reviews related code to Koha::Reviews
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17829


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829
[Bug 17829] Move GetMember to Koha::Patron
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #17 from Victor Grousset/tuxayo  ---
BTW any idea why it doesn't seem to affect 16.11?
A least for the explosion part. It still shows "Your comment" + the edit button
when the patron is deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jonathan Druart  changed:

   What|Removed |Added

Summary|Reviews from deleted|Reviews from deleted
   |patrons make opac-detail|patrons make few scripts to
   |explode |explode

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/