[Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can be fixed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #7 from Katrin Fischer  ---
I think this is a duplicate of another bug in PQA (please reset if I am wrong:


Bug 20953 - Discharge can be requested several times on OPAC
>Patch reoganised the code so that the following FIXME is obsolete :
>  'FIXME looks like $available is not needed'
>Patch also replaces 'op' arg test to also check undef : input->param("op") // 
>''

*** This bug has been marked as a duplicate of bug 20953 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can be fixed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990

--- Comment #6 from Aleisha Amohia  ---
Created attachment 76554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76554=edit
Bug 19990: Removing unnecessary variable from opac/opac-discharge.pl

To test:
1) Ensure useDischarge syspref is enabled
2) Go to OPAC, click ask for a discharge
3) Go to staff side homepage, click 'Discharge requests pending'
4) Allow Discharge
5) Go to the user's page and remove the discharge restriction
6) Apply patch and repeat steps 2-4, ensuring that all behaviour stays
the same

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can be fixed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can be fixed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990

Fridolin SOMERS  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20953

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can be fixed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990

--- Comment #5 from Fridolin SOMERS  ---
(In reply to Fridolin SOMERS from comment #4)
> I see $available means discharge is validated by a librarian in staff
> interface, different from $pending.

Oh I think I get it now :

FIXME means 'available' template param could directly be
Koha::Patron::Discharge::is_discharged({borrowernumber => $loggedinuser}).
Because Koha::Patron::Discharge::is_discharged() looks if discharge is
validated.

Is it correct ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can be fixed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #4 from Fridolin SOMERS  ---
I see $available means discharge is validated by a librarian in staff
interface, different from $pending.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can be fixed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Hm, I am seeing this in the template:

[% ELSIF available %]
  Get your discharge

I think available is in use or patch is incomplete.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can be fixed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990

Maksim Sen  changed:

   What|Removed |Added

 CC||maksim@inlibro.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can be fixed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990

Maksim Sen  changed:

   What|Removed |Added

  Attachment #70599|0   |1
is obsolete||

--- Comment #2 from Maksim Sen  ---
Created attachment 71864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71864=edit
Bug-19960: FIXME $available is not needed

Test plan:
1. Open opac-discharge.pl
2. Check that $available doesn't exist

https://bugs.koha-community.org/show_bug.cgi?id=19990
Signed-off-by: Maksim Sen 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can be fixed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990

jway...@hotmail.com changed:

   What|Removed |Added

 CC||jway...@hotmail.com
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can be fixed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990

--- Comment #1 from jway...@hotmail.com ---
Created attachment 70599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70599=edit
Bug-19960: FIXME $available is not needed

Test plan:
1. Open opac-discharge.pl
2. Check that $available doesn't exist

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can be fixed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990

Aleisha Amohia  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/