[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Sally Lodico  changed:

   What|Removed |Added

 Blocks||35159


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35159
[Bug 35159] New edit item limitation to library groups also prevents batch
modification of items owned by other libraries.
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-09-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #466 from Kyle M Hall  ---
> Sure, I added bug 34814 (hope I did it right).

Looks good. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-09-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #465 from Anneli Österman  ---
(In reply to Kyle M Hall from comment #464)
> (In reply to Anneli Österman from comment #463)
> > I'm not sure if this is somehow covered in this huge bug but I noticed that
> > if you are limiting the editing per library group you lose the ability to
> > choose items on record details page. This is enabled in
> > StaffDetailItemSelection. You cannot choose your own items either. It would
> > be ok not to choose items that you cannot edit/delete but if you cannot
> > choose your own items it is a big disadvantage. You cannot choose multiple
> > items and do batch edits or deletes to them from details page. I tested the
> > feature in PTFS Europe's sandbox (v. 23.06).
> 
> Can you file a dependent bug report for this issue?

Sure, I added bug 34814 (hope I did it right).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-09-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Anneli Österman  changed:

   What|Removed |Added

 Blocks||34814


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34814
[Bug 34814] Limiting item editing to library or library group disables choosing
items from record's details page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #464 from Kyle M Hall  ---
(In reply to Anneli Österman from comment #463)
> I'm not sure if this is somehow covered in this huge bug but I noticed that
> if you are limiting the editing per library group you lose the ability to
> choose items on record details page. This is enabled in
> StaffDetailItemSelection. You cannot choose your own items either. It would
> be ok not to choose items that you cannot edit/delete but if you cannot
> choose your own items it is a big disadvantage. You cannot choose multiple
> items and do batch edits or deletes to them from details page. I tested the
> feature in PTFS Europe's sandbox (v. 23.06).

Can you file a dependent bug report for this issue?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Anneli Österman  changed:

   What|Removed |Added

 CC||anneli.osterman@koha-suomi.
   ||fi

--- Comment #463 from Anneli Österman  ---
I'm not sure if this is somehow covered in this huge bug but I noticed that if
you are limiting the editing per library group you lose the ability to choose
items on record details page. This is enabled in StaffDetailItemSelection. You
cannot choose your own items either. It would be ok not to choose items that
you cannot edit/delete but if you cannot choose your own items it is a big
disadvantage. You cannot choose multiple items and do batch edits or deletes to
them from details page. I tested the feature in PTFS Europe's sandbox (v.
23.06).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-08-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||34589


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34589
[Bug 34589] Update on bug 20256 is not idempotent
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|Sponsored by CLiC (Colorado |**Sponsored by** *CLiC
  release notes|Library Consortium).|(Colorado Library
   ||Consortium)*
   ||
   ||This adds
   ||the ability to limit item
   ||editing to staff users from
   ||libraries within a specific
   ||library group. This is done
   ||via a new option when
   ||creating item groups. There
   ||is also a new system
   ||preference `edit_any_item`
   ||that permits users to edit
   ||all items on a record
   ||independent of the library
   ||groups and their own home
   ||library.
   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/681
  Documentation||Caroline Cyr La Rose
contact||
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Jessie Zairo  changed:

   What|Removed |Added

  Text to go in the||Sponsored by CLiC (Colorado
  release notes||Library Consortium).
  Documentation|Sponsored by CLiC (Colorado |
 submission|Library Consortium).|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-03-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Jessie Zairo  changed:

   What|Removed |Added

  Documentation||Sponsored by CLiC (Colorado
 submission||Library Consortium).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||33070


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33070
[Bug 33070] Get rid of Koha::Patron->can_edit_item and use can_edit_item_from
instead
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||33054

--- Comment #462 from Jonathan Druart  ---
(In reply to Tomás Cohen Arazi from comment #460)
> Kyle, we talked about a fix for a random failure on
> t/db_dependent/Koha/Acquisition/Order.t related to this bug. Please check.

Failing again, see bug 33054.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33054
[Bug 33054] Koha/Acquisition/Order.t is failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-02-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #461 from Jonathan Druart  ---
1530 my $branchcode =
1531 $ref eq 'Koha::Item' ? $item->homebranch
1532   : $ref eq 'HASH'   ? $item->{homebranch}
1533   : $ref eq q{}  ? $item
1534   :undef;

This reads bad, and introduce an incorrect pattern, can you have another look
at it please?

Why not simply having can_edit_items_from that takes the branchcode?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-02-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords|rel_23_05_candidate |additional_work_needed

--- Comment #460 from Tomás Cohen Arazi  ---
Kyle, we talked about a fix for a random failure on
t/db_dependent/Koha/Acquisition/Order.t related to this bug. Please check.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-02-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #459 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #440)
> Hi Kyle,
> 
> does the last patch set fix the error Michaela noted on comment 430? 
> 
> Michaela also told that in her testing it showed the behavior as you
> described it - so I need to do my homework and retest. I aim to have another
> go at this patch set on Friday. Fingers crossed.

It's Friday, but  I am no longer needed here :D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #458 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |
 Status|Signed Off  |Passed QA

--- Comment #457 from Tomás Cohen Arazi  ---
I tested the feature and after a rebase fix Kyle did it is working properly.
The QA scripts are happy, things are covered by tests and they pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #145951|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #145955|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #145954|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #145953|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #145952|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #456 from Tomás Cohen Arazi  ---
Created attachment 145955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145955=edit
Bug 20256: Update groups editor

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #455 from Tomás Cohen Arazi  ---
Created attachment 145954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145954=edit
Bug 20256: Add new methods for checking item editing permissions

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #454 from Tomás Cohen Arazi  ---
Created attachment 145953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145953=edit
Bug 20256: Refactor subs for rights to view patrons to make them generic for
general use

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #453 from Tomás Cohen Arazi  ---
Created attachment 145952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145952=edit
Bug 20256: Add new permission to editor

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #452 from Tomás Cohen Arazi  ---
Created attachment 145951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145951=edit
Bug 20256: Update database

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Create two library groups with some libraries in them,
   make sure to enable the new feature to limit editing of items
4) Test the functionality, if an item is owned by a library in
   your group, you should have full editing abilities. If an item
   is from a different group, you should only be able to make the
   same changes you would be able to if IndependentBranches were.

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #145896|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #145895|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #145894|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #145893|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #145892|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Kyle M Hall  changed:

   What|Removed |Added

URL||https://github.com/bywaters
   ||olutions/bywater-koha-devel
   ||/tree/bug_20256

--- Comment #451 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #440)
> Hi Kyle,
> 
> does the last patch set fix the error Michaela noted on comment 430? 
> 
> Michaela also told that in her testing it showed the behavior as you
> described it - so I need to do my homework and retest. I aim to have another
> go at this patch set on Friday. Fingers crossed.

Yes it should! I'm getting "413 Request Entity Too Large" when I attach my new
patchset, so I've posted the github url in the URL field for this bug.

https://github.com/bywatersolutions/bywater-koha-devel/tree/bug_20256

I will deprecate the attached patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #450 from Kyle M Hall  ---
Created attachment 145896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145896=edit
Bug 20256: Update groups editor

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #449 from Kyle M Hall  ---
Created attachment 145895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145895=edit
Bug 20256: Add new methods for checking item editing permissions

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #448 from Kyle M Hall  ---
Created attachment 145894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145894=edit
Bug 20256: Refactor subs for rights to view patrons to make them generic for
general use

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #447 from Kyle M Hall  ---
Created attachment 145893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145893=edit
Bug 20256: Add new permission to editor

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #145887|0   |1
is obsolete||
 Attachment #145888|0   |1
is obsolete||
 Attachment #145889|0   |1
is obsolete||
 Attachment #145890|0   |1
is obsolete||
 Attachment #145891|0   |1
is obsolete||

--- Comment #446 from Kyle M Hall  ---
Created attachment 145892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145892=edit
Bug 20256: Update database

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Create two library groups with some libraries in them,
   make sure to enable the new feature to limit editing of items
4) Test the functionality, if an item is owned by a library in
   your group, you should have full editing abilities. If an item
   is from a different group, you should only be able to make the
   same changes you would be able to if IndependentBranches were.

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #445 from Kyle M Hall  ---
Created attachment 145891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145891=edit
Bug 20256: Update groups editor

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #444 from Kyle M Hall  ---
Created attachment 145890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145890=edit
Bug 20256: Add new methods for checking item editing permissions

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #443 from Kyle M Hall  ---
Created attachment 145889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145889=edit
Bug 20256: Refactor subs for rights to view patrons to make them generic for
general use

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #442 from Kyle M Hall  ---
Created attachment 145888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145888=edit
Bug 20256: Add new permission to editor

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #145809|0   |1
is obsolete||
 Attachment #145810|0   |1
is obsolete||
 Attachment #145811|0   |1
is obsolete||
 Attachment #145812|0   |1
is obsolete||
 Attachment #145813|0   |1
is obsolete||
 Attachment #145814|0   |1
is obsolete||
 Attachment #145815|0   |1
is obsolete||
 Attachment #145816|0   |1
is obsolete||

--- Comment #441 from Kyle M Hall  ---
Created attachment 145887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145887=edit
Bug 20256: Update database

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Create two library groups with some libraries in them,
   make sure to enable the new feature to limit editing of items
4) Test the functionality, if an item is owned by a library in
   your group, you should have full editing abilities. If an item
   is from a different group, you should only be able to make the
   same changes you would be able to if IndependentBranches were.

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #440 from Katrin Fischer  ---
Hi Kyle,

does the last patch set fix the error Michaela noted on comment 430? 

Michaela also told that in her testing it showed the behavior as you described
it - so I need to do my homework and retest. I aim to have another go at this
patch set on Friday. Fingers crossed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #439 from Kyle M Hall  ---
Created attachment 145816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145816=edit
Bug 20256: Update DB Schema [DO NOT PUSH]

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #438 from Kyle M Hall  ---
Created attachment 145815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145815=edit
Bug 20256: Add unit tests

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #437 from Kyle M Hall  ---
Created attachment 145814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145814=edit
Bug 20256: Use new methods

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #436 from Kyle M Hall  ---
Created attachment 145813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145813=edit
Bug 20256: Update groups editor

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #435 from Kyle M Hall  ---
Created attachment 145812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145812=edit
Bug 20256: Add new methods for checking item editing permissions

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #434 from Kyle M Hall  ---
Created attachment 145811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145811=edit
Bug 20256: Refactor subs for rights to view patrons to make them generic for
general use

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #433 from Kyle M Hall  ---
Created attachment 145810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145810=edit
Bug 20256: Add new permission to editor

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #145482|0   |1
is obsolete||
 Attachment #145483|0   |1
is obsolete||
 Attachment #145484|0   |1
is obsolete||
 Attachment #145485|0   |1
is obsolete||
 Attachment #145486|0   |1
is obsolete||
 Attachment #145487|0   |1
is obsolete||
 Attachment #145488|0   |1
is obsolete||
 Attachment #145489|0   |1
is obsolete||

--- Comment #432 from Kyle M Hall  ---
Created attachment 145809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145809=edit
Bug 20256: Update database

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Create two library groups with some libraries in them,
   make sure to enable the new feature to limit editing of items
4) Test the functionality, if an item is owned by a library in
   your group, you should have full editing abilities. If an item
   is from a different group, you should only be able to make the
   same changes you would be able to if IndependentBranches were.

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||31791


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791
[Bug 31791] Add the ability to lock records to prevent modification through the
Koha staff interface(s).
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Martin Renvoize  changed:

   What|Removed |Added

 CC|martin.renvoize@ptfs-europe |
   |.com|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #431 from Katrin Fischer  ---
(In reply to Michaela Sieber from comment #430)
> (In reply to Kyle M Hall from comment #429)
> > 
> > Please try again! Patches needed a rebase against master.
> 
> 
> Error when trying to see the detail view of a biblio:
> 
> Could not compile /kohadevbox/koha/catalogue/detail.pl
> 
> http://staff-edititems.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/catalogue/
> detail.pl?biblionumber=30

Full error is: 

Could not compile /kohadevbox/koha/catalogue/detail.pl: Global symbol
"$item_object" requires explicit package name (did you forget to declare "my
$item_object"?) at /kohadevbox/koha/catalogue/detail.pl line 445.
BEGIN not safe after errors--compilation aborted at
/kohadevbox/koha/catalogue/detail.pl line 693.
 at /usr/share/perl5/CGI/Compile.pm line 144

Maybe a rebase issue with some changes on master?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #430 from Michaela Sieber  ---
(In reply to Kyle M Hall from comment #429)
> 
> Please try again! Patches needed a rebase against master.


Error when trying to see the detail view of a biblio:

Could not compile /kohadevbox/koha/catalogue/detail.pl

http://staff-edititems.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/catalogue/detail.pl?biblionumber=30

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #429 from Kyle M Hall  ---
(In reply to Michaela Sieber from comment #420)
> Hi Kyle, 
> I would like to test this feature but it was not possible to create a
> sandbox: https://sandbox.bywatersolutions.com/provision_log/bug20256
> 
> Could you please have a look? 
> Thanks! 
> :-)

Please try again! Patches needed a rebase against master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #428 from Kyle M Hall  ---
Created attachment 145489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145489=edit
Bug 20256: Update DB Schema [DO NOT PUSH]

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #427 from Kyle M Hall  ---
Created attachment 145488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145488=edit
Bug 20256: Add unit tests

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #426 from Kyle M Hall  ---
Created attachment 145487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145487=edit
Bug 20256: Use new methods

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #425 from Kyle M Hall  ---
Created attachment 145486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145486=edit
Bug 20256: Update groups editor

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #424 from Kyle M Hall  ---
Created attachment 145485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145485=edit
Bug 20256: Add new methods for checking item editing permissions

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #423 from Kyle M Hall  ---
Created attachment 145484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145484=edit
Bug 20256: Refactor subs for rights to view patrons to make them generic for
general use

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #422 from Kyle M Hall  ---
Created attachment 145483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145483=edit
Bug 20256: Add new permission to editor

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #145286|0   |1
is obsolete||
 Attachment #145287|0   |1
is obsolete||
 Attachment #145288|0   |1
is obsolete||
 Attachment #145289|0   |1
is obsolete||
 Attachment #145290|0   |1
is obsolete||
 Attachment #145291|0   |1
is obsolete||
 Attachment #145292|0   |1
is obsolete||
 Attachment #145293|0   |1
is obsolete||

--- Comment #421 from Kyle M Hall  ---
Created attachment 145482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145482=edit
Bug 20256: Update database

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Create two library groups with some libraries in them,
   make sure to enable the new feature to limit editing of items
4) Test the functionality, if an item is owned by a library in
   your group, you should have full editing abilities. If an item
   is from a different group, you should only be able to make the
   same changes you would be able to if IndependentBranches were.

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #420 from Michaela Sieber  ---
Hi Kyle, 
I would like to test this feature but it was not possible to create a sandbox:
https://sandbox.bywatersolutions.com/provision_log/bug20256

Could you please have a look? 
Thanks! 
:-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Katrin Fischer  changed:

   What|Removed |Added

 CC||michaela.sie...@kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #419 from Kyle M Hall  ---
Follow-ups have been squashed into the main patch set to make everything
manageable and readable again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #418 from Kyle M Hall  ---
Created attachment 145293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145293=edit
Bug 20256: Update DB Schema [DO NOT PUSH]

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #417 from Kyle M Hall  ---
Created attachment 145292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145292=edit
Bug 20256: Add unit tests

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #416 from Kyle M Hall  ---
Created attachment 145291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145291=edit
Bug 20256: Use new methods

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #415 from Kyle M Hall  ---
Created attachment 145290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145290=edit
Bug 20256: Update groups editor

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #414 from Kyle M Hall  ---
Created attachment 145289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145289=edit
Bug 20256: Add new methods for checking item editing permissions

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #413 from Kyle M Hall  ---
Created attachment 145288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145288=edit
Bug 20256: Refactor subs for rights to view patrons to make them generic for
general use

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #412 from Kyle M Hall  ---
Created attachment 145287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145287=edit
Bug 20256: Add new permission to editor

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-01-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #143527|0   |1
is obsolete||
 Attachment #143529|0   |1
is obsolete||
 Attachment #143530|0   |1
is obsolete||
 Attachment #143531|0   |1
is obsolete||
 Attachment #143532|0   |1
is obsolete||
 Attachment #143533|0   |1
is obsolete||
 Attachment #143534|0   |1
is obsolete||
 Attachment #143535|0   |1
is obsolete||
 Attachment #143536|0   |1
is obsolete||
 Attachment #143537|0   |1
is obsolete||
 Attachment #143538|0   |1
is obsolete||
 Attachment #143539|0   |1
is obsolete||
 Attachment #143540|0   |1
is obsolete||
 Attachment #143541|0   |1
is obsolete||
 Attachment #143542|0   |1
is obsolete||
 Attachment #143543|0   |1
is obsolete||
 Attachment #143544|0   |1
is obsolete||
 Attachment #143545|0   |1
is obsolete||
 Attachment #143546|0   |1
is obsolete||
 Attachment #143547|0   |1
is obsolete||
 Attachment #143548|0   |1
is obsolete||
 Attachment #143549|0   |1
is obsolete||
 Attachment #143550|0   |1
is obsolete||
 Attachment #143551|0   |1
is obsolete||
 Attachment #143552|0   |1
is obsolete||
 Attachment #143553|0   |1
is obsolete||
 Attachment #143554|0   |1
is obsolete||
 Attachment #143555|0   |1
is obsolete||
 Attachment #143556|0   |1
is obsolete||

--- Comment #411 from Kyle M Hall  ---
Created attachment 145286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145286=edit
Bug 20256: Update database

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Create two library groups with some libraries in them,
   make sure to enable the new feature to limit editing of items
4) Test the functionality, if an item is owned by a library in
   your group, you should have full editing abilities. If an item
   is from a different group, you should only be able to make the
   same changes you would be able to if IndependentBranches were.

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #410 from Kyle M Hall  ---
Created attachment 143556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143556=edit
Bug 20256: (QA follow-up) Hide link to delete item if unable to delete the item

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #409 from Kyle M Hall  ---
Created attachment 143555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143555=edit
Bug 20256: (QA follow-up) Fix explosion for items batch edit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #408 from Kyle M Hall  ---
Created attachment 143554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143554=edit
Bug 20256: (QA follow-up) Allow removal of course reserves for items that
cannot be edited

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #407 from Kyle M Hall  ---
Created attachment 143553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143553=edit
Bug 20256: (QA follow-up) hide Edit chooice in Actions on items editor if item
cannot be edited

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #406 from Kyle M Hall  ---
Created attachment 143552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143552=edit
Bug 20256: (QA follow-up) Fix typo in permission descriptions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #405 from Kyle M Hall  ---
Created attachment 143551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143551=edit
Bug 20256: (QA follow-up) Update group feature description

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #404 from Kyle M Hall  ---
Created attachment 143550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143550=edit
Bug 20256: (QA follow-up) Update permission descriptions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #403 from Kyle M Hall  ---
Created attachment 143549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143549=edit
Bug 20256: (QA follow-up) Remove duplicated sub

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #402 from Kyle M Hall  ---
Created attachment 143548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143548=edit
Bug 20256: (QA follow-up) Fix typo in comment on kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #401 from Kyle M Hall  ---
Created attachment 143547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143547=edit
Bug 20256: (follow-up) Fix spelling

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #400 from Kyle M Hall  ---
Created attachment 143546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143546=edit
Bug 20256: Update DB Schema [DO NOT PUSH]

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #399 from Kyle M Hall  ---
Created attachment 143545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143545=edit
Bug 20256: (QA follow-up) Implement for item search

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #398 from Kyle M Hall  ---
Created attachment 143544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143544=edit
Bug 20256: (QA follow-up) Implement for course reserves

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #397 from Kyle M Hall  ---
Created attachment 143543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143543=edit
Bug 20256: Mark ft_limit_item_editing as boolean in schema file

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #396 from Kyle M Hall  ---
Created attachment 143542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143542=edit
Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions
for

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #395 from Kyle M Hall  ---
Created attachment 143541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143541=edit
Bug 20256: (QA follow-up) Give existing users with edit_items permission
edit_any_item as well

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #394 from Kyle M Hall  ---
Created attachment 143540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143540=edit
Bug 20256: (QA follow-up) Handle non-existing userenv

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #393 from Kyle M Hall  ---
Created attachment 143539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143539=edit
Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit
this item

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #392 from Kyle M Hall  ---
Created attachment 143538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143538=edit
Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to
item.can_be_edited

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #391 from Kyle M Hall  ---
Created attachment 143537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143537=edit
Bug 20256: (QA follow-up) test borrowernumber in userenv too

Bug 22600 added userenv for scripts, so userenv is defined, but some of
values in userenv not

Test plan:
Run with some params: misc/cronjobs/delete_items.pl

--> without this patch you will se error message:
Can't call method "can_edit_item" on an undefined value at
/home/vagrant/kohaclone/C4/Items.pm line 1748
--> with this patch everything works smoothly

Signed-off-by: Bob Bennhoff - CLiC 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   5   6   >