[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-04-23 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED

--- Comment #17 from Nick Clemens  ---
Enhancement, skipping for stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-03-27 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

--- Comment #16 from Jonathan Druart  
---
Last patch pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-03-26 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

--- Comment #15 from Jonathan Druart  
---
Created attachment 73295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73295=edit
Bug 20267: .gitignore do not need to be mapped in Makefile

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-03-26 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #14 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-03-19 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #72591|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-03-19 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #13 from Jonathan Druart  
---
I agree with Julian, personal stuffs should go to .git/info/exclude and not
tracked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-03-09 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-03-09 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

--- Comment #12 from Julian Maurice  ---
(In reply to Tomás Cohen Arazi from comment #11)
> (In reply to Julian Maurice from comment #10)
> > I'm not sure the IDE's stuff should go in there. It's not related to Koha
> > and is different for everyone (I use Vim, some use Emacs and some strange
> > people even use Eclipse :))
> > I'd rather keep these "personal settings" in $HOME/.config/git/ignore or
> > .git/info/exclude
> 
> We could add those too :-D
I don't need to, Vim temporary files are already ignored by my global git
config

> Feel free to remove them if you wish.
I won't remove them (it won't affect me after all) and I'll let RM have the
final word.

But let me try to convince you :)
- If anyone adds their personal preferences to this file, it can quickly become
bloated (for instance I also use ctags, so I choose to ignore /.ctags and
/TAGS, and I also have .proverc and .prove)
- If you add these preferences to $HOME/.config/git/ignore instead, the rules
work across all your git repositories, so you don't have add them again and
again to all the repositories you are working on.
So it's good for Koha (clean .gitignore) and good for you (your custom ignore
rules all in one place) :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-03-09 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

--- Comment #11 from Tomás Cohen Arazi  ---
(In reply to Julian Maurice from comment #10)
> I'm not sure the IDE's stuff should go in there. It's not related to Koha
> and is different for everyone (I use Vim, some use Emacs and some strange
> people even use Eclipse :))
> I'd rather keep these "personal settings" in $HOME/.config/git/ignore or
> .git/info/exclude

We could add those too :-D

Feel free to remove them if you wish.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-03-09 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

--- Comment #10 from Julian Maurice  ---
I'm not sure the IDE's stuff should go in there. It's not related to Koha and
is different for everyone (I use Vim, some use Emacs and some strange people
even use Eclipse :))
I'd rather keep these "personal settings" in $HOME/.config/git/ignore or
.git/info/exclude

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-03-09 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 CC||tomasco...@gmail.com
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-03-09 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

--- Comment #9 from Tomás Cohen Arazi  ---
Created attachment 72591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72591=edit
Bug 20267: Add more ignores

This patch adds more known files that should be ignored:
- Devel::Cover output
- NTYProf output
- Known used IDE files

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-03-09 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #72203|0   |1
is obsolete||

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 72590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72590=edit
Bug 20267: Add basic .gitignore

Ignore files generated by ExtUtils::MakeMaker

NOTE: Limited scope does not affect files created
  by translation utilities

Signed-off-by: Mark Tompsett 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-03-02 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

--- Comment #7 from Maksim Sen  ---
Ignore comment 6,

I accidentally submitted a patch when I tried to sign off your patch.

Sorry about that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-03-02 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

Maksim Sen  changed:

   What|Removed |Added

  Attachment #72389|0   |1
is obsolete||
  Attachment #72389|1   |0
   is patch||

--- Comment #6 from Maksim Sen  ---
Comment on attachment 72389
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72389
Hi Maksim,

>From 2b8905cb588a594d54843ec5ffeef578d92c8d3c Mon Sep 17 00:00:00 2001
>From: Julian Maurice 
>Date: Thu, 22 Feb 2018 10:51:27 +0100
>Subject: [PATCH] Bug 20267: Add basic .gitignore
>
>Ignore files generated by ExtUtils::MakeMaker
>
>NOTE: Limited scope does not affect files created
>  by translation utilities
>
>Signed-off-by: Mark Tompsett 
>Signed-off-by: Maksim Sen 
>---
> .gitignore | 4 
> 1 file changed, 4 insertions(+)
> create mode 100644 .gitignore
>
>diff --git a/.gitignore b/.gitignore
>new file mode 100644
>index 000..7befa23
>--- /dev/null
>+++ b/.gitignore
>@@ -0,0 +1,4 @@
>+/MYMETA.*
>+/blib/
>+/Makefile
>+/pm_to_blib
>-- 
>2.7.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-03-02 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

--- Comment #5 from Maksim Sen  ---
Created attachment 72389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72389=edit
Hi Maksim,

here's a possible test plan:

1. Run `perl Makefile.PL` followed by `make` to generate the files MYMETA.json,
MYMETA.yml, Makefile, pm_to_blib and directory blib/
2. See that those files appear in the output of `git status`
3. Apply patch
4. Run `git status` again and see that they are no longer displayed.

Signed-off-by: Maksim Sen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-02-26 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

M. Tompsett  changed:

   What|Removed |Added

  Attachment #72067|0   |1
is obsolete||

--- Comment #4 from M. Tompsett  ---
Created attachment 72203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72203=edit
Bug 20267: Add basic .gitignore

Ignore files generated by ExtUtils::MakeMaker

NOTE: Limited scope does not affect files created
  by translation utilities

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-02-26 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-02-26 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

--- Comment #3 from Julian Maurice  ---
Hi Maksim,

here's a possible test plan:

1. Run `perl Makefile.PL` followed by `make` to generate the files MYMETA.json,
MYMETA.yml, Makefile, pm_to_blib and directory blib/
2. See that those files appear in the output of `git status`
3. Apply patch
4. Run `git status` again and see that they are no longer displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-02-23 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

Maksim Sen  changed:

   What|Removed |Added

 CC||maksim@inlibro.com

--- Comment #2 from Maksim Sen  ---
Hey Julian,

Can you put a test plan for the patch? (even if it's a very simple one)

Thanks a bunch,

Maksim Sen

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-02-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20267] Add basic .gitignore

2018-02-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267

--- Comment #1 from Julian Maurice  ---
Created attachment 72067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72067=edit
Bug 20267: Add basic .gitignore

Ignore files generated by ExtUtils::MakeMaker

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/