[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-05-15 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #90 from Benjamin Rokseth  ---
Adjusted to all qa feedback, except:
- left warn instead of die in atomicupdate - it would be removed by RM when
moved to updatedatabase.pl anyways I suppose
- qa tools: FAIL   Koha/Patron.pm, FAIL   pod, Spurious text after =cut
I could not reproduce. Ran qa tools and it passed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-05-15 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #89 from Benjamin Rokseth  ---
Created attachment 75347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75347=edit
Bug 20271: (QA follow-up): rename to deleted_on and various fixes

- renamed deleted_at => deleted_on
- removed failing sql in t/db_dependent/OAI/Server.t
- removed deprecated autoincrement checks in about.pl
- fixed errors in catalogue_stats.tt and catalogue_stats.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-05-11 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #88 from Benjamin Rokseth  ---
Marcel, thanks for thorough feedback!
will address the issues asap so it gets into master sooner than later.
Downgraded to major, enhancement it is definitely not ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-05-11 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

   Severity|critical|major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-05-11 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #87 from Marcel de Rooy  ---
I am not sure if we should mark this one as critical btw. I would go for major
when viewing it as a bugfix. But enh could be argued too.
Not so sure if the RMaints want to backport this one?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-05-11 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Failed QA

--- Comment #86 from Marcel de Rooy  ---
Great job, Francesco
I did not finish my QA now, but want to report some issues I found already. And
they unfortunately confirm that this patch set will not make it anymore into
18.05 ;)
But it would be good to have in master early.

qa tools: FAIL   Koha/Patron.pm, FAIL   pod, Spurious text after =cut
deleted_at should probably be better: deleted_on; we also have updated_on etc.
$dbh->do( "ALTER TABLE biblio ADD COLUMN deleted_at datetime DEFAULT NULL" ) or
warn $DBI::errstr;
Probably it warns already and you should die here ?
Running OAI/Server.t
ok 12 - use Koha::OAI::Server::ResumptionToken;
DBD::mysql::db do failed: Table 'koha_dev.deletedbiblio' doesn't exist [for
Statement "DELETE FROM deletedbiblio"] at t/db_dependent/OAI/Server.t line 68.
DBD::mysql::db do failed: Table 'koha_dev.deletedbiblioitems' doesn't exist
[for Statement "DELETE FROM deletedbiblioitems"] at t/db_dependent/OAI/Server.t
line 69.
DBD::mysql::db do failed: Table 'koha_dev.deleteditems' doesn't exist [for
Statement "DELETE FROM deleteditems"] at t/db_dependent/OAI/Server.t line 70.
git grep deletedbiblio
about.pl:q|select b.biblionumber from biblio b join deletedbiblio db on
b.biblionumber=db.biblionumber|,
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/web_services.pref (a
few other refs too)
git grep deleteditems
about.pl again
koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt:
   
might not be a problem?
misc/export_records.pl:WHERE deleteditems.biblionumber = ? AND
deleted_at IS NOT NULL
does not look good
reports/catalogue_stats.pl:$linefilter[0] = @$filters[15] if ( $line =~
/deleteditems\.timestamp/ );
we should probably get rid of those things; they are confusing now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-05-11 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #85 from Marcel de Rooy  ---
Created attachment 75265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75265=edit
Bug 20271: (follow-up) DBIx schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-05-11 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |BLOCKED

--- Comment #84 from Marcel de Rooy  ---
Looking here now, but I feel that this patch set will not make it anymore to
18.05.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-18 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #74223|0   |1
is obsolete||

--- Comment #83 from Brendan Gallagher  ---
Created attachment 74416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74416=edit
Bug 20271: atomicupdate - support mysql < 5.7 and address foreign key issues

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-18 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #74188|0   |1
is obsolete||

--- Comment #80 from Brendan Gallagher  ---
Created attachment 74413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74413=edit
Bug 20271: Use a single pass in the OAI-PMH provider

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-18 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #74187|0   |1
is obsolete||

--- Comment #79 from Brendan Gallagher  ---
Created attachment 74412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74412=edit
Bug 20271: add atomic update

Bug 20271: disable foreign keys on deletedbiblio_metadata

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-18 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #74190|0   |1
is obsolete||

--- Comment #82 from Brendan Gallagher  ---
Created attachment 74415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74415=edit
Bug 20271: print instead of warn unmovable items

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-18 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #74189|0   |1
is obsolete||

--- Comment #81 from Brendan Gallagher  ---
Created attachment 74414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74414=edit
Bug 20271: fix whitespace issues in C4::Items

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-18 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #74185|0   |1
is obsolete||

--- Comment #77 from Brendan Gallagher  ---
Created attachment 74410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74410=edit
Bug 20271: delete biblio and biblio_metadata in one go

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-18 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #74186|0   |1
is obsolete||

--- Comment #78 from Brendan Gallagher  ---
Created attachment 74411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74411=edit
Bug 20271: remove comments regarding deleteditems and -biblio*

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-18 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-18 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #74182|0   |1
is obsolete||

--- Comment #74 from Brendan Gallagher  ---
Created attachment 74407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74407=edit
Bug 20271: merging delete biblio/items

The present bug merges the following tables:
deletedbiblio  -> biblio
deletedbiblioitems -> biblioitems
deletedbiblio_metadata -> biblio_metadata
deleteditems   -> items

and adds a column deleted_at to signify time of deletion, if deleted

it replaces all occurrences of the mentioned occurences and uses
of mentioned deleted* tables

upgrade is handled by moving rows from deleted* tables to the live
ones. If all rows are moved, the corresponding tables are dropped.
If there are duplicates or conflicts (duplicate barcodes e.g.) they
reminders are left for scrutiny and table renamed to _deleted*

Test plan:

1) Make sure you have a db with at least a few deleted biblios,
   biblioitems and items.
2) Apply patch and run updatedatabase.pl
3) Make note of the db upgrade messages, if you get a message like:
   There were x deleteditems that could not be moved, please check
_deleteditems
   you should check the _deleteditems table and verify that they are
   actual conflicts
4) Click around in the web interface and make sure you can delete items
   and biblios
5) "Undelete" an item by NULLing the deleted_at column for an item
   and verify that it returns in interface (Not neccessary really)

Signed-off-by: Brendan A Gallagher 
Worked on two different databases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-18 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #74183|0   |1
is obsolete||

--- Comment #75 from Brendan Gallagher  ---
Created attachment 74408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74408=edit
Bug 20271: fix remaining tests

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-18 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #74184|0   |1
is obsolete||

--- Comment #76 from Brendan Gallagher  ---
Created attachment 74409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74409=edit
Bug 20271: update kohastructure.sql

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-16 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #73 from Benjamin Rokseth  ---
Created attachment 74223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74223=edit
Bug 20271: atomicupdate - support mysql < 5.7 and address foreign key issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-14 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #72 from Benjamin Rokseth  ---
Created attachment 74190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74190=edit
Bug 20271: print instead of warn unmovable items

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-14 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #74139|0   |1
is obsolete||

--- Comment #68 from Benjamin Rokseth  ---
Created attachment 74186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74186=edit
Bug 20271: remove comments regarding deleteditems and -biblio*

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-14 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #74142|0   |1
is obsolete||

--- Comment #71 from Benjamin Rokseth  ---
Created attachment 74189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74189=edit
Bug 20271: fix whitespace issues in C4::Items

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-14 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #74140|0   |1
is obsolete||

--- Comment #69 from Benjamin Rokseth  ---
Created attachment 74187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74187=edit
Bug 20271: add atomic update

Bug 20271: disable foreign keys on deletedbiblio_metadata

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-14 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #74138|0   |1
is obsolete||

--- Comment #67 from Benjamin Rokseth  ---
Created attachment 74185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74185=edit
Bug 20271: delete biblio and biblio_metadata in one go

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-14 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #74141|0   |1
is obsolete||

--- Comment #70 from Benjamin Rokseth  ---
Created attachment 74188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74188=edit
Bug 20271: Use a single pass in the OAI-PMH provider

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-14 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #74135|0   |1
is obsolete||

--- Comment #64 from Benjamin Rokseth  ---
Created attachment 74182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74182=edit
Bug 20271: merging delete biblio/items

The present bug merges the following tables:
deletedbiblio  -> biblio
deletedbiblioitems -> biblioitems
deletedbiblio_metadata -> biblio_metadata
deleteditems   -> items

and adds a column deleted_at to signify time of deletion, if deleted

it replaces all occurrences of the mentioned occurences and uses
of mentioned deleted* tables

upgrade is handled by moving rows from deleted* tables to the live
ones. If all rows are moved, the corresponding tables are dropped.
If there are duplicates or conflicts (duplicate barcodes e.g.) they
reminders are left for scrutiny and table renamed to _deleted*

Test plan:

1) Make sure you have a db with at least a few deleted biblios,
   biblioitems and items.
2) Apply patch and run updatedatabase.pl
3) Make note of the db upgrade messages, if you get a message like:
   There were x deleteditems that could not be moved, please check
_deleteditems
   you should check the _deleteditems table and verify that they are
   actual conflicts
4) Click around in the web interface and make sure you can delete items
   and biblios
5) "Undelete" an item by NULLing the deleted_at column for an item
   and verify that it returns in interface (Not neccessary really)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-14 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #74137|0   |1
is obsolete||

--- Comment #66 from Benjamin Rokseth  ---
Created attachment 74184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74184=edit
Bug 20271: update kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-14 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #74136|0   |1
is obsolete||

--- Comment #65 from Benjamin Rokseth  ---
Created attachment 74183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74183=edit
Bug 20271: fix remaining tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #74132|0   |1
is obsolete||

--- Comment #61 from Benjamin Rokseth  ---
Created attachment 74140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74140=edit
Bug 20271: add atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #74133|0   |1
is obsolete||

--- Comment #62 from Benjamin Rokseth  ---
Created attachment 74141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74141=edit
Bug 20271: Use a single pass in the OAI-PMH provider

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #74131|0   |1
is obsolete||

--- Comment #60 from Benjamin Rokseth  ---
Created attachment 74139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74139=edit
Bug 20271: remove comments regarding deleteditems and -biblio*

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #74129|0   |1
is obsolete||

--- Comment #58 from Benjamin Rokseth  ---
Created attachment 74137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74137=edit
Bug 20271: update kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #74128|0   |1
is obsolete||

--- Comment #57 from Benjamin Rokseth  ---
Created attachment 74136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74136=edit
Bug 20271: fix remaining tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #74134|0   |1
is obsolete||

--- Comment #63 from Benjamin Rokseth  ---
Created attachment 74142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74142=edit
Bug 20271: fix whitespace issues in C4::Items

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #74130|0   |1
is obsolete||

--- Comment #59 from Benjamin Rokseth  ---
Created attachment 74138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74138=edit
Bug 20271: delete biblio and biblio_metadata in one go

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #74127|0   |1
is obsolete||

--- Comment #56 from Benjamin Rokseth  ---
Created attachment 74135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74135=edit
Bug 20271: merging delete biblio/items

The present bug merges the following tables:
deletedbiblio  -> biblio
deletedbiblioitems -> biblioitems
deletedbiblio_metadata -> biblio_metadata
deleteditems   -> items

and adds a column deleted_at to signify time of deletion, if deleted

it replaces all occurrences of the mentioned occurences and uses
of mentioned deleted* tables

upgrade is handled by moving rows from deleted* tables to the live
ones. If all rows are moved, the corresponding tables are dropped.
If there are duplicates or conflicts (duplicate barcodes e.g.) they
reminders are left for scrutiny and table renamed to _deleted*

Test plan:

1) Make sure you have a db with at least a few deleted biblios,
   biblioitems and items.
2) Apply patch and run updatedatabase.pl
3) Make note of the db upgrade messages, if you get a message like:
   There were x deleteditems that could not be moved, please check
_deleteditems
   you should check the _deleteditems table and verify that they are
   actual conflicts
4) Click around in the web interface and make sure you can delete items
   and biblios
5) "Undelete" an item by NULLing the deleted_at column for an item
   and verify that it returns in interface (Not neccessary really)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #73760|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #73765|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #55 from Benjamin Rokseth  ---
Created attachment 74134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74134=edit
Bug 20271: fix whitespace issues in C4::Items

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #53 from Benjamin Rokseth  ---
Created attachment 74132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74132=edit
Bug 20271: add atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #73764|0   |1
is obsolete||

--- Comment #52 from Benjamin Rokseth  ---
Created attachment 74131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74131=edit
Bug 20271: remove comments regarding deleteditems and -biblio*

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #54 from Benjamin Rokseth  ---
Created attachment 74133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74133=edit
Bug 20271: Use a single pass in the OAI-PMH provider

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #73762|0   |1
is obsolete||

--- Comment #50 from Benjamin Rokseth  ---
Created attachment 74129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74129=edit
Bug 20271: update kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #73761|0   |1
is obsolete||

--- Comment #49 from Benjamin Rokseth  ---
Created attachment 74128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74128=edit
Bug 20271: fix remaining tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #73763|0   |1
is obsolete||

--- Comment #51 from Benjamin Rokseth  ---
Created attachment 74130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74130=edit
Bug 20271: delete biblio and biblio_metadata in one go

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #73759|0   |1
is obsolete||

--- Comment #48 from Benjamin Rokseth  ---
Created attachment 74127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74127=edit
Bug 20271: merging delete biblio/items

The present bug merges the following tables:
deletedbiblio  -> biblio
deletedbiblioitems -> biblioitems
deletedbiblio_metadata -> biblio_metadata
deleteditems   -> items

and adds a column deleted_at to signify time of deletion, if deleted

it replaces all occurrences of the mentioned occurences and uses
of mentioned deleted* tables

upgrade is handled by moving rows from deleted* tables to the live
ones. If all rows are moved, the corresponding tables are dropped.
If there are duplicates or conflicts (duplicate barcodes e.g.) they
reminders are left for scrutiny and table renamed to _deleted*

Test plan:

1) Make sure you have a db with at least a few deleted biblios,
   biblioitems and items.
2) Apply patch and run updatedatabase.pl
3) Make note of the db upgrade messages, if you get a message like:
   There were x deleteditems that could not be moved, please check
_deleteditems
   you should check the _deleteditems table and verify that they are
   actual conflicts
4) Click around in the web interface and make sure you can delete items
   and biblios
5) "Undelete" an item by NULLing the deleted_at column for an item
   and verify that it returns in interface (Not neccessary really)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-12 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Chris Slone  changed:

   What|Removed |Added

 CC||cslone@camdencountylibrary.
   ||org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-11 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #73537|0   |1
is obsolete||

--- Comment #47 from Benjamin Rokseth  ---
Comment on attachment 73537
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73537
Bug 20271: fix remaining tests, add checks and report in atomicupdate

Forgot to obsolete this

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-06 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #46 from Benjamin Rokseth  ---
Replaced die with warn in atomicupdate, and rebased and squashed a bit.
Should be ready for testing now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-06 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #41 from Benjamin Rokseth  ---
Created attachment 73761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73761=edit
Bug 20271: fix remaining tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-06 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #73597|0   |1
is obsolete||

--- Comment #45 from Benjamin Rokseth  ---
Created attachment 73765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73765=edit
Bug 20271 - Use a single pass in the OAI-PMH provider

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-06 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #73538|0   |1
is obsolete||

--- Comment #42 from Benjamin Rokseth  ---
Created attachment 73762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73762=edit
Bug 20271: update kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-06 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #73540|0   |1
is obsolete||

--- Comment #44 from Benjamin Rokseth  ---
Created attachment 73764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73764=edit
Bug 20271: remove comments regarding deleteditems and -biblio*

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-06 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #73539|0   |1
is obsolete||

--- Comment #43 from Benjamin Rokseth  ---
Created attachment 73763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73763=edit
Bug 20271: delete biblio and biblio_metadata in one go

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-06 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #73536|0   |1
is obsolete||

--- Comment #40 from Benjamin Rokseth  ---
Created attachment 73760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73760=edit
Bug 20271 - merge deletedbiblio and -items back - add atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-06 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #73535|0   |1
is obsolete||

--- Comment #39 from Benjamin Rokseth  ---
Created attachment 73759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73759=edit
Bug 20271: merging delete biblio/items

NOTE: deleteditems/biblio on OAI
not sure how to test this, but the changes should be good enough

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #38 from Ere Maijala  ---
Ok, fair enough. I think Benjamin's proposal of dropping both without die'ing
makes sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #37 from Francesco Rivetti  ---
(In reply to Benjamin Rokseth from comment #36)
> fail to remember, but probably I put it there because otherwise it
> complained, perhaps due to the "rename table". the idea was that any
> leftovers from conflicts should be moved to temporary tables (prepended with
> _) so that one could check and delete them at convenience

We had to drop the constraint to avoid the delete on cascade. When we clean up
the deletedbiblio andt able, we don't want to drop any items which were left
behind because not properly merged.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #36 from Benjamin Rokseth  ---
(In reply to Benjamin Rokseth from comment #32)
> (In reply to Ere Maijala from comment #31)
> > I'm working on it now. 
> > 
> > 
> > Looks like there may be a typo in the atomic update. I got the following
> > error:
> > 
> > updatedatabase.pl: DBD::mysql::db do failed: Can't DROP FOREIGN KEY
> > `deletedbiblio_metadata_fk_1`; check that it exists [for Statement "ALTER
> > TABLE deletedbiblio_metadata DROP FOREIGN KEY deletedbiblio_metadata_fk_1"]
> > at (eval 1389) line 8.
> > 
> > Looking at the old kohastructure.sql I believe it should have tried to drop
> > 'deletedrecord_metadata_fk_1'.
> 
> hmm, sad to say, but no, it's not a typo but db design issues.
> this commit seems to have added to the confusion:
> https://github.com/Koha-Community/Koha/commit/
> 739e2e0c5dc26502e195e2cc4c687ababdcaf381 (Bug 17196)
> 
> and following Bug 18284 you can see that most agree on deleted* tables being
> a bad idea in the first place.
> 
> Problem is, kohastructure.sql and updatedatabase.pl is not in sync and
> libraries having migrated from 16.05 and before would need to delete this
> foreign key. And this patch is most important for them anyways.
> 
> I suppose we could add a delete foreign key for both and ignore errors
> rather than die in the final version

fail to remember, but probably I put it there because otherwise it complained,
perhaps due to the "rename table". the idea was that any leftovers from
conflicts should be moved to temporary tables (prepended with _) so that one
could check and delete them at convenience

I will remove the dies in the atomicupdate and see if it works for us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #35 from Ere Maijala  ---
Changes for the OAI-PMH provider have been attached. I'm really happy to make
it so much more simple. Please feel free to rebase or whatever is necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #34 from Ere Maijala  ---
Created attachment 73597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73597=edit
Bug 20271 - Use a single pass in the OAI-PMH provider

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #33 from Ere Maijala  ---
Oh, that's a nasty one. But do you even have to drop the constraints to delete
the table? I think it's enough to drop the table and all the constraints there
would be dropped too, no?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #32 from Benjamin Rokseth  ---
(In reply to Ere Maijala from comment #31)
> I'm working on it now. 
> 
> 
> Looks like there may be a typo in the atomic update. I got the following
> error:
> 
> updatedatabase.pl: DBD::mysql::db do failed: Can't DROP FOREIGN KEY
> `deletedbiblio_metadata_fk_1`; check that it exists [for Statement "ALTER
> TABLE deletedbiblio_metadata DROP FOREIGN KEY deletedbiblio_metadata_fk_1"]
> at (eval 1389) line 8.
> 
> Looking at the old kohastructure.sql I believe it should have tried to drop
> 'deletedrecord_metadata_fk_1'.

hmm, sad to say, but no, it's not a typo but db design issues.
this commit seems to have added to the confusion:
https://github.com/Koha-Community/Koha/commit/739e2e0c5dc26502e195e2cc4c687ababdcaf381
(Bug 17196)

and following Bug 18284 you can see that most agree on deleted* tables being a
bad idea in the first place.

Problem is, kohastructure.sql and updatedatabase.pl is not in sync and
libraries having migrated from 16.05 and before would need to delete this
foreign key. And this patch is most important for them anyways.

I suppose we could add a delete foreign key for both and ignore errors rather
than die in the final version

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #31 from Ere Maijala  ---
I'm working on it now. 


Looks like there may be a typo in the atomic update. I got the following error:

updatedatabase.pl: DBD::mysql::db do failed: Can't DROP FOREIGN KEY
`deletedbiblio_metadata_fk_1`; check that it exists [for Statement "ALTER TABLE
deletedbiblio_metadata DROP FOREIGN KEY deletedbiblio_metadata_fk_1"] at (eval
1389) line 8.

Looking at the old kohastructure.sql I believe it should have tried to drop
'deletedrecord_metadata_fk_1'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-02 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #30 from Benjamin Rokseth  ---
rebased against master and added fixes to comments except OAI.

Ere, since you voluntered to add the neccessary fixes to OAI, I leave them to
you ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-02 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #27 from Benjamin Rokseth  ---
Created attachment 73538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73538=edit
Bug 20271: update kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-02 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #73093|0   |1
is obsolete||

--- Comment #26 from Benjamin Rokseth  ---
Created attachment 73537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73537=edit
Bug 20271: fix remaining tests, add checks and report in atomicupdate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-02 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #29 from Benjamin Rokseth  ---
Created attachment 73540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73540=edit
Bug 20271: remove comments regarding deleteditems and -biblio*

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-02 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #28 from Benjamin Rokseth  ---
Created attachment 73539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73539=edit
Bug 20271: delete biblio and biblio_metadata in one go

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-02 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #73091|0   |1
is obsolete||

--- Comment #24 from Benjamin Rokseth  ---
Created attachment 73535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73535=edit
Bug 20271: merging delete biblio/items

NOTE: deleteditems/biblio on OAI
not sure how to test this, but the changes should be good enough

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-04-02 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #73092|0   |1
is obsolete||

--- Comment #25 from Benjamin Rokseth  ---
Created attachment 73536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73536=edit
Bug 20271 - merge deletedbiblio and -items back - add atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-03-27 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #23 from Ere Maijala  ---
Sorry for the comment spam... one more: the call to
_koha_delete_biblio_metadata has been removed from _koha_delete_biblio. As far
as I can see nothing takes care of marking the metadata record deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-03-27 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #22 from Ere Maijala  ---
And one more: there are still comments that refer to the deleted* tables.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-03-27 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #21 from Ere Maijala  ---
One more note: I couldn't find any changes to kohastructure.sql. Are they
missing from the patches or did I just miss them?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-03-27 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #20 from Ere Maijala  ---
I think the OAI-PMH provider should now be changed to return all records in a
single pass. It was built to return deleted records separately because that was
much faster than joining tables on the fly, but when deleted and non-deleted
records are in the same table this complication is not needed anymore. I think
the whole ListBase class could be removed in this case.

Please let me know if you'd rather let me do the relevant changes in the OAI
classes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-03-26 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Ere Maijala  changed:

   What|Removed |Added

 CC||ere.maij...@helsinki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-03-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-03-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #19 from Francesco Rivetti  ---
thanks Benjamin!

(In reply to Benjamin Rokseth from comment #16)
> Created attachment 73093 [details] [review]
> Bug 20271: fix remaining tests, add checks and report in atomicupdate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-03-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #18 from Benjamin Rokseth  ---
raised the importance to critical since it does in fact lead to data loss and
possibly data corruption

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-03-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

   Severity|major   |critical

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-03-19 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #17 from Benjamin Rokseth  ---
Ready for testing now, test plan:

1) make sure you have some deleted biblios and items
2) apply patch and run updatedatabase
3) if you have any clashing keys, they should be reported during updatedatabase
and be left in renamed corresponding tables with _ (e.g. _deleteditems)
4) run update_dbix_class_files.pl (to make sure schemas and rest api are ok)
5) check that db_dependent tests concerning biblios and items pass OK
6) check that you can still delete items and biblio
7) for any deleted item or biblio, you should now have a timestamp in the
'deleted_at' column.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-03-19 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #72799|0   |1
is obsolete||

--- Comment #14 from Benjamin Rokseth  ---
Created attachment 73091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73091=edit
Bug 20271: merging delete biblio/items

NOTE: deleteditems/biblio on OAI
not sure how to test this, but the changes should be good enough

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-03-19 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #72800|0   |1
is obsolete||

--- Comment #15 from Benjamin Rokseth  ---
Created attachment 73092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73092=edit
Bug 20271 - merge deletedbiblio and -items back - add atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-03-19 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #16 from Benjamin Rokseth  ---
Created attachment 73093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73093=edit
Bug 20271: fix remaining tests, add checks and report in atomicupdate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-03-15 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #13 from Francesco Rivetti  ---
(In reply to Jon Knight from comment #12)
> Just a random thought to throw into this: would it be worth creating
> database views to replicate the old tables based on the new ones?  That way
> if any installations have pre-existing reports that use the old tables in
> their queries, they will still continue to work.
> 
> For example something like this:
> 
> CREATE VIEW old_issues AS SELECT * FROM issues WHERE deleted_at IS NOT NULL;

I thought about it, but you most likely need the view for "issues" than
"old_issues", which means:

RENAME TABLE issues TO all_issues;
CREATE VIEW issues AS SELECT * FROM issues WHERE delted_at IS NULL;

but then, more code will need to be changed for updates/insert/deletes

OTOH, most reports UNION issues with old_issues, might be smart to take this
opportunity to simplify them?

(note, this applies to deleteditems/biblios as well)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-03-14 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jon Knight  changed:

   What|Removed |Added

 CC||j.p.kni...@lboro.ac.uk

--- Comment #12 from Jon Knight  ---
Just a random thought to throw into this: would it be worth creating database
views to replicate the old tables based on the new ones?  That way if any
installations have pre-existing reports that use the old tables in their
queries, they will still continue to work.

For example something like this:

CREATE VIEW old_issues AS SELECT * FROM issues WHERE deleted_at IS NOT NULL;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-03-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #11 from Benjamin Rokseth  ---
Updated the failing tests, except for the weird GetItemsForInventory test which
needs another look.

Ready for testing, we renamed the ticket to only concern tables deletedbiblio,
deletedbiblioitems, deletedbiblio_metadata and deleteditems, since they are
most crucial to avoid more data loss and corruption.

Suggest to rename deleted* tables temporarily before deleting them, so any
merge conflicts can be examined first

Also suggest to run misc/devel/update_dbix_class_files.pl after, so schema/apis
etc work as expected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-03-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #10 from Benjamin Rokseth  ---
Created attachment 72800
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72800=edit
Bug 20271 - merge deletedbiblio and -items back - add atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-03-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #72300|0   |1
is obsolete||

--- Comment #9 from Benjamin Rokseth  ---
Created attachment 72799
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72799=edit
Bug 20271: merging delete biblio/items

NOTE: deleteditems/biblio on OAI
not sure how to test this, but the changes should be good enough

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

2018-03-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

 CC||benjamin.rokseth@deichman.n
   ||o
Summary|Merge deleted/old tables|Merge deletedbiblio* and
   |with their "alive" cousins  |deleteitems tables with
   ||their "alive" cousins

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/