[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Stable|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #58 from Mason James  ---
(In reply to Jonathan Druart from comment #51)
> Pushed to master for 18.05, thanks to everybody involved!

hi Frido, would you accept this patchset for the 17.11 release?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #57 from Mason James  ---
(In reply to Narcis Garcia from comment #52)
> PHP uses parameter "upload_tmp_dir", usually set at php.ini or webserver
> site profile. Doesn't Perl have some similar to not make necessary to check
> filesystem paths and permissions?
> 
> I have a Koha 17.11 running in Debian 9 (Stretch) without problem about
> uploads. How does Koha 17.11 deal with this?

fyi: i've hit this problem on deb9 with 17.11.6 + plack

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Pongtawat  changed:

   What|Removed |Added

 CC||janus...@gmail.com

--- Comment #56 from Pongtawat  ---
*** Bug 19676 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Eugene Espinoza  changed:

   What|Removed |Added

 CC||eugen...@yahoo.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #55 from Jonathan Druart  
---
(In reply to Narcis Garcia from comment #54)
> Is "template_cache_dir" parameter affected by this issue?

No

> I have Koha 17.11 running on Debian 9 without this directive. Should I
> enable it when following performance recommendations?

Yes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #54 from Narcis Garcia  ---
Is "template_cache_dir" parameter affected by this issue?
I have Koha 17.11 running on Debian 9 without this directive. Should I enable
it when following performance recommendations?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #53 from Jonathan Druart  
---
(In reply to Narcis Garcia from comment #52)
> PHP uses parameter "upload_tmp_dir", usually set at php.ini or webserver
> site profile. Doesn't Perl have some similar to not make necessary to check
> filesystem paths and permissions?
> 
> I have a Koha 17.11 running in Debian 9 (Stretch) without problem about
> uploads. How does Koha 17.11 deal with this?

Did you see comment 4?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Narcis Garcia  changed:

   What|Removed |Added

 CC||informat...@actiu.net

--- Comment #52 from Narcis Garcia  ---
PHP uses parameter "upload_tmp_dir", usually set at php.ini or webserver site
profile. Doesn't Perl have some similar to not make necessary to check
filesystem paths and permissions?

I have a Koha 17.11 running in Debian 9 (Stretch) without problem about
uploads. How does Koha 17.11 deal with this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_18_05_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #51 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #50 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #48)
> (In reply to Jonathan Druart from comment #46)
> > (In reply to Marcel de Rooy from comment #45)
> > > I would recommend release notes and a db rev warning to alert people to 
> > > move
> > > existing installs in this direction.
> > 
> > Maybe on the about page?
> 
> Yeah, there is an about warning already on the new tmp config var. A print
> warning from updatedatabase would be extra.

I do not think it is necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #49 from Jonathan Druart  
---
Created attachment 75305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75305=edit
Bug 20428: Display warning if the entry is empty

And not only if the entry is missing. We should do the same for other
entries.
Also, use Koha::UploadedFile->temporary_directory to know the fallback
value.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #48 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #46)
> (In reply to Marcel de Rooy from comment #45)
> > I would recommend release notes and a db rev warning to alert people to move
> > existing installs in this direction.
> 
> Maybe on the about page?

Yeah, there is an about warning already on the new tmp config var. A print
warning from updatedatabase would be extra.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #47 from Tomás Cohen Arazi  ---
(In reply to Marcel de Rooy from comment #45)
> I would recommend release notes and a db rev warning to alert people to move
> existing installs in this direction.

I agree there should be an IMPORTANT: notice in the release notes for people in
Stretch. And I think it is not the only one on this release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #46 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #45)
> I would recommend release notes and a db rev warning to alert people to move
> existing installs in this direction.

Maybe on the about page?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #45 from Marcel de Rooy  ---
I would recommend release notes and a db rev warning to alert people to move
existing installs in this direction.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75286|0   |1
is obsolete||

--- Comment #43 from Marcel de Rooy  ---
Created attachment 75297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75297=edit
Bug 20428: Make upload_tmp a more general tmp directory

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #44 from Marcel de Rooy  ---
Created attachment 75298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75298=edit
Bug 20428: (QA follow-up) Remove redundant directory level

Upload creates its own upload folder in the temp folder, so there is no
need to add another level in temporary_directory.
Removing the creation of this folder in koha-create-dirs too.

Also removing the use Koha::UploadedFiles in about.pl. No longer needed.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75282|0   |1
is obsolete||

--- Comment #42 from Marcel de Rooy  ---
Created attachment 75296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75296=edit
Bug 20428: Added missing parameter --upload-tmp-path

Line 463 lists valid parameters, but it was missing
upload-tmp-path: which resulted in the koha-create
saying it is an invalid parameter.

TEST PLAN
-
1) apply all patches but this.
2) sudo perl ~/misc4dev/cp_debian_files.pl
3) restart_all
4) sudo koha-create --create-db --upload-tmp-path unique-path
awesome-test-name
   -- Fails to run.
5) apply this patch
6) repeat 2-4
7) sudo vi /etc/koha/sites/awesome-test-name/koha-conf.xml
   -- the upload_tmp_path entry should have unique-path
  in it.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75280|0   |1
is obsolete||

--- Comment #40 from Marcel de Rooy  ---
Created attachment 75294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75294=edit
Bug 20428: Make Koha::UploadedFile use the new config entry for tmp files

This patch makes Koha::UploadedFile->temporary_directory try to use the
new configuration entry. It will fallback to File::Spec->tmpdir
otherwise.

Signed-off-by: Kyle M Hall 

Signed-off-by: Mark Tompsett 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75279|0   |1
is obsolete||

--- Comment #39 from Marcel de Rooy  ---
Created attachment 75293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75293=edit
Bug 20428: Add the option to specify a tmp uploads dir

This patch adds an option to the koha-conf.xml file for specifying
a temporary uploaded files directory.

The koha-create script is adjusted to handle it and a convenient option
switch is added. If ommited, it will default to
/var/lib/koha//uploads_tmp.

koha-create-dirs is patched to create the required directory with the
right permissions.

The docs get the new parameter documented.

Signed-off-by: Kyle M Hall 

Signed-off-by: Mark Tompsett 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75281|0   |1
is obsolete||

--- Comment #41 from Marcel de Rooy  ---
Created attachment 75295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75295=edit
Bug 20428: Make about.pl inform about missing upload_tmp_path entry

This patch makes about.pl warn about a missing upload_tmp_path entry in
koha-conf.xml. It also mentions the effectively used tmp dir.

Signed-off-by: Kyle M Hall 

Signed-off-by: Mark Tompsett 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #38 from Marcel de Rooy  ---
dev-koha@dev:/usr/share/koha/devclone$ ll /var/lib/koha/dev/tmp/uploads/
drwxr-xr-x 2 dev-koha dev-koha 4096 May 14 08:56 koha_dev_upload

Removing this additional level. In an enhancement we can remove the database
name from the main upload folder in tmp since it is instance bound now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #37 from Marcel de Rooy  ---
(In reply to Tomás Cohen Arazi from comment #36)
> Marcel: can you review the last changes?

QA: Looking here now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #36 from Tomás Cohen Arazi  ---
Marcel: can you review the last changes?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #75283|0   |1
is obsolete||

--- Comment #35 from Tomás Cohen Arazi  ---
Created attachment 75286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75286=edit
Bug 20428: Make upload_tmp a more general tmp directory

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #75172|0   |1
is obsolete||

--- Comment #33 from Tomás Cohen Arazi  ---
Created attachment 75282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75282=edit
Bug 20428: Added missing parameter --upload-tmp-path

Line 463 lists valid parameters, but it was missing
upload-tmp-path: which resulted in the koha-create
saying it is an invalid parameter.

TEST PLAN
-
1) apply all patches but this.
2) sudo perl ~/misc4dev/cp_debian_files.pl
3) restart_all
4) sudo koha-create --create-db --upload-tmp-path unique-path
awesome-test-name
   -- Fails to run.
5) apply this patch
6) repeat 2-4
7) sudo vi /etc/koha/sites/awesome-test-name/koha-conf.xml
   -- the upload_tmp_path entry should have unique-path
  in it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #75275|0   |1
is obsolete||

--- Comment #34 from Tomás Cohen Arazi  ---
Created attachment 75283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75283=edit
Bug 20428: Make upload_tmp a more general tmp directory

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #75171|0   |1
is obsolete||

--- Comment #32 from Tomás Cohen Arazi  ---
Created attachment 75281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75281=edit
Bug 20428: Make about.pl inform about missing upload_tmp_path entry

This patch makes about.pl warn about a missing upload_tmp_path entry in
koha-conf.xml. It also mentions the effectively used tmp dir.

Signed-off-by: Kyle M Hall 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #75170|0   |1
is obsolete||

--- Comment #31 from Tomás Cohen Arazi  ---
Created attachment 75280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75280=edit
Bug 20428: Make Koha::UploadedFile use the new config entry for tmp files

This patch makes Koha::UploadedFile->temporary_directory try to use the
new configuration entry. It will fallback to File::Spec->tmpdir
otherwise.

Signed-off-by: Kyle M Hall 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #75169|0   |1
is obsolete||

--- Comment #30 from Tomás Cohen Arazi  ---
Created attachment 75279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75279=edit
Bug 20428: Add the option to specify a tmp uploads dir

This patch adds an option to the koha-conf.xml file for specifying
a temporary uploaded files directory.

The koha-create script is adjusted to handle it and a convenient option
switch is added. If ommited, it will default to
/var/lib/koha//uploads_tmp.

koha-create-dirs is patched to create the required directory with the
right permissions.

The docs get the new parameter documented.

Signed-off-by: Kyle M Hall 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #29 from Tomás Cohen Arazi  ---
Created attachment 75275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75275=edit
Bug 20428: Make upload_tmp a more general tmp directory

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |ASSIGNED

--- Comment #28 from Tomás Cohen Arazi  ---
(In reply to Marcel de Rooy from comment #27)
> (In reply to Tomás Cohen Arazi from comment #26)
> > (In reply to Marcel de Rooy from comment #19)
> > > No access to /tmp? This will probably affect much more than upload?
> > > What about CGI sessions? Several cron jobs ?
> > > We should also look for hardcoded /tmp's in the codebase..
> > > etc.
> > > 
> > > Or make sure that koha-instance has enough permissions at install/upgrade 
> > > ?
> > 
> > You are right about this being a broader problem for Stretch users. Kyle
> > filed bug 20727 to have that conversation as this one only deals with file
> > uploads.
> 
> I think koha-conf should contain an entry for an alternative tmp directory.
> Upload should then create a subfolder there.
> But the config var should be more general and not be upload-tmp-path..

I agree. Will try to provide a sensible follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #27 from Marcel de Rooy  ---
(In reply to Tomás Cohen Arazi from comment #26)
> (In reply to Marcel de Rooy from comment #19)
> > No access to /tmp? This will probably affect much more than upload?
> > What about CGI sessions? Several cron jobs ?
> > We should also look for hardcoded /tmp's in the codebase..
> > etc.
> > 
> > Or make sure that koha-instance has enough permissions at install/upgrade ?
> 
> You are right about this being a broader problem for Stretch users. Kyle
> filed bug 20727 to have that conversation as this one only deals with file
> uploads.

I think koha-conf should contain an entry for an alternative tmp directory.
Upload should then create a subfolder there.
But the config var should be more general and not be upload-tmp-path..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #26 from Tomás Cohen Arazi  ---
(In reply to Marcel de Rooy from comment #19)
> No access to /tmp? This will probably affect much more than upload?
> What about CGI sessions? Several cron jobs ?
> We should also look for hardcoded /tmp's in the codebase..
> etc.
> 
> Or make sure that koha-instance has enough permissions at install/upgrade ?

You are right about this being a broader problem for Stretch users. Kyle filed
bug 20727 to have that conversation as this one only deals with file uploads.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #25 from Tomás Cohen Arazi  ---
This is PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

M. Tompsett  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff
 CC||mtomp...@hotmail.com

--- Comment #24 from M. Tompsett  ---
I'm going for lunch, but I'll have to test this on Stretch for a MARC import to
be sure. Changing back to needs signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

M. Tompsett  changed:

   What|Removed |Added

  Attachment #75162|0   |1
is obsolete||

--- Comment #20 from M. Tompsett  ---
Created attachment 75169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75169=edit
Bug 20428: Add the option to specify a tmp uploads dir

This patch adds an option to the koha-conf.xml file for specifying
a temporary uploaded files directory.

The koha-create script is adjusted to handle it and a convenient option
switch is added. If ommited, it will default to
/var/lib/koha//uploads_tmp.

koha-create-dirs is patched to create the required directory with the
right permissions.

The docs get the new parameter documented.

Signed-off-by: Kyle M Hall 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

M. Tompsett  changed:

   What|Removed |Added

  Attachment #75164|0   |1
is obsolete||

--- Comment #22 from M. Tompsett  ---
Created attachment 75171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75171=edit
Bug 20428: Make about.pl inform about missing upload_tmp_path entry

This patch makes about.pl warn about a missing upload_tmp_path entry in
koha-conf.xml. It also mentions the effectively used tmp dir.

Signed-off-by: Kyle M Hall 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

M. Tompsett  changed:

   What|Removed |Added

  Attachment #75163|0   |1
is obsolete||

--- Comment #21 from M. Tompsett  ---
Created attachment 75170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75170=edit
Bug 20428: Make Koha::UploadedFile use the new config entry for tmp files

This patch makes Koha::UploadedFile->temporary_directory try to use the
new configuration entry. It will fallback to File::Spec->tmpdir
otherwise.

Signed-off-by: Kyle M Hall 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #23 from M. Tompsett  ---
Created attachment 75172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75172=edit
Bug 20428: Added missing parameter --upload-tmp-path

Line 463 lists valid parameters, but it was missing
upload-tmp-path: which resulted in the koha-create
saying it is an invalid parameter.

TEST PLAN
-
1) apply all patches but this.
2) sudo perl ~/misc4dev/cp_debian_files.pl
3) restart_all
4) sudo koha-create --create-db --upload-tmp-path unique-path
awesome-test-name
   -- Fails to run.
5) apply this patch
6) repeat 2-4
7) sudo vi /etc/koha/sites/awesome-test-name/koha-conf.xml
   -- the upload_tmp_path entry should have unique-path
  in it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #19 from Marcel de Rooy  ---
No access to /tmp? This will probably affect much more than upload?
What about CGI sessions? Several cron jobs ?
We should also look for hardcoded /tmp's in the codebase..
etc.

Or make sure that koha-instance has enough permissions at install/upgrade ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #17 from Kyle M Hall  ---
Created attachment 75163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75163=edit
Bug 20428: Make Koha::UploadedFile use the new config entry for tmp files

This patch makes Koha::UploadedFile->temporary_directory try to use the
new configuration entry. It will fallback to File::Spec->tmpdir
otherwise.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #18 from Kyle M Hall  ---
Created attachment 75164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75164=edit
Bug 20428: Make about.pl inform about missing upload_tmp_path entry

This patch makes about.pl warn about a missing upload_tmp_path entry in
koha-conf.xml. It also mentions the effectively used tmp dir.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #75159|0   |1
is obsolete||
  Attachment #75160|0   |1
is obsolete||
  Attachment #75161|0   |1
is obsolete||

--- Comment #16 from Kyle M Hall  ---
Created attachment 75162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75162=edit
Bug 20428: Add the option to specify a tmp uploads dir

This patch adds an option to the koha-conf.xml file for specifying
a temporary uploaded files directory.

The koha-create script is adjusted to handle it and a convenient option
switch is added. If ommited, it will default to
/var/lib/koha//uploads_tmp.

koha-create-dirs is patched to create the required directory with the
right permissions.

The docs get the new parameter documented.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||20727


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727
[Bug 20727] Replace usage of File::Spec->tmpdir with
Koha::UploadedFile->temporary_directory
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #73430|0   |1
is obsolete||

--- Comment #14 from Tomás Cohen Arazi  ---
Created attachment 75160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75160=edit
Bug 20428: Make Koha::UploadedFile use the new config entry for tmp files

This patch makes Koha::UploadedFile->temporary_directory try to use the
new configuration entry. It will fallback to File::Spec->tmpdir
otherwise.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #73429|0   |1
is obsolete||

--- Comment #13 from Tomás Cohen Arazi  ---
Created attachment 75159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75159=edit
Bug 20428: Add the option to specify a tmp uploads dir

This patch adds an option to the koha-conf.xml file for specifying
a temporary uploaded files directory.

The koha-create script is adjusted to handle it and a convenient option
switch is added. If ommited, it will default to
/var/lib/koha//uploads_tmp.

koha-create-dirs is patched to create the required directory with the
right permissions.

The docs get the new parameter documented.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #73431|0   |1
is obsolete||

--- Comment #15 from Tomás Cohen Arazi  ---
Created attachment 75161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75161=edit
Bug 20428: Make about.pl inform about missing upload_tmp_path entry

This patch makes about.pl warn about a missing upload_tmp_path entry in
koha-conf.xml. It also mentions the effectively used tmp dir.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #12 from M. Tompsett  ---
Comment on attachment 73430
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73430
Bug 20428: Make Koha::UploadedFile use the new config entry for tmp files

Review of attachment 73430:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20428=73430)
-

::: Koha/UploadedFile.pm
@@ +169,5 @@
>  sub temporary_directory {
>  my ( $class ) = @_;
> +return (C4::Context->config('upload_tmp_path'))
> +? C4::Context->config('upload_tmp_path')
> +: File::Spec->tmpdir;

Why a trinary when a || File::Spec->tmpdir would work more nicely?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||cbut...@gmail.com

--- Comment #11 from Tomás Cohen Arazi  ---
*** Bug 19898 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #73427|0   |1
is obsolete||

--- Comment #9 from Tomás Cohen Arazi  ---
Created attachment 73430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73430=edit
Bug 20428: Make Koha::UploadedFile use the new config entry for tmp files

This patch makes Koha::UploadedFile->temporary_directory try to use the
new configuration entry. It will fallback to File::Spec->tmpdir
otherwise.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #73428|0   |1
is obsolete||

--- Comment #10 from Tomás Cohen Arazi  ---
Created attachment 73431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73431=edit
Bug 20428: Make about.pl inform about missing upload_tmp_path entry

This patch makes about.pl warn about a missing upload_tmp_path entry in
koha-conf.xml. It also mentions the effectively used tmp dir.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #73426|0   |1
is obsolete||

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 73429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73429=edit
Bug 20428: Add the option to specify a tmp uploads dir

This patch adds an option to the koha-conf.xml file for specifying
a temporary uploaded files directory.

The koha-create script is adjusted to handle it and a convenient option
switch is added. If ommited, it will default to
/var/lib/koha//uploads_tmp.

koha-create-dirs is patched to create the required directory with the
right permissions.

The docs get the new parameter documented.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #6 from Tomás Cohen Arazi  ---
Created attachment 73427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73427=edit
Bug 20428: Make Koha::UploadedFile use the new config entry for tmp files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 73428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73428=edit
Bug 20428: Make about.pl inform about missing upload_tmp_path entry

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 73426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73426=edit
Bug 20428: Add the option to specify a tmp uploads dir

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #4 from Tomás Cohen Arazi  ---
(In reply to paxed from comment #3)
> Would this be caused by systemd PrivateTmp?
> 
> https://www.maxoberberger.net/blog/2017/10/debian-9-private-tmp.html

That's the most probable cause! But the solution should be what Kyle said:
creating a per-instance temp dir and adjusting the cleanup script to deal with
it too.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

paxed  changed:

   What|Removed |Added

 CC||pasi.kalli...@joensuu.fi

--- Comment #3 from paxed  ---
Would this be caused by systemd PrivateTmp?

https://www.maxoberberger.net/blog/2017/10/debian-9-private-tmp.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #2 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #1)
> If it is confirmed, it's blocker for 18.05

To give a bit more detail, we had two Koha servers that were upgraded to
Stretch. Both servers exhibited this behavior. The file upload would work just
fine, the files would show up in /tmp as expected, but then Koha was unable to
'see' those files. In the code, if you printed a list of files in /tmp, Koha
would see the tmp dir as empty! It's like to Koha, /tmp was a write-only
filesystem!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||tomasco...@gmail.com
   Keywords||rel_18_05_candidate

--- Comment #1 from Jonathan Druart  
---
If it is confirmed, it's blocker for 18.05

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Josef Moravec  changed:

   What|Removed |Added

 CC||blac...@gmail.com,
   ||josef.mora...@gmail.com,
   ||r...@rbit.cz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/