subject:"\[Koha\-bugs\] \[Bug 20589\] Add field boosting and use elastic query fields parameter instead of deprecated

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2021-05-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||28279


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279
[Bug 28279] mappings.yaml no longer in sync
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2020-11-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2020-07-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Nick Clemens  changed:

   What|Removed |Added

 Blocks||25864


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25864
[Bug 25864] Case sensitivity breaks searching of some fields in ES5
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #74 from Martin Renvoize  ---
Thanks for the fast followup Nick :) Pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #73 from Nick Clemens  ---
(In reply to Martin Renvoize from comment #70)
> Hmm, I think it's this one that causing a fair few breaks in tests on master
> right now.. 
> 
> I've narrowed down some of the issues.. for example I don't think we need
> the Koha::SearchFields->weighted_fields tests at all any more (you've
> removed the method entirely in your patch but missed this test).
> 
> But, there are some more I'm less confident about.. can you guys take a look
> please?

I attached a patch, I think the mappings test is probably not the best, but I
think we should delete/replace it on its own bug, this gets things running
again for now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #72 from Nick Clemens  ---
Created attachment 93624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93624=edit
Bug 20589: (follow-up) Fix tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #71 from Martin Renvoize  ---
Created attachment 93590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93590=edit
Bug 20589: (RM follow-up) Fix Koha::SearchField.t

This patch removes the unit test for the weighted_fields method which
this bug removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #70 from Martin Renvoize  ---
Hmm, I think it's this one that causing a fair few breaks in tests on master
right now.. 

I've narrowed down some of the issues.. for example I don't think we need the
Koha::SearchFields->weighted_fields tests at all any more (you've removed the
method entirely in your patch but missed this test).

But, there are some more I'm less confident about.. can you guys take a look
please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #69 from David Gustafsson  ---
Wonderful, thanks everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||Manual,
   ||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #68 from Martin Renvoize  ---
Thanks all, great enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #67 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20388

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Alex Arnaud  changed:

   What|Removed |Added

 QA Contact||alex.arn...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Alex Arnaud  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #66 from Alex Arnaud  ---
 - Proposed features works
 - QA tools ok,
 - code ok,
 - work with ES 5.x and 6.x
 - also fix a relevance sorting issue. Great!

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #93352|0   |1
is obsolete||

--- Comment #64 from Alex Arnaud  ---
Created attachment 93383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93383=edit
Bug 20589: DO NOT PUSH Schema changes

Signed-off-by: Nick Clemens 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #93353|0   |1
is obsolete||

--- Comment #65 from Alex Arnaud  ---
Created attachment 93384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93384=edit
Bug 20589: Remove expanded_facet variable and fix tests

Thi is a rebase from 14419 to remove an unused variable

Also update tests to expect the new expected result

Signed-off-by: Nick Clemens 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #93350|0   |1
is obsolete||

--- Comment #62 from Alex Arnaud  ---
Created attachment 93381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93381=edit
Bug 20589: Exclude boolean fields from search fields

Signed-off-by: Nick Clemens 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #93348|0   |1
is obsolete||

--- Comment #60 from Alex Arnaud  ---
Created attachment 93379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93379=edit
Bug 20589: Add field boosting and use query_string fields parameter

Generate a list of fields for the query_string query fields parameter,
with possible boosts, instead of using "_all"-field. Also add "search"
flag in search_marc_to_field table so that certain mappings can be
excluded from searches. Add option to include/exclude fields in
query_string "fields" parameter depending on searching in OPAC or staff
client. Refactor code to remove all other dependencies on "_all"-field.

How to test:
1) Reindex authorities and biblios.
2) Search biblios and try to verify that this works as expected.
3) Search authorities and try to verify that this works as expected.
4) Go to "Search engine configuration"
5) Change some "Boost", "Staff client", and "OPAC" settings and save.
6) Verify that those settings where saved accordingly.
7) Click the "Biblios" or "Authorities" tab and change one or more
   "Searchable" settings
8) Verfiy that those settings where saved accordingly.
9) Try to verify that these settings has taken effect by peforming
   some biblios and/or authorities searches.

Sponsorded-by: Gothenburg Univesity Library

Signed-off-by: Nick Clemens 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #93351|0   |1
is obsolete||

--- Comment #63 from Alex Arnaud  ---
Created attachment 93382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93382=edit
Bug 20589: Add option for searching entire record if record stored as array

Signed-off-by: Nick Clemens 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #93349|0   |1
is obsolete||

--- Comment #61 from Alex Arnaud  ---
Created attachment 93380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93380=edit
Bug 20589: fix QueryBuilder tests

Signed-off-by: Nick Clemens 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #59 from Nick Clemens  ---
Added minor followup

Everything seems to work as expected. The authority searching changes seem to
be an improvement:
previously an 'exact' search matched any term, now it must match the entire
field. Punctuation could be excluded in the future, but exact match should eb
exact so I think good

starts with searches and sorting are improved

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #58 from Nick Clemens  ---
Created attachment 93353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93353=edit
Bug 20589: Remove expanded_facet variable and fix tests

Thi is a rebase from 14419 to remove an unused variable

Also update tests to expect the new expected result

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #57 from Nick Clemens  ---
Created attachment 93352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93352=edit
Bug 20589: DO NOT PUSH Schema changes

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #56 from Nick Clemens  ---
Created attachment 93351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93351=edit
Bug 20589: Add option for searching entire record if record stored as array

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #54 from Nick Clemens  ---
Created attachment 93349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93349=edit
Bug 20589: fix QueryBuilder tests

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #55 from Nick Clemens  ---
Created attachment 93350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93350=edit
Bug 20589: Exclude boolean fields from search fields

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-10-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Nick Clemens  changed:

   What|Removed |Added

  Attachment #93247|0   |1
is obsolete||
  Attachment #93248|0   |1
is obsolete||
  Attachment #93249|0   |1
is obsolete||
  Attachment #93250|0   |1
is obsolete||
  Attachment #93251|0   |1
is obsolete||

--- Comment #53 from Nick Clemens  ---
Created attachment 93348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93348=edit
Bug 20589: Add field boosting and use query_string fields parameter

Generate a list of fields for the query_string query fields parameter,
with possible boosts, instead of using "_all"-field. Also add "search"
flag in search_marc_to_field table so that certain mappings can be
excluded from searches. Add option to include/exclude fields in
query_string "fields" parameter depending on searching in OPAC or staff
client. Refactor code to remove all other dependencies on "_all"-field.

How to test:
1) Reindex authorities and biblios.
2) Search biblios and try to verify that this works as expected.
3) Search authorities and try to verify that this works as expected.
4) Go to "Search engine configuration"
5) Change some "Boost", "Staff client", and "OPAC" settings and save.
6) Verify that those settings where saved accordingly.
7) Click the "Biblios" or "Authorities" tab and change one or more
   "Searchable" settings
8) Verfiy that those settings where saved accordingly.
9) Try to verify that these settings has taken effect by peforming
   some biblios and/or authorities searches.

Sponsorded-by: Gothenburg Univesity Library

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-09-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

David Gustafsson  changed:

   What|Removed |Added

  Attachment #93241|0   |1
is obsolete||

--- Comment #51 from David Gustafsson  ---
Created attachment 93250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93250=edit
Bug 20589: Add option for searching entire record if record stored as array

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-09-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

David Gustafsson  changed:

   What|Removed |Added

  Attachment #93239|0   |1
is obsolete||

--- Comment #49 from David Gustafsson  ---
Created attachment 93248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93248=edit
Bug 20589: fix QueryBuilder tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-09-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #52 from David Gustafsson  ---
Created attachment 93251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93251=edit
Bug 20589: DO NOT PUSH Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-09-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

David Gustafsson  changed:

   What|Removed |Added

  Attachment #93240|0   |1
is obsolete||

--- Comment #50 from David Gustafsson  ---
Created attachment 93249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93249=edit
Bug 20589: Exclude boolean fields from search fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-09-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

David Gustafsson  changed:

   What|Removed |Added

  Attachment #93238|0   |1
is obsolete||

--- Comment #48 from David Gustafsson  ---
Created attachment 93247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93247=edit
Bug 20589: Add field boosting and use query_string fields parameter

Generate a list of fields for the query_string query fields parameter,
with possible boosts, instead of using "_all"-field. Also add "search"
flag in search_marc_to_field table so that certain mappings can be
excluded from searches. Add option to include/exclude fields in
query_string "fields" parameter depending on searching in OPAC or staff
client. Refactor code to remove all other dependencies on "_all"-field.

How to test:
1) Reindex authorities and biblios.
2) Search biblios and try to verify that this works as expected.
3) Search authorities and try to verify that this works as expected.
4) Go to "Search engine configuration"
5) Change some "Boost", "Staff client", and "OPAC" settings and save.
6) Verify that those settings where saved accordingly.
7) Click the "Biblios" or "Authorities" tab and change one or more
   "Searchable" settings
8) Verfiy that those settings where saved accordingly.
9) Try to verify that these settings has taken effect by peforming
   some biblios and/or authorities searches.

Sponsorded-by: Gothenburg Univesity Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-09-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #47 from David Gustafsson  ---
(In reply to Nick Clemens from comment #42)
> Rebased and tested, this works excellently, I would love to move this
> forward, but I see a few issues in the patches:
> 1 - You removed QueryWeightedFields, but Zebra uses this, I obsoleted that
> patch
> 2 - There are changes to the authority searches here, things are improved,
> but a bit too strict, they don't relate to this bug, can you move those to a
> new report?
> 3 - Schema changes are mixed into first patch, they should be their own so
> RM can generate separately
> 4 - I did a minor rebase on top of 22258 and added a followup to allow
> searchig the entire record if using marc array
> 
> Let me know if this makes sense or if I went too far anywhere

Thanks for the feedback! Rebased aagainst master since did not apply again.

1) Ok, I obviously missed that used by Zebra, thanks!

2) I gave this a lot of thought, but on the other hand not sure got it right.
It would be possible to break out some changes introduced into separate issues,
but they would all depend on each other and would be harder to maintain. So
it's bundled together for practical reasons and time constraints. I might have
time later on to split things up, but unfortunately not at the moment.

3) Forgot to fix this, but will do that.

4) Great, thanks :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-09-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

David Gustafsson  changed:

   What|Removed |Added

  Attachment #92457|0   |1
is obsolete||

--- Comment #46 from David Gustafsson  ---
Created attachment 93241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93241=edit
Bug 20589: Add option for searching entire record if record stored as array

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-09-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

David Gustafsson  changed:

   What|Removed |Added

  Attachment #92454|0   |1
is obsolete||

--- Comment #43 from David Gustafsson  ---
Created attachment 93238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93238=edit
Bug 20589: Add field boosting and use query_string fields parameter

Generate a list of fields for the query_string query fields parameter,
with possible boosts, instead of using "_all"-field. Also add "search"
flag in search_marc_to_field table so that certain mappings can be
excluded from searches. Add option to include/exclude fields in
query_string "fields" parameter depending on searching in OPAC or staff
client. Refactor code to remove all other dependencies on "_all"-field.

How to test:
1) Reindex authorities and biblios.
2) Search biblios and try to verify that this works as expected.
3) Search authorities and try to verify that this works as expected.
4) Go to "Search engine configuration"
5) Change some "Boost", "Staff client", and "OPAC" settings and save.
6) Verify that those settings where saved accordingly.
7) Click the "Biblios" or "Authorities" tab and change one or more
   "Searchable" settings
8) Verfiy that those settings where saved accordingly.
9) Try to verify that these settings has taken effect by peforming
   some biblios and/or authorities searches.

Sponsorded-by: Gothenburg Univesity Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-09-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

David Gustafsson  changed:

   What|Removed |Added

  Attachment #92456|0   |1
is obsolete||

--- Comment #45 from David Gustafsson  ---
Created attachment 93240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93240=edit
Bug 20589: Exclude boolean fields from search fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-09-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

David Gustafsson  changed:

   What|Removed |Added

  Attachment #92455|0   |1
is obsolete||

--- Comment #44 from David Gustafsson  ---
Created attachment 93239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93239=edit
Bug 20589: fix QueryBuilder tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-08-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #42 from Nick Clemens  ---
Rebased and tested, this works excellently, I would love to move this forward,
but I see a few issues in the patches:
1 - You removed QueryWeightedFields, but Zebra uses this, I obsoleted that
patch
2 - There are changes to the authority searches here, things are improved, but
a bit too strict, they don't relate to this bug, can you move those to a new
report?
3 - Schema changes are mixed into first patch, they should be their own so RM
can generate separately
4 - I did a minor rebase on top of 22258 and added a followup to allow searchig
the entire record if using marc array

Let me know if this makes sense or if I went too far anywhere

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-08-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #40 from Nick Clemens  ---
Created attachment 92456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92456=edit
Bug 20589: Exclude boolean fields from search fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-08-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #41 from Nick Clemens  ---
Created attachment 92457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92457=edit
Bug 20589: Add option for searching entire record if record stored as array

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-08-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #39 from Nick Clemens  ---
Created attachment 92455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92455=edit
Bug 20589: fix QueryBuilder tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-08-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Nick Clemens  changed:

   What|Removed |Added

  Attachment #87411|0   |1
is obsolete||
  Attachment #87412|0   |1
is obsolete||
  Attachment #87415|0   |1
is obsolete||
  Attachment #87416|0   |1
is obsolete||

--- Comment #38 from Nick Clemens  ---
Created attachment 92454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92454=edit
Bug 20589: Add field boosting and use query_string fields parameter

Generate a list of fields for the query_string query fields parameter,
with possible boosts, instead of using "_all"-field. Also add "search"
flag in search_marc_to_field table so that certain mappings can be
excluded from searches. Add option to include/exclude fields in
query_string "fields" parameter depending on searching in OPAC or staff
client. Refactor code to remove all other dependencies on "_all"-field.

How to test:
1) Reindex authorities and biblios.
2) Search biblios and try to verify that this works as expected.
3) Search authorities and try to verify that this works as expected.
4) Go to "Search engine configuration"
5) Change some "Boost", "Staff client", and "OPAC" settings and save.
6) Verify that those settings where saved accordingly.
7) Click the "Biblios" or "Authorities" tab and change one or more
   "Searchable" settings
8) Verfiy that those settings where saved accordingly.
9) Try to verify that these settings has taken effect by peforming
   some biblios and/or authorities searches.

Sponsorded-by: Gothenburg Univesity Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

David Gustafsson  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #37 from David Gustafsson  ---
@Alex Arnaud

Thanks for the comments.
Regarding the query "(publisher:autrement OR jean)" I think it should be
written as "publisher:(autrement OR jean)" to get the results you want. Also,
surrounding parentheses can be left out of all the queries. They are only
needed if you need to group sub-expressions. I don't think that Koha should try
to reduce the field-list by parsing the query, this greatly increases
complexity without any real  benefit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Alex Arnaud  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-04-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

e.betemps  changed:

   What|Removed |Added

 CC||e.bete...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #36 from Alex Arnaud  ---
Hello David,

First: i like this work :). 
The idea of targeting only searchable fields instead of systematically fall
back on the entire record make results more consistent (even with boosting).

however, here are some observations:

When searching on a specific field (i.e "Autrement" as publisher), we keep all
others searchable fields in the target list:

"query_string": {
  "query": "(publisher:autrement)",
  "fields": [
"LC-card-number",
"Local-number",
"publisher",
+ all searchable fields
  ]
}
That has no matter on the results here since the following query returns the
same results:

"query_string": {
  "query": "(publisher:autrement)",
}

But keeping field list seems to be useless.

A better thing would be to use only fields list instead of having the target in
query. Like that:

"query_string": {
  "query": "(autrement)",
  "fields": [
  publisher
  ]
}

This also returns the same result (for me) and allows user to make more
complete searches such like "autrement AND jean"
If i request this:

"query_string": {
  "query": "(publisher:autrement OR jean)"
  "fields": [
"LC-card-number",
"Local-number",
"publisher",
+ all searchable
  ],
}
I get many irrelevant results (more than 600 in my database that are not
related with what i typed)
Or this one:

"query_string": {
  "query": "(autrement OR jean)"
  "fields": [
"publisher"
  ],
}
Returns only records containing "Autrement" or "jean" in publisher.
Seems more correct to me.

Sorry for the long comment, waiting for your feedback

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

David Gustafsson  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #35 from David Gustafsson  ---
Created attachment 87416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87416=edit
Bug 20589: Remove QueryWeightFields syspref since no longer in use

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #34 from David Gustafsson  ---
Created attachment 87415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87415=edit
Bug 20589: Exclude boolean fields from search fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

David Gustafsson  changed:

   What|Removed |Added

  Attachment #87358|0   |1
is obsolete||

--- Comment #32 from David Gustafsson  ---
Created attachment 87411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87411=edit
Bug 20589: Add field boosting and use query_string fields parameter

Generate a list of fields for the query_string query fields parameter,
with possible boosts, instead of using "_all"-field. Also add "search"
flag in search_marc_to_field table so that certain mappings can be
excluded from searches. Add option to include/exclude fields in
query_string "fields" parameter depending on searching in OPAC or staff
client. Refactor code to remove all other dependencies on "_all"-field.

How to test:
1) Reindex authorities and biblios.
2) Search biblios and try to verify that this works as expected.
3) Search authorities and try to verify that this works as expected.
4) Go to "Search engine configuration"
5) Change some "Boost", "Staff client", and "OPAC" settings and save.
6) Verify that those settings where saved accordingly.
7) Click the "Biblios" or "Authorities" tab and change one or more
   "Searchable" settings
8) Verfiy that those settings where saved accordingly.
9) Try to verify that these settings has taken effect by peforming
   some biblios and/or authorities searches.

Sponsorded-by: Gothenburg Univesity Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #33 from David Gustafsson  ---
Created attachment 87412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87412=edit
Bug 20589: fix QueryBuilder tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-04-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-04-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #31 from David Gustafsson  ---
Not ready for signoff though. One test fails, I know the reason but it's not
trivial to fix (association need to be used in test data and don't know if that
is possible with TestBuilder).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-04-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

David Gustafsson  changed:

   What|Removed |Added

  Attachment #83019|0   |1
is obsolete||

--- Comment #30 from David Gustafsson  ---
Created attachment 87358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87358=edit
Bug 20589: Add field boosting and use query_string fields parameter

Generate a list of fields for the query_string query fields parameter,
with possible boosts, instead of using "_all"-field. Also add "search"
flag in search_marc_to_field table so that certain mappings can be
excluded from searches. Add option to include/exclude fields in
query_string "fields" parameter depending on searching in OPAC or staff
client. Refactor code to remove all other dependencies on "_all"-field.

How to test:
1) Reindex authorities and biblios.
2) Search biblios and try to verify that this works as expected.
3) Search authorities and try to verify that this works as expected.
4) Go to "Search engine configuration"
5) Change some "Boost", "Staff client", and "OPAC" settings and save.
6) Verify that those settings where saved accordingly.
7) Click the "Biblios" or "Authorities" tab and change one or more
   "Searchable" settings
8) Verfiy that those settings where saved accordingly.
9) Try to verify that these settings has taken effect by peforming
   some biblios and/or authorities searches.

Sponsorded-by: Gothenburg Univesity Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-04-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #29 from David Gustafsson  ---
Just rebased this, but need to test some more and make sure tests are not
broken. Should have that done by tomorrow.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-03-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Björn Nylén  changed:

   What|Removed |Added

 CC||bjorn.ny...@ub.lu.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Alex Arnaud  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #28 from David Gustafsson  ---
Yes, agree. I had forgotten about that. Should be easy to fix. Might be able to
do so Friday or next week.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #27 from Nick Clemens  ---
David, one request here would be to include the opac/staff columns to the
mapping yaml file as well - changes that can be lost on a mapping reload are
harder to track and keep in place

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Nick Clemens  changed:

   What|Removed |Added

 CC||ere.maij...@helsinki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2019-03-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-12-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #26 from David Gustafsson  ---
Fixed incorrectly named is_mapped_biblios to mapped_biblios in mappings.tt.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-12-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

David Gustafsson  changed:

   What|Removed |Added

  Attachment #83016|0   |1
is obsolete||

--- Comment #25 from David Gustafsson  ---
Created attachment 83019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83019=edit
Bug 20589: Add field boosting and use query_string fields parameter

Generate a list of fields for the query_string query fields parameter,
with possible boosts, instead of using "_all"-field. Also add "search"
flag in search_marc_to_field table so that certain mappings can be
excluded from searches. Add option to include/exclude fields in
query_string "fields" parameter depending on searching in OPAC or staff
client. Refactor code to remove all other dependencies on "_all"-field.

How to test:
1) Reindex authorities and biblios.
2) Search biblios and try to verify that this works as expected.
3) Search authorities and try to verify that this works as expected.
4) Go to "Search engine configuration"
5) Change some "Boost", "Staff client", and "OPAC" settings and save.
6) Verify that those settings where saved accordingly.
7) Click the "Biblios" or "Authorities" tab and change one or more
   "Searchable" settings
8) Verfiy that those settings where saved accordingly.
9) Try to verify that these settings has taken effect by peforming
   some biblios and/or authorities searches.

Sponsorded-by: Gothenburg Univesity Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-12-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

David Gustafsson  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #24 from David Gustafsson  ---
Rebase against master (but currently untested).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-12-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

David Gustafsson  changed:

   What|Removed |Added

  Attachment #82544|0   |1
is obsolete||

--- Comment #23 from David Gustafsson  ---
Created attachment 83016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83016=edit
Bug 20589: Add field boosting and use query_string fields parameter

Generate a list of fields for the query_string query fields parameter,
with possible boosts, instead of using "_all"-field. Also add "search"
flag in search_marc_to_field table so that certain mappings can be
excluded from searches. Add option to include/exclude fields in
query_string "fields" parameter depending on searching in OPAC or staff
client. Refactor code to remove all other dependencies on "_all"-field.

How to test:
1) Reindex authorities and biblios.
2) Search biblios and try to verify that this works as expected.
3) Search authorities and try to verify that this works as expected.
4) Go to "Search engine configuration"
5) Change some "Boost", "Staff client", and "OPAC" settings and save.
6) Verify that those settings where saved accordingly.
7) Click the "Biblios" or "Authorities" tab and change one or more
   "Searchable" settings
8) Verfiy that those settings where saved accordingly.
9) Try to verify that these settings has taken effect by peforming
   some biblios and/or authorities searches.

Sponsorded-by: Gothenburg Univesity Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-11-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Séverine Queune  changed:

   What|Removed |Added

 CC||nicolas.legr...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-11-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #22 from David Gustafsson  ---
Here is a more verbose explaction of most of the changes:

- Remove syspref QueryWeightFields as this seems not to be used anyway.

- Replace hard coded 'biblios' and 'authorities' in mappings.pl with constants.

- Add _search_fields method in QueryParser for returning weighted/unweighted
search fields for OPAC/STaffClient (as optional subfield, used primarily for
authorities search).

Refactor authorities search. This part is a a litte bit iffy:

What mainly confuses me is the motivation behind the differentiation between
is/=, and "exact". With regards to elastic that operator only seems to be used
in C4/Matcher.pm. It also occurs in Koha/QueryParser/Driver/PQF.pm and
Koha/REST/Plugin/Query.pm but i don't believe Elastic is used as backend for
those. What I can gather there where actually no difference between is/= and
"exact" before my changes as is/= performed a "term" query on ".phrase"
and "exact" performed a "match_phrase" on the same field, which is pointless
since the "phrase" subfield is not tokenized (used keyword analyser). So I
simplified this and use the same query for both is/= and "exact".

As "exact" queries seems to be used for matching, I also thought it would be
more fitting to perform a case insensitive match instead of also removing
punctuation (which could result in unexpected matches).

I also noticed that the Authorities type drop-down in the authorities search
was not respected, so this is not included in the query if selected.

Also noted there is an $and_or option to build_authorities_query_compat that is
not used, this should probably be addressed, but not fixed in this patch.

Tidy up the index/fields configuration a little bit:

- Rename all occurrences of misspelled "analyser" to "analyzer".
- Rename "my_normalizer" to more descriptive "nfkc_cf_normalizer".
- Rename "normalizer_keyword" to more descriptive "icu_folding_normalizer".
- Rename subfield "lc_raw" to "ci_raw" (case insensitive). I don't think this
subfield actually was case insensitive before since "my_normalizer" was used
wich is only performing UTF normalization, not case folding.
- Don't use "phrase" subfield for sorting, this is incorrect and will result in
strange results since byte order of characters is used. There is also no need
for a subfield for the sort field. I removed the subfield and changed type to
"icu_collation_keyword", which will attempt to sort in order with the least
conflicts between languages. Ideally there should be a syspref for setting
collation language to sort by. This is a pretty trivial fix so might open a new
issue for that.

As a result of this "phrase" is almost not used at all, and could probably be
removed with phrase queries on the search field instead in a later stage (which
would decrease index size considerably).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-11-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

David Gustafsson  changed:

   What|Removed |Added

  Attachment #82503|0   |1
is obsolete||

--- Comment #21 from David Gustafsson  ---
Created attachment 82544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82544=edit
Bug 20589: Add field boosting and use query_string fields parameter

Generate a list of fields for the query_string query fields parameter,
with possible boosts, instead of using "_all"-field. Also add "search"
flag in search_marc_to_field table so that certain mappings can be
excluded from searches. Add option to include/exclude fields in
query_string "fields" parameter depending on searching in OPAC or staff
client. Refactor code to remove all other dependencies on "_all"-field.

How to test:
1) Reindex authorities and biblios.
2) Search biblios and try to verify that this works as expected.
3) Search authorities and try to verify that this works as expected.
4) Go to "Search engine configuration"
5) Change some "Boost", "Staff client", and "OPAC" settings and save.
6) Verify that those settings where saved accordingly.
7) Click the "Biblios" or "Authorities" tab and change one or more
   "Searchable" settings
8) Verfiy that those settings where saved accordingly.
9) Try to verify that these settings has taken effect by peforming
   some biblios and/or authorities searches.

Sponsorded-by: Gothenburg Univesity Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-11-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #20 from David Gustafsson  ---
I will write a summary of the changes with motivations behind each one as this
can be difficult to understand by just looking at the code. I'm also a little
bit confused my self with regards to the correct behaviour of
build_auth_query_compat for example. And would probably have to setup a Zebra
instance to find out exactly how the different options are supposed to work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-11-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #19 from David Gustafsson  ---
*but since removing '_all' also requires adjusting this _part_ such a patch
would probably cause merge conflict with this one. So it could be simple to
bundle theses changes as one patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-11-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #18 from David Gustafsson  ---
This is still work in progress. Have not adjusted tests for the refactored code
for example. There are parts of this patch regarding fixes for authorities
search that could be a separate patch, but since removing '_all' also requires
adjusting this patch such a patch would probably cause merge conflict with this
one. So it could be simple to bundle theses changes as one patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-11-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

David Gustafsson  changed:

   What|Removed |Added

  Attachment #74419|0   |1
is obsolete||

--- Comment #17 from David Gustafsson  ---
Created attachment 82503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82503=edit
Bug 20589: Add field boosting and use query_string fields parameter

Generate a list of fields for the query_string query fields parameter,
with possible boosts, instead of using "_all"-field. Also add "search"
flag in search_marc_to_field table so that certain mappings can be
excluded from searches. Add option to include/exclude fields in
query_string "fields" parameter depending on searching in OPAC or staff
client. Refactor code to remove all other dependencies on "_all"-field.

How to test:
1) Reindex authorities and biblios.
2) Search biblios and try to verify that this works as expected.
3) Search authorities and try to verify that this works as expected.
4) Go to "Search engine configuration"
5) Change some "Boost", "Staff client", and "OPAC" settings and save.
6) Verify that those settings where saved accordingly.
7) Click the "Biblios" or "Authorities" tab and change one or more
   "Searchable" settings
8) Verfiy that those settings where saved accordingly.
9) Try to verify that these settings has taken effect by peforming
   some biblios and/or authorities searches.

Sponsorded-by: Gothenburg Univesity Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-11-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Bug 20589 depends on bug 18316, which changed state.

Bug 18316 Summary: Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-11-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #16 from David Gustafsson  ---
I have started working on this now since 18316 has been merged. Will update
beginning of next week.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

David Gustafsson  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #15 from David Gustafsson  ---
I think this patch in it's current state needs to be refactored with regard to
the changes introduces in Bug 18316 once has been pushed to master. I will do
this, but will probably wait until it has been pushed (which it seems close to
be).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-10-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|BLOCKED |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-04-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

David Gustafsson  changed:

   What|Removed |Added

 Status|Needs Signoff   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-04-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

--- Comment #14 from Séverine Queune  ---
I a bit lost because of last comments and allusion about merging it with bug
18316 : should this one be tested ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-04-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #13 from Katrin Fischer  ---
Hi David, if you write bug 18316 instead of bug_18316, bugzilla will
automagically link it. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-04-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

David Gustafsson  changed:

   What|Removed |Added

 Depends on||18316


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316
[Bug 18316] Add weighting/relevancy options to ElasticSearch
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #12 from David Gustafsson  ---
And about the searchable parameter, I think we are going to need this in the
future so included it as did not see a major downside of doing so. The problem
this might solve is that we would want to have exclusive "sort"-field mappings,
not included in the main field. The idea is to allow mappings to be written on
the form "035a|035b|035c", and this would mean that the first field that has a
value gets mapped, the rest skipped. We have disabled sorting since it's very
unpredictable for multivalued fields, and this was seen as a possible future
solution.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #11 from David Gustafsson  ---
Yes, I think the best option would be to try getting bug_18316 merged, and then
refactor this upon that. I completely missed bug_18316 before starting to work
on this. I tried applying bug_18316 but was unable to do so because of some
git-error, think there might be something wonky with the current patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Alex Arnaud  changed:

   What|Removed |Added

 CC||alex.arn...@biblibre.com

--- Comment #10 from Alex Arnaud  ---
Searchable parameter on search fields (staff/opac) is nice.
But, is searchable parameter on mapping useful? We can just remove the mapping,
right?

This patch could be rebased on bug 18316, that brings boost for simple search.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

2018-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|Add field boosting and use  |Add field boosting and use
   |elastic query fields|elastic query fields
   |parameter instead of|parameter instead of
   |depricated _all |deprecated _all

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

88 matches

Mail list logo