[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Owen Leonard changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 --- Comment #11 from Owen Leonard --- Anyone have an opinion on whether I should work on backporting this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Martin Renvoize changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #10 from Martin Renvoize --- Reverted in 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Jonathan Druart changed: What|Removed |Added Blocks||21024 --- Comment #9 from Jonathan Druart --- (In reply to Jonathan Druart from comment #8) > Bad one, there is a JS error on the search result, which breaks all JS > functionalities (add to basket, list, etc.) See bug 20864. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 [Bug 21024] JS error on search result breaks JS functionalities -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 --- Comment #8 from Jonathan Druart --- Bad one, there is a JS error on the search result, which breaks all JS functionalities (add to basket, list, etc.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 --- Comment #7 from Fridolin SOMERS --- Depends on Bug 19290 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Fridolin SOMERS changed: What|Removed |Added Depends on||19290 CC||fridolin.som...@biblibre.co ||m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290 [Bug 19290] Browse selected biblios - Staff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Master|Pushed to Stable --- Comment #6 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Jonathan Druart changed: What|Removed |Added Attachment #76196|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 76289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76289=edit Bug 20864: Only set bibs_selected cookie when BrowseResultSelection is activated This patch adds a system preference check around the call to the JavaScript include which sets the bibs_selected cookie. With BrowseResultsSelection disabled, the cookie should never be set. To test you should be using a browser with a tool for inspecting cookies. View the cookies for your Koha domain under each of these conditions, clearing cookies between each step: Without the patch applied: - With BrowseResultSelection enabled, search for any item. Your cookie tool should report that you have a bibs_selected cookie stored. - With BrowseResultSelection disabled, search for any item. You should have a bibs_selected cookie. With the patch applied: - With the BrowseResultSelection system preference enabled, search for any item. Your cookie tool should report that you have a bibs_selected cookie stored. - With BrowseResultSelection disabled, search for any item. You should have no bibs_selected cookie. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- Hum yes, "commons.js" was certainly not the best name. Maybe the test must be moved to common.js, but not blocker for this quick fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Katrin Fischer changed: What|Removed |Added Attachment #75771|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 76196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76196=edit Bug 20864: Only set bibs_selected cookie when BrowseResultSelection is activated This patch adds a system preference check around the call to the JavaScript include which sets the bibs_selected cookie. With BrowseResultsSelection disabled, the cookie should never be set. To test you should be using a browser with a tool for inspecting cookies. View the cookies for your Koha domain under each of these conditions, clearing cookies between each step: Without the patch applied: - With BrowseResultSelection enabled, search for any item. Your cookie tool should report that you have a bibs_selected cookie stored. - With BrowseResultSelection disabled, search for any item. You should have a bibs_selected cookie. With the patch applied: - With the BrowseResultSelection system preference enabled, search for any item. Your cookie tool should report that you have a bibs_selected cookie stored. - With BrowseResultSelection disabled, search for any item. You should have no bibs_selected cookie. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 --- Comment #1 from Owen Leonard --- Created attachment 75771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75771=edit Bug 20864: Only set bibs_selected cookie when BrowseResultSelection is activated This patch adds a system preference check around the call to the JavaScript include which sets the bibs_selected cookie. With BrowseResultsSelection disabled, the cookie should never be set. To test you should be using a browser with a tool for inspecting cookies. View the cookies for your Koha domain under each of these conditions, clearing cookies between each step: Without the patch applied: - With BrowseResultSelection enabled, search for any item. Your cookie tool should report that you have a bibs_selected cookie stored. - With BrowseResultSelection disabled, search for any item. You should have a bibs_selected cookie. With the patch applied: - With the BrowseResultSelection system preference enabled, search for any item. Your cookie tool should report that you have a bibs_selected cookie stored. - With BrowseResultSelection disabled, search for any item. You should have no bibs_selected cookie. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Katrin Fischer changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
