[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #38 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|tomasco...@gmail.com|n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #37 from Nick Clemens --- Created attachment 112693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112693=edit Bug 20888: (follow-up) revert unecessary change on jquery selector Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #36 from Nick Clemens --- Created attachment 112692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112692=edit Bug 20888: (follow-up) 'is not' operator behaves as 'not like' Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Tomás Cohen Arazi changed: What|Removed |Added Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Nick Clemens changed: What|Removed |Added Attachment #112453|0 |1 is obsolete|| Attachment #112454|0 |1 is obsolete|| Attachment #112455|0 |1 is obsolete|| --- Comment #35 from Nick Clemens --- Created attachment 112691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112691=edit Bug 20888: Allow use of boolean operator 'not' in item search Test plan: - Apply the patch - Check that you have a 'is not' option in the third box in item search - Check that you can exclude items from the search results with this 'is not' option - Check that you can still combine parameters with 'and' and 'or' - Check that the exclusion works for custom fields (see Administration > Item search fields) - Check that the exclusion works for custom fields linked to authorised values Signed-off-by: Amandine Zocca Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #34 from Katrin Fischer --- Created attachment 112455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112455=edit Bug 20888: (follow-up) revert unecessary change on jquery selector Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #33 from Katrin Fischer --- Created attachment 112454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112454=edit Bug 20888: (follow-up) 'is not' operator behaves as 'not like' Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Katrin Fischer changed: What|Removed |Added Attachment #111265|0 |1 is obsolete|| Attachment #111266|0 |1 is obsolete|| Attachment #111267|0 |1 is obsolete|| --- Comment #32 from Katrin Fischer --- Created attachment 112453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112453=edit Bug 20888: Allow use of boolean operator 'not' in item search Test plan: - Apply the patch - Check that you have a 'is not' option in the third box in item search - Check that you can exclude items from the search results with this 'is not' option - Check that you can still combine parameters with 'and' and 'or' - Check that the exclusion works for custom fields (see Administration > Item search fields) - Check that the exclusion works for custom fields linked to authorised values Signed-off-by: Amandine Zocca Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Fridolin SOMERS changed: What|Removed |Added Attachment #93370|0 |1 is obsolete|| --- Comment #29 from Fridolin SOMERS --- Created attachment 111265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111265=edit Bug 20888: Allow use of boolean operator 'not' in item search Test plan: - Apply the patch - Check that you have a 'is not' option in the third box in item search - Check that you can exclude items from the search results with this 'is not' option - Check that you can still combine parameters with 'and' and 'or' - Check that the exclusion works for custom fields (see Administration > Item search fields) - Check that the exclusion works for custom fields linked to authorised values Signed-off-by: Amandine Zocca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Fridolin SOMERS changed: What|Removed |Added Attachment #97627|0 |1 is obsolete|| --- Comment #31 from Fridolin SOMERS --- Created attachment 111267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111267=edit Bug 20888: Follow-up: revert unecessary change on jquery selector -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Fridolin SOMERS changed: What|Removed |Added Attachment #97626|0 |1 is obsolete|| --- Comment #30 from Fridolin SOMERS --- Created attachment 111266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111266=edit Bug 20888: Follow-up: 'is not' operator behaves as 'not like' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Fridolin SOMERS changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Patch doesn't apply --- Comment #28 from Katrin Fischer --- Hi Matts, could you please rebase? I am stuck with a: error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #27 from Matthias Meusburger --- IF = not like... else = not like? => Yes, this is made for "not like" to be selected if needed when going back to the search. The "is" option is just above. I tested with a custom item search option for "Withdrawn" linked to the WITHDRAWN authorised value. If I pick "is not" Withdrawn I get the only withdrawn item. If I pick 'is' withdrawn... I get all the other items. It works ok on master for the 'is' case. => I tested again, with the following configurations: Unimarc : custom withdrawn search field => OK Marc21 : custom withdrawn search field => OK Marc21 : default withdrawn search field => OK Could you possibly give it another go, Cait? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #26 from Katrin Fischer --- Hi Matts, have been testing: + + is +[% IF params.op == 'not like' %] + is not +[% ELSE %] + is not +[% END IF = not like... else = not like? I tested with a custom item search option for "Withdrawn" linked to the WITHDRAWN authorised value. If I pick "is not" Withdrawn I get the only withdrawn item. If I pick 'is' withdrawn... I get all the other items. It works ok on master for the 'is' case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Matthias Meusburger changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #25 from Matthias Meusburger --- Frido, you were right, this change was unnecessary and has been reverted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #24 from Matthias Meusburger --- Created attachment 97627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97627=edit Bug 20888: Follow-up: revert unecessary change on jquery selector -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #23 from Matthias Meusburger --- Katrin, here's the modification you asked for: 'is not' now behaves like 'not like' (just like 'is' behaves like 'like') -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #22 from Matthias Meusburger --- Created attachment 97626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97626=edit Bug 20888: Follow-up: 'is not' operator behaves as 'not like' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888
--- Comment #21 from Fridolin SOMERS ---
Hi
-$('div.form-field-select-text select[name="f"]').change(function()
{
+$('div.form-field-select-text
select.form-field-column').change(function() {
is this change necessary ?
New select has name "op".
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #20 from Matthias Meusburger --- Ok, understood. I'll submit a new patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #19 from Katrin Fischer --- (In reply to Matthias Meusburger from comment #18) > I think we should rename "is" to "is like" then. This way it will be > consistent, with the following options: > > - is like > - is not > > An "is" and/or "is not like" option may be added in the future, and it will > still be consistent. > > What do you think? One problem we see with item search is that people expect it to work like the bibliographic search. For example, when searching for "Title is some words", they expect results to come up, but often forget to put the truncation. If the title actually is "these some words" the search will only find it if you use: Title is %some words". I think that's the reason, why we should not change the wording, we do use the SQL operator "like" and unless you use truncation, it works like an exact search. But it gives you the option to use the truncation. And I think we want the same behavior for adding the 'not' operator: If the libraries don't add truncation characters it will actually behave like !=, but they have the option to add them to make search a bit broader. Also: The hint below the search options will then be accurate, otherwise it would be misleading: You can use the following wildcard characters: % _ % matches any number of characters _ matches only a single character -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #18 from Matthias Meusburger --- I think we should rename "is" to "is like" then. This way it will be consistent, with the following options: - is like - is not An "is" and/or "is not like" option may be added in the future, and it will still be consistent. What do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #17 from Katrin Fischer --- Wondering: If is translates to "like", should "not" not translate to "not like"? Currently it will be != which doesn't allow for truncation. Example would be a search for: Title does not contain a certain keyword. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #16 from sandbo...@biblibre.com --- Created attachment 93370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93370=edit Bug 20888: Allow use of boolean operator 'not' in item search Test plan: - Apply the patch - Check that you have a 'is not' option in the third box in item search - Check that you can exclude items from the search results with this 'is not' option - Check that you can still combine parameters with 'and' and 'or' - Check that the exclusion works for custom fields (see Administration > Item search fields) - Check that the exclusion works for custom fields linked to authorised values Signed-off-by: Amandine Zocca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 sandbo...@biblibre.com changed: What|Removed |Added Attachment #93347|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 sandbo...@biblibre.com changed: What|Removed |Added CC||sandbo...@biblibre.com Status|Needs Signoff |Signed Off --- Comment #15 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Amandine Zocca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #14 from Matthias Meusburger --- The patch has been rebased, it should apply correctly on the sandboxes now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Matthias Meusburger changed: What|Removed |Added Attachment #85281|0 |1 is obsolete|| --- Comment #13 from Matthias Meusburger --- Created attachment 93347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93347=edit Bug 20888: Allow use of boolean operator 'not' in item search Test plan: - Apply the patch - Check that you have a 'is not' option in the third box in item search - Check that you can exclude items from the search results with this 'is not' option - Check that you can still combine parameters with 'and' and 'or' - Check that the exclusion works for custom fields (see Administration > Item search fields) - Check that the exclusion works for custom fields linked to authorised values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Axelle Aix-Marseille Université changed: What|Removed |Added CC||axelle.clari...@univ-amu.fr --- Comment #12 from Axelle Aix-Marseille Université --- We try to test today : this patch doesn't apply on a sandbox (Biblibre n°1) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Katrin Fischer changed: What|Removed |Added Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #11 from Matthias Meusburger --- Thanks Frido. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Fridolin SOMERS changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #10 from Fridolin SOMERS --- (In reply to Matthias Meusburger from comment #9) > Frido, I don't get the status of this BZ or your comment. > > The patch applies on master. What is to rebase exactly? Which bug are you > referring to? What are you expecting me to do? Sorry its really not clear (even for me). I have created Bug 22596 for use of raw filter and added as dependency. Now I see the raw filter already there in your patch so forget what I said ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #9 from Matthias Meusburger --- Frido, I don't get the status of this BZ or your comment. The patch applies on master. What is to rebase exactly? Which bug are you referring to? What are you expecting me to do? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #8 from Katrin Fischer --- Matthias, can you please rebase? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22595 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Fridolin SOMERS changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Fridolin SOMERS --- I have created a dedicated bug for raw filter. Please rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Depends on||22596 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 [Bug 22596] html TT filter is breaking items search with custom field -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Matthias Meusburger changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #6 from Matthias Meusburger --- Fixed QA using $raw filter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Matthias Meusburger changed: What|Removed |Added Attachment #84692|0 |1 is obsolete|| --- Comment #5 from Matthias Meusburger --- Created attachment 85281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85281=edit Bug 20888: Allow use of boolean operator 'not' in item search Test plan: - Apply the patch - Check that you have a 'is not' option in the third box in item search - Check that you can exclude items from the search results with this 'is not' option - Check that you can still combine parameters with 'and' and 'or' - Check that the exclusion works for custom fields (see Administration > Item search fields) - Check that the exclusion works for custom fields linked to authorised values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Pierre-Marc Thibault changed: What|Removed |Added CC||pierre-marc.thibault@inlibr ||o.com Status|Needs Signoff |Failed QA --- Comment #4 from Pierre-Marc Thibault --- The patch does not pass the QA test : FAILkoha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt FAIL filters missing_filter at line 237 (var authorised_values = [% authorised_values_json %];) OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #3 from Matthias Meusburger --- Oops, sorry :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |matthias.meusburger@biblibr |ity.org |e.com --- Comment #2 from Katrin Fischer --- Please don't forget to add yourself as assignee :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Matthias Meusburger changed: What|Removed |Added CC||matthias.meusburger@biblibr ||e.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #1 from Matthias Meusburger --- Created attachment 84692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84692=edit Bug 20888: Allow use of boolean operator 'not' in item search Test plan: - Apply the patch - Check that you have a 'is not' option in the third box in item search - Check that you can exclude items from the search results with this 'is not' option - Check that you can still combine parameters with 'and' and 'or' - Check that the exclusion works for custom fields (see Administration > Item search fields) - Check that the exclusion works for custom fields linked to authorised values -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
