[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Resolution|--- |FIXED Status|Pushed to master|RESOLVED --- Comment #47 from Fridolin SOMERS --- Enhancement not pushed to 19.05.x I prefer not change this display in stable branche -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #46 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Katrin Fischer changed: What|Removed |Added Attachment #91123|0 |1 is obsolete|| --- Comment #45 from Katrin Fischer --- Created attachment 91164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91164=edit Bug 20959: Style checkin form more like the checkout form, with collapsed settings panel This patch modifies the structure of the checkin form so that settings (Specify return date, book drop mode, forgive overdue charges) are in a collapsed panel when inactive. The style of the barcode field and the mode notification messages has been changed to reduce the vertical motion of the form when selecting options. Some class names have been changed in circulation.tt and circulation.js to make them appropriate for use on both forms. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. - View the checkin page. The "checkin settings" panel should be collapsed by default. - Confirm that the settings panel collapses and expands as it should. - Confirm that selecting "Forgive overdue charges" or "Book drop mode" trigger the display of the correct message and that the style of the barcode field is changed. - Confirm that after submitting a barcode for check-in, the settings panel stays open and your selected settings are still selected. - Confirm that specifying a due date and selecting "remember" shows a new message with the selected date. - Confirm that unchecking "remember" hides the message. - Confirm that date settings are remembered and the correct message displayed (or not) during check-in. - Test with CircSidebar enabled and disabled. Signed-off-by: Arthur Bousquet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #44 from Katrin Fischer --- This works well for me, just a spelling question: Remember due date for next check in Should it be check-in in this case? (substantive)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Arthur Bousquet changed: What|Removed |Added Attachment #91081|0 |1 is obsolete|| --- Comment #43 from Arthur Bousquet --- Created attachment 91123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91123=edit Bug 20959: Style checkin form more like the checkout form, with collapsed settings panel This patch modifies the structure of the checkin form so that settings (Specify return date, book drop mode, forgive overdue charges) are in a collapsed panel when inactive. The style of the barcode field and the mode notification messages has been changed to reduce the vertical motion of the form when selecting options. Some class names have been changed in circulation.tt and circulation.js to make them appropriate for use on both forms. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. - View the checkin page. The "checkin settings" panel should be collapsed by default. - Confirm that the settings panel collapses and expands as it should. - Confirm that selecting "Forgive overdue charges" or "Book drop mode" trigger the display of the correct message and that the style of the barcode field is changed. - Confirm that after submitting a barcode for check-in, the settings panel stays open and your selected settings are still selected. - Confirm that specifying a due date and selecting "remember" shows a new message with the selected date. - Confirm that unchecking "remember" hides the message. - Confirm that date settings are remembered and the correct message displayed (or not) during check-in. - Test with CircSidebar enabled and disabled. Signed-off-by: Arthur Bousquet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Arthur Bousquet changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Attachment #87933|0 |1 is obsolete|| Attachment #87934|0 |1 is obsolete|| --- Comment #42 from Owen Leonard --- Created attachment 91081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91081=edit Bug 20959: Style checkin form more like the checkout form, with collapsed settings panel This patch modifies the structure of the checkin form so that settings (Specify return date, book drop mode, forgive overdue charges) are in a collapsed panel when inactive. The style of the barcode field and the mode notification messages has been changed to reduce the vertical motion of the form when selecting options. Some class names have been changed in circulation.tt and circulation.js to make them appropriate for use on both forms. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. - View the checkin page. The "checkin settings" panel should be collapsed by default. - Confirm that the settings panel collapses and expands as it should. - Confirm that selecting "Forgive overdue charges" or "Book drop mode" trigger the display of the correct message and that the style of the barcode field is changed. - Confirm that after submitting a barcode for check-in, the settings panel stays open and your selected settings are still selected. - Confirm that specifying a due date and selecting "remember" shows a new message with the selected date. - Confirm that unchecking "remember" hides the message. - Confirm that date settings are remembered and the correct message displayed (or not) during check-in. - Test with CircSidebar enabled and disabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Katrin Fischer changed: What|Removed |Added Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #41 from Séverine Queune --- Hi Owen, Everything works fine, I've just got a question before signing this patch. The only case the panel collapse is when I select a specific return date without checking the box "Remember for next check in". That doesn't surprise me, but do you consider this is a correct behaviour ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 José-Mario Monteiro-Santos changed: What|Removed |Added CC||jose-mario.monteiro-santos@ ||inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 José-Mario Monteiro-Santos changed: What|Removed |Added Attachment #87422|0 |1 is obsolete|| --- Comment #40 from José-Mario Monteiro-Santos --- Created attachment 87934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87934=edit Bug 20959: (QA follow-up) Add missing $KohaDates filter This patch adds a missing $KohaDates filter to the display of the book drop mode "effective checkin" date. To test, apply the patch and go to Circulation -> Check in. Check the "Book drop mode" box. The message which displays should show a correctly-formatted effective checkin date. Signed-off-by: Jose-Mario Monteiro-Santos -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 José-Mario Monteiro-Santos changed: What|Removed |Added Attachment #86729|0 |1 is obsolete|| --- Comment #39 from José-Mario Monteiro-Santos --- Created attachment 87933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87933=edit Bug 20959: Style checkin form more like the checkout form, with collapsed settings panel This patch modifies the structure of the checkin form so that settings (Specify return date, book drop mode, forgive overdue charges) are in a collapsed panel when inactive. The style of the barcode field and the mode notification messages has been changed to reduce the vertical motion of the form when selecting options. Some class names have been changed in circulation.tt and circulation.js to make them appropriate for use on both forms. To test, apply the patch and clear your browser cache if necessary. - View the checkin page. The "checkin settings" panel should be collapsed by default. - Confirm that the settings panel collapses and expands as it should. - Confirm that selecting "Forgive overdue charges" or "Book drop mode" trigger the display of the correct message and that the style of the barcode field is changed. - Confirm that after submitting a barcode for check-in, the settings panel stays open and your selected settings are still selected. - Test with CircSidebar enabled and disabled. Signed-off-by: Jose-Mario Monteiro-Santos -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #38 from Owen Leonard --- Created attachment 87422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87422=edit Bug 20959: (QA follow-up) Add missing $KohaDates filter This patch adds a missing $KohaDates filter to the display of the book drop mode "effective checkin" date. To test, apply the patch and go to Circulation -> Check in. Check the "Book drop mode" box. The message which displays should show a correctly-formatted effective checkin date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #37 from Katrin Fischer --- Hi Owen, this looks nice! Just something small: the effective checkin date for book drop mode shows in a strange format: 2019-04-02T22:40:10. Can you take a look? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Katrin Fischer changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #36 from Katrin Fischer --- *** Bug 14516 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Attachment #86477|0 |1 is obsolete|| --- Comment #35 from Owen Leonard --- Created attachment 86729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86729=edit Bug 20959: Style checkin form more like the checkout form, with collapsed settings panel This patch modifies the structure of the checkin form so that settings (Specify return date, book drop mode, forgive overdue charges) are in a collapsed panel when inactive. The style of the barcode field and the mode notification messages has been changed to reduce the vertical motion of the form when selecting options. Some class names have been changed in circulation.tt and circulation.js to make them appropriate for use on both forms. To test, apply the patch and clear your browser cache if necessary. - View the checkin page. The "checkin settings" panel should be collapsed by default. - Confirm that the settings panel collapses and expands as it should. - Confirm that selecting "Forgive overdue charges" or "Book drop mode" trigger the display of the correct message and that the style of the barcode field is changed. - Confirm that after submitting a barcode for check-in, the settings panel stays open and your selected settings are still selected. - Test with CircSidebar enabled and disabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #34 from Owen Leonard --- The rebase for this was tedious enough that I think it could use another look in the form of a signoff. Please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Attachment #82995|0 |1 is obsolete|| Attachment #82996|0 |1 is obsolete|| Attachment #82997|0 |1 is obsolete|| Attachment #83180|0 |1 is obsolete|| Attachment #83772|0 |1 is obsolete|| --- Comment #33 from Owen Leonard --- Created attachment 86477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86477=edit Bug 20959: Style checkin form more like the checkout form, with collapsed settings panel This patch modifies the structure of the checkin form so that settings (Specify return date, book drop mode, forgive overdue charges) are in a collapsed panel when inactive. The style of the barcode field and the mode notification messages has been changed to reduce the vertical motion of the form when selecting options. Some class names have been changed in circulation.tt and circulation.js to make them appropriate for use on both forms. To test, apply the patch and clear your browser cache if necessary. - View the checkin page. The "checkin settings" panel should be collapsed by default. - Confirm that the settings panel collapses and expands as it should. - Confirm that selecting "Forgive overdue charges" or "Book drop mode" trigger the display of the correct message and that the style of the barcode field is changed. - Confirm that after submitting a barcode for check-in, the settings panel stays open and your selected settings are still selected. - Test with CircSidebar enabled and disabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #32 from Katrin Fischer --- Rebase? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #31 from Jonathan Druart --- (In reply to Owen Leonard from comment #30) > Sorry Jonathan I missed that you had added a follow-up to this. I've > submitted an alternative which uses preventDefault. I don't think it makes > sense to use the other solution just to make the link target wider. While a > wider click target might be easier in some cases, I think it's usually > better to make the click target match the controls so that clicking in > "empty space" doesn't give unexpected results. I always miss that link :) But I am ok with your solution if you disagree. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #30 from Owen Leonard --- Sorry Jonathan I missed that you had added a follow-up to this. I've submitted an alternative which uses preventDefault. I don't think it makes sense to use the other solution just to make the link target wider. While a wider click target might be easier in some cases, I think it's usually better to make the click target match the controls so that clicking in "empty space" doesn't give unexpected results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #29 from Owen Leonard --- Created attachment 83772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83772=edit Bug 20959: (follow-up) Alternate: Add preventDefault to link controls This patch adds a missing preventDefault to the function for showing and hiding the checkin settings panel. This prevents the page from unexpected scrolling when the link is clicked. To test, apply the patch and go to Circulation -> Check in. Reduce the height of the browser window until you have to scroll down to reveal the "Checkin settings" link. Clicking it should not cause the page to scroll. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #28 from Jonathan Druart --- (In reply to Jonathan Druart from comment #27) > Created attachment 83180 [details] [review] > Bug 20959: Prevent the scrollbar to move to the top on click Hi Owen, can you give me your opinion on this patch? I can provide a follow-up to fix the :hover style if you think it is ok. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #27 from Jonathan Druart --- Created attachment 83180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83180=edit Bug 20959: Prevent the scrollbar to move to the top on click We could use e.preventDefault but it seems better to make the link wider than just the size of the text. However we lost the on a:hover style, we may want to reintroduce it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #25 from Owen Leonard --- Created attachment 82996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82996=edit Bug 20959: (follow-up) Prevent checkin button from wrapping This follow-up wraps the checkin form in a div to prevent the button from wrapping to the line below the input. To test, apply the patch and clear your browser cache if necessary. View the checkin page to confirm that there isn't a layout problem. Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #26 from Owen Leonard --- Created attachment 82997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82997=edit Bug 20959: (follow-up) Keep informational notes open after checkin This patch modifies the template so that the on-screen messages about settings like 'Book drop mode' stay open from one checkout to another. To test, apply the patch and test checking combinations of 'Forgive overdue charges' and 'Book drop mode,' verifying that their corresponding onscreen messages appear correctly and stay visible (or not) from one checkout to another. Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Attachment #78839|0 |1 is obsolete|| Attachment #78840|0 |1 is obsolete|| Attachment #79757|0 |1 is obsolete|| --- Comment #24 from Owen Leonard --- Created attachment 82995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82995=edit Bug 20959: Style checkin form more like the checkout form, with collapsed settings panel This patch modifies the structure of the checkin form so that settings (Specify return date, book drop mode, forgive overdue charges) are in a collapsed panel when inactive. The style of the barcode field and the mode notification messages has been changed to reduce the vertical motion of the form when selecting options. Some class names have been changed in circulation.tt and circulation.js to make them appropriate for use on both forms. To test, apply the patch and clear your browser cache if necessary. - View the checkin page. The "checkin settings" panel should be collapsed by default. - Confirm that the settings panel collapses and expands as it should. - Confirm that selecting "Forgive overdue charges" or "Book drop mode" trigger the display of the correct message and that the style of the barcode field is changed. - Confirm that after submitting a barcode for check-in, the settings panel stays open and your selected settings are still selected. Signed-off-by: Josef Moravec Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #23 from Katrin Fischer --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||katrin.fisc...@bsz-bw.de --- Comment #22 from Katrin Fischer --- Patch doesn't apply - Owen, can you please rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Attachment #78841|0 |1 is obsolete|| --- Comment #21 from Owen Leonard --- Created attachment 79757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79757=edit Bug 20959: (Follow-up) Keep informational notes open after checkin This patch modifies the template so that the on-screen messages about settings like 'Book drop mode' stay open from one checkout to another. To test, apply the patch and test checking combinations of 'Forgive overdue charges' and 'Book drop mode,' verifying that their corresponding onscreen messages appear correctly and stay visible (or not) from one checkout to another. Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #20 from Jonathan Druart --- In the last patch the following part reads wrong: +[% IF ( forgivemanualholdsexpire ) %] + +[% ELSE %] + +[% END %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #19 from Christopher Brannon --- I signed off, as it works as described. My concerns still apply. Also, I don't know if it is consistent behavior prior to the patch, but why doesn't using the manual date option present a message up on the right like the checkboxes do? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Christopher Brannon changed: What|Removed |Added Attachment #78831|0 |1 is obsolete|| --- Comment #18 from Christopher Brannon --- Created attachment 78841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78841=edit Bug 20959: (Follow-up) Keep informational notes open after checkin This patch modifies the template so that the on-screen messages about settings like 'Book drop mode' stay open from one checkout to another. To test, apply the patch and test checking combinations of 'Forgive overdue charges' and 'Book drop mode,' verifying that their corresponding onscreen messages appear correctly and stay visible (or not) from one checkout to another. Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Christopher Brannon changed: What|Removed |Added Attachment #78812|0 |1 is obsolete|| --- Comment #17 from Christopher Brannon --- Created attachment 78840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78840=edit Bug 20959: (follow-up) Prevent checkin button from wrapping This follow-up wraps the checkin form in a div to prevent the button from wrapping to the line below the input. To test, apply the patch and clear your browser cache if necessary. View the checkin page to confirm that there isn't a layout problem. Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Christopher Brannon changed: What|Removed |Added Attachment #78810|0 |1 is obsolete|| --- Comment #16 from Christopher Brannon --- Created attachment 78839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78839=edit Bug 20959: Style checkin form more like the checkout form, with collapsed settings panel This patch modifies the structure of the checkin form so that settings (Specify return date, book drop mode, forgive overdue charges) are in a collapsed panel when inactive. The style of the barcode field and the mode notification messages has been changed to reduce the vertical motion of the form when selecting options. Some class names have been changed in circulation.tt and circulation.js to make them appropriate for use on both forms. To test, apply the patch and clear your browser cache if necessary. - View the checkin page. The "checkin settings" panel should be collapsed by default. - Confirm that the settings panel collapses and expands as it should. - Confirm that selecting "Forgive overdue charges" or "Book drop mode" trigger the display of the correct message and that the style of the barcode field is changed. - Confirm that after submitting a barcode for check-in, the settings panel stays open and your selected settings are still selected. Signed-off-by: Josef Moravec Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Christopher Brannon changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org --- Comment #15 from Christopher Brannon --- Display wise it works as described. The layout looks fine on my end. The only issue I have is that this changes past behavior, in that you have an extra step to open the options. Typical upgrades try to maintain past behavior, and are changed by preference setting. While I HATE having another preference setting, I know too many people are going to complain that they have to open that up every morning. This may be griped about more than the similar switch on the checkout page. Perhaps, instead of a system preference, you do the same kind of setting similar to the checkbox on the checkouts TABLE that keeps the table open everytime you pull up the page. The other thought is, why have a message displayed to the side, if when you have the feature active, it always shows? Seems redundant. Cool, but redundant. The ONLY reason I would have the messages pinned to the side is if the feature settings were not glued to the page. Make sense? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #14 from Owen Leonard --- Created attachment 78831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78831=edit Bug 20959: (Follow-up) Keep informational notes open after checkin This patch modifies the template so that the on-screen messages about settings like 'Book drop mode' stay open from one checkout to another. To test, apply the patch and test checking combinations of 'Forgive overdue charges' and 'Book drop mode,' verifying that their corresponding onscreen messages appear correctly and stay visible (or not) from one checkout to another. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Attachment #76560|0 |1 is obsolete|| Attachment #76561|0 |1 is obsolete|| --- Comment #12 from Owen Leonard --- Created attachment 78810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78810=edit Bug 20959: Style checkin form more like the checkout form, with collapsed settings panel This patch modifies the structure of the checkin form so that settings (Specify return date, book drop mode, forgive overdue charges) are in a collapsed panel when inactive. The style of the barcode field and the mode notification messages has been changed to reduce the vertical motion of the form when selecting options. Some class names have been changed in circulation.tt and circulation.js to make them appropriate for use on both forms. To test, apply the patch and clear your browser cache if necessary. - View the checkin page. The "checkin settings" panel should be collapsed by default. - Confirm that the settings panel collapses and expands as it should. - Confirm that selecting "Forgive overdue charges" or "Book drop mode" trigger the display of the correct message and that the style of the barcode field is changed. - Confirm that after submitting a barcode for check-in, the settings panel stays open and your selected settings are still selected. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #13 from Owen Leonard --- Created attachment 78812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78812=edit Bug 20959: (follow-up) Prevent checkin button from wrapping This follow-up wraps the checkin form in a div to prevent the button from wrapping to the line below the input. To test, apply the patch and clear your browser cache if necessary. View the checkin page to confirm that there isn't a layout problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Attachment #76561|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Attachment #76560|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Attachment #78733|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Attachment #78734|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Attachment #76526|0 |1 is obsolete|| Attachment #76561|0 |1 is obsolete|| --- Comment #10 from Owen Leonard --- Created attachment 78733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78733=edit Bug 20959: Style checkin form more like the checkout form, with collapsed settings panel This patch modifies the structure of the checkin form so that settings (Specify return date, book drop mode, forgive overdue charges) are in a collapsed panel when inactive. The style of the barcode field and the mode notification messages has been changed to reduce the vertical motion of the form when selecting options. Some class names have been changed in circulation.tt and circulation.js to make them appropriate for use on both forms. To test, apply the patch and clear your browser cache if necessary. - View the checkin page. The "checkin settings" panel should be collapsed by default. - Confirm that the settings panel collapses and expands as it should. - Confirm that selecting "Forgive overdue charges" or "Book drop mode" trigger the display of the correct message and that the style of the barcode field is changed. - Confirm that after submitting a barcode for check-in, the settings panel stays open and your selected settings are still selected. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #11 from Owen Leonard --- Created attachment 78734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78734=edit Bug 20959: (follow-up) Prevent checkin button from wrapping This follow-up wraps the checkin form in a div to prevent the button from wrapping to the line below the input. To test, apply the patch and clear your browser cache if necessary. View the checkin page to confirm that there isn't a layout problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #9 from Jonathan Druart --- (In reply to Jonathan Druart from comment #8) > Still not: https://screenshots.firefox.com/fqd4mfODVhwLxDXI/pro.kohadev.org Well yes, it fixed the position of the button. But now the messages on the right (settings) overlap the button. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #8 from Jonathan Druart --- Still not: https://screenshots.firefox.com/fqd4mfODVhwLxDXI/pro.kohadev.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #7 from Owen Leonard --- Created attachment 76561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76561=edit Bug 20959: (follow-up) Prevent checkin button from wrapping This follow-up wraps the checkin form in a div to prevent the button from wrapping to the line below the input. To test, apply the patch and clear your browser cache if necessary. View the checkin page to confirm that there isn't a layout problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Attachment #76560|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Attachment #76526|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Attachment #76526|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 76560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76560=edit Bug 20959: Style checkin form more like the checkout form, with collapsed settings panel This patch modifies the structure of the checkin form so that settings (Specify return date, book drop mode, forgive overdue charges) are in a collapsed panel when inactive. The style of the barcode field and the mode notification messages has been changed to reduce the vertical motion of the form when selecting options. Some class names have been changed in circulation.tt and circulation.js to make them appropriate for use on both forms. To test, apply the patch and clear your browser cache if necessary. - View the checkin page. The "checkin settings" panel should be collapsed by default. - Confirm that the settings panel collapses and expands as it should. - Confirm that selecting "Forgive overdue charges" or "Book drop mode" trigger the display of the correct message and that the style of the barcode field is changed. - Confirm that after submitting a barcode for check-in, the settings panel stays open and your selected settings are still selected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart --- Tomas tested on Ubuntu 18.04 + 1080p, with chrome, chromium and FF: https://snag.gy/LGTqCl.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- I have the "Checkin" button at the bottom of the barcode input. https://screenshots.firefox.com/FK6HtuCBLyx28NEA/pro.kohadev.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Josef Moravec changed: What|Removed |Added Attachment #76139|0 |1 is obsolete|| --- Comment #3 from Josef Moravec --- Created attachment 76526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76526=edit Bug 20959: Style checkin form more like the checkout form, with collapsed settings panel This patch modifies the structure of the checkin form so that settings (Specify return date, book drop mode, forgive overdue charges) are in a collapsed panel when inactive. The style of the barcode field and the mode notification messages has been changed to reduce the vertical motion of the form when selecting options. Some class names have been changed in circulation.tt and circulation.js to make them appropriate for use on both forms. To test, apply the patch and clear your browser cache if necessary. - View the checkin page. The "checkin settings" panel should be collapsed by default. - Confirm that the settings panel collapses and expands as it should. - Confirm that selecting "Forgive overdue charges" or "Book drop mode" trigger the display of the correct message and that the style of the barcode field is changed. - Confirm that after submitting a barcode for check-in, the settings panel stays open and your selected settings are still selected. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Sally Healey changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #2 from Owen Leonard --- Created attachment 76139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76139=edit Bug 20959: Style checkin form more like the checkout form, with collapsed settings panel This patch modifies the structure of the checkin form so that settings (Specify return date, book drop mode, forgive overdue charges) are in a collapsed panel when inactive. The style of the barcode field and the mode notification messages has been changed to reduce the vertical motion of the form when selecting options. Some class names have been changed in circulation.tt and circulation.js to make them appropriate for use on both forms. To test, apply the patch and clear your browser cache if necessary. - View the checkin page. The "checkin settings" panel should be collapsed by default. - Confirm that the settings panel collapses and expands as it should. - Confirm that selecting "Forgive overdue charges" or "Book drop mode" trigger the display of the correct message and that the style of the barcode field is changed. - Confirm that after submitting a barcode for check-in, the settings panel stays open and your selected settings are still selected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #1 from Owen Leonard --- Created attachment 76137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76137=edit Screenshot showing active book drop mode setting -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
