[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED --- Comment #10 from Fridolin SOMERS --- Pushed to 17.05.x for 17.05.14 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #9 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 Regular expression are a curse, they can be hell or heaven :D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Master|Pushed to Stable --- Comment #8 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 Katrin Fischer changed: What|Removed |Added Attachment #76290|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 Katrin Fischer changed: What|Removed |Added Attachment #76281|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 --- Comment #6 from Katrin Fischer --- Created attachment 76304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76304=edit Bug 20972: Add a testcase for bug 20972 Ensure all 10 characters of ISBN are preserved And that ISBNs and EANs are correctly identidied in the PIA segment Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 --- Comment #5 from Katrin Fischer --- Created attachment 76303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76303=edit Bug 20972: If ISBN has 10 numbers only the first 9 numbers are used If ISBN has 10 numbers only the first 9 numbers are being added to the Edifact-message (PIA+5+3540556753:IB') This is caused by wrong positioning of capturing parentheses in a regular expression. Sponsored-by: Gothenburg University Library Signed-off-by: Colin Campbell Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 --- Comment #4 from Katrin Fischer --- Thx for the quick sign-off and tests, Colin! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 --- Comment #3 from Colin Campbell --- Created attachment 76290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76290=edit Add a test case for this to Ediorder.t Add a test for this bug and ensure routine is correctly distinguishing 10 character ISBNs from 13 digit EANs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 Colin Campbell changed: What|Removed |Added Attachment #76225|0 |1 is obsolete|| --- Comment #2 from Colin Campbell --- Created attachment 76281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76281=edit Signed off patch correcting ISBN extraction Signed off patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 Colin Campbell changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 Jonathan Druart changed: What|Removed |Added Depends on||7736 Status|NEW |Needs Signoff Version|17.05 |master CC||jonathan.dru...@bugs.koha-c ||ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 [Bug 7736] Edifact QUOTE and ORDER functionality -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 Katrin Fischer changed: What|Removed |Added CC||colin.campbell@ptfs-europe. ||com, ||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972 --- Comment #1 from Johan Larsson --- Created attachment 76225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76225=edit Bug 20972: If ISBN has 10 numbers only the first 9 numbers are used If ISBN has 10 numbers only the first 9 numbers are being added to the Edifact-message (PIA+5+3540556753:IB') This is caused by wrong positioning of capturing parentheses in a regular expression. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
