[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Martin Renvoize changed: What|Removed |Added Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Martin Renvoize changed: What|Removed |Added Blocks|21756 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 [Bug 21756] Update C4::Accounts::manualinvoice to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Martin Renvoize changed: What|Removed |Added Blocks||21756 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 [Bug 21756] Update C4::Accounts::manualinvoice to use Koha::Account->add_credit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21002 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Martin Renvoize changed: What|Removed |Added Blocks|21002 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Bug 20978 depends on bug 20946, which changed state. Bug 20946 Summary: Cannot pay fines for patrons with credits https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Blocks||21584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 [Bug 21584] Wrong offset type for Lost Item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Master|RESOLVED --- Comment #29 from Martin Renvoize --- Awesome to see the code cleanup going on here! Not backporting to 18.05.x series at the moment as it's an enhancement/refactoring piece. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #28 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76727|0 |1 is obsolete|| --- Comment #27 from Tomás Cohen Arazi --- Created attachment 76733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76733=edit Bug 20978: (QA follow-up) Do not delete existing data on tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76726|0 |1 is obsolete|| --- Comment #26 from Tomás Cohen Arazi --- Created attachment 76727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76727=edit Bug 20978: (QA follow-up) Do not delete existing data on tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 76726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76726=edit Bug 20978: (QA follow-up) Do not delete existing data on tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76515|0 |1 is obsolete|| --- Comment #24 from Tomás Cohen Arazi --- Created attachment 76636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76636=edit Bug 20978: (follow-up) POD completeness Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76441|0 |1 is obsolete|| --- Comment #23 from Tomás Cohen Arazi --- Created attachment 76635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76635=edit Bug 20978: (follow-up) Another use case from C4::Circulation Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76440|0 |1 is obsolete|| --- Comment #22 from Tomás Cohen Arazi --- Created attachment 76634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76634=edit Bug 20978: Add Koha::Account::add_credit This patch adds: - Koha::Account::add_credit - A single source of truth for accounttype and offset_type values To test: - Apply the first patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: Tests fail! - Apply this patch - Run: k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76439|0 |1 is obsolete|| --- Comment #21 from Tomás Cohen Arazi --- Created attachment 76633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76633=edit Bug 20978: Unit tests This patch adds unit tests for Koha::Account::add_credit. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 76515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76515=edit Bug 20978: (follow-up) POD completeness Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Blocks||21002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Josef Moravec changed: What|Removed |Added Blocks||20997 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 [Bug 20997] Add Koha::Account::Line::apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 --- Comment #19 from Kyle M Hall --- Created attachment 76441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76441=edit Bug 20978: (follow-up) Another use case from C4::Circulation Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 --- Comment #18 from Kyle M Hall --- Created attachment 76440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76440=edit Bug 20978: Add Koha::Account::add_credit This patch adds: - Koha::Account::add_credit - A single source of truth for accounttype and offset_type values To test: - Apply the first patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: Tests fail! - Apply this patch - Run: k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Kyle M Hall changed: What|Removed |Added Attachment #76396|0 |1 is obsolete|| Attachment #76397|0 |1 is obsolete|| Attachment #76398|0 |1 is obsolete|| --- Comment #17 from Kyle M Hall --- Created attachment 76439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76439=edit Bug 20978: Unit tests This patch adds unit tests for Koha::Account::add_credit. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Josef Moravec changed: What|Removed |Added Blocks|20990 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990 [Bug 20990] Add Koha::Account::outstanding_credits -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 --- Comment #16 from Josef Moravec --- Created attachment 76398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76398=edit Bug 20978: (follow-up) Another use case from C4::Circulation Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Josef Moravec changed: What|Removed |Added Attachment #76319|0 |1 is obsolete|| Attachment #76320|0 |1 is obsolete|| Attachment #76321|0 |1 is obsolete|| --- Comment #14 from Josef Moravec --- Created attachment 76396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76396=edit Bug 20978: Unit tests This patch adds unit tests for Koha::Account::add_credit. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 --- Comment #15 from Josef Moravec --- Created attachment 76397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76397=edit Bug 20978: Add Koha::Account::add_credit This patch adds: - Koha::Account::add_credit - A single source of truth for accounttype and offset_type values To test: - Apply the first patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: Tests fail! - Apply this patch - Run: k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Josef Moravec changed: What|Removed |Added Blocks||20990 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990 [Bug 20990] Add Koha::Account::outstanding_credits -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Blocks||14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Depends on||20946 --- Comment #13 from Tomás Cohen Arazi --- I rebased on top of bug 20946, which is more urgent as it affects the stable branches. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946 [Bug 20946] Cannot pay fines for patrons with credits -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76279|0 |1 is obsolete|| --- Comment #11 from Tomás Cohen Arazi --- Created attachment 76320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76320=edit Bug 20978: Add Koha::Account::add_credit This patch adds: - Koha::Account::add_credit - A single source of truth for accounttype and offset_type values To test: - Apply the first patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: Tests fail! - Apply this patch - Run: k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76278|0 |1 is obsolete|| --- Comment #10 from Tomás Cohen Arazi --- Created attachment 76319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76319=edit Bug 20978: Unit tests This patch adds unit tests for Koha::Account::add_credit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76280|0 |1 is obsolete|| --- Comment #12 from Tomás Cohen Arazi --- Created attachment 76321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76321=edit Bug 20978: (follow-up) Another use case from C4::Circulation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76245|0 |1 is obsolete|| --- Comment #9 from Tomás Cohen Arazi --- Created attachment 76280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76280=edit Bug 20978: (follow-up) Another use case from C4::Circulation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76244|0 |1 is obsolete|| --- Comment #8 from Tomás Cohen Arazi --- Created attachment 76279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76279=edit Bug 20978: Add Koha::Account::add_credit This patch adds: - Koha::Account::add_credit - A single source of truth for accounttype and offset_type values To test: - Apply the first patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: Tests fail! - Apply this patch - Run: k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76243|0 |1 is obsolete|| --- Comment #7 from Tomás Cohen Arazi --- Created attachment 76278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76278=edit Bug 20978: Unit tests This patch adds unit tests for Koha::Account::add_credit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Blocks||20980 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 [Bug 20980] Manual credit offsets are stored as debits -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76242|0 |1 is obsolete|| --- Comment #6 from Tomás Cohen Arazi --- Created attachment 76245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76245=edit Bug 20978: (follow-up) Another use case from C4::Circulation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76240|0 |1 is obsolete|| --- Comment #4 from Tomás Cohen Arazi --- Created attachment 76243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76243=edit Bug 20978: Unit tests This patch adds unit tests for Koha::Account::add_credit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76241|0 |1 is obsolete|| --- Comment #5 from Tomás Cohen Arazi --- Created attachment 76244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76244=edit Bug 20978: Add Koha::Account::add_credit This patch adds: - Koha::Account::add_credit - A single source of truth for accounttype and offset_type values To test: - Apply the first patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: Tests fail! - Apply this patch - Run: k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added CC||kyle.m.h...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 76242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76242=edit Bug 20978: (follow-up) Another use case from C4::Circulation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 76241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76241=edit Bug 20978: Add Koha::Account::add_credit This patch adds: - Koha::Account::add_credit - A single source of truth for accounttype and offset_type values To test: - Apply the first patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: Tests fail! - Apply this patch - Run: k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 76240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76240=edit Bug 20978: Unit tests This patch adds unit tests for Koha::Account::add_credit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Blocks||20944 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 [Bug 20944] Add routes to add credits and debits to a patron's account -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
