[Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED CC||fridolin.som...@biblibre.co ||m --- Comment #12 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 Martin Renvoize changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Master|Pushed to Stable --- Comment #11 from Martin Renvoize --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015
Marcel de Rooy changed:
What|Removed |Added
Attachment #80751|0 |1
is obsolete||
--- Comment #8 from Marcel de Rooy ---
Created attachment 81865
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81865=edit
Bug 21015: fix performance issue with C4::Members
loading Koha::Schema ("use Koha::Schema;") takes significantly time as
it loads almost a couple hundred classes. Koha::Database has done that
already once and we can use it to get the ResultSet "Borrower" as
well, so let's use that. This also make the code more unified because
Koha::Database is used throughout the code instead of Koha::Schema.
Signed-off-by: Jonathan Druart
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 Marcel de Rooy changed: What|Removed |Added Attachment #80752|0 |1 is obsolete|| --- Comment #9 from Marcel de Rooy --- Created attachment 81866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81866=edit Bug 21015: Remove unecessary 'use Koha::Schema' statements in t/ Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 --- Comment #7 from David Cook --- Awesome! I should've looked more thoroughly when I reported #21160. This should have some nice knock on effects, especially for CGI users. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #6 from Jonathan Druart --- ho, excellent! % more t.pl use C4::Members; print get_cardnumber_length(); Without the patch: ~1.6s With the patch: 0.8s -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 --- Comment #5 from Jonathan Druart --- Created attachment 80752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80752=edit Bug 21015: Remove unecessary 'use Koha::Schema' statements in t/ Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015
Jonathan Druart changed:
What|Removed |Added
Attachment #76556|0 |1
is obsolete||
--- Comment #4 from Jonathan Druart
---
Created attachment 80751
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80751=edit
Bug 21015: fix performance issue with C4::Members
loading Koha::Schema ("use Koha::Schema;") takes significantly time as
it loads almost a couple hundred classes. Koha::Database has done that
already once and we can use it to get the ResultSet "Borrower" as
well, so let's use that. This also make the code more unified because
Koha::Database is used throughout the code instead of Koha::Schema.
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 Jonathan Druart changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from Jonathan Druart --- *** Bug 21160 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi, this is already looking good. Could you still add a little test plan to see where the routine is used for the testers? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 j.kylm...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |j.kylm...@gmail.com |ity.org | --- Comment #1 from j.kylm...@gmail.com --- Created attachment 76556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76556=edit Bug 21015: fix performance issue with C4::Members This is the proposed patch but please run the tests as I have not done so (yet). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
