[Koha-bugs] [Bug 21096] Garbled username on intranet login page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED --- Comment #15 from Fridolin SOMERS --- Depends on Bug 18403 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 Fridolin SOMERS changed: What|Removed |Added Depends on||18403 CC||fridolin.som...@biblibre.co ||m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Master|Pushed to Stable --- Comment #14 from Martin Renvoize --- Pushed to 18.05.x for 18.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #13 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096
Jonathan Druart changed:
What|Removed |Added
Attachment #77415|0 |1
is obsolete||
--- Comment #12 from Jonathan Druart
---
Created attachment 78286
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78286=edit
Bug 21096: Do not display loggedinusername in template
This patch is a little fix for a much bigger hidden issues.
The original issue:
1. Set the firstname and surname values of a paontr to utf-8 characters
("wide characters"), for instance 月月
2. Use this patron to login at the staff interface
=> In the header the logged in patron's info (concat of firstname and
surname) are displayed correctly
3. Hit whatever link
=> In the header the info are now displayed incorrectly
("ææ")
What happens?
After that the user loggin, loggedinusername is set with the value from
the DB (borrowers.userid)
On next hits it is picked from the session (which contains the decoded
utf8 value, see first lines of C4::Context->set_userenv)
From C4::Auth::checkauth:
834 $s_userid = $session->param('id') // ''
The quick fix is to use the logged_in_user variable in the template, but
it seems that issues may occurred if external authentication is used
(ldap, shib, cas). Could someone test this?
Test plan:
Make sure the original issue is fixed
Signed-off-by: Owen Leonard
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 Nick Clemens changed: What|Removed |Added Status|Passed QA |Patch doesn't apply CC||n...@bywatersolutions.com --- Comment #11 from Nick Clemens --- (In reply to Jonathan Druart from comment #9) > Note for QA: > > 254 # A bit of a hack, but I don't know there's a nicer way > 255 # to do it. > 256 $user = $patron->firstname . ' ' . $patron->surname; > > Is this still valid? If yes, the patch is not enough. I cannot trigger this code, I think this patch should be good for now. Can you rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096
Katrin Fischer changed:
What|Removed |Added
Attachment #77271|0 |1
is obsolete||
--- Comment #10 from Katrin Fischer ---
Created attachment 77415
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77415=edit
Bug 21096: Do not display loggedinusername in template
This patch is a little fix for a much bigger hidden issues.
The original issue:
1. Set the firstname and surname values of a paontr to utf-8 characters
("wide characters"), for instance 月月
2. Use this patron to login at the staff interface
=> In the header the logged in patron's info (concat of firstname and
surname) are displayed correctly
3. Hit whatever link
=> In the header the info are now displayed incorrectly
("ææ")
What happens?
After that the user loggin, loggedinusername is set with the value from
the DB (borrowers.userid)
On next hits it is picked from the session (which contains the decoded
utf8 value, see first lines of C4::Context->set_userenv)
From C4::Auth::checkauth:
834 $s_userid = $session->param('id') // ''
The quick fix is to use the logged_in_user variable in the template, but
it seems that issues may occurred if external authentication is used
(ldap, shib, cas). Could someone test this?
Test plan:
Make sure the original issue is fixed
Signed-off-by: Owen Leonard
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 Katrin Fischer changed: What|Removed |Added Summary|Garbled username on |Garbled username on |intranet login page.|intranet login page CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 --- Comment #9 from Jonathan Druart --- Note for QA: 254 # A bit of a hack, but I don't know there's a nicer way 255 # to do it. 256 $user = $patron->firstname . ' ' . $patron->surname; Is this still valid? If yes, the patch is not enough. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096
Owen Leonard changed:
What|Removed |Added
Attachment #77270|0 |1
is obsolete||
--- Comment #8 from Owen Leonard ---
Created attachment 77271
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77271=edit
Bug 21096: Do not display loggedinusername in template
This patch is a little fix for a much bigger hidden issues.
The original issue:
1. Set the firstname and surname values of a paontr to utf-8 characters
("wide characters"), for instance 月月
2. Use this patron to login at the staff interface
=> In the header the logged in patron's info (concat of firstname and
surname) are displayed correctly
3. Hit whatever link
=> In the header the info are now displayed incorrectly
("ææ")
What happens?
After that the user loggin, loggedinusername is set with the value from
the DB (borrowers.userid)
On next hits it is picked from the session (which contains the decoded
utf8 value, see first lines of C4::Context->set_userenv)
From C4::Auth::checkauth:
834 $s_userid = $session->param('id') // ''
The quick fix is to use the logged_in_user variable in the template, but
it seems that issues may occurred if external authentication is used
(ldap, shib, cas). Could someone test this?
Test plan:
Make sure the original issue is fixed
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096
--- Comment #7 from Jonathan Druart
---
Created attachment 77270
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77270=edit
Bug 21096: Do not display loggedinusername in template
This patch is a little fix for a much bigger hidden issues.
The original issue:
1. Set the firstname and surname values of a paontr to utf-8 characters
("wide characters"), for instance 月月
2. Use this patron to login at the staff interface
=> In the header the logged in patron's info (concat of firstname and
surname) are displayed correctly
3. Hit whatever link
=> In the header the info are now displayed incorrectly
("ææ")
What happens?
After that the user loggin, loggedinusername is set with the value from
the DB (borrowers.userid)
On next hits it is picked from the session (which contains the decoded
utf8 value, see first lines of C4::Context->set_userenv)
From C4::Auth::checkauth:
834 $s_userid = $session->param('id') // ''
The quick fix is to use the logged_in_user variable in the template, but
it seems that issues may occurred if external authentication is used
(ldap, shib, cas). Could someone test this?
Test plan:
Make sure the original issue is fixed
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED Version|18.05 |master --- Comment #6 from Jonathan Druart --- Confirmed on master. It appends on second click (no when just logged in). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 --- Comment #5 from Lauski Mori --- (In reply to Lauski Mori from comment #4) > (In reply to Jonathan Druart from comment #3) > > (In reply to Jonathan Druart from comment #2) > > > You should paste here the values of surname and firstname you have set for > > > this user. > > > > And the userid (it is the one displayed on the intranet side actually) > > Hello, Jonathan Druart! > I set the same value for surname and firstname: they were 月 and 月, which > were Traditional Chinese Characters. Also the userid was 月月 as a full name for surname and firstname. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 --- Comment #4 from Lauski Mori --- (In reply to Jonathan Druart from comment #3) > (In reply to Jonathan Druart from comment #2) > > You should paste here the values of surname and firstname you have set for > > this user. > > And the userid (it is the one displayed on the intranet side actually) Hello, Jonathan Druart! I set the same value for surname and firstname: they were 月 and 月, which were Traditional Chinese Characters. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 --- Comment #3 from Jonathan Druart --- (In reply to Jonathan Druart from comment #2) > You should paste here the values of surname and firstname you have set for > this user. And the userid (it is the one displayed on the intranet side actually) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #2 from Jonathan Druart --- You should paste here the values of surname and firstname you have set for this user. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 Owen Leonard changed: What|Removed |Added Severity|new feature |normal --- Comment #1 from Owen Leonard --- For what it's worth, I didn't find this to be a problem in master, testing with Firefox and Chrome on Windows 10. I copied and pasted characters from this page for testing: http://carlgene.com/blog/2012/02/45-mandarin-sentences-with-chinese-characteristics/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
