[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-09-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Alex Buckley  changed:

   What|Removed |Added

  Attachment #78010|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-09-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Alex Buckley  changed:

   What|Removed |Added

  Attachment #78008|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-09-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

--- Comment #18 from Katrin Fischer  ---
Hi Alex,

can you provide a new patch changing the default behaviour (no syspref needed)
plz? We are getting closer to the freeze dates and it would be nice to see this
go in!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Jesse Maseto  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||je...@bywatersolutions.com

--- Comment #17 from Jesse Maseto  ---
PATCH DOESNT APPLY.


Applying: Bug 21174: (alternate) Sysprefs to enable the opening of OPAC cart in
one click
Using index info to reconstruct a base tree...
M   koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
Failed to merge in the changes.
Patch failed at 0001 Bug 21174: (alternate) Sysprefs to enable the opening of
OPAC cart in one click
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-21174-alternate-Sysprefs-to-enable-the-opening-vGL1MP.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

--- Comment #16 from Katrin Fischer  ---
Fewer clicks++

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20678

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21249

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Elaine Bradtke  changed:

   What|Removed |Added

 CC||e...@efdss.org

--- Comment #15 from Elaine Bradtke  ---
Yes, the fewer clicks the better. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #14 from Josef Moravec  ---
Hi all, about the question asked on mailing lists: I think the default
behaviour change to one click to show the cart does make sense. So I am for it
;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Alex Buckley  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21173,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21241,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21159

--- Comment #13 from Alex Buckley  ---
Hi Owen and Katrin

Thanks, Owen I have taken a look at your commit and signed off on it. I have
also added a new commit containing the atomicupdate file and some changes to
basket.js fixing a few minor bugs. 

Now when both commits the JS error is not being thrown, and so I have reset
this back to 'Needs signoff'. Can you please take a look/test at my new commit?

Additionally, as you may have seen I have asked the general and dev mailing
lists about what peoples thoughts on the default cart popup opening process is,
and for feedback on changing the default behavior for opening the cart popup to
just clicking on the cart icon once to load the cart popup. 

Cheers,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

--- Comment #12 from Alex Buckley  ---
Created attachment 78010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78010=edit
Bug 21174 - Syspref for choosing to load cart popup upon one click on the cart
icon.

Instead of OPAC users having to click on the cart icon, then having to
click on the dropdown box 'Items in your cart:..' to load the cart popup
with this syspref enabled OPAC users only need to click once on theOPAC
cart icon and the cart popup loads.

Test plan:
1. In Koha OPAC click on the cart icon (making sure to have items in the
cart and the dropdown box 'Items in your cart:..' appears.

2. Click this dropdown and the cart popup appears.

3. Confirm you can successfully remove items from and empty the
cart

4. Apply patch

5. Restart memcached, plack and in koha-shell run
./updatedatabase.pl

6. By default the new syspref in this patch is turned off.
Therefore repeat steps: 1,2,3 and confirm they work the same as before you
applied the commit

7. In Koha staff client go to Administration->Global system
preferences and enable the 'EnableOneClickToOpenCartPopup' preference

8. Back in the OPAC click on the cart icon (making sure to have items in
the cart) and notice no 'Items in your: ..' dropdown appears
instead the cart popup loads straight away.

9. Confirm the items in your cart is displayed by the cart popup

10. Confirm you can remove items from/empty the cart

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Alex Buckley  changed:

   What|Removed |Added

  Attachment #78009|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

--- Comment #11 from Alex Buckley  ---
Created attachment 78009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78009=edit
Bug 21174 - Syspref for choosing to load cart popup upon one click on the cart
icon.

Instead of OPAC users having to click on the cart icon, then having to
click on the dropdown box 'Items in your cart:..' to load the cart popup
with this syspref enabled OPAC users only need to click once on theOPAC
cart icon and the cart popup loads.

Test plan:
1. In Koha OPAC click on the cart icon (making sure to have items in the
cart and the dropdown box 'Items in your cart:..' appears.

2. Click this dropdown and the cart popup appears.

3. Confirm you can successfully remove items from and empty the
cart

4. Apply patch

5. Restart memcached, plack and in koha-shell run
./updatedatabase.pl

6. By default the new syspref in this patch is turned off.
Therefore repeat steps: 1,2,3 and confirm they work the same as before you
applied the commit

7. In Koha staff client go to Administration->Global system
preferences and enable the 'EnableOneClickToOpenCartPopup' preference

8. Back in the OPAC click on the cart icon (making sure to have items in
the cart) and notice no 'Items in your: ..' dropdown appears
instead the cart popup loads straight away.

9. Confirm the items in your cart is displayed by the cart popup

10. Confirm you can remove items from/empty the cart

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

--- Comment #10 from Alex Buckley  ---
Created attachment 78008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78008=edit
Bug 21174: (alternate) Sysprefs to enable the opening of OPAC cart in one click

This is an alternate patch which would replace the proposed changes to
masthead.inc, opac-bottom.inc, opac-basket.tt, and basket.js.

This patch slightly changes the markup in masthead.inc so that the Cart
link doesn't try to interpret it as a dropdown trigger, and switches out
the ID attribute so that it triggers the right action from basket.js.

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Alex Buckley  changed:

   What|Removed |Added

  Attachment #78007|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Alex Buckley  changed:

   What|Removed |Added

  Attachment #77684|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Alex Buckley  changed:

   What|Removed |Added

  Attachment #77642|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

--- Comment #9 from Alex Buckley  ---
Created attachment 78007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78007=edit
Bug 21174 - Syspref for choosing to load cart popup upon one click on the cart
icon.

Instead of OPAC users having to click on the cart icon, then having to
click on the dropdown box 'Items in your cart:..' to load the cart popup
with this syspref enabled OPAC users only need to click once on theOPAC
cart icon and the cart popup loads.

Test plan:
1. In Koha OPAC click on the cart icon (making sure to have items in the
cart and the dropdown box 'Items in your cart:..' appears.

2. Click this dropdown and the cart popup appears.

3. Confirm you can successfully remove items from and empty the
cart

4. Apply patch

5. Restart memcached, plack and in koha-shell run
./updatedatabase.pl

6. By default the new syspref in this patch is turned off.
Therefore repeat steps: 1,2,3 and confirm they work the same as before you
applied the commit

7. In Koha staff client go to Administration->Global system
preferences and enable the 'EnableOneClickToOpenCartPopup' preference

8. Back in the OPAC click on the cart icon (making sure to have items in
the cart) and notice no 'Items in your: ..' dropdown appears
instead the cart popup loads straight away.

9. Confirm the items in your cart is displayed by the cart popup

10. Confirm you can remove items from/empty the cart

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Alex Buckley  changed:

   What|Removed |Added

  Attachment #78006|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

--- Comment #8 from Alex Buckley  ---
Created attachment 78006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78006=edit
Bug 21174 - Added missing atomicupdate

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

--- Comment #7 from Katrin Fischer  ---
+1 for asking the mailing list, the current behaviour causes a bit of confusion
here and there

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #6 from Owen Leonard  ---
Alex: I think my proposed patch would simplify the change you want to make. See
if it works for you.

Your patch is missing an update to the database, and I think that's causing a
blocking JavaScript error. I'm going to mark this failed QA for that.

BUT... Does anyone really love the way it currently works? Maybe we should just
make this updated interaction the default? I think it would be worth asking on
the Koha mailing list.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

--- Comment #5 from Owen Leonard  ---
Created attachment 77684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77684=edit
Bug 21174: (alternate) Sysprefs to enable the opening of OPAC cart in one click

This is an alternate patch which would replace the proposed changes to
masthead.inc, opac-bottom.inc, opac-basket.tt, and basket.js.

This patch slightly changes the markup in masthead.inc so that the Cart
link doesn't try to interpret it as a dropdown trigger, and switches out
the ID attribute so that it triggers the right action from basket.js.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Alex Buckley  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #4 from Alex Buckley  ---
Amended commit added containing a test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

--- Comment #3 from Alex Buckley  ---
Created attachment 77642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77642=edit
Bug 21174 - Implemented syspref to enable the loading of cart popup on one
click

Test plan:
1. In Koha OPAC click on the cart icon (making sure to have items in the
cart and the dropdown box 'Items in your cart:..' appears.

2. Click this dropdown and the cart popup appears.

3. Confirm you can successfully remove items from and empty the cart

4. Apply patch

5. Restart memcached, plack and in koha-shell run ./updatedatabase.pl

6. By default the new syspref in this patch is turned off. Therefore
repeat steps: 1,2,3 and confirm they work the same as before you applied
the commit

7. In Koha staff client go to Administration->Global system preferences
and enable the 'EnableOneClickToOpenCartPopup' preference

8. Back in the OPAC click on the cart icon (making sure to have items in
the cart) and notice no 'Items in your: ..' dropdown appears instead the
cart popup loads straight away.

9. Confirm the items in your cart is displayed by the cart popup

10. Confirm you can remove items from/empty the cart

Sponsored-By: Toi Ohomai Insitute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Alex Buckley  changed:

   What|Removed |Added

  Attachment #77550|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de,
   ||oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Alex Buckley  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |alexbuck...@catalyst.net.nz
 Status|NEW |ASSIGNED

--- Comment #2 from Alex Buckley  ---
I will amend the commit message shortly to contain a test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

--- Comment #1 from Alex Buckley  ---
Created attachment 77550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77550=edit
Bug 21174 - Implemented syspref to enable the loading of cart popup on one
click

Sponsored-By: Toi Ohomai Insitute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/