[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Nick Clemens changed: What|Removed |Added Blocks||22288 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288 [Bug 22288] Barcode file does not work in modifying items in batch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Bug 21183 depends on bug 21182, which changed state. Bug 21182 Summary: acqui/check_duplicate_barcode_ajax.pl is not longer in use https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21182 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED CC||martin.renvoize@ptfs-europe ||.com --- Comment #16 from Martin Renvoize --- Refactoring enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #15 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Katrin Fischer changed: What|Removed |Added Attachment #77936|0 |1 is obsolete|| Attachment #77937|0 |1 is obsolete|| Attachment #77938|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 78056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78056=edit Bug 21183: Remove GetItemnumberFromBarcode Test plan: git grep GetItemnumberFromBarcode should not return anything Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 --- Comment #14 from Katrin Fischer --- Created attachment 78058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78058=edit Bug 21183: Fix ->get_column call context I am not sure to understand what's going on here. Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183
--- Comment #13 from Katrin Fischer ---
Created attachment 78057
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78057=edit
Bug 21183: Replace C4::Items::GetItemnumberFromBarcode calls
C4::Items::GetItemnumberFromBarcode calls can be replaced with
Koha::Items->find({ barcode => $barcode });
We should make sure the barcode existed in DB and so that ->find
returns an object. Note that most of the time we just wanted to know if
the barcode existed.
The changes are very simple, the only one that need attention is
the one in batchMod.pl. It is basically reusing what we did on
bug 21141.
Test plan:
Use the batch item modification/deletion tools to modify/delete items
from their barcode (using the textarea or a file)
Signed-off-by: Josef Moravec
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183
--- Comment #10 from Josef Moravec ---
Created attachment 77937
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77937=edit
Bug 21183: Replace C4::Items::GetItemnumberFromBarcode calls
C4::Items::GetItemnumberFromBarcode calls can be replaced with
Koha::Items->find({ barcode => $barcode });
We should make sure the barcode existed in DB and so that ->find
returns an object. Note that most of the time we just wanted to know if
the barcode existed.
The changes are very simple, the only one that need attention is
the one in batchMod.pl. It is basically reusing what we did on
bug 21141.
Test plan:
Use the batch item modification/deletion tools to modify/delete items
from their barcode (using the textarea or a file)
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Josef Moravec changed: What|Removed |Added Attachment #77587|0 |1 is obsolete|| Attachment #77930|0 |1 is obsolete|| Attachment #77933|0 |1 is obsolete|| --- Comment #9 from Josef Moravec --- Created attachment 77936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77936=edit Bug 21183: Remove GetItemnumberFromBarcode Test plan: git grep GetItemnumberFromBarcode should not return anything Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 --- Comment #11 from Josef Moravec --- Created attachment 77938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77938=edit Bug 21183: Fix ->get_column call context I am not sure to understand what's going on here. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #8 from Jonathan Druart --- Hum, weird... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 --- Comment #7 from Jonathan Druart --- Created attachment 77933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77933=edit Bug 21183: Fix ->get_column call context I am not sure to understand what's going on here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183
Josef Moravec changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #6 from Josef Moravec ---
Sorry, but still not working:
Can't use string ("2") as an ARRAY ref while "strict refs" in use at
/home/vagrant/kohaclone/tools/batchMod.pl line 269
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183
Jonathan Druart changed:
What|Removed |Added
Attachment #77687|0 |1
is obsolete||
--- Comment #5 from Jonathan Druart
---
Created attachment 77930
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77930=edit
Bug 21183: Replace C4::Items::GetItemnumberFromBarcode calls
C4::Items::GetItemnumberFromBarcode calls can be replaced with
Koha::Items->find({ barcode => $barcode });
We should make sure the barcode existed in DB and so that ->find
returns an object. Note that most of the time we just wanted to know if
the barcode existed.
The changes are very simple, the only one that need attention is
the one in batchMod.pl. It is basically reusing what we did on
bug 21141.
Test plan:
Use the batch item modification/deletion tools to modify/delete items
from their barcode (using the textarea or a file)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||josef.mora...@gmail.com --- Comment #4 from Josef Moravec --- After submitting some barcodes in tools -> item batch modification: Can't locate object method "get_column" via package "0" (perhaps you forgot to load "0"?) at /home/vagrant/kohaclone/tools/batchMod.pl line 268. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183
Jonathan Druart changed:
What|Removed |Added
Attachment #77586|0 |1
is obsolete||
--- Comment #3 from Jonathan Druart
---
Created attachment 77687
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77687=edit
Bug 21183: Replace C4::Items::GetItemnumberFromBarcode calls
C4::Items::GetItemnumberFromBarcode calls can be replaced with
Koha::Items->find({ barcode => $barcode });
We should make sure the barcode existed in DB and so that ->find
returns an object. Note that most of the time we just wanted to know if
the barcode existed.
The changes are very simple, the only one that need attention is
the one in batchMod.pl. It is basically reusing what we did on
bug 21141.
Test plan:
Use the batch item modification/deletion tools to modify/delete items
from their barcode (using the textarea or a file)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Jonathan Druart changed: What|Removed |Added Blocks||21184 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183
--- Comment #1 from Jonathan Druart
---
Created attachment 77586
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77586=edit
Bug 21183: Replace C4::Items::GetItemnumberFromBarcode calls
C4::Items::GetItemnumberFromBarcode calls can be replaced with
Koha::Items->find({ barcode => $barcode });
We should make sure the barcode existed in DB and so that ->find
returns an object. Note that most of the time we just wanted to know if
the barcode existed.
The changes are very simple, the only one that need attention is
the one in batchMod.pl. It is basically reusing what we did on
bug 21141.
Test plan:
Use the batch item modification/deletion tools to modify/delete items
from their barcode (using the textarea or a file)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 --- Comment #2 from Jonathan Druart --- Created attachment 77587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77587=edit Bug 21183: Remove GetItemnumberFromBarcode Test plan: git grep GetItemnumberFromBarcode should not return anything -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Jonathan Druart changed: What|Removed |Added Depends on||21182 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21182 [Bug 21182] acqui/check_duplicate_barcode_ajax.pl is not longer in use -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21183] C4::Items - Remove GetItemnumberFromBarcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21183 Jonathan Druart changed: What|Removed |Added Blocks||18252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 [Bug 18252] Move C4::Items code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
