[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Matthias Le Gac changed: What|Removed |Added CC||matthias.le-...@inlibro.com --- Comment #21 from Matthias Le Gac --- Rebase to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Matthias Le Gac changed: What|Removed |Added Attachment #158679|0 |1 is obsolete|| Attachment #158680|0 |1 is obsolete|| Attachment #158681|0 |1 is obsolete|| --- Comment #20 from Matthias Le Gac --- Created attachment 162064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162064=edit Bug 21214: cleanup_database.pl rebase to master Librarians sometime worry if a certain email was sent or not to a patron (PREDUES, ODUES, etc.), and iirc, there are no way to have that information once the cleanup_database.pl has run, unless we dig back an archive of their database. This patch would let an admin choose which letters to keep in the message_queue, based on its letter_code, by passing a comma-separated list to the script. TEST PLAN: 1) Either you have already have data, or you'll want to add some new test lines in your message_queue table . INSERT INTO message_queue(borrowernumber,letter_code,message_transport_type,status,time_queued) VALUES(1,,'email','sent','2018-01-01 00:00:42'); 2) Make a backup of this table 3) Run the script patchless with the --mail 1 option 3.1) Messages older than 1 day should have been deleted 4) Put the data back in 5) Apply patch 6) Choose a letter_code you'd like to keep, and run the script with --mail 1 --keep-lc [,] 7) Messages older than 1 day that don't have the code [or ] should've been deleted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Matthias Le Gac changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #19 from Lucas Gass --- Works as described. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Lucas Gass changed: What|Removed |Added Attachment #148625|0 |1 is obsolete|| --- Comment #18 from Lucas Gass --- Created attachment 158681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158681=edit Bug 21214: (fix) Rebuild the sql query Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Lucas Gass changed: What|Removed |Added Attachment #148623|0 |1 is obsolete|| --- Comment #17 from Lucas Gass --- Created attachment 158680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158680=edit Bug_21214: Change of SQL request in condition $mail with letter_code and code modification Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Lucas Gass changed: What|Removed |Added Attachment #148622|0 |1 is obsolete|| --- Comment #16 from Lucas Gass --- Created attachment 158679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158679=edit Bug 21214: cleanup_database.pl --keep-lc to dodge deletion in message_queue based on letter_code Librarians sometime worry if a certain email was sent or not to a patron (PREDUES, ODUES, etc.), and iirc, there are no way to have that information once the cleanup_database.pl has run, unless we dig back an archive of their database. This patch would let an admin choose which letters to keep in the message_queue, based on its letter_code, by passing a comma-separated list to the script. TEST PLAN: 1) Either you have already have data, or you'll want to add some new test lines in your message_queue table . INSERT INTO message_queue(borrowernumber,letter_code,message_transport_type,status,time_queued) VALUES(1,,'email','sent','2018-01-01 00:00:42'); 2) Make a backup of this table 3) Run the script patchless with the --mail 1 option 3.1) Messages older than 1 day should have been deleted 4) Put the data back in 5) Apply patch 6) Choose a letter_code you'd like to keep, and run the script with --mail 1 --keep-lc [,] 7) Messages older than 1 day that don't have the code [or ] should've been deleted Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 --- Comment #15 from Hammat wele --- Created attachment 148625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148625=edit Bug 21214: (fix) Rebuild the sql query -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Hammat wele changed: What|Removed |Added Attachment #148624|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 --- Comment #14 from Hammat wele --- Created attachment 148624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148624=edit Bug 21214: (fix) Change letter_code with letter_id in the sql query and code modification -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Hammat wele changed: What|Removed |Added CC||hammat.w...@inlibro.com --- Comment #13 from Hammat wele --- Rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Hammat wele changed: What|Removed |Added Attachment #113009|0 |1 is obsolete|| --- Comment #12 from Hammat wele --- Created attachment 148623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148623=edit Bug_21214: Change of SQL request in condition $mail with letter_code and code modification -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Hammat wele changed: What|Removed |Added Attachment #113008|0 |1 is obsolete|| --- Comment #11 from Hammat wele --- Created attachment 148622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148622=edit Bug 21214: cleanup_database.pl --keep-lc to dodge deletion in message_queue based on letter_code Librarians sometime worry if a certain email was sent or not to a patron (PREDUES, ODUES, etc.), and iirc, there are no way to have that information once the cleanup_database.pl has run, unless we dig back an archive of their database. This patch would let an admin choose which letters to keep in the message_queue, based on its letter_code, by passing a comma-separated list to the script. TEST PLAN: 1) Either you have already have data, or you'll want to add some new test lines in your message_queue table . INSERT INTO message_queue(borrowernumber,letter_code,message_transport_type,status,time_queued) VALUES(1,,'email','sent','2018-01-01 00:00:42'); 2) Make a backup of this table 3) Run the script patchless with the --mail 1 option 3.1) Messages older than 1 day should have been deleted 4) Put the data back in 5) Apply patch 6) Choose a letter_code you'd like to keep, and run the script with --mail 1 --keep-lc [,] 7) Messages older than 1 day that don't have the code [or ] should've been deleted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Ivan Dziuba changed: What|Removed |Added Attachment #77762|0 |1 is obsolete|| --- Comment #9 from Ivan Dziuba --- Created attachment 113008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113008=edit Bug 21214: cleanup_database.pl --keep-lc to dodge deletion in message_queue based on letter_code Librarians sometime worry if a certain email was sent or not to a patron (PREDUES, ODUES, etc.), and iirc, there are no way to have that information once the cleanup_database.pl has run, unless we dig back an archive of their database. This patch would let an admin choose which letters to keep in the message_queue, based on its letter_code, by passing a comma-separated list to the script. TEST PLAN: 1) Either you have already have data, or you'll want to add some new test lines in your message_queue table . INSERT INTO message_queue(borrowernumber,letter_code,message_transport_type,status,time_queued) VALUES(1,,'email','sent','2018-01-01 00:00:42'); 2) Make a backup of this table 3) Run the script patchless with the --mail 1 option 3.1) Messages older than 1 day should have been deleted 4) Put the data back in 5) Apply patch 6) Choose a letter_code you'd like to keep, and run the script with --mail 1 --keep-lc [,] 7) Messages older than 1 day that don't have the code [or ] should've been deleted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 --- Comment #10 from Ivan Dziuba --- Created attachment 113009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113009=edit Bug_21214: Change of SQL request in condition $mail with letter_code and code modification -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Blou changed: What|Removed |Added Attachment #77762|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Blou changed: What|Removed |Added Attachment #112993|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Blou changed: What|Removed |Added Attachment #112994|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Blou changed: What|Removed |Added Attachment #113002|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 --- Comment #8 from Ivan Dziuba --- Created attachment 113002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113002=edit Bug_21214: Changes after merge -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Ivan Dziuba changed: What|Removed |Added Attachment #112992|0 |1 is obsolete|| --- Comment #7 from Ivan Dziuba --- Created attachment 112994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112994=edit Bug 21214: I changed cleanup_database.pl and some corrections with --keep-lc to dodge deletion in message_queue based on letter_code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Ivan Dziuba changed: What|Removed |Added Attachment #77762|0 |1 is obsolete|| --- Comment #6 from Ivan Dziuba --- Created attachment 112993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112993=edit Bug 21214: cleanup_database.pl --keep-lc to dodge deletion in message_queue based on letter_code Librarians sometime worry if a certain email was sent or not to a patron (PREDUES, ODUES, etc.), and iirc, there are no way to have that information once the cleanup_database.pl has run, unless we dig back an archive of their database. This patch would let an admin choose which letters to keep in the message_queue, based on its letter_code, by passing a comma-separated list to the script. TEST PLAN: 1) Either you have already have data, or you'll want to add some new test lines in your message_queue table . INSERT INTO message_queue(borrowernumber,letter_code,message_transport_type,status,time_queued) VALUES(1,,'email','sent','2018-01-01 00:00:42'); 2) Make a backup of this table 3) Run the script patchless with the --mail 1 option 3.1) Messages older than 1 day should have been deleted 4) Put the data back in 5) Apply patch 6) Choose a letter_code you'd like to keep, and run the script with --mail 1 --keep-lc [,] 7) Messages older than 1 day that don't have the code [or ] should've been deleted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 --- Comment #5 from Ivan Dziuba --- Created attachment 112992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112992=edit Bug 21214: I changed cleanup_database.pl and some corrections with --keep-lc to dodge deletion in message_queue based on letter_code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Ivan Dziuba changed: What|Removed |Added CC||ivan.dzi...@inlibro.com Status|Failed QA |Needs Signoff Assignee|charles.far...@inlibro.com |ivan.dzi...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
CC||bgkrie...@gmail.com
Status|Needs Signoff |Failed QA
--- Comment #4 from Bernardo Gonzalez Kriegel ---
Hi, there is a problem in the code
-> 243 my $quoted_codes = '';
244 if ($letter_codes) {
245 my @codes = map { "'$_'" } split(',', $letter_codes);
-> 246 my $quoted_codes = join(',', @codes);
247 }
Two "my $quoted_codes", in lines 243 and 246.
$quoted_codes passed to execute will always be empty.
Remove the second 'my'
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Charles Farmer changed: What|Removed |Added Attachment #77756|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |charles.far...@inlibro.com |ity.org | CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Charles, please don't forget to assign the bug to yourself when providing a patch! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 --- Comment #2 from Charles Farmer --- Created attachment 77762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77762=edit Bug 21214: cleanup_database.pl --keep-lc to dodge deletion in message_queue based on letter_code Librarians sometime worry if a certain email was sent or not to a patron (PREDUES, ODUES, etc.), and iirc, there are no way to have that information once the cleanup_database.pl has run, unless we dig back an archive of their database. This patch would let an admin choose which letters to keep in the message_queue, based on its letter_code, by passing a comma-separated list to the script. TEST PLAN: 1) Either you have already have data, or you'll want to add some new test lines in your message_queue table . INSERT INTO message_queue(borrowernumber,letter_code,message_transport_type,status,time_queued) VALUES(1,,'email','sent','2018-01-01 00:00:42'); 2) Make a backup of this table 3) Run the script patchless with the --mail 1 option 3.1) Messages older than 1 day should have been deleted 4) Put the data back in 5) Apply patch 6) Choose a letter_code you'd like to keep, and run the script with --mail 1 --keep-lc [,] 7) Messages older than 1 day that don't have the code [or ] should've been deleted -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Charles Farmer changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 --- Comment #1 from Charles Farmer --- Created attachment 77756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77756=edit BZ 21214: cleanup_database.pl --keep-lc to dodge deletion in message_queue based on letter_code Librarians sometime worry if a certain email was sent or not to a patron (PREDUES, ODUES, etc.), and iirc, there are no way to have that information once the cleanup_database.pl has run, unless we dig back an archive of their database. This patch would let an admin choose which letters to keep in the message_queue, based on its letter_code, by passing a comma-separated list to the script. TEST PLAN: 1) Either you have already have data, or you'll want to add some new test lines in your message_queue table . INSERT INTO message_queue(borrowernumber,letter_code,message_transport_type,status,time_queued) VALUES(1,,'email','sent','2018-01-01 00:00:42'); 2) Make a backup of this table 3) Run the script patchless with the --mail 1 option 3.1) Messages older than 1 day should have been deleted 4) Put the data back in 5) Apply patch 6) Choose a letter_code you'd like to keep, and run the script with --mail 1 --keep-lc [,] 7) Messages older than 1 day that don't have the code [or ] should've been deleted -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Charles Farmer changed: What|Removed |Added CC||charles.far...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
