[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Master|RESOLVED Resolution|--- |FIXED --- Comment #13 from Martin Renvoize --- Fixes to issues caused by bug 19474 not in 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Bug 21239 depends on bug 21237, which changed state. Bug 21237 Summary: Clean up staff client SCSS https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21237 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #12 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Bug 21239 depends on bug 21234, which changed state. Bug 21234 Summary: Remove our .clearfix class in favor of Bootstrap's https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21234 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Chris Cormack changed: What|Removed |Added Attachment #78061|0 |1 is obsolete|| --- Comment #11 from Chris Cormack --- Created attachment 78102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78102=edit Bug 21239: CSS regressions caused by SCSS move This patch corrects some mistakes in staff-global.scss made during the conversion from CSS. To test, apply the patch and regenerate your CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. View various forms in the staff client which have hints and required fields, including: - Notices & slips -> Modify notice - Administration -> Budgets -> Modify budget Verify that date format hints are positioned correctly. Try to submit the form with empty required fields and verify that the "This field is required" message is positioned correctly. Signed-off-by: Jonathan Druart Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Jonathan Druart changed: What|Removed |Added Attachment #77985|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 78061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78061=edit Bug 21239: CSS regressions caused by SCSS move This patch corrects some mistakes in staff-global.scss made during the conversion from CSS. To test, apply the patch and regenerate your CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. View various forms in the staff client which have hints and required fields, including: - Notices & slips -> Modify notice - Administration -> Budgets -> Modify budget Verify that date format hints are positioned correctly. Try to submit the form with empty required fields and verify that the "This field is required" message is positioned correctly. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #9 from Katrin Fischer --- Applied bug 21234 and bug 21237, but this one conflicts on top: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21239: CSS regressions caused by SCSS move fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 --- Comment #8 from Jonathan Druart --- Comment on attachment 77985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77985 Bug 21239: CSS regressions caused by SCSS move Review of attachment 77985: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=21239=77985) - ::: koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss @@ +1124,4 @@ > font-weight: bold; > margin-right: 1em; > text-align: right; > +width: 9em; I found this rule when viewing a suggestion: /suggestion/suggestion.pl?suggestionid=1=show -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Jonathan Druart changed: What|Removed |Added Attachment #77978|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 77985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77985=edit Bug 21239: CSS regressions caused by SCSS move This patch corrects some mistakes in staff-global.scss made during the conversion from CSS. To test, apply the patch and regenerate your CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. View various forms in the staff client which have hints and required fields, including: - Notices & slips -> Modify notice - Administration -> Budgets -> Modify budget Verify that date format hints are positioned correctly. Try to submit the form with empty required fields and verify that the "This field is required" message is positioned correctly. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 --- Comment #6 from Owen Leonard --- Created attachment 77978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77978=edit Bug 21239: CSS regressions caused by SCSS move This patch corrects some mistakes in staff-global.scss made during the conversion from CSS. To test, apply the patch and regenerate your CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. View various forms in the staff client which have hints and required fields, including: - Notices & slips -> Modify notice - Administration -> Budgets -> Modify budget Verify that date format hints are positioned correctly. Try to submit the form with empty required fields and verify that the "This field is required" message is positioned correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Depends on||21237 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21237 [Bug 21237] Clean up staff client SCSS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Jonathan Druart changed: What|Removed |Added Depends on||21234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21234 [Bug 21234] Remove our .clearfix class in favor of Bootstrap's -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Owen Leonard changed: What|Removed |Added Version|unspecified |master --- Comment #5 from Owen Leonard --- (In reply to Jonathan Druart from comment #2) > Before: https://snag.gy/gMR5US.jpg > After : https://snag.gy/hMmZbu.jpg Fixed by Bug 21234 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 --- Comment #4 from Jonathan Druart --- Mandatory fields Before : https://snag.gy/VhyPXM.jpg After : https://snag.gy/WZdGCM.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 --- Comment #3 from Jonathan Druart --- (In reply to Jonathan Druart from comment #1) > .hint Also https://snag.gy/KlPSYp.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 --- Comment #2 from Jonathan Druart --- Buttons for Datatables Before: https://snag.gy/gMR5US.jpg After : https://snag.gy/hMmZbu.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Jonathan Druart changed: What|Removed |Added Depends on||19474 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 [Bug 19474] Convert staff client CSS to SCSS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 --- Comment #1 from Jonathan Druart --- .hint https://snag.gy/yJYbav.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
