[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 Alex Buckley changed: What|Removed |Added Blocks||21776 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21776 [Bug 21776] Set ACQ_NOTIF_ON_RECEIV notice message_transport_type to sms if syspref is enabled and patron has an smsalertnumber but no email -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #8 from Alex Buckley --- Hi Martin and Katrin, I have finished and attached a follow-up patch which introduces a new syspref to control if notices (in this case suggestion notices) are sent by sms if the borrower does not have an email set. ex i.e. it replaces the automatic fallback from my first patch. Can you please have a test and let me know if this is what you had in mind or if you would like further changes? I can also go through and make bug reports for all the other instances where the message_transport_type of 'email' is hardcoded, so they can also use this syspref fallback as well if you'd like me to. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 --- Comment #7 from Alex Buckley --- Created attachment 81975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81975=edit Bug 21241: (follow-up) Syspref to control fallback to SMS when no email is defined This patch adds a new system preference (MessageTransportTypeFallbackToSMSIfNoPatronEmail) which if enabled Koha will send suggestion notices by SMS if a borrower has a defined SMSalertnumber and no email. The use of the syspref prevents automatic fallback to sending suggestion notices as SMS when there's no defined email. Test plan: 1. Chose a patron who has no email address set, but does have a smsalertnumber set (this value is set in the Patron messaging preferences section after the SMSSendDriver syspref is set) 2. Log into the OPAC with that user and submit a suggestion 3. In the staff client go to Acquisitions->Suggestions and tick the suggestion and set its status to 'Accepted' 4. In the database query the message_queue and notice the message_transport_type of the message is set to 'email' even though the patron has no email address set. 5. Apply patches, restart memcached and plack 6. Check the 'MessageTransportTypeFallbackToSMSIfNoPatronEmail' syspref is disabled 7. Repeat steps 2,3 and observe in the message_queue table the message_transport_type = 'email' i.e. If the syspref is disabled then the message is still sent by email to borrowers with defined smsalertnumber and no email address 8. Enable the 'MessageTransportTypeFallbackToSMSIfNoPatronEmail' syspref and repeat steps 2,3 and notice the message_transport_type = 'sms' i.e. If the syspref is enabled then the message is sent by sms to borrowers with defined smsalertnumber and no email address 9. Repeat steps 2,3 with a patron with an email address and no smsalertnumber trying with the 'MessageTransportTypeFallbackToSMSIfNoPatronEmail' syspref enabled and disabled and notice in both cases the message_transport_type = email. i.e. If a borrower has an email address defined the suggestion notice will always be sent via email 10. Repeat steps 2,3 with a patron with no email or smsalertnumber trying with the 'MessageTransportTypeFallbackToSMSIfNoPatronEmail' syspref enabled and disabled and notice in both cases the message_transport_type = email i.e. If the borrower has no smsalertnumber and no email defined then the suggestion notice will be sent by 'email' 11. Run t/db_dependent/Suggestions.t Sponsored-By: Brimbank Libraries, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 Alex Buckley changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 --- Comment #6 from Katrin Fischer --- (In reply to Martin Renvoize from comment #5) > SMS can be costly to libraries.. as such I feel this should be bound to a > preference in case the library doesn't want to allow this type of message to > be sent via SMS. > > I'm also a bit concerned that it's a one-off.. I'm sure there are lots of > cases where a fallback sequence could be prescribed and it would be nice to > at least record bugs for each of those if not fixing them all at the same > time. > > Finally.. an alternative could be to shift this notice type into the > advanced messaging preferences perhaps? +1 I also think an automatic fallback here could be problematic. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Failed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #5 from Martin Renvoize --- SMS can be costly to libraries.. as such I feel this should be bound to a preference in case the library doesn't want to allow this type of message to be sent via SMS. I'm also a bit concerned that it's a one-off.. I'm sure there are lots of cases where a fallback sequence could be prescribed and it would be nice to at least record bugs for each of those if not fixing them all at the same time. Finally.. an alternative could be to shift this notice type into the advanced messaging preferences perhaps? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 Alex Buckley changed: What|Removed |Added Text to go in the||If a borrower has no email release notes||address but does have a ||smsalertnumber value set ||then send the suggestion ||notice as an sms. CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 Owen Leonard changed: What|Removed |Added Attachment #79189|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 81625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81625=edit Bug 21241: Conditional to choose appropriate message_transport_type for suggestion notices Introducing a conditional into C4/Suggestions.pm to check if no patron email exists but a smsalertnumber does exist then the suggestion notice message_transport_type is set to 'sms', otherwise the suggestion message_transport_type='email'. This ensures patrons with no email address still receieve their suggestion notices because at present the message_transport_type is hardcoded to 'email'. Test plan: 1. Chose a patron who has no email address set, but does have a smsalertnumber set (this value is set in the Patron messaging preferences section after the SMSSendDriver syspref is set) 2. Log into the OPAC with that user and submit a suggestion 3. In the staff client go to Acquisitions->Suggestions and tick the suggestion and set its status to 'Accepted' 4. In the database query the message_queue and notice the message_transport_type of the message is set to 'email' even though the patron has no email address set. 5. Apply this patch, restart memcached and plack 6. Repeat steps 2,3 with the same patron and query the message_queue table again and notice this time the message_transport_type = 'sms' 7. Repeat steps 2,3 with a patron with no smsalertnumber or email address. Query the database and observe the message_transport_type=email. If no smsalertnumber is set then the message_transport_type is set to 'email' by default Sponsored-By: Brimbank Library, Australia Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 Alex Buckley changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 --- Comment #3 from Alex Buckley --- This is in use by Brimbank library so that acquisitions notices are not attempted to be sent via email to patrons with no defined email address. This would be a useful one to be tested and upstreamed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 --- Comment #2 from Alex Buckley --- Created attachment 79189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79189=edit Bug 21241 - Conditional to choose appropriate message_transport_type for suggestion notices Introducing a conditional into C4/Suggestions.pm to check if no patron email exists but a smsalertnumber does exist then the suggestion notice message_transport_type is set to 'sms', otherwise the suggestion message_transport_type='email'. This ensures patrons with no email address still receieve their suggestion notices because at present the message_transport_type is hardcoded to 'email'. Test plan: 1. Chose a patron who has no email address set, but does have a smsalertnumber set (this value is set in the Patron messaging preferences section after the SMSSendDriver syspref is set) 2. Log into the OPAC with that user and submit a suggestion 3. In the staff client go to Acquisitions->Suggestions and tick the suggestion and set its status to 'Accepted' 4. In the database query the message_queue and notice the message_transport_type of the message is set to 'email' even though the patron has no email address set. 5. Apply this patch, restart memcached and plack 6. Repeat steps 2,3 with the same patron and query the message_queue table again and notice this time the message_transport_type = 'sms' 7. Repeat steps 2,3 with a patron with no smsalertnumber or email address. Query the database and observe the message_transport_type=email. If no smsalertnumber is set then the message_transport_type is set to 'email' by default Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 Alex Buckley changed: What|Removed |Added Attachment #77960|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 Alex Buckley changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 Alex Buckley changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21174 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 --- Comment #1 from Alex Buckley --- Created attachment 77960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77960=edit Bug 21241 - Conditional to choose appropriate message_transport_type for suggestion notices Introducing a conditional into C4/Suggestions.pm to check if no patron email exists but a smsalertnumber does exist then the suggestion notice message_transport_type is set to 'sms', otherwise the suggestion message_transport_type='email'. This ensures patrons with no email address still receieve their suggestion notices because at present the message_transport_type is hardcoded to 'email'. Test plan: 1. Chose a patron who has no email address set, but does have a smsalertnumber set (this value is set in the Patron messaging preferences section after the SMSSendDriver syspref is set) 2. Log into the OPAC with that user and submit a suggestion 3. In the staff client go to Acquisitions->Suggestions and tick the suggestion and set its status to 'Accepted' 4. In the database query the message_queue and notice the message_transport_type of the message is set to 'email' even though the patron has no email address set. 5. Apply this patch, restart memcached and plack 6. Repeat steps 2,3 with the same patron and query the message_queue table again and notice this time the message_transport_type = 'sms' 7. Repeat steps 2,3 with a patron with no smsalertnumber or email address. Query the database and observe the message_transport_type=email. If no smsalertnumber is set then the message_transport_type is set to 'email' by default -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
