[Koha-bugs] [Bug 21243] Regression: SRU mapping popup for bibliographic records is unstyled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21243] Regression: SRU mapping popup for bibliographic records is unstyled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #12 from Fridolin SOMERS --- Depends on Bug 21151 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21243] Regression: SRU mapping popup for bibliographic records is unstyled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 Bug 21243 depends on bug 21151, which changed state. Bug 21151 Summary: SRU search fields mapping pop-up comes up empty https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21151 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21243] Regression: SRU mapping popup for bibliographic records is unstyled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com --- Comment #11 from Martin Renvoize --- Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21243] Regression: SRU mapping popup for bibliographic records is unstyled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21243] Regression: SRU mapping popup for bibliographic records is unstyled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 --- Comment #9 from Katrin Fischer --- Ok, probably also fixed by adding SRU for authorities then. I had checked the validator at the time, but the other patches altered page structure. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21243] Regression: SRU mapping popup for bibliographic records is unstyled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 --- Comment #8 from Nick Clemens --- Created attachment 78044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78044=edit Bug 21243: (follow-up) Remove extra '' tag To test: 1 - Go to Admin->Z39/SRU servers 2 - Pick a server or add one 3 - Click 'Modify' button for mappings 4 - Copy the HTML of the popup into w3c validator https://validator.w3.org/#validate_by_input 5 - Note extra closing div 6 - Apply patch 7 - Repeat 8 - Success -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21243] Regression: SRU mapping popup for bibliographic records is unstyled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 --- Comment #7 from Nick Clemens --- (In reply to Nick Clemens from comment #6) > (In reply to Katrin Fischer from comment #5) > > Is reverting bug 21151 and repushing it correctly also an option? It adds a > > missing div as well. > > The div does seem to have been added, it was a typo during rebase that I > deleted the line, I think we can just add it here > > bug 13618 would make revert more difficult I think Looking again, I think that extra closing div is incorrect. We have a closing div in intranet-bottom.inc - with 21151 we have an extra closing tag (run the generated html through the wc3 validator) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21243] Regression: SRU mapping popup for bibliographic records is unstyled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #6 from Nick Clemens --- (In reply to Katrin Fischer from comment #5) > Is reverting bug 21151 and repushing it correctly also an option? It adds a > missing div as well. The div does seem to have been added, it was a typo during rebase that I deleted the line, I think we can just add it here bug 13618 would make revert more difficult I think -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21243] Regression: SRU mapping popup for bibliographic records is unstyled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 --- Comment #5 from Katrin Fischer --- Is reverting bug 21151 and repushing it correctly also an option? It adds a missing div as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21243] Regression: SRU mapping popup for bibliographic records is unstyled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21243] Regression: SRU mapping popup for bibliographic records is unstyled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 Kyle M Hall changed: What|Removed |Added Attachment #78026|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 78041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78041=edit Bug 21243: Regression: SRU mapping popup for bibliographic records is unstyled This patch corrects a regression caused by Bug 21151: The include file which adds CSS to the page was removed from the template. To test, apply the patch and go to Administration -> Z39.50/SRU servers -> New SRU server. - Click the "Modify" button next to "SRU Search fields mapping" - Verify that the pop-up window is correctly styled. Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21243] Regression: SRU mapping popup for bibliographic records is unstyled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 Claire Gravely changed: What|Removed |Added Attachment #77982|0 |1 is obsolete|| --- Comment #3 from Claire Gravely --- Created attachment 78026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78026=edit Bug 21243: Regression: SRU mapping popup for bibliographic records is unstyled This patch corrects a regression caused by Bug 21151: The include file which adds CSS to the page was removed from the template. To test, apply the patch and go to Administration -> Z39.50/SRU servers -> New SRU server. - Click the "Modify" button next to "SRU Search fields mapping" - Verify that the pop-up window is correctly styled. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21243] Regression: SRU mapping popup for bibliographic records is unstyled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 Claire Gravely changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21243] Regression: SRU mapping popup for bibliographic records is unstyled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- Hm, my patch on bug 21552 didn't remove it, only added a parameter - wonder what happened there? +[% INCLUDE 'doc-head-close.inc' popup => 1 %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21243] Regression: SRU mapping popup for bibliographic records is unstyled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 Owen Leonard changed: What|Removed |Added Blocks||20743 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20743 [Bug 20743] Update two-column templates with Bootstrap grid: Administration part 7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21243] Regression: SRU mapping popup for bibliographic records is unstyled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 --- Comment #1 from Owen Leonard --- Created attachment 77982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77982=edit Bug 21243: Regression: SRU mapping popup for bibliographic records is unstyled This patch corrects a regression caused by Bug 21151: The include file which adds CSS to the page was removed from the template. To test, apply the patch and go to Administration -> Z39.50/SRU servers -> New SRU server. - Click the "Modify" button next to "SRU Search fields mapping" - Verify that the pop-up window is correctly styled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21243] Regression: SRU mapping popup for bibliographic records is unstyled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21243 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
