[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Jonathan Druart changed: What|Removed |Added Attachment #96036|0 |1 is obsolete|| --- Comment #18 from Jonathan Druart --- Created attachment 96037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96037=edit Bug 21270: Display "Make an Interlibrary loan request" even if "suggestions" is turned off Test plan: - Turn off "suggestions" - Turn on "ILLModule" => When logged in you should see the "Make an Interlibrary loan request" - Turn on "suggestions" - Turn off "ILLModule" => When logged in you should see the "Make a purchase suggestion" - Turn on "suggestions" - Turn on "ILLModule" => When logged in you should see both links. - Turn off "suggestions" - Turn off "ILLModule" => You should not see the "Not finding what you're looking for?" block - Turn on "suggestions" - Turn on AnonSuggestions => You should see the "Make a purchase suggestion" even when logged out -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Andrew Isherwood changed: What|Removed |Added Attachment #96034|0 |1 is obsolete|| --- Comment #17 from Andrew Isherwood --- Created attachment 96036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96036=edit Bug 21270: Display "Make an Interlibrary loan request" even if "suggestions" is turned off Test plan: - Turn off "suggestions" - Enable ILLModule When logged in you should see the "Make an Interlibrary loan request" on the opac search result if not result is displayed Signed-off-by: Andrew Isherwood -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Andrew Isherwood changed: What|Removed |Added Attachment #95807|0 |1 is obsolete|| --- Comment #16 from Andrew Isherwood --- Created attachment 96035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96035=edit Bug 21270: "Not finding what you're looking for" displaying uselessly When doing OPAC search, at the bottom you have an offer presented with "Not finding what you're looking for" to introduce Suggestions or ILL if enabled. Bug 7317 modified the if-else and now if you enable ILLModule but not AnonSuggestions and are not logged, you have this little string sitting there, offering nothing to the user. Just taunting them... TEST: 0) Set IllModule to true, AnonSuggestions to false. 1) Without login, just to an OPAC search. At the bottom will be a nice string laughing at your failed search 2) Apply the patch. 3) Problem at 1) is fixed. 4) Login to validate that ILL link now appear. 5) Modify combination of IllModule and AnonSuggestions to validate links appearing. Patch applies and functions as described. Signed-off-by: Dilan Johnpullé Signed-off-by: Andrew Isherwood -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |ASSIGNED Assignee|philippe.blo...@inlibro.com |jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 --- Comment #15 from Jonathan Druart --- Created attachment 96034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96034=edit Bug 21270: Display "Make an Interlibrary loan request" even if "suggestions" is turned off Test plan: - Turn off "suggestions" - Enable ILLModule When logged in you should see the "Make an Interlibrary loan request" on the opac search result if not result is displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 --- Comment #14 from Nick Clemens --- (In reply to Jonathan Druart from comment #12) > (In reply to Jonathan Druart from comment #10) > > Sorry, trying to make this moving forward but it's confusing me. > > > > I am also expecting to see "Make an Interlibrary loan request" even if > > "suggestions" is turned off. > > If we all agree on that, I am going to provide a patch. I agree and Katrin seems to agree above, I think this works -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 --- Comment #13 from Andrew Isherwood --- Sounds reasonable to me -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 --- Comment #12 from Jonathan Druart --- (In reply to Jonathan Druart from comment #10) > Sorry, trying to make this moving forward but it's confusing me. > > I am also expecting to see "Make an Interlibrary loan request" even if > "suggestions" is turned off. If we all agree on that, I am going to provide a patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Jonathan Druart changed: What|Removed |Added CC||andrew.isherwood@ptfs-europ ||e.com --- Comment #11 from Jonathan Druart --- Andrew, can you give your opinion on this one please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #10 from Jonathan Druart --- Sorry, trying to make this moving forward but it's confusing me. I am also expecting to see "Make an Interlibrary loan request" even if "suggestions" is turned off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Blou changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Blou changed: What|Removed |Added Attachment #78239|0 |1 is obsolete|| --- Comment #9 from Blou --- Created attachment 95807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95807=edit Bug 21270: "Not finding what you're looking for" displaying uselessly When doing OPAC search, at the bottom you have an offer presented with "Not finding what you're looking for" to introduce Suggestions or ILL if enabled. Bug 7317 modified the if-else and now if you enable ILLModule but not AnonSuggestions and are not logged, you have this little string sitting there, offering nothing to the user. Just taunting them... TEST: 0) Set IllModule to true, AnonSuggestions to false. 1) Without login, just to an OPAC search. At the bottom will be a nice string laughing at your failed search 2) Apply the patch. 3) Problem at 1) is fixed. 4) Login to validate that ILL link now appear. 5) Modify combination of IllModule and AnonSuggestions to validate links appearing. Patch applies and functions as described. Signed-off-by: Dilan Johnpullé -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #8 from Marcel de Rooy --- loggedinusername == 1 ? Are you sure that this is correct? I am not ;) $user = $patron->firstname . ' ' . $patron->surname; $template->param( loggedinusername => $user ); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|In Discussion |Signed Off --- Comment #7 from Nick Clemens --- (In reply to Katrin Fischer from comment #3) > I don't feel like the suggested fix is correct. If you don't allow > suggestions, but ILL is turned on, now nothing displays. I think as the > hints are arranged as list items, there is no reason not to show ILL in this > constellation: > > - not logged in > - ill module enabled > - suggestions and anon suggestions not active But we actually don't show ILL in that situation, the logic to show ILL is: [% IF Koha.Preference( 'ILLModule' ) == 1 && loggedinusername %] So if not logged it it never shows, so the check for logged in username means the removal of the ILL check in the larger loop has no effect. I think this one can move forward -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 --- Comment #6 from Katrin Fischer --- I'v asked some others on their opinions as well - will get back to this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |In Discussion --- Comment #5 from Marcel de Rooy --- Moving to In Discussion. Katrin, could you reply on this one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Blou changed: What|Removed |Added CC||eric.be...@inlibro.com Status|Failed QA |Signed Off --- Comment #4 from Blou --- (In reply to Katrin Fischer from comment #3) > I don't feel like the suggested fix is correct. If you don't allow > suggestions, but ILL is turned on, now nothing displays. I think as the > hints are arranged as list items, there is no reason not to show ILL in this > constellation: > > - not logged in > - ill module enabled > - suggestions and anon suggestions not active That is a different behavior. I was just fixing the original intent, which clearly put ILL **UNDER** suggestion. Without suggestion, no ILL. I'm not changing ILL's behavior, that is a different ticket. A whole one :) They initially coded it so that it would not appear unless 'suggestion' was ON. My fix doesn't alter that. NOTE: that would be very easy to do, but then open a larger discussion beforehand, not on "display" but on ILL... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- I don't feel like the suggested fix is correct. If you don't allow suggestions, but ILL is turned on, now nothing displays. I think as the hints are arranged as list items, there is no reason not to show ILL in this constellation: - not logged in - ill module enabled - suggestions and anon suggestions not active -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Dilan Johnpullé changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Dilan Johnpullé changed: What|Removed |Added Attachment #78141|0 |1 is obsolete|| --- Comment #2 from Dilan Johnpullé --- Created attachment 78239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78239=edit Bug 21270: "Not finding what you're looking for" displaying uselessly When doing OPAC search, at the bottom you have an offer presented with "Not finding what you're looking for" to introduce Suggestions or ILL if enabled. Bug 7317 modified the if-else and now if you enable ILLModule but not AnonSuggestions and are not logged, you have this little string sitting there, offering nothing to the user. Just taunting them... TEST: 0) Set IllModule to true, AnonSuggestions to false. 1) Without login, just to an OPAC search. At the bottom will be a nice string laughing at your failed search 2) Apply the patch. 3) Problem at 1) is fixed. 4) Login to validate that ILL link now appear. 5) Modify combination of IllModule and AnonSuggestions to validate links appearing. Patch applies and functions as described. Signed-off-by: Dilan Johnpullé -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Blou changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 --- Comment #1 from Blou --- Created attachment 78141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78141=edit Bug 21270: "Not finding what you're looking for" displaying uselessly When doing OPAC search, at the bottom you have an offer presented with "Not finding what you're looking for" to introduce Suggestions or ILL if enabled. Bug 7317 modified the if-else and now if you enable ILLModule but not AnonSuggestions and are not logged, you have this little string sitting there, offering nothing to the user. Just taunting them... TEST: 0) Set IllModule to true, AnonSuggestions to false. 1) Without login, just to an OPAC search. At the bottom will be a nice string laughing at your failed search 2) Apply the patch. 3) Problem at 1) is fixed. 4) Login to validate that ILL link now appear. 5) Modify combination of IllModule and AnonSuggestions to validate links appearing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Blou changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |philippe.blo...@inlibro.com |ity.org | CC||charles.far...@inlibro.com, ||philippe.blo...@inlibro.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
