[Koha-bugs] [Bug 21396] Missing use statements in Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 --- Comment #14 from Jonathan Druart --- (In reply to Fridolin SOMERS from comment #11) > (In reply to Fridolin SOMERS from comment #10) > > Ok there is ReturnLostItem, > > > > Pushed to 17.11.x for 17.11.12 > > Ok not OK, it brakes UT > t/db_dependent/Members/GetOverdues.t > t/db_dependent/Members/GetPendingIssues.t > > I dont understand why, I revert. These test files do no longer exist in master, and so have not been modified by bug 21133. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21396] Missing use statements in Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 Jonathan Druart changed: What|Removed |Added Attachment #79486|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart --- Created attachment 81981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81981=edit [17.11.x] Bug 21396: Add 2 missing use statements in Koha::Account 1. require C4::Letters must be use C4::Letters (from bug 19191) 2. There is call to C4::Circulation::ReturnLostItem, but no use of C4::Circulation (from bug 20631) Test plan: finger crossed, I ran the tests from t/db_dependent/Koha and they all passed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21396] Missing use statements in Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 --- Comment #13 from Jonathan Druart --- Created attachment 81982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81982=edit Bug 21396: Fix tests for 17.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21396] Missing use statements in Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 --- Comment #11 from Fridolin SOMERS --- (In reply to Fridolin SOMERS from comment #10) > Ok there is ReturnLostItem, > > Pushed to 17.11.x for 17.11.12 Ok not OK, it brakes UT t/db_dependent/Members/GetOverdues.t t/db_dependent/Members/GetPendingIssues.t I dont understand why, I revert. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21396] Missing use statements in Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 --- Comment #10 from Fridolin SOMERS --- Ok there is ReturnLostItem, Pushed to 17.11.x for 17.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21396] Missing use statements in Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21396] Missing use statements in Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 --- Comment #9 from Jonathan Druart --- (In reply to Fridolin SOMERS from comment #8) > Bug 19191 nor Bug 20631 in 17.11.x but must it be pushed anyway ? If there is the call to ReturnLostItem, yes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21396] Missing use statements in Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #8 from Fridolin SOMERS --- Bug 19191 nor Bug 20631 in 17.11.x but must it be pushed anyway ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21396] Missing use statements in Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 --- Comment #7 from Jonathan Druart --- (In reply to Jonathan Druart from comment #6) > (In reply to Martin Renvoize from comment #5) > > Pushed to 18.05.x for 18.05.05 > > This one causes the failing test on Jenkins > koha_1 | Undefined subroutine ::Items::ModZebra called at > /kohadevbox/koha/C4/Items.pm line 302. See bug 21133, I have attached a version for 18.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21396] Missing use statements in Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 --- Comment #6 from Jonathan Druart --- (In reply to Martin Renvoize from comment #5) > Pushed to 18.05.x for 18.05.05 This one causes the failing test on Jenkins koha_1 | Undefined subroutine ::Items::ModZebra called at /kohadevbox/koha/C4/Items.pm line 302. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21396] Missing use statements in Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com --- Comment #5 from Martin Renvoize --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21396] Missing use statements in Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21396] Missing use statements in Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21396] Missing use statements in Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 Katrin Fischer changed: What|Removed |Added Attachment #79407|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 79486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79486=edit Bug 21396: Add 2 missing use statements in Koha::Account 1. require C4::Letters must be use C4::Letters (from bug 19191) 2. There is call to C4::Circulation::ReturnLostItem, but no use of C4::Circulation (from bug 20631) Test plan: finger crossed, I ran the tests from t/db_dependent/Koha and they all passed Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21396] Missing use statements in Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 Michal Denar changed: What|Removed |Added Attachment #79255|0 |1 is obsolete|| --- Comment #2 from Michal Denar --- Created attachment 79407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79407=edit Bug 21396: Add 2 missing use statements in Koha::Account 1. require C4::Letters must be use C4::Letters (from bug 19191) 2. There is call to C4::Circulation::ReturnLostItem, but no use of C4::Circulation (from bug 20631) Test plan: finger crossed, I ran the tests from t/db_dependent/Koha and they all passed Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21396] Missing use statements in Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21396] Missing use statements in Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21396] Missing use statements in Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 --- Comment #1 from Jonathan Druart --- Created attachment 79255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79255=edit Bug 21396: Add 2 missing use statements in Koha::Account 1. require C4::Letters must be use C4::Letters (from bug 19191) 2. There is call to C4::Circulation::ReturnLostItem, but no use of C4::Circulation (from bug 20631) Test plan: finger crossed, I ran the tests from t/db_dependent/Koha and they all passed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21396] Missing use statements in Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 Jonathan Druart changed: What|Removed |Added Depends on||20631 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 [Bug 20631] C4::Acounts claims to use ReturnLostItem but doesn't -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21396] Missing use statements in Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 Jonathan Druart changed: What|Removed |Added Depends on||19191 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 [Bug 19191] Add ability to email receipts for account payments and write-offs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
