[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-12-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Fridolin SOMERS  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Stable|RESOLVED

--- Comment #28 from Fridolin SOMERS  ---
Depends on Bug 17602 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-12-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Mirko Tietgen  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #27 from Mirko Tietgen  ---
Also needed in 17.11, adding Fridolin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #26 from Lucas Gass  ---
backported to 18.05 for 18.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #25 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

--- Comment #23 from Tomás Cohen Arazi  ---
Created attachment 82399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82399=edit
Bug 21567: Move Koha_ExternalContent_OverDrive.t to db_dependent

This tests pass on the build step only because they are skipped, due to
the absense of Test::DBIx::Class library.

It makes sense for them to be in the db_dependent directory, as they are
not completely mocked (re: external world interactions).

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

--- Comment #24 from Tomás Cohen Arazi  ---
Created attachment 82400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82400=edit
Bug 21567: Remove Koha_ExternalContent_RecordedBooks.t

This patch removes this file. The included tests are similar to those in
the db_dependent section, with the difference that this have some things
mocked. But the tests still require name resolution and connecting to
the RB servers. This situation breaks package building without any
noticeable gain.

The feature could be better tested by mocking WebService::ILS calls (so
no external world contact), but it belongs to a separate bug report.

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Marcel de Rooy 
Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #82398|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #82393|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #22 from Mirko Tietgen  ---
I signed off on Bug 21567: Remove Koha_ExternalContent_RecordedBooks.t as a
"Passed QA"

Setting to "Needs signoff" for Bug 21567: Move Koha_ExternalContent_OverDrive.t
to db_dependent.

Nightly is all green with these to applied, let's get this over with.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #82352|0   |1
is obsolete||

--- Comment #21 from Mirko Tietgen  ---
Created attachment 82398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82398=edit
Bug 21567: Remove Koha_ExternalContent_RecordedBooks.t

This patch removes this file. The included tests are similar to those in
the db_dependent section, with the difference that this have some things
mocked. But the tests still require name resolution and connecting to
the RB servers. This situation breaks package building without any
noticeable gain.

The feature could be better tested by mocking WebService::ILS calls (so
no external world contact), but it belongs to a separate bug report.

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

--- Comment #20 from Mirko Tietgen  ---
Created attachment 82393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82393=edit
Bug 21567: Move Koha_ExternalContent_OverDrive.t to db_dependent

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

--- Comment #19 from Mirko Tietgen  ---
(In reply to Julian Maurice from comment #16)
> Just a thought: why not just skip the test if network is unavailable ?
> Something like this: https://metacpan.org/pod/LWP::Online#Test-Mode


(In reply to Tomás Cohen Arazi from comment #9)
> This tests should be moved into db_dependent if external world interaction
> is expected.



So, which one should it be for t/Koha_ExternalContent_OverDrive.t? I'd be in
favour of moving the test, but I'd be ok with adding the dependency too. Any
preferences?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

--- Comment #18 from Mirko Tietgen  ---
Funny thing I just found while dissecting the build process …

> I: pbuilder: network access will be disabled during build

Which explains why network is fine for other tasks but the test fails. :D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

--- Comment #17 from Mirko Tietgen  ---
(In reply to Julian Maurice from comment #16)
> Just a thought: why not just skip the test if network is unavailable ?
> Something like this: https://metacpan.org/pod/LWP::Online#Test-Mode

I don't think it is a network issue on my end. 

> # 500 Can't connect to oauth.overdrive.com:443

indicates we get out of the build machine, but not into the server, doesn't it?
Other network tasks during build work ok. I'll have another look what is going
on.

RecordedBooks is fixed with deleting the file. OverDrive would be skipped
during package build if moved to db_dependent. But I don't know if it is the
correct solution.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #16 from Julian Maurice  ---
Just a thought: why not just skip the test if network is unavailable ?
Something like this: https://metacpan.org/pod/LWP::Online#Test-Mode

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

--- Comment #15 from Srdjan Jankovic  ---
(In reply to Tomás Cohen Arazi from comment #14)
> The tests in t/db_dependent/Koha_ExternalContent_RecordedBooks.t work, I
> haven't checked how much they cover the functionality, though.

Without credentials - very little if any. With credentials reasonable amount.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

--- Comment #14 from Tomás Cohen Arazi  ---
(In reply to Srdjan Jankovic from comment #13)
> Apologies, at the time I wrote it it was not breaking things, and it was
> useful for me to make sure it integrates well.
> 
> I could try to make it more friendly, just not sure if my test credentials
> are still valid.

The tests in t/db_dependent/Koha_ExternalContent_RecordedBooks.t work, I
haven't checked how much they cover the functionality, though.
The DB independent tests could also be implemented by mocking all
WebService::ILS interactions, thus encapsulating external interactions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

--- Comment #13 from Srdjan Jankovic  ---
Apologies, at the time I wrote it it was not breaking things, and it was useful
for me to make sure it integrates well.

I could try to make it more friendly, just not sure if my test credentials are
still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #82344|0   |1
is obsolete||

--- Comment #12 from Marcel de Rooy  ---
Created attachment 82352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82352=edit
Bug 21567: Remove Koha_ExternalContent_RecordedBooks.t

This patch removes this file. The included tests are similar to those in
the db_dependent section, with the difference that this have some things
mocked. But the tests still require name resolution and connecting to
the RB servers. This situation breaks package building without any
noticeable gain.

The feature could be better tested by mocking WebService::ILS calls (so
no external world contact), but it belongs to a separate bug report.

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Jonathan Druart  changed:

   What|Removed |Added

 CC||srd...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #80664|0   |1
is obsolete||

--- Comment #11 from Tomás Cohen Arazi  ---
Created attachment 82344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82344=edit
Bug 21567: Remove Koha_ExternalContent_RecordedBooks.t

This patch removes this file. The included tests are similar to those in
the db_dependent section, with the difference that this have some things
mocked. But the tests still require name resolution and connecting to
the RB servers. This situation breaks package building without any
noticeable gain.

The feature could be better tested by mocking WebService::ILS calls (so
no external world contact), but it belongs to a separate bug report.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

--- Comment #10 from Tomás Cohen Arazi  ---
There's a similar file in t/db_dependent. This tests shoudl just get removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords||rel_18_11_candidate
 CC||tomasco...@gmail.com
 Status|NEW |In Discussion
   Severity|normal  |blocker

--- Comment #9 from Tomás Cohen Arazi  ---
This tests should be moved into db_dependent if external world interaction is
expected. This tests could remain in t/ if WebService::ILS behaviour was
completely mocked.

As-is, they block package building.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

--- Comment #8 from Jonathan Druart  
---
The test is skipping if ENV RECORDEDBOOKS_TEST_LIBRARY_ID is not set, I have no
idea where it comes from and so it will always be skipped as we never set it
anywhere...

I let a comment on bug 17602.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

--- Comment #6 from Jonathan Druart  
---
(In reply to Mirko Tietgen from comment #5)
> # Client-Warning: Internal response
> # 
> # Can't connect to api.rbdigital.com:80

So it's a network issue apparently

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

--- Comment #5 from Mirko Tietgen  ---
(In reply to Jonathan Druart from comment #4)
> I cannot recreate the failure and the output is not verbose enough. With
> this patch we could know what is the error.

Here is the more verbose output with the patch applied:

#   Failed test 'Invalid RecordedBooks partner credentials'
#   at t/Koha_ExternalContent_RecordedBooks.t line 29.
#   'Can't connect to api.rbdigital.com:80
# Request:
# GET http://api.rbdigital.com/v1/libraries/DUMMY/search?all=art
# Authorization: Basic DUMMY
# User-Agent: libwww-perl/6.08
# 
# 
# Response:
# 500 Can't connect to api.rbdigital.com:80
# Content-Type: text/plain
# Client-Date: Wed, 17 Oct 2018 08:16:37 GMT
# Client-Warning: Internal response
# 
# Can't connect to api.rbdigital.com:80
# 
# Name or service not known at /usr/share/perl5/LWP/Protocol/http.pm line 49.
# '
# doesn't match '(?^u:This endpoint can be called by authorized trusted app
or trusted partner only)'
# Looks like you failed 1 test of 3.
t/Koha_ExternalContent_RecordedBooks.t .. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests 
(less 1 skipped subtest: 1 okay)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17602


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602
[Bug 17602] Integrate support for RecordedBooks (formerly OneClickDigital) API
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
I cannot recreate the failure and the output is not verbose enough. With this
patch we could know what is the error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

--- Comment #3 from Jonathan Druart  
---
Created attachment 80664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80664=edit
Bug 21567: Use like instead of ok in RecordedBooks.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Martin Renvoize  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

Mirko Tietgen  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17602

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-10-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

--- Comment #2 from Mirko Tietgen  ---
t/Koha_ExternalContent_OverDrive.t .. skipped: Need Test::DBIx::Class

That's why it does not fail on the other image.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build

2018-10-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567

--- Comment #1 from Mirko Tietgen  ---
A different build fails only one of the tests

#   Failed test 'Invalid RecordedBooks partner credentials'
#   at t/Koha_ExternalContent_RecordedBooks.t line 29.
# Looks like you failed 1 test of 3.
t/Koha_ExternalContent_RecordedBooks.t .. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests 
(less 1 skipped subtest: 1 okay)

The other problem may be related to the pbuilder image then.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/