[Koha-bugs] [Bug 21585] Ignore missing firstname in ILL requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com --- Comment #10 from Martin Renvoize --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21585] Ignore missing firstname in ILL requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #9 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21585] Ignore missing firstname in ILL requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 Josef Moravec changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |mag...@libriotech.no |ity.org | CC||josef.mora...@gmail.com QA Contact||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21585] Ignore missing firstname in ILL requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 Josef Moravec changed: What|Removed |Added Attachment #81686|0 |1 is obsolete|| --- Comment #8 from Josef Moravec --- Created attachment 81723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81723=edit Bug 21585: Ignore missing firstname in ILL requests table To test: - Make sure you have a patron with just a surname and no firstname - Create an ILL request so that the name of this patron shows up in the Patron column of the ILL requests table - Before the patch, the name will display as "null Surname" - Apply the patch - Reload the ILL requests page - The name should now display as just "Surname" - Sign ye merrily off Signed-off-by: Andrew Isherwood Signed-off-by: Josef Moravec -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21585] Ignore missing firstname in ILL requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21585] Ignore missing firstname in ILL requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 Andrew Isherwood changed: What|Removed |Added Attachment #80679|0 |1 is obsolete|| --- Comment #7 from Andrew Isherwood --- Created attachment 81686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81686=edit Bug 21585 - Ignore missing firstname in ILL requests table To test: - Make sure you have a patron with just a surname and no firstname - Create an ILL request so that the name of this patron shows up in the Patron column of the ILL requests table - Before the patch, the name will display as "null Surname" - Apply the patch - Reload the ILL requests page - The name should now display as just "Surname" - Sign ye merrily off Signed-off-by: Andrew Isherwood -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21585] Ignore missing firstname in ILL requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 Andrew Isherwood changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21585] Ignore missing firstname in ILL requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 --- Comment #6 from Andrew Isherwood --- Aha! You're right! Creating an organisational user then creating a request for them does indeed demonstrate the problem. I'll test your patch now and sign off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21585] Ignore missing firstname in ILL requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 --- Comment #5 from Magnus Enger --- Thanks for testing, Andrew and Owen! I still see the problem, and I think I know what is happening: If you create a regular, adult type user and give it only a surname, the firstname field in the database will be the empty string. This will display fine in the Patron column of the "List requests" table. If you create a user that is of the Organization type, the field for firstname will not be displayed, and the database column will be NULL. This will display as "null" in the Patron column. Could you please check your borrowers.firstname columns and see if this could explain what you are seeing? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21585] Ignore missing firstname in ILL requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 --- Comment #4 from Owen Leonard --- I can't reproduce this bug either. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21585] Ignore missing firstname in ILL requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 Andrew Isherwood changed: What|Removed |Added CC||andrew.isherwood@ptfs-europ ||e.com --- Comment #3 from Andrew Isherwood --- I can't replicate this on master now. I'm wondering if one of the ILL bugs that has been merged recently has inadvertently fixed it. Can you still replicate it Magnus? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21585] Ignore missing firstname in ILL requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 Magnus Enger changed: What|Removed |Added Depends on||7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21585] Ignore missing firstname in ILL requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 Magnus Enger changed: What|Removed |Added Summary|Missing firstname shows as |Ignore missing firstname in |"null" in table of ILL |ILL requests table |requests| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/