[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 --- Comment #11 from Kyle M Hall --- Created attachment 83753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83753=edit Bug 21738: make call of CanBookBeReserved more safe Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 Kyle M Hall changed: What|Removed |Added Attachment #82251|0 |1 is obsolete|| Attachment #83637|0 |1 is obsolete|| --- Comment #10 from Kyle M Hall --- Created attachment 83752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83752=edit Bug 21738: check items count in C4:ILSDI::HoldTitle Test plan: - Try holding a title without items via ILS-DI (cgi-bin/koha/ilsdi.pl?service=HoldTitle_id=1_id=1), - you get an error, - apply this patch, - try again, - you should get the code "Notitems"Bug 21738: check items count in C4:ILSDI::HoldTitle Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 Alex Arnaud changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 Alex Arnaud changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 --- Comment #9 from Alex Arnaud --- Created attachment 83637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83637=edit Bug 21738: make call of CanBookBeReserved more safe -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
CC||m.de.r...@rijksmuseum.nl
--- Comment #8 from Marcel de Rooy ---
return { code => 'NotHoldable' } unless CanBookBeReserved( $borrowernumber,
$biblionumber )->{status} eq 'OK';
This line just needs attention imo. If there are no items, you may get back an
undef. So just check that. And do not assume you have a hash.
No need to duplicate the hostitems stuff at all?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738
--- Comment #7 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #6)
> I am wondering if we should not move
> $canReserve->{status} //= ''
> from reserve/request.pl to CanBookBeReserved
>
> That will make the calls to CanBookBeReserved safe.
>
> Kyle, what are your thoughts about that?
Yes, that sounds like a good idea to me!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738
Jonathan Druart changed:
What|Removed |Added
CC||k...@bywatersolutions.com
--- Comment #6 from Jonathan Druart
---
I am wondering if we should not move
$canReserve->{status} //= ''
from reserve/request.pl to CanBookBeReserved
That will make the calls to CanBookBeReserved safe.
Kyle, what are your thoughts about that?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 Jonathan Druart changed: What|Removed |Added Depends on||15524 --- Comment #5 from Jonathan Druart --- This is a regression since 18.05, we need it into 18.11 Caused by commit 5f485e476b2c5521d59bda6d48b56ed36cff3f86 Bug 15524: (QA follow-up) Change Can[Book|Item]BeReserved to return hashref, pass limit to template Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 [Bug 15524] Set limit on maximum possible holds per patron by category -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 Alex Arnaud changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #4 from Alex Arnaud --- The patch above is a replacement one. Since we need to know the number of items before having the patron making the request, we can't check items count in CanBookBeReserved. So i simply write the same test in ILSDI::HoldTitle than in reserve/request.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 Alex Arnaud changed: What|Removed |Added Attachment #81754|0 |1 is obsolete|| --- Comment #3 from Alex Arnaud --- Created attachment 82251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82251=edit Bug 21738: check items count in C4:ILSDI::HoldTitle Test plan: - Try holding a title without items via ILS-DI (cgi-bin/koha/ilsdi.pl?service=HoldTitle_id=1_id=1), - you get an error, - apply this patch, - try again, - you should get the code "Notitems"Bug 21738: check items count in C4:ILSDI::HoldTitle -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #2 from Jonathan Druart --- If I hit /reserve/request.pl?biblionumbers=1/2/3_hold=1 I see: https://snag.gy/myA5aP.jpg The patron search box should not be there. If I search for a patron, I get: https://snag.gy/tuRJb1.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 Alex Arnaud changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 Alex Arnaud changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 --- Comment #1 from Alex Arnaud --- Created attachment 81754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81754=edit Bug 21738: Move counting of items in C4::Reserves::CanBookBeReserved Test plan: - Try holding a title without items via ILS-DI => error, - try the same via UI => message is "Cannot place hold: this record has no items attached." - apply this patch, - try to hold a title without items via ILS-DI => "NotHoldable", - try again via UI => message is still "NotHoldable" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 Alex Arnaud changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
