[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Jonathan Druart changed: What|Removed |Added Blocks||25765 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #15 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 --- Comment #14 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Katrin Fischer changed: What|Removed |Added Attachment #99681|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 99833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99833=edit Bug 21746: Remove NO_LIBRARY_SET NO_LIBRARY_SET was used when the DB user was logged in. Since bug 20489 it's not longer possible. We could remove the code. One occurrence left in C4::InstallAuth as there is no (real) logged in user yet. Test plan: * Install Koha to make sure NO_LIBRARY_SET is not needed during the install process * Login into Koha * Make sure the your library's name is displayed correctly in the header * Set another library * Confirm that the library's name is updated Signed-off-by: Bernardo Gonzalez Kriegel No problem during install, nor changing library. Fixed (pre-existing) tab in circ/branchtransfers.pl No errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #99071|0 |1 is obsolete|| --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 99681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99681=edit Bug 21746: Remove NO_LIBRARY_SET NO_LIBRARY_SET was used when the DB user was logged in. Since bug 20489 it's not longer possible. We could remove the code. One occurrence left in C4::InstallAuth as there is no (real) logged in user yet. Test plan: * Install Koha to make sure NO_LIBRARY_SET is not needed during the install process * Login into Koha * Make sure the your library's name is displayed correctly in the header * Set another library * Confirm that the library's name is updated Signed-off-by: Bernardo Gonzalez Kriegel No problem during install, nor changing library. Fixed (pre-existing) tab in circ/branchtransfers.pl No errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 --- Comment #11 from Jonathan Druart --- (In reply to Owen Leonard from comment #9) > (In reply to Jonathan Druart from comment #8) > > Test plan: > > * Confirm that the library's name is updated > > This didn't work in my test. The previous library name still showed up. Yes, sorry about that. I revived patches I had on a local branch, but they went to far and were wrong. Only the first patch is relevant here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Jonathan Druart changed: What|Removed |Added Attachment #98934|0 |1 is obsolete|| Attachment #98935|0 |1 is obsolete|| Attachment #98936|0 |1 is obsolete|| Attachment #98937|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 99071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99071=edit Bug 21746: Remove NO_LIBRARY_SET NO_LIBRARY_SET was used when the DB user was logged in. Since bug 20489 it's not longer possible. We could remove the code. One occurrence left in C4::InstallAuth as there is no (real) logged in user yet. Test plan: * Install Koha to make sure NO_LIBRARY_SET is not needed during the install process * Login into Koha * Make sure the your library's name is displayed correctly in the header * Set another library * Confirm that the library's name is updated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #9 from Owen Leonard --- (In reply to Jonathan Druart from comment #8) > Test plan: > * Confirm that the library's name is updated This didn't work in my test. The previous library name still showed up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 --- Comment #8 from Jonathan Druart --- Test plan: * Install Koha to make sure NO_LIBRARY_SET is not needed during the install process * Loggin into Koha * Make sure the your library's name is displayed correctly in the header * Set another library * Confirm that the library's name is updated Other occurrences will be check by QA that will make sure there is no typo in the patches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 --- Comment #7 from Jonathan Druart --- Created attachment 98937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98937=edit Bug 21746: Remove 3 more uneeded variables from C4::Auth They are not used in the templates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 --- Comment #6 from Jonathan Druart --- Created attachment 98936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98936=edit Bug 21746: Remove GetLoggedInBranchcode This method from the Branches TT plugin is not needed as we can use logged_in_user -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 --- Comment #4 from Jonathan Druart --- Created attachment 98934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98934=edit Bug 21746: Remove NO_LIBRARY_SET NO_LIBRARY_SET was used when the DB user was logged in. Since bug 20489 it's not longer possible. We could remove the code. One occurrence left in C4::InstallAuth as there is no (real) logged in user yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 --- Comment #5 from Jonathan Druart --- Created attachment 98935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98935=edit Bug 21746: Remove LoginBranchname and LoginBranchcode Those 2 variables can be replaced by logged_in_user that is passed to all the template via C4::Auth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Katrin Fischer changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Katrin Fischer changed: What|Removed |Added Status|REOPENED|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 --- Comment #3 from Katrin Fischer --- (In reply to Katrin Fischer from comment #2) > I can confirm it's fixed now - looks like we forgot to close the bug! Sorry, wrong bug! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Katrin Fischer changed: What|Removed |Added Resolution|--- |FIXED CC||katrin.fisc...@bsz-bw.de Status|ASSIGNED|RESOLVED --- Comment #2 from Katrin Fischer --- I can confirm it's fixed now - looks like we forgot to close the bug! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #1 from M. Tompsett --- NO_LIBRARY_SET is also used for the initial web install, which requires the DB user. So, probably not entirely removing NO_LIBRARY_SET, because the branches table won't even exist at the initial web install. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
