[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Andrew Fuerste-Henry changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to stable|RESOLVED CC||and...@bywatersolutions.com --- Comment #20 from Andrew Fuerste-Henry --- Enhancement, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Fridolin Somers changed: What|Removed |Added Version(s)|21.05.00|21.05.00,20.11.06 released in|| Status|Pushed to master|Pushed to stable --- Comment #19 from Fridolin Somers --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 --- Comment #18 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Katrin Fischer changed: What|Removed |Added Text to go in the||This adds the description release notes||of the withdrawn status to ||the message that is ||displayed when a withdrawn ||item is returned. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Katrin Fischer changed: What|Removed |Added Attachment #117914|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 119795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119795=edit Bug 21883: Show authorized value description for withdrawn in check-in During check-in (circ/returns.pl) the withdrawn information may be displayed in a message : "Item is withdrawn". Like Bug 21877 we should display the withdrawn authorized value description during check-in. This patch adds this display. Text changed in order to look maximum like in checkout : https://git.koha-community.org/Koha-community/Koha/src/commit/a57278f39b8c5b7a82b21671f266dbf32e2d41a0/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt#L368 Uses class 'ci-withdrawn' to ease hidding this new information via CSS. Test plan : 1) On a catalog with items.withdrawn defined with authorized values category WITHDRAWN 2) Define in WITHDRAWN an authorized values 1 with description 'dropped in trash' 3) Define in WITHDRAWN an authorized values 2 with description empty 4) Check-out an item 5) Edit this item with withdrawn=1 6) Check-in this item => You see 'Item has been withdrawn (dropped in trash)' 7) Edit this item with withdrawn=2 8) Check-in this item => You see 'Item has been withdrawn' Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Katrin Fischer changed: What|Removed |Added Attachment #117913|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 119794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119794=edit Bug 21883: Pass the item to the template This patch update the controller to pass a full item object to the template instead of a subset of item fields and updates the template to utilise the object. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Bug 21883 depends on bug 26323, which changed state. Bug 26323 Summary: Not_for_loan, damaged, location and ccode values must be retrieved from the correct AV category https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 David Nind changed: What|Removed |Added Attachment #117720|0 |1 is obsolete|| --- Comment #15 from David Nind --- Created attachment 117914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117914=edit Bug 21883: Show authorized value description for withdrawn in check-in During check-in (circ/returns.pl) the withdrawn information may be displayed in a message : "Item is withdrawn". Like Bug 21877 we should display the withdrawn authorized value description during check-in. This patch adds this display. Text changed in order to look maximum like in checkout : https://git.koha-community.org/Koha-community/Koha/src/commit/a57278f39b8c5b7a82b21671f266dbf32e2d41a0/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt#L368 Uses class 'ci-withdrawn' to ease hidding this new information via CSS. Test plan : 1) On a catalog with items.withdrawn defined with authorized values category WITHDRAWN 2) Define in WITHDRAWN an authorized values 1 with description 'dropped in trash' 3) Define in WITHDRAWN an authorized values 2 with description empty 4) Check-out an item 5) Edit this item with withdrawn=1 6) Check-in this item => You see 'Item has been withdrawn (dropped in trash)' 7) Edit this item with withdrawn=2 8) Check-in this item => You see 'Item has been withdrawn' Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 David Nind changed: What|Removed |Added Attachment #117719|0 |1 is obsolete|| --- Comment #14 from David Nind --- Created attachment 117913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117913=edit Bug 21883: Pass the item to the template This patch update the controller to pass a full item object to the template instead of a subset of item fields and updates the template to utilise the object. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Fridolin Somers changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #13 from Fridolin Somers --- (In reply to David Nind from comment #12) > Sorry Fridolin, I was too slow retesting - patch no longer applies: > > .. > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 21883: AddShow authorized value description for withdrawn in > check-in > error: sha1 information is lacking or useless > (koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt). > error: could not build fake ancestor > .. Ah I had renamed a commit so there was a patch to obsolete. Please test again :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Fridolin Somers changed: What|Removed |Added Attachment #111038|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #12 from David Nind --- Sorry Fridolin, I was too slow retesting - patch no longer applies: .. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21883: AddShow authorized value description for withdrawn in check-in error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt). error: could not build fake ancestor .. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 --- Comment #11 from Fridolin Somers --- Created attachment 117720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117720=edit Bug 21883: Show authorized value description for withdrawn in check-in During check-in (circ/returns.pl) the withdrawn information may be displayed in a message : "Item is withdrawn". Like Bug 21877 we should display the withdrawn authorized value description during check-in. This patch adds this display. Text changed in order to look maximum like in checkout : https://git.koha-community.org/Koha-community/Koha/src/commit/a57278f39b8c5b7a82b21671f266dbf32e2d41a0/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt#L368 Uses class 'ci-withdrawn' to ease hidding this new information via CSS. Test plan : 1) On a catalog with items.withdrawn defined with authorized values category WITHDRAWN 2) Define in WITHDRAWN an authorized values 1 with description 'dropped in trash' 3) Define in WITHDRAWN an authorized values 2 with description empty 4) Check-out an item 5) Edit this item with withdrawn=1 6) Check-in this item => You see 'Item has been withdrawn (dropped in trash)' 7) Edit this item with withdrawn=2 8) Check-in this item => You see 'Item has been withdrawn' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Fridolin Somers changed: What|Removed |Added Attachment #111037|0 |1 is obsolete|| --- Comment #10 from Fridolin Somers --- Created attachment 117719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117719=edit Bug 21883: Pass the item to the template This patch update the controller to pass a full item object to the template instead of a subset of item fields and updates the template to utilise the object. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Fridolin Somers changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Martin Renvoize changed: What|Removed |Added Assignee|martin.renvoize@ptfs-europe |koha-b...@lists.koha-commun |.com|ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Katrin Fischer --- Was checkign this one for Academy, but doesn't apply right now (see also previous comment from David) Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21883: Pass the item to the template Applying: Bug 21883: AddShow authorized value description for withdrawn in check-in error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt). error: could not build fake ancestor Patch failed at 0001 Bug 21883: AddShow authorized value description for withdrawn in check-in The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21883-AddShow-authorized-value-description-for-SKAaMC.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #8 from David Nind --- Hi Martin. I struggled with this one, maybe my brain isn't working this morning 8-) : 1. I edited the values in WITHDRAWN to: Dropped in trash => assigned to authorised value 1 (empty) => description left blank for authorized value 2 2. When you edit an item's withdrawal status you get a drop down list of: (blank) <= it is blank, it doesn't display as (blank) Dropped in trash I guess making it blank is just for testing, not sure why you would in real life. 3. The values in the drop down list wrap around rather than the drop down list getting wider to accommodate the width of the description. 4. The message displayed when checking in an item with a withdrawal status where the description is blank - it displays the authorized value in brackets in a ci-withdrawn class: . Item is withdrawn. (2) As per 4 above, I don't get the behaviour in test plan step 8. Other notes for myself: - BlockReturnOfWithdrawnItems: enable sor disables items withdrawn for m being checked in - In the staff interface and the OPAC the description for the withdrawn value is shown in various places. If the withdrawn authorized value description or OPAC description are empty, it shows as: . Staff interface - withdrawn status column when you have selected edit items for a record: 2 . OPAC - status column in the OPAC view of the record: 2 . OPAC - MARC view, withdrawn status column for list of items: (blank) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #7 from Martin Renvoize --- Adopted.. Patche reworked as requested. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Martin Renvoize changed: What|Removed |Added Assignee|fridolin.som...@biblibre.co |martin.renvoize@ptfs-europe |m |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 --- Comment #6 from Martin Renvoize --- Created attachment 111038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111038=edit Bug 21883: AddShow authorized value description for withdrawn in check-in During check-in (circ/returns.pl) the withdrawn information may be displayed in a message : "Item is withdrawn". Like Bug 21877 we should display the withdrawn authorized value Description during check-in. This patch adds this display. Add for easier translation. Also adds class 'ci-withdrawn' to ease hidding this new information via CSS. Test plan : 1) On a catalog with items.withdrawn defined with authorized values category WITHDRAWN 2) Define in WITHDRAWN an authorized values 1 with description 'dropped in trash' 3) Define in WITHDRAWN an authorized values 2 with description empty 4) Check-out an item 5) Edit this item with withdrawn=1 6) Check-in this item => You see 'Item is withdrawn (dropped in trash)' 7) Edit this item with withdrawn=2 8) Check-in this item => You see 'Item is withdrawn' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Martin Renvoize changed: What|Removed |Added Attachment #82810|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 --- Comment #5 from Martin Renvoize --- Created attachment 111037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111037=edit Bug 21883: Pass the item to the template This patch update the controller to pass a full item object to the template instead of a subset of item fields and updates the template to utilise the object. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Martin Renvoize changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Depends on||26323 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 [Bug 26323] Not_for_loan, damaged, location and ccode values must be retrieved from the correct AV category -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26323 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18170 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart --- Pass the item object to the template instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Pierre-Marc Thibault changed: What|Removed |Added Attachment #82648|0 |1 is obsolete|| --- Comment #3 from Pierre-Marc Thibault --- Created attachment 82810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82810=edit Bug 21883: Show authorized value description for withdrawn in check-in During check-in (circ/returns.pl) the withdrawn information may be displayed in a message : "Item is withdrawn". Like Bug 21877 we should display the withdrawn authorized value description during check-in. This patch adds this display. Add for easier translation. Also adds class 'ci-withdrawn' to ease hidding this new information via CSS. Test plan : 1) On a catalog with items.withdrawn defined with authorized values category WITHDRAWN 2) Define in WITHDRAWN an authorized values 1 with description 'dropped in trash' 3) Define in WITHDRAWN an authorized values 2 with description empty 4) Check-out an item 5) Edit this item with withdrawn=1 6) Check-in this item => You see 'Item is withdrawn (dropped in trash)' 7) Edit this item with withdrawn=2 8) Check-in this item => You see 'Item is withdrawn' Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Pierre-Marc Thibault changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||pierre-marc.thibault@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 --- Comment #2 from Fridolin SOMERS --- Oh be sure syspref BlockReturnOfWithdrawnItems is 'Block' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 --- Comment #1 from Fridolin SOMERS --- Created attachment 82648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82648=edit Bug 21883: Show authorized value description for withdrawn in check-in During check-in (circ/returns.pl) the withdrawn information may be displayed in a message : "Item is withdrawn". Like Bug 21877 we should display the withdrawn authorized value description during check-in. This patch adds this display. Add for easier translation. Also adds class 'ci-withdrawn' to ease hidding this new information via CSS. Test plan : 1) On a catalog with items.withdrawn defined with authorized values category WITHDRAWN 2) Define in WITHDRAWN an authorized values 1 with description 'dropped in trash' 3) Define in WITHDRAWN an authorized values 2 with description empty 4) Check-out an item 5) Edit this item with withdrawn=1 6) Check-in this item => You see 'Item is withdrawn (dropped in trash)' 7) Edit this item with withdrawn=2 8) Check-in this item => You see 'Item is withdrawn' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Fridolin SOMERS changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15922 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Fridolin SOMERS changed: What|Removed |Added Status|NEW |ASSIGNED See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21877 Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
