[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Owen Leonard changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #11 from Lucas Gass --- not backporting enhancement to 18.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com --- Comment #10 from Martin Renvoize --- Always nice to have a little tidy up.. pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Bug 21948 depends on bug 21304, which changed state. Bug 21304 Summary: Update two-column templates with Bootstrap grid: Catalog https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #9 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Katrin Fischer changed: What|Removed |Added Attachment #86045|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 86125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86125=edit Bug 21948: Clean up style of item detail page This patch removes some page-specific style from the item detail page in the staff client and adds some markup in order to trigger a more generally-used style. This patch also adds a font-awesome icon to the "Edit item" link on the page. To test, apply the patch and regenerate the staff client CSS. Open a bibliographic record and view the "Items tab." Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Hayley Mapley changed: What|Removed |Added Attachment #85981|0 |1 is obsolete|| --- Comment #7 from Hayley Mapley --- Created attachment 86045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86045=edit Bug 21948: Clean up style of item detail page This patch removes some page-specific style from the item detail page in the staff client and adds some markup in order to trigger a more generally-used style. This patch also adds a font-awesome icon to the "Edit item" link on the page. To test, apply the patch and regenerate the staff client CSS. Open a bibliographic record and view the "Items tab." Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Hayley Mapley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 --- Comment #6 from Owen Leonard --- (In reply to Hayley Mapley from comment #4) > Patch does not apply. > error: sha1 information is lacking or useless Usually this kind of error means the patch required a dependency (Bug 21304), but I have rebased both patches to be safe. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Owen Leonard changed: What|Removed |Added Attachment #82859|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 85981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85981=edit Bug 21948: Clean up style of item detail page This patch removes some page-specific style from the item detail page in the staff client and adds some markup in order to trigger a more generally-used style. This patch also adds a font-awesome icon to the "Edit item" link on the page. To test, apply the patch and regenerate the staff client CSS. Open a bibliographic record and view the "Items tab." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Hayley Mapley changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||hayleymap...@catalyst.net.n ||z --- Comment #4 from Hayley Mapley --- Patch does not apply. Applying: Bug 21948: Clean up style of item detail page .git/rebase-apply/patch:46: trailing whitespace. No. of items: [% count | html %][% IF ( hiddencount ) %]total ([% showncount | html %] shown / [% hiddencount | html %] hidden) error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss). error: could not build fake ancestor Patch failed at 0001 Bug 21948: Clean up style of item detail page The copy of the patch that failed is found in: .git/rebase-apply/patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Ethan changed: What|Removed |Added Assignee|ethan.amo...@gmail.com |oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Ethan changed: What|Removed |Added Assignee|oleon...@myacpl.org |ethan.amo...@gmail.com CC||ethan.amo...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 --- Comment #3 from Owen Leonard --- (In reply to Josef Moravec from comment #1) > After this work, the bug 18061 could became duplicate This patch makes very minor changes, so there is still plenty of room for a more thorough overhaul if necessary. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 --- Comment #2 from Owen Leonard --- Created attachment 82859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82859=edit Bug 21948: Clean up style of item detail page This patch removes some page-specific style from the item detail page in the staff client and adds some markup in order to trigger a more generally-used style. This patch also adds a font-awesome icon to the "Edit item" link on the page. To test, apply the patch and regenerate the staff client CSS. Open a bibliographic record and view the "Items tab." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18061 --- Comment #1 from Josef Moravec --- After this work, the bug 18061 could became duplicate, which is absolutely OK ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
