[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Jonathan Druart changed: What|Removed |Added Blocks||22585 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22585 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585 [Bug 22585] Fix remaining double-escaped CAS links -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22585 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED --- Comment #8 from Fridolin SOMERS --- Not needed for 18.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Martin Renvoize changed: What|Removed |Added Keywords|rel_18_11_candidate | Status|Pushed to Master|Pushed to Stable --- Comment #7 from Martin Renvoize --- Pushed to 18.11.x for 18.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #5 from Martin Renvoize --- Be nice to fix this in with Auth_with_cas or Auth_with_shibboleth to be consistent.. but that work shouldn't hold this patch up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Martin Renvoize changed: What|Removed |Added Attachment #83169|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 83178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83178=edit Bug 21973: Do not url escape casServerUrl It is already escaped correctly in C4::Auth_with_cas::_url_with_get_params using URI::Escape::uri_escape Note that shibbolethLoginUrl is not and must be url escaped in template ("be consistent, they said") Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Kyle M Hall changed: What|Removed |Added Attachment #83022|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 83169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83169=edit Bug 21973: Do not url escape casServerUrl It is already escaped correctly in C4::Auth_with_cas::_url_with_get_params using URI::Escape::uri_escape Note that shibbolethLoginUrl is not and must be url escaped in template ("be consistent, they said") Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Jonathan Druart changed: What|Removed |Added Keywords||rel_18_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Owen Leonard changed: What|Removed |Added Attachment #82978|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 83022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83022=edit Bug 21973: Do not url escape casServerUrl It is already escaped correctly in C4::Auth_with_cas::_url_with_get_params using URI::Escape::uri_escape Note that shibbolethLoginUrl is not and must be url escaped in template ("be consistent, they said") -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 --- Comment #1 from Jonathan Druart --- Created attachment 82978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82978=edit Bug 21973: Do not url escape casServerUrl It is already escaped correctly in C4::Auth_with_cas::_url_with_get_params using URI::Escape::uri_escape Note that shibbolethLoginUrl is not and must be url escaped in template ("be consistent, they said") -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Jonathan Druart changed: What|Removed |Added Depends on||21526 CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 [Bug 21526] TT variables used to build a link should be uri filtered -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/