[Koha-bugs] [Bug 22046] Simplify C4::Matcher->get_matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046 Jonathan Druart changed: What|Removed |Added Blocks||24348 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24348 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24348 [Bug 24348] Record matching rules: required match checks does not work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22046] Simplify C4::Matcher->get_matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046 Andreas Jonsson changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24348 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22046] Simplify C4::Matcher->get_matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|RESOLVED CC||martin.renvoize@ptfs-europe ||.com Resolution|--- |FIXED --- Comment #8 from Martin Renvoize --- I'm not going to backport this architectural enhancement to 18.11.x series at this time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22046] Simplify C4::Matcher->get_matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22046] Simplify C4::Matcher->get_matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22046] Simplify C4::Matcher->get_matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046 --- Comment #6 from Marcel de Rooy --- Code looks good to me. Tests would be even more convincing ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22046] Simplify C4::Matcher->get_matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22046] Simplify C4::Matcher->get_matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046 Marcel de Rooy changed: What|Removed |Added Attachment #89058|0 |1 is obsolete|| --- Comment #5 from Marcel de Rooy --- Created attachment 90017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90017=edit Bug 22046: Simplify and unify the code for get_matches To test: 1 - Stage some records for import 2 - Manage the records 3 - Use several different matching rules and note the results 4 - Apply patch 5 - Try several matching rules again and note the results have not changed 6 - Try under both search engines (Zebra and ES) Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22046] Simplify C4::Matcher->get_matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22046] Simplify C4::Matcher->get_matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046 Liz Rea changed: What|Removed |Added Attachment #83475|0 |1 is obsolete|| --- Comment #4 from Liz Rea --- Created attachment 89058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89058=edit Bug 22046: Simplify and unify the code for get_matches To test: 1 - Stage some records for import 2 - Manage the records 3 - Use several different matching rules and note the results 4 - Apply patch 5 - Try several matching rules again and note the results have not changed 6 - Try under both search engines (Zebra and ES) Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22046] Simplify C4::Matcher->get_matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22046] Simplify C4::Matcher->get_matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046 --- Comment #3 from Nick Clemens --- (In reply to David Cook from comment #2) > I haven't looked at the patch but might be worth keeping in mind > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710. I don't think it should have any effect here - this simply removes a conditional on SearchEngine setting so that the matcher code is the same in either scenario (the check does still happen, but in a subroutine, this removes a second check) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22046] Simplify C4::Matcher->get_matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- I haven't looked at the patch but might be worth keeping in mind https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
