[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #16 from Lucas Gass --- missing dependency for 18.05.x will not backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Martin Renvoize changed: What|Removed |Added Blocks||17006 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 [Bug 17006] Add route to change patron's password -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Master|Pushed to Stable --- Comment #15 from Martin Renvoize --- Invisible enhancement, I'm choosing to backport this to the 18.11.x series for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #14 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 84424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84424=edit Bug 22047: Fix opac/opac-passwd.pl call Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 84423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84423=edit Bug 22047: Add 'skip_validation' param to Koha::Patron->set_password This patch makes Koha::Patron->set_password expect a hashref as param and adds support for an 'skip_validation' param to be passed. Its purpose is to make the method skip the relevant password strength checks if required. It targets the Auth_with_ldap.pm usage when the 'update_password' flag is set in the configuration. The tests on this bug cover this use case so, to test: - Apply the tests patch - Run: $ kshell k$ prove t/db_dependent/Koha/Patrons.t => FAIL: Tests fail, code doesn't work as expected - Apply this patch - Run: k$ prove t/db_dependent/Koha/Patrons.t => SUCCESS: Tests pass! Yay! - Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 84422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84422=edit Bug 22047: Unit tests Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi changed: What|Removed |Added Attachment #83594|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi changed: What|Removed |Added Status|Patch doesn't apply |Passed QA CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi changed: What|Removed |Added Attachment #83595|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi changed: What|Removed |Added Attachment #83596|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Patch doesn't apply --- Comment #10 from Nick Clemens --- Minor rebase needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Bug 22047 depends on bug 21547, which changed state. Bug 21547 Summary: Use set_password in opac-passwd and remove sub goodkey https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21547 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 --- Comment #8 from Josef Moravec --- Created attachment 83595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83595=edit Bug 22047: Add 'skip_validation' param to Koha::Patron->set_password This patch makes Koha::Patron->set_password expect a hashref as param and adds support for an 'skip_validation' param to be passed. Its purpose is to make the method skip the relevant password strength checks if required. It targets the Auth_with_ldap.pm usage when the 'update_password' flag is set in the configuration. The tests on this bug cover this use case so, to test: - Apply the tests patch - Run: $ kshell k$ prove t/db_dependent/Koha/Patrons.t => FAIL: Tests fail, code doesn't work as expected - Apply this patch - Run: k$ prove t/db_dependent/Koha/Patrons.t => SUCCESS: Tests pass! Yay! - Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 --- Comment #9 from Josef Moravec --- Created attachment 83596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83596=edit Bug 22047: Fix opac/opac-passwd.pl call Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Josef Moravec changed: What|Removed |Added Attachment #83582|0 |1 is obsolete|| Attachment #83583|0 |1 is obsolete|| Attachment #83584|0 |1 is obsolete|| --- Comment #7 from Josef Moravec --- Created attachment 83594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83594=edit Bug 22047: Unit tests Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 --- Comment #5 from Kyle M Hall --- Created attachment 83583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83583=edit Bug 22047: Add 'skip_validation' param to Koha::Patron->set_password This patch makes Koha::Patron->set_password expect a hashref as param and adds support for an 'skip_validation' param to be passed. Its purpose is to make the method skip the relevant password strength checks if required. It targets the Auth_with_ldap.pm usage when the 'update_password' flag is set in the configuration. The tests on this bug cover this use case so, to test: - Apply the tests patch - Run: $ kshell k$ prove t/db_dependent/Koha/Patrons.t => FAIL: Tests fail, code doesn't work as expected - Apply this patch - Run: k$ prove t/db_dependent/Koha/Patrons.t => SUCCESS: Tests pass! Yay! - Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 --- Comment #6 from Kyle M Hall --- Created attachment 83584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83584=edit Bug 22047: Fix opac/opac-passwd.pl call Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Kyle M Hall changed: What|Removed |Added Attachment #83491|0 |1 is obsolete|| Attachment #83492|0 |1 is obsolete|| Attachment #83493|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 83582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83582=edit Bug 22047: Unit tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi changed: What|Removed |Added Blocks|21992 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 [Bug 21992] Remove Koha::Patron::update_password -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi changed: What|Removed |Added Blocks||22048 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048 [Bug 22048] Use set_password instead of update_password in the codebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff Summary|set_password should have an |set_password should have a |'unsafe' param |'skip_validation' param -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
