[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED CC||fridolin.som...@biblibre.co ||m Status|Pushed to Stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #15 from Lucas Gass --- enhancement not backporting to 18.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #14 from Martin Renvoize --- Developer aid, backporting to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #13 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 Josef Moravec changed: What|Removed |Added Attachment #83657|0 |1 is obsolete|| Attachment #83658|0 |1 is obsolete|| Attachment #83659|0 |1 is obsolete|| --- Comment #10 from Josef Moravec --- Created attachment 83723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83723=edit Bug 22051: Add Koha::Exceptions::Object::WrongValue This patch adds a new exception to be thrown in Koha::Object->store when a DBIC exception is thrown regarding bad data format. To test: - Apply this patch - Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 --- Comment #12 from Josef Moravec --- Created attachment 83725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83725=edit Bug 22051: Make Koha::Object->store translate incorrect value exceptions This patch adds a new condition to Koha::Object->store so it catches incorrect value-related DBIC exceptions. This DBIC exceptions get now translated into Koha::Exceptions::Object::BadValue exceptions with relevant parameters passed. To test: - Apply the exception and unit tests patches - Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: Tests fail because this exception handling code is not implemented - Apply this patch - Run: k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 --- Comment #11 from Josef Moravec --- Created attachment 83724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83724=edit Bug 22051: Unit tests Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 Charles Farmer changed: What|Removed |Added Attachment #83623|0 |1 is obsolete|| --- Comment #8 from Charles Farmer --- Created attachment 83658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83658=edit Bug 22051: Unit tests Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 Charles Farmer changed: What|Removed |Added Attachment #83624|0 |1 is obsolete|| --- Comment #9 from Charles Farmer --- Created attachment 83659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83659=edit Bug 22051: Make Koha::Object->store translate incorrect value exceptions This patch adds a new condition to Koha::Object->store so it catches incorrect value-related DBIC exceptions. This DBIC exceptions get now translated into Koha::Exceptions::Object::BadValue exceptions with relevant parameters passed. To test: - Apply the exception and unit tests patches - Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: Tests fail because this exception handling code is not implemented - Apply this patch - Run: k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 Charles Farmer changed: What|Removed |Added Attachment #83622|0 |1 is obsolete|| --- Comment #7 from Charles Farmer --- Created attachment 83657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83657=edit Bug 22051: Add Koha::Exceptions::Object::WrongValue This patch adds a new exception to be thrown in Koha::Object->store when a DBIC exception is thrown regarding bad data format. To test: - Apply this patch - Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 --- Comment #6 from Owen Leonard --- Created attachment 83624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83624=edit Bug 22051: Make Koha::Object->store translate incorrect value exceptions This patch adds a new condition to Koha::Object->store so it catches incorrect value-related DBIC exceptions. This DBIC exceptions get now translated into Koha::Exceptions::Object::BadValue exceptions with relevant parameters passed. To test: - Apply the exception and unit tests patches - Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: Tests fail because this exception handling code is not implemented - Apply this patch - Run: k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 Owen Leonard changed: What|Removed |Added Attachment #83534|0 |1 is obsolete|| Attachment #83535|0 |1 is obsolete|| Attachment #83536|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 83622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83622=edit Bug 22051: Add Koha::Exceptions::Object::WrongValue This patch adds a new exception to be thrown in Koha::Object->store when a DBIC exception is thrown regarding bad data format. To test: - Apply this patch - Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 --- Comment #5 from Owen Leonard --- Created attachment 83623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83623=edit Bug 22051: Unit tests Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 Tomás Cohen Arazi changed: What|Removed |Added Blocks||22049 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 [Bug 22049] MarkIssueReturned should rely on returndate only -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 Tomás Cohen Arazi changed: What|Removed |Added Summary|Make Koha::Object->store|Make Koha::Object->store |translate 'Incorrect|translate 'Incorrect |datetime value' exceptions |value' exceptions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/