[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Jonathan Druart changed: What|Removed |Added Blocks||29931 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Martin Renvoize changed: What|Removed |Added Blocks|23171 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 [Bug 23171] Improve plugin performance -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Martin Renvoize changed: What|Removed |Added Blocks||23171 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 [Bug 23171] Improve plugin performance -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Martin Renvoize changed: What|Removed |Added Blocks||23168 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 [Bug 23168] Ability to disable some plugins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Fridolin SOMERS changed: What|Removed |Added Blocks||21073 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 [Bug 21073] Improve plugin performance -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Nick Clemens changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #35 from Nick Clemens --- (In reply to Tomás Cohen Arazi from comment #32) > @RM, follow-up fixes the tests. This has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Martin Renvoize changed: What|Removed |Added Version(s)||19.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Master|RESOLVED CC||martin.renvoize@ptfs-europe ||.com --- Comment #34 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Owen Leonard changed: What|Removed |Added Blocks||22906 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22906 [Bug 22906] Minor corrections to plugins home page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tomás Cohen Arazi changed: What|Removed |Added Attachment #89551|0 |1 is obsolete|| --- Comment #33 from Tomás Cohen Arazi --- Created attachment 89558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89558=edit Bug 22053: (QA follow-up) Fix tests This patch makes the tests enable the plugins that are required for them. Otherwise unexpected failures can happen Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tomás Cohen Arazi changed: What|Removed |Added Keywords||additional_work_needed --- Comment #32 from Tomás Cohen Arazi --- @RM, follow-up fixes the tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #31 from Tomás Cohen Arazi --- Created attachment 89551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89551=edit Bug 22053: (QA follow-up) Fix tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #30 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053
--- Comment #29 from Tomás Cohen Arazi ---
Created attachment 89116
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89116=edit
Bug 22053: (QA follow-up) Override enable_plugins configuration
This patch makes the update script override the configured
enable_plugins setting in koha-conf.xml.
on testing the failure I wrote trivial tests on how
Koha::Plugins->new({ enable_plugins => 1 }) should work. Adding them to
this patch as well.
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Nick Clemens changed: What|Removed |Added Status|Passed QA |Failed QA CC||n...@bywatersolutions.com --- Comment #28 from Nick Clemens --- The updatedatabase fails for installations without plugins enabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tomás Cohen Arazi changed: What|Removed |Added Keywords|release-notes-needed| Text to go in the||The ability to release notes||enable/disable plugins is ||added. This is particularly ||handy when testing new ||plugins or when plugins are ||not (yet) fully configured ||for production use. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tomás Cohen Arazi changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 89043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89043=edit Bug 22053: (QA follow-up) More tests This patch adds tests for: - $plugin->enable and $plugin->disable are chainable (i.e. return $self) - Disabled plugins don't inject routes To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t \ t/db_dependent/Plugins.t => SUCCESS: Tests pass Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #26 from Tomás Cohen Arazi --- Created attachment 89042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89042=edit Bug 22053: update database Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 89040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89040=edit Bug 22053: create unit tests Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 89041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89041=edit Bug 22053: ability to enable/disable some plugins Test plan: - apply this patch(es), - launch an updatedabase, - go to plugins/plugins-home.pl and deal with enable/disable method - install a plugin like KitchenSink https://github.com/bywatersolutions/koha-plugin-kitchen-sink - once installed, the plugin change the background color of the staff client to orange. - disable the plugin, - background color should be set back to the original one Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tomás Cohen Arazi changed: What|Removed |Added Attachment #88819|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86964|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tomás Cohen Arazi changed: What|Removed |Added Attachment #88818|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tomás Cohen Arazi changed: What|Removed |Added Attachment #88820|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tomás Cohen Arazi changed: What|Removed |Added Attachment #88783|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tomás Cohen Arazi changed: What|Removed |Added Attachment #88785|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tomás Cohen Arazi changed: What|Removed |Added Attachment #88784|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #23 from Alex Arnaud --- (In reply to Agustín Moyano from comment #21) > Hello Alex, awesome job!, it works great.. > > Just a little question.. > > I noticed that disabled plugins have the "run plugin" button enabled, and > when you click on it works.. > > shouldn't that button be disabled if you disable the entire plugin?.. or > this bug is intended only for hookup functions? Hello Agustín, IMO, disabled plugins can be run and configured in the "plugins area" (koha/plugins/*). The only thing this patch does is to prevent calls of disabled plugins anywhere else in Koha (hooks). I don't see any advantage of preventing uses of run or configure methods since you can just ignore them. But a hook calls systematically all plugins implementing a specific method and you might need that does not happen for one of them until your are done with the configuration (for exemple) without removing it from your server. Thx for testing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #22 from Agustín Moyano --- (In reply to Agustín Moyano from comment #21) > Hello Alex, awesome job!, it works great.. > > Just a little question.. > > I noticed that disabled plugins have the "run plugin" button enabled, and > when you click on it works.. > > shouldn't that button be disabled if you disable the entire plugin?.. or > this bug is intended only for hookup functions? s/"run plugin" button/"run tool" option/g :P -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Agustín Moyano changed: What|Removed |Added CC||agustinmoy...@theke.io --- Comment #21 from Agustín Moyano --- Hello Alex, awesome job!, it works great.. Just a little question.. I noticed that disabled plugins have the "run plugin" button enabled, and when you click on it works.. shouldn't that button be disabled if you disable the entire plugin?.. or this bug is intended only for hookup functions? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #19 from Agustín Moyano --- Created attachment 88819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88819=edit Bug 22053: ability to enable/disable some plugins Test plan: - apply this patch(es), - launch an updatedabase, - go to plugins/plugins-home.pl and deal with enable/disable method - install a plugin like KitchenSink https://github.com/bywatersolutions/koha-plugin-kitchen-sink - once installed, the plugin change the background color of the staff client to orange. - disable the plugin, - background color should be set back to the original one Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #20 from Agustín Moyano --- Created attachment 88820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88820=edit Bug 22053: update database Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #18 from Agustín Moyano --- Created attachment 88818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88818=edit Bug 22053: create unit tests Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #17 from Claire Gravely --- Created attachment 88785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88785=edit [SIGNED-OFF] Bug 22053: update database Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Claire Gravely changed: What|Removed |Added Attachment #86961|0 |1 is obsolete|| Attachment #86962|0 |1 is obsolete|| Attachment #86963|0 |1 is obsolete|| --- Comment #15 from Claire Gravely --- Created attachment 88783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88783=edit [SIGNED-OFF] Bug 22053: create unit tests Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #16 from Claire Gravely --- Created attachment 88784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88784=edit [SIGNED-OFF] Bug 22053: ability to enable/disable some plugins Test plan: - apply this patch(es), - launch an updatedabase, - go to plugins/plugins-home.pl and deal with enable/disable method - install a plugin like KitchenSink https://github.com/bywatersolutions/koha-plugin-kitchen-sink - once installed, the plugin change the background color of the staff client to orange. - disable the plugin, - background color should be set back to the original one Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Claire Gravely changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 axel changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 axel changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||axel.amg...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Alex Arnaud changed: What|Removed |Added Attachment #83538|0 |1 is obsolete|| --- Comment #12 from Alex Arnaud --- Created attachment 86962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86962=edit Bug 22053: ability to enable/disable some plugins Test plan: - apply this patch(es), - launch an updatedabase, - go to plugins/plugins-home.pl and deal with enable/disable method - install a plugin like KitchenSink https://github.com/bywatersolutions/koha-plugin-kitchen-sink - once installed, the plugin change the background color of the staff client to orange. - disable the plugin, - background color should be set back to the original one Rebased-on: 2019-03-25 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Alex Arnaud changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Alex Arnaud changed: What|Removed |Added Attachment #83540|0 |1 is obsolete|| --- Comment #14 from Alex Arnaud --- Created attachment 86964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86964=edit [DO NOT PUSH] Bug 22053: provide staff-global.css Rebased-on: 2019-03-25 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Alex Arnaud changed: What|Removed |Added Attachment #83539|0 |1 is obsolete|| --- Comment #13 from Alex Arnaud --- Created attachment 86963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86963=edit Bug 22053: update database Rebased-on: 2019-03-25 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Alex Arnaud changed: What|Removed |Added Attachment #83537|0 |1 is obsolete|| --- Comment #11 from Alex Arnaud --- Created attachment 86961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86961=edit Bug 22053: create unit tests Rebased-on: 2019-03-25 Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 José-Mario Monteiro-Santos changed: What|Removed |Added CC||jose-mario.monteiro-santos@ ||inlibro.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Pierre-Marc Thibault changed: What|Removed |Added Attachment #83667|0 |1 is obsolete|| Attachment #83667|1 |0 is patch|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #9 from Pierre-Marc Thibault --- Created attachment 83666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83666=edit Bug 10676: Fix behaviour of OpacHiddenItems for items.restricted The numerical restricted value was overwritten in GetItemsInfo with the description. So OpacHiddenItems would only work for restricted using the description, not the numerical value of the authorised value like for other similar status fields. This changes GetItemsInfo to use a separate variable for the description, as it's already done for notforloan and changes the template files where the variable is used accordingly. To test - Before applying patch - Configure OpacHiddenItems with: restricted: [1] - Find a record with more than one item and mark one of the items as "Restricted Access" (assume standard sample data - check authorised value if status doesn't exist) - Verify the item is still shown in OPAC. - Apply patch - Verify that the item is now hidden - Verify that the status still displays nicely in the staff detail page - Delete OpacHiddenItems - Verify that the status is showing nicely in the OPAC detail page Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #10 from Pierre-Marc Thibault --- Created attachment 83667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83667=edit Bug 10676: Add unit tests - GetItemsInfo To test: prove t/db_dependent/Items.t Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #8 from Katrin Fischer --- I marked the other as a duplicate of this one - bug with patches always wins :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #7 from Alex Arnaud --- (In reply to Katrin Fischer from comment #6) > Please always check for existing bugs first ;) I checked! But surely the wrong way >_< There is no patch on the first one. So what do i do ? Closing this one and submit my patches on bug 21558 or i keep my patches there ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #6 from Katrin Fischer --- Please always check for existing bugs first ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- *** Bug 21558 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Alex Arnaud changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #4 from Alex Arnaud --- Created attachment 83540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83540=edit [DO NOT PUSH] Bug 22053: provide staff-global.css -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #3 from Alex Arnaud --- Created attachment 83539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83539=edit Bug 22053: update database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #2 from Alex Arnaud --- Created attachment 83538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83538=edit Bug 22053: ability to enable/disable some plugins Test plan: - apply this patch(es), - launch an updatedabase, - go to plugins/plugins-home.pl and deal with enable/disable method - install a plugin like KitchenSink https://github.com/bywatersolutions/koha-plugin-kitchen-sink - once installed, the plugin change the background color of the staff client to orange. - disable the plugin, - background color should be set back to the original one -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #1 from Alex Arnaud --- Created attachment 83537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83537=edit Bug 22053: create unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Alex Arnaud changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
