[Koha-bugs] [Bug 22066] branchcode should be recorded for manual credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED --- Comment #7 from Tomás Cohen Arazi --- The dependency is not in 18.05, so it is safe to skip this one! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22066] branchcode should be recorded for manual credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066 Jesse Maseto changed: What|Removed |Added CC||je...@bywatersolutions.com --- Comment #6 from Jesse Maseto --- Merge conflict with 18.05.x. Please rebase to 18.05.x if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22066] branchcode should be recorded for manual credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #5 from Martin Renvoize --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22066] branchcode should be recorded for manual credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22066] branchcode should be recorded for manual credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22066] branchcode should be recorded for manual credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22066] branchcode should be recorded for manual credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066 Josef Moravec changed: What|Removed |Added Attachment #83742|0 |1 is obsolete|| --- Comment #3 from Josef Moravec --- Created attachment 83744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83744=edit Bug 22066: Record library_id for manual credits On creating manual credits, the (newly introduced) branchcode should be set now. This trivial patch makes it work. To test: - Create a manual credit for a known patron - Using MySQL check the result: $ sudo mysql > SELECT * FROM accountlines WHERE borrowernumber=; => FAIL: The created accountline row has NULL for the branchcode - Apply this patch - Create a manual credit for the patron - Run: > SELECT * FROM accountlines WHERE borrowernumber=; => SUCCESS: branchcode is set correctly -Sign off :-D Signed-off-by: Owen Leonard Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22066] branchcode should be recorded for manual credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22066] branchcode should be recorded for manual credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066 Owen Leonard changed: What|Removed |Added Attachment #83699|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 83742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83742=edit Bug 22066: Record library_id for manual credits On creating manual credits, the (newly introduced) branchcode should be set now. This trivial patch makes it work. To test: - Create a manual credit for a known patron - Using MySQL check the result: $ sudo mysql > SELECT * FROM accountlines WHERE borrowernumber=; => FAIL: The created accountline row has NULL for the branchcode - Apply this patch - Create a manual credit for the patron - Run: > SELECT * FROM accountlines WHERE borrowernumber=; => SUCCESS: branchcode is set correctly -Sign off :-D Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22066] branchcode should be recorded for manual credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22066] branchcode should be recorded for manual credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22066] branchcode should be recorded for manual credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22066] branchcode should be recorded for manual credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 83699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83699=edit Bug 22066: Record library_id for manual credits On creating manual credits, the (newly introduced) branchcode should be set now. This trivial patch makes it work. To test: - Create a manual credit for a known patron - Using MySQL check the result: $ sudo mysql > SELECT * FROM accountlines WHERE borrowernumber=; => FAIL: The created accountline row has NULL for the branchcode - Apply this patch - Create a manual credit for the patron - Run: > SELECT * FROM accountlines WHERE borrowernumber=; => SUCCESS: branchcode is set correctly -Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22066] branchcode should be recorded for manual credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066 Bug 22066 depends on bug 19066, which changed state. Bug 19066 Summary: Add branchcode to accountlines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22066] branchcode should be recorded for manual credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066 Tomás Cohen Arazi changed: What|Removed |Added Summary|Branchcode should be|branchcode should be |recorded for manual credits |recorded for manual credits -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22066] Branchcode should be recorded for manual credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Depends on||19066 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 [Bug 19066] Add branchcode to accountlines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
