[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.druart+koha@gmail. |oleon...@myacpl.org |com | --- Comment #19 from Jonathan Druart --- I won't have time to dedicate to this in the near future. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | Assignee|oleon...@myacpl.org |jonathan.druart+koha@gmail. ||com CC||m.de.r...@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #16 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #17 from Marcel de Rooy --- This is very weird code. Apart from the encoding, the paging seems to be buggy too. Can reproduce the issue Frido mentioned: Back to results (pos 9 with 5 results per page WHEN coming back from pos 10) /cgi-bin/koha/opac-search.pl?idx=kw_by=relevance_dsc=b%C3%83%C2%B6%C3%83%C2%B6k => böök The previous and next links are good, but the Back to results becomes even more bad when paging back and forth.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment #18 from Marcel de Rooy --- Have to conclude that this is not ready for passing QA yet. Just removing the encoding/escaping does not look good. We meet the issue here too of the encoding of CGI::Session. If we store unicode stuff (in the URL) within param busc, how does it get stored and how should we retrieve? It feels like we should do conversion as early as we retrieve and as late as we store it again. And such that it survives pure ASCII, Latin and 'real' Unicode. -use URI::Escape qw( uri_escape_utf8 uri_unescape ); +use C4::Search; This does not look good either. Probably we need to move URI::Escape to the top. The whole logic for Back and Next in this feature looks buggy. But that is outside the scope of this report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #15 from Fridolin Somers --- (In reply to Jonathan Druart from comment #14) > (In reply to Fridolin Somers from comment #12) > > I do reproduce. > > > > Searching for bööks. > > > > Browsing from result n°18 to n°19 then n°20 does not break encoding. > > Browsing from result n°20 to n°19 breaks encoding. > > Browsing from result n°19 to n°18 does not break encoding. > > > > o_O > > With or without the patch? Without patch. Feels strange to remove URI escape, we should try with URI chars like & ? = -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #14 from Jonathan Druart --- (In reply to Fridolin Somers from comment #12) > I do reproduce. > > Searching for bööks. > > Browsing from result n°18 to n°19 then n°20 does not break encoding. > Browsing from result n°20 to n°19 breaks encoding. > Browsing from result n°19 to n°18 does not break encoding. > > o_O With or without the patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #13 from Katrin Fischer --- (In reply to Fridolin Somers from comment #12) > I do reproduce. > > Searching for bööks. > > Browsing from result n°18 to n°19 then n°20 does not break encoding. > Browsing from result n°20 to n°19 breaks encoding. > Browsing from result n°19 to n°18 does not break encoding. > > o_O Thx Frido, I have a feeling it could have to do with the "last record on a page" somehow? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #12 from Fridolin Somers --- I do reproduce. Searching for bööks. Browsing from result n°18 to n°19 then n°20 does not break encoding. Browsing from result n°20 to n°19 breaks encoding. Browsing from result n°19 to n°18 does not break encoding. o_O -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #11 from Katrin Fischer --- I know the patch and commit message need some more work, but maybe the updated test plan in comment#9 and the SO will help to get some more eyes on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Katrin Fischer changed: What|Removed |Added Attachment #115529|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 136550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136550=edit Bug 22070: Try to fix encoding and escaping issue on browse result Pretty sure this does not work but in my tests it seems to fix the problem. Note that if there are several pages, the next link won't appear if you are on the last result of the first page. I don't understand why this code is so complicated, couldn't we port what we have on the staff interface (browser.js)? Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #9 from Katrin Fischer --- I'll have another go at making this reproducable in a simpler way: 1) Fresh ktd sample database, reset_all, even used a private window. 2) OPAC: search for: bööks 3) Open detail page of last result on the result list. 4) In the browser, click on "Previous" 5) Check the URL for "back to results" - it will show broken characters 6) Click on it - it's broken ... and the patch fixes this for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #8 from Owen Leonard --- I don't seem to be able to reproduce this bug in master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #7 from Katrin Fischer --- Hi Jonathan, it is related. In my test plan, it asks you to click on next from the last result of the first page, but you noted: > Note that if there are several pages, the next link won't appear if you > are on the last result of the first page. And it's true... but then it's not. I managed to sometimes have that 'next' button and then when you click it, it causes the encoding issue on the 'back to results' link. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #6 from Jonathan Druart --- I don't understand, Katrin. What you are describing does not seem related to this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #5 from Katrin Fischer --- The Next link is not always hidden on the last result of the page, but sometimes, this might be another bug. If you keep previous/next'ing you will eventually see the next link to jump to first result of the second page and the link back to results breaks. The patch doesn't fix it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #4 from Katrin Fischer --- The encoding issue is still present in 20.11 and master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20529 --- Comment #3 from Katrin Fischer --- Could this be somehow related to the discussion on bug 20529? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #2 from Jonathan Druart --- Created attachment 115529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115529=edit Bug 22070: Try to fix encoding and escaping issue on browse result Pretty sure this does not work but in my tests it seems to fix the problem. Note that if there are several pages, the next link won't appear if you are on the last result of the first page. I don't understand why this code is so complicated, couldn't we port what we have on the staff interface (browser.js)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Jonathan Druart changed: What|Removed |Added Depends on||11515, 11944 CC||jonathan.dru...@bugs.koha-c ||ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 [Bug 11515] Encoding problem with OpacBrowseResults https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 [Bug 11944] Cleanup Koha UTF-8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Marjorie Barry-Vila changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #1 from Katrin Fischer --- Still valid for 18.11. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
