[Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 Kyle M Hall changed: What|Removed |Added Resolution|--- |WONTFIX Status|Failed QA |RESOLVED --- Comment #9 from Kyle M Hall --- Closing this bug out. At this point we've had the new behavior longer than we had the old behavior and I expect it's simpler for everyone to change their groups hierarchy rather than push this patch. For posterity, the fix is to make new root groups for each of your first tier sub-groups, and enable the search group feature for each of them. That means changing something like this: RootGroup: SearchGroup1: LibraryA LibraryB SearchGroup2: LibraryC LibraryD SearchGroup3: LibraryE LibraryF to this: RootSearchGroup1: LibraryA LibraryB RootSearchGroup2: LibraryC LibraryD RootSearchGroup3: LibraryE LibraryF -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 --- Comment #8 from Kyle M Hall --- (In reply to Katrin Fischer from comment #5) > I am still not sure if the fix is right :( > > My reasoning is that people might have added sub groups for organizing > relying on the fact that they will not take effect. So changing it one way > or the other now will make someone unhappy. I think we have the best compromise here at this time. > Allowing only the root group settings seems the more logical path to me. I'm not sure I understand. Are you saying you want to codify this regression? > > Also: An empty root group won't show up (good), but an empty sub group will. I'd be happy to look at that after we get this cleared up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 --- Comment #7 from Kyle M Hall --- (In reply to Katrin Fischer from comment #3) > Hi Kyle, > > I have seen the issue on updating, but I am not able to create the first > setup from the GUI anymore, I only get the checkbox options when I am at > root level. I am not sure what the best solution is, changing the GUI to > allow for both or improving the update scripts? > > RootGroup > Searchgroup > > Can you take a look? Right, you only enable this at the root level. The idea is to have a single group per-feature. We definitely wouldn't want a given feature to be turned on or off in different subgroups of a root group. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 --- Comment #6 from Lisette Scheer --- If the decision is to allow root groups only, is there a way to give an option on subgroups for people to convert subgroups to root groups? If so, that would help people who have it set up in the original logic switch over without much trouble. Lisette -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 --- Comment #5 from Katrin Fischer --- I am still not sure if the fix is right :( My reasoning is that people might have added sub groups for organizing relying on the fact that they will not take effect. So changing it one way or the other now will make someone unhappy. Allowing only the root group settings seems the more logical path to me. Also: An empty root group won't show up (good), but an empty sub group will. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- Hi Kyle, I have seen the issue on updating, but I am not able to create the first setup from the GUI anymore, I only get the checkbox options when I am at root level. I am not sure what the best solution is, changing the GUI to allow for both or improving the update scripts? RootGroup Searchgroup Can you take a look? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 --- Comment #4 from Katrin Fischer --- Hm, I think I misread the test plan. So the 'attributes' are set top level and then inherited? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 Katrin Fischer changed: What|Removed |Added Version|unspecified |master CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 Joel Sasse changed: What|Removed |Added CC||jsa...@plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 Maryse Simard changed: What|Removed |Added Attachment #84209|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 84211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84211=edit Bug 22173: Search Groups broken by change in expected structure The original logic of Search Groups using the heirarchical library groups was to enable search groups on a root group and have each sub group be a search group listed in the pulldown: RootGroup: SearchGroup1: LibraryA LibraryB SearchGroup2: LibraryC LibraryD SearchGroup3: LibraryE LibraryF At some point, the code was changed to expect the each search group to be the root group: RootSearchGroup1: LibraryA LibraryB RootSearchGroup2: LibraryC LibraryD RootSearchGroup3: LibraryE LibraryF It's likely that both styles are being used in production now with different versions. If a library upgrades, their search groups will be broken. If we revert the change, currently up to date libraries will have search groups broken. Instead, we should accommodate both configurations. So, if a root group has libraries as direct children, it should be displayed as a search group. If it does not, we should display the child search groups instead. Test Plan: 1) Set up a root group with multiple subgroups each with libraries, enable staff and opac search groups for that root group 2) Note the root group is displayed in all the search pulldowns instead of the subgroups 3) Apply this patch 4) Restart all the things! 5) Note the search pulldowns now contain the subgroups instead 6) Create another root group, add only libraries to it. Set it as a search group for staff and opac. 7) Note the search pulldowns now contain this group as well! Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 --- Comment #1 from Kyle M Hall --- Created attachment 84209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84209=edit Bug 22173: Search Groups broken by change in expected structure The original logic of Search Groups using the heirarchical library groups was to enable search groups on a root group and have each sub group be a search group listed in the pulldown: RootGroup: SearchGroup1: LibraryA LibraryB SearchGroup2: LibraryC LibraryD SearchGroup3: LibraryE LibraryF At some point, the code was changed to expect the each search group to be the root group: RootSearchGroup1: LibraryA LibraryB RootSearchGroup2: LibraryC LibraryD RootSearchGroup3: LibraryE LibraryF It's likely that both styles are being used in production now with different versions. If a library upgrades, their search groups will be broken. If we revert the change, currently up to date libraries will have search groups broken. Instead, we should accommodate both configurations. So, if a root group has libraries as direct children, it should be displayed as a search group. If it does not, we should display the child search groups instead. Test Plan: 1) Set up a root group with multiple subgroups each with libraries, enable staff and opac search groups for that root group 2) Note the root group is displayed in all the search pulldowns instead of the subgroups 3) Apply this patch 4) Restart all the things! 5) Note the search pulldowns now contain the subgroups instead 6) Create another root group, add only libraries to it. Set it as a search group for staff and opac. 7) Note the search pulldowns now contain this group as well! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 Kyle M Hall changed: What|Removed |Added Assignee|oleon...@myacpl.org |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
