[Koha-bugs] [Bug 22193] Mana - share comments about reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 Josef Moravec changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #8 from Josef Moravec --- sorry, does not apply cleanly on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22193] Mana - share comments about reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 --- Comment #7 from Alex Arnaud --- Created attachment 90349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90349=edit Bug 22193: QA follow up - return undef instead of an array if no ressource id -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22193] Mana - share comments about reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 Alex Arnaud changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22193] Mana - share comments about reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193
--- Comment #6 from Josef Moravec ---
Comment on attachment 84650
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84650
Bug 22193: Code refactoring/improvments
Review of attachment 84650:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=22193=84650)
-
::: Koha/SharedContent.pm
@@ +141,5 @@
> +sub get_entity_comments {
> +my ($resource, $id) = @_;
> +
> +unless ($id) {
> +return [];
I would like to see here an implicit undef, so just 'return;'
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22193] Mana - share comments about reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22193] Mana - share comments about reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22193] Mana - share comments about reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 --- Comment #5 from Owen Leonard --- Created attachment 84651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84651=edit Bug 22193: Share report comments Test plan: - apply this patches, - download a report from Mana, - you should see a "Report mistake" button when you show, edit and run this report, - click on Report mistake -> New and type a comment, - check that it appears on the list, - reload the page, check the comment is still in the list, - click on Report mistake -> your comment, - ckeck the count has been incremented, - reload the page, the counter is still the same Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22193] Mana - share comments about reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 Owen Leonard changed: What|Removed |Added Attachment #84366|0 |1 is obsolete|| Attachment #84367|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 84650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84650=edit Bug 22193: Code refactoring/improvments Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22193] Mana - share comments about reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 Bug 22193 depends on bug 17047, which changed state. Bug 17047 Summary: Mana Knowledge Base : share data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22193] Mana - share comments about reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com --- Comment #3 from Michal Denar --- Hi Alex, last two lines on test plan don't work for me More than one comments https://screenshots.firefox.com/bUEQMVj2BDVcwhpJ/localhost After reload: back "New" https://screenshots.firefox.com/f65JRGJd5rayY6ll/localhost Mike -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22193] Mana - share comments about reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 Alex Arnaud changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22193] Mana - share comments about reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 --- Comment #2 from Alex Arnaud --- Created attachment 84367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84367=edit Bug 22193: Share report comments Test plan: - apply this patches, - download a report from Mana, - you should see a "Report mistake" button when you show, edit and run this report, - click on Report mistake -> New and type a comment, - check that it appears on the list, - reload the page, check the comment is still in the list, - click on Report mistake -> your comment, - ckeck the count has been incremented, - reload the page, the counter is still the same -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22193] Mana - share comments about reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 --- Comment #1 from Alex Arnaud --- Created attachment 84366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84366=edit Bug 22193: Code refactoring/improvments -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22193] Mana - share comments about reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 Alex Arnaud changed: What|Removed |Added Depends on||17047 Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
