[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable --- Comment #13 from Lucas Gass --- backported to 18.11.x for 18.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Fridolin SOMERS changed: What|Removed |Added Depends on||21078 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21078 [Bug 21078] Overdrive JS breaks when window opened from another site -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Fridolin SOMERS changed: What|Removed |Added Version(s)|19.11.00|19.11.00,19.05.05 released in|| CC||fridolin.som...@biblibre.co ||m Status|Pushed to master|Pushed to stable --- Comment #12 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 --- Comment #11 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Marcel de Rooy changed: What|Removed |Added Attachment #92633|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 93181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93181=edit Bug 22602: Fix OverDrive circulation when coming from another site On bug 21078 we caught an error and returned, this makes us skip some variable setting that we need. This patch moves that code into its own function. To test: 0 - Have OverDrive circulation setup and working 1 - Place a link to your kohadev installation on another site 2 - Follow that link to the opac 3 - Note all items show as 'Place hold' even if available copies 4 - Apply patch 5 - Repeat 1&2 6 - Note the items availability shows correctly Signed-off-by: Elizabeth Quinn Signed-off-by: Marcel de Rooy Looks good to me, but cannot test Overdrive. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 --- Comment #9 from Marcel de Rooy --- (In reply to Bouzid Fergani from comment #8) > Created attachment 92821 [details] [review] > Bug 23272: (RM followup) Fix failing tests > > This bug introduced a regression whereby if any authorized value has no > branch limitations then the authorized value administration page would > fail to display at all. > > A simple ternary corrects the issue, but I'm now wondering about the > logic of returning 'undef' from 'get_branch_limits'.. perhaps an empty > (or full) resultset might be a better option to prevent us from > requireing ternaries before calling chained methods on such objects. > > Signed-off-by: Martin Renvoize > Signed-off-by: Bouzid Fergani Bouzid: buy a new keyboard ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Marcel de Rooy changed: What|Removed |Added Attachment #92821|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 --- Comment #8 from Bouzid Fergani --- Created attachment 92821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92821=edit Bug 23272: (RM followup) Fix failing tests This bug introduced a regression whereby if any authorized value has no branch limitations then the authorized value administration page would fail to display at all. A simple ternary corrects the issue, but I'm now wondering about the logic of returning 'undef' from 'get_branch_limits'.. perhaps an empty (or full) resultset might be a better option to prevent us from requireing ternaries before calling chained methods on such objects. Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Nick Clemens changed: What|Removed |Added Attachment #92501|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 92633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92633=edit Bug 22602: Fix OverDrive circulation when coming from another site On bug 21078 we caught an error and returned, this makes us skip some variable setting that we need. This patch moves that code into its own function. To test: 0 - Have OverDrive circulation setup and working 1 - Place a link to your kohadev installation on another site 2 - Follow that link to the opac 3 - Note all items show as 'Place hold' even if available copies 4 - Apply patch 5 - Repeat 1&2 6 - Note the items availability shows correctly Signed-off-by: Elizabeth Quinn -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA CC||m.de.r...@rijksmuseum.nl --- Comment #6 from Marcel de Rooy --- From: root You might wanna fix that too ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- Is there any way to test this without an Overdrive account? Or way to get one for testing purposes? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 --- Comment #4 from Nick Clemens --- (In reply to Liz Rea from comment #2) > I was having trouble replicating the original problem, does it still happen > for you? > > Liz Yes, we still have libraries exhibiting this issue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Nick Clemens changed: What|Removed |Added Attachment #87352|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 92501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92501=edit Bug 22602: Fix OverDrive circulation when coming from another site On bug 21078 we caught an error and returned, this makes us skip some variable setting that we need. This patch moves that code into its own function. To test: 0 - Have OverDrive circulation setup and working 1 - Place a link to your kohadev installation on another site 2 - Follow that link to the opac 3 - Note all items show as 'Place hold' even if available copies 4 - Apply patch 5 - Repeat 1&2 6 - Note the items availability shows correctly Signed-off-by: Elizabeth Quinn -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #2 from Liz Rea --- I was having trouble replicating the original problem, does it still happen for you? Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 --- Comment #1 from Nick Clemens --- Created attachment 87352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87352=edit Bug 22602: Fix OverDrive circulation when coming from another site On bug 21078 we caught an error and returned, this makes us skip some variable setting that we need. This patch moves that code into its own function. To test: 0 - Have OverDrive circulation setup and working 1 - Place a link to your kohadev installation on another site 2 - Follow that link to the opac 3 - Note all items show as 'Place hold' even if available copies 4 - Apply patch 5 - Repeat 1&2 6 - Note the items availability shows correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Nick Clemens changed: What|Removed |Added Assignee|oleon...@myacpl.org |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
