[Koha-bugs] [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800 Bug 22800 depends on bug 22550, which changed state. Bug 22550 Summary: OPAC suggestion form doesn't require mandatory fields https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com Version(s)||19.05.00, 18.11.06 released in|| --- Comment #5 from Martin Renvoize --- Pushed to 18.11.x for 18.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800 Chris Cormack changed: What|Removed |Added Attachment #89325|0 |1 is obsolete|| --- Comment #3 from Chris Cormack --- Created attachment 89337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89337=edit Bug 22800: (bug 22550 follow-up) Do not raw filter when not necessary (OPAC suggestions) This is a follow-up for bug 22550, we do not need to use the $raw filter. Test plan: Same as bug 22550: Test plan: Test plan: 1. OPAC->login->your purchase suggestions->New purchase suggestion 2. Click button "Submit your suggestion" directly without filling in any field. Empty suggestion record was added succeffully. 3. Apply the patch. 4. Click button "Submit your suggestion" directly without filling in any field. The required fields should be labeled in red. (you can change the mandatory fields by preference 'OPACSuggestionMandatoryFields') Signed-off-by: Bin Wen Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800 Bin changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800 Bin changed: What|Removed |Added Attachment #88993|0 |1 is obsolete|| --- Comment #2 from Bin --- Created attachment 89325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89325=edit Bug 22800: (bug 22550 follow-up) Do not raw filter when not necessary (OPAC suggestions) This is a follow-up for bug 22550, we do not need to use the $raw filter. Test plan: Same as bug 22550: Test plan: Test plan: 1. OPAC->login->your purchase suggestions->New purchase suggestion 2. Click button "Submit your suggestion" directly without filling in any field. Empty suggestion record was added succeffully. 3. Apply the patch. 4. Click button "Submit your suggestion" directly without filling in any field. The required fields should be labeled in red. (you can change the mandatory fields by preference 'OPACSuggestionMandatoryFields') Signed-off-by: Bin Wen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800 --- Comment #1 from Jonathan Druart --- Created attachment 88993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88993=edit Bug 22800: (bug 22550 follow-up) Do not raw filter when not necessary (OPAC suggestions) This is a follow-up for bug 22550, we do not need to use the $raw filter. Test plan: Same as bug 22550: Test plan: Test plan: 1. OPAC->login->your purchase suggestions->New purchase suggestion 2. Click button "Submit your suggestion" directly without filling in any field. Empty suggestion record was added succeffully. 3. Apply the patch. 4. Click button "Submit your suggestion" directly without filling in any field. The required fields should be labeled in red. (you can change the mandatory fields by preference 'OPACSuggestionMandatoryFields') -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800 Jonathan Druart changed: What|Removed |Added Depends on||22550 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 [Bug 22550] OPAC suggestion form doesn't require mandatory fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
