[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #72 from Lucas Gass --- patchset does not apply clean to 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #71 from Jonathan Druart --- (In reply to Jonathan Druart from comment #69) > Created attachment 112824 [details] [review] > Bug 22806: Remove perlcritic errors > > Subroutine "new" called using indirect syntax at line 415, column 18. See > page 349 of PBP. (Severity: 4) > Subroutine "new" called using indirect syntax at line 420, column 14. See > page 349 of PBP. (Severity: 4) Pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #70 from Arthur Suzuki --- Yes! Thank you Jonathan! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #69 from Jonathan Druart --- Created attachment 112824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112824=edit Bug 22806: Remove perlcritic errors Subroutine "new" called using indirect syntax at line 415, column 18. See page 349 of PBP. (Severity: 4) Subroutine "new" called using indirect syntax at line 420, column 14. See page 349 of PBP. (Severity: 4) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #68 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #67 from Jonathan Druart --- (In reply to Martin Renvoize from comment #51) > I think you need to: > * add your new return value to the ENUM of failure reasons in > club_holds_to_patron_holds Isn't it still valid? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #66 from Arthur Suzuki --- thanks for the qa :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #65 from Nick Clemens --- This will change behaviour on staff side I believe - before there was no check of patron possession, but it is overrideable and so I believe is part of the bug fix, not a problem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Nick Clemens changed: What|Removed |Added Attachment #110973|0 |1 is obsolete|| --- Comment #61 from Nick Clemens --- Created attachment 111771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111771=edit Bug 22806: CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Signed-off-by: Laurence Rault Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Nick Clemens changed: What|Removed |Added Attachment #110975|0 |1 is obsolete|| --- Comment #63 from Nick Clemens --- Created attachment 111773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111773=edit Bug 22806: Unit Tests Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Nick Clemens changed: What|Removed |Added Attachment #110976|0 |1 is obsolete|| --- Comment #64 from Nick Clemens --- Created attachment 111774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111774=edit Bug 22806: (QA follow-up) Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Nick Clemens changed: What|Removed |Added Attachment #110974|0 |1 is obsolete|| --- Comment #62 from Nick Clemens --- Created attachment 111772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111772=edit Bug 22806: (follow-up) CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions As CanBookBeReserved() was failing as $patron and and $biblio were not instantiated I fixed that up. Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Sponsored-By: Catalyst IT Signed-off-by: Laurence Rault Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #60 from Arthur Suzuki --- (In reply to Katrin Fischer from comment #59) > Patches apply, tests pass. But I'd feel a bit better if someone else took a > look here. Martin or Nick, could you continue? Thanks to Katrin and the future second QA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #59 from Katrin Fischer --- Patches apply, tests pass. But I'd feel a bit better if someone else took a look here. Martin or Nick, could you continue? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Katrin Fischer changed: What|Removed |Added QA Contact|m.de.r...@rijksmuseum.nl|testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #58 from Arthur Suzuki --- (In reply to Martin Renvoize from comment #52) > Oh.. hang on.. it looks like Nick caught these issues too and there's > conversation about a QA followup patch.. but I'm not seeing it? I guess I did some mis-manipulation with git bz, it was in the obsoletes :) re-uploaded and did a rebase of the former patches on the way. hope it will be good enough this time! (yay, fingercrossed) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #56 from Arthur Suzuki --- Created attachment 110975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110975=edit Bug 22806: Unit Tests Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #57 from Arthur Suzuki --- Created attachment 110976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110976=edit Bug 22806: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #55 from Arthur Suzuki --- Created attachment 110974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110974=edit Bug 22806: (follow-up) CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions As CanBookBeReserved() was failing as $patron and and $biblio were not instantiated I fixed that up. Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Sponsored-By: Catalyst IT Signed-off-by: Laurence Rault Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki changed: What|Removed |Added Attachment #110100|0 |1 is obsolete|| Attachment #110101|0 |1 is obsolete|| Attachment #110102|0 |1 is obsolete|| --- Comment #54 from Arthur Suzuki --- Created attachment 110973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110973=edit Bug 22806: CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Signed-off-by: Laurence Rault Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #53 from Arthur Suzuki --- yup, still, thanks martin for the helpful technical advises. And thanks to both of you (nick, martin) for reviewing. I'll do the follow-up. Arthur -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #52 from Martin Renvoize --- Oh.. hang on.. it looks like Nick caught these issues too and there's conversation about a QA followup patch.. but I'm not seeing it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Failed QA --- Comment #51 from Martin Renvoize --- Sorry Arthur, I don't think you've accounted for the additional return status you've introduced in enough places. I think you need to: * add your new return value to the ENUM of failure reasons in club_holds_to_patron_holds * add handling for the new return value to reserve/placerequest.pl, reserve/request.pl and request.tt Failing QA for now.. good work in starting the move of these checks into a suitable level. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #50 from Arthur Suzuki --- Created attachment 110102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110102=edit Bug 22806: Unit Tests Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki changed: What|Removed |Added Attachment #106778|0 |1 is obsolete|| Attachment #106779|0 |1 is obsolete|| Attachment #106780|0 |1 is obsolete|| Attachment #107806|0 |1 is obsolete|| --- Comment #48 from Arthur Suzuki --- Created attachment 110100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110100=edit Bug 22806: CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Signed-off-by: Laurence Rault Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #49 from Arthur Suzuki --- Created attachment 110101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110101=edit Bug 22806: (follow-up) CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions As CanBookBeReserved() was failing as $patron and and $biblio were not instantiated I fixed that up. Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Sponsored-By: Catalyst IT Signed-off-by: Laurence Rault Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 David Nind changed: What|Removed |Added Text to go in the|Checks for the |This enhancement makes sure release notes|"AllowHoldOnPatronPossessio |that checks for the |n" policy is now even |"AllowHoldsOnPatronsPossess |across all interfaces |ions" policy is now made |(Staff, Opac, WebServices). |for all interfaces (Staff |Bypassing this policy from |interface, OPAC, |Staff interface needs to be |WebServices). Before this |enforced with |change it was not checked |"AllowHoldPolicyOverride" |for WebServices (ILS-DI). || ||"AllowHoldPolicyOverride" ||can be used to override ||this setting for the Staff ||interface. || ||Note: This ||enhancement introduces a ||behaviour change, so if you ||use either of these system ||preferences review the ||settings to make sure they ||work as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #47 from David Nind --- I tried to retest, but the patches no longer apply 8-( Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22806: CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Using index info to reconstruct a base tree... M C4/Reserves.pm Falling back to patching base and 3-way merge... Auto-merging C4/Reserves.pm Applying: Bug 22806: (follow-up) CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Applying: Bug 22806: Unit Tests Using index info to reconstruct a base tree... M t/db_dependent/ILSDI_Services.t M t/db_dependent/Reserves.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Reserves.t CONFLICT (content): Merge conflict in t/db_dependent/Reserves.t Auto-merging t/db_dependent/ILSDI_Services.t CONFLICT (content): Merge conflict in t/db_dependent/ILSDI_Services.t error: Failed to merge in the changes. Patch failed at 0001 Bug 22806: Unit Tests The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-22806-Unit-Tests-Z7uKNQ.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #46 from Magnus Enger --- Does this have to be "Needs Signoff" because of the QA followup patch, or can it go back to QA directly? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #45 from Magnus Enger --- (In reply to Arthur Suzuki from comment #43) > Made a text proposal on the appropriate field on bugzilla (in the mean time) I think that is the right thing to do. There are scripts that make sure "Text to go in the release notes" actually goes into the release notes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #44 from Magnus Enger --- *** Bug 24466 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #43 from Arthur Suzuki --- Made a text proposal on the appropriate field on bugzilla (in the mean time) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki changed: What|Removed |Added Text to go in the||Checks for the release notes||"AllowHoldOnPatronPossessio ||n" policy is now even ||across all interfaces ||(Staff, Opac, WebServices). ||Bypassing this policy from ||Staff interface needs to be ||enforced with ||"AllowHoldPolicyOverride" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #42 from Arthur Suzuki --- (In reply to Nick Clemens from comment #40) > Thanks Arthur! you're welcome Sir! > 1 - > With this patchset the message to the patron changes from" > This title cannot be requested because it's already in your possession. > To: > There are no items that can be placed on hold. > We should pass the exact reason if possible this problem has been addressed with new version of the qa patch :) > 2 - > On the staff side before these patches I am warned that patron has this in > possession, but I can still place the hold > After the patches I cannot place a hold unless AllowHoldPolicyOverride is set > This is probably appropriate, but it is a behaviour change and should be > noted in release notes hummm... I can see there is a folder called "misc/release_notes" but not sure which file is to be edited in there, if any. Some clue to get out of the glue? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki changed: What|Removed |Added Attachment #107760|0 |1 is obsolete|| --- Comment #41 from Arthur Suzuki --- Created attachment 107806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107806=edit Bug 22806: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #40 from Nick Clemens --- (In reply to Arthur Suzuki from comment #39) > (In reply to Nick Clemens from comment #37) > > This works as described, I do see that we have checks for this in reserve.pl > > and opac-reserve.pl - can they be removed now that they are being added to > > the modules? > > Indeed! Done in the QA patch :) Thanks Arthur! Two things I note: 1 - With this patchset the message to the patron changes from" This title cannot be requested because it's already in your possession. To: There are no items that can be placed on hold. We should pass the exact reason if possible 2 - On the staff side before these patches I am warned that patron has this in possession, but I can still place the hold After the patches I cannot place a hold unless AllowHoldPolicyOverride is set This is probably appropriate, but it is a behaviour change and should be noted in release notes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #39 from Arthur Suzuki --- (In reply to Nick Clemens from comment #37) > This works as described, I do see that we have checks for this in reserve.pl > and opac-reserve.pl - can they be removed now that they are being added to > the modules? Indeed! Done in the QA patch :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #38 from Arthur Suzuki --- Created attachment 107760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107760=edit Bug 22806: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #37 from Nick Clemens --- This works as described, I do see that we have checks for this in reserve.pl and opac-reserve.pl - can they be removed now that they are being added to the modules? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #36 from Arthur Suzuki --- yay, super thanks for signing off! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 David Nind changed: What|Removed |Added Attachment #100174|0 |1 is obsolete|| --- Comment #34 from David Nind --- Created attachment 106779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106779=edit Bug 22806: (follow-up) CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions As CanBookBeReserved() was failing as $patron and and $biblio were not instantiated I fixed that up. Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Sponsored-By: Catalyst IT Signed-off-by: Laurence Rault Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 David Nind changed: What|Removed |Added Attachment #100173|0 |1 is obsolete|| --- Comment #33 from David Nind --- Created attachment 106778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106778=edit Bug 22806: CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Signed-off-by: Laurence Rault Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 David Nind changed: What|Removed |Added Attachment #106564|0 |1 is obsolete|| --- Comment #35 from David Nind --- Created attachment 106780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106780=edit Bug 22806: Unit Tests Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #32 from Arthur Suzuki --- added some tests to C4/Reserves as well :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki changed: What|Removed |Added Attachment #100175|0 |1 is obsolete|| --- Comment #31 from Arthur Suzuki --- Created attachment 106564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106564=edit Bug 22806: Unit Tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki changed: What|Removed |Added Summary|HoldTitle and HoldItem do |CanBookBeReserve and |not check |CanItemBeReserve do not |AllowHoldsOnPatronsPossessi |check |ons |AllowHoldsOnPatronsPossessi ||ons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
