[Koha-bugs] [Bug 22905] Cannot upate the status of suggestions if the branchcode filter is set to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 Marcel de Rooy changed: What|Removed |Added Attachment #89884|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Cannot upate the status of suggestions if the branchcode filter is set to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 --- Comment #16 from Marcel de Rooy --- (In reply to Liz Rea from comment #15) > Well, I'm going to say I've signed off Jonathan's, it fixes the problem and > I prefer the approach there. > > I'd like to get this fixed and we have a patch, let's have another QA person > look at it and decide. > > Liz Dont worry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Cannot upate the status of suggestions if the branchcode filter is set to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 --- Comment #15 from Liz Rea --- Well, I'm going to say I've signed off Jonathan's, it fixes the problem and I prefer the approach there. I'd like to get this fixed and we have a patch, let's have another QA person look at it and decide. Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Cannot upate the status of suggestions if the branchcode filter is set to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 --- Comment #14 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #13) > I think my patch is much more regression proof. Sure. Any dev should be convinced of that ;) > I do not trust yours. Good to hear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Cannot upate the status of suggestions if the branchcode filter is set to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 --- Comment #13 from Jonathan Druart --- I think my patch is much more regression proof. It makes the code does what it must do. There are much more variables in the filters that have the same name: budgetid, title, etc. I wanted to provide a patch in which we can trust. I do not trust yours, because I did not spend 2 hours to make sure there are no more bugs (interference with variable's name). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Cannot upate the status of suggestions if the branchcode filter is set to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #12 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #1) > All this code is awful, I have no idea how to fix it simply and without > introduce regressions. Yes, this definitely is horrible. I suggest a simpler fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Cannot upate the status of suggestions if the branchcode filter is set to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 --- Comment #11 from Marcel de Rooy --- Created attachment 89884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89884=edit Bug 22905: Counterpatch removing just branchcode The suggested patches replace using $suggestion_only, making much more changes than needed. I would opt for removing the offending branchcode. In this case __ANY__. Apart from strict SQL mode, it is just wrong. This patch touches just one line. Same test plan. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Cannot upate the status of suggestions if the branchcode filter is set to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 Liz Rea changed: What|Removed |Added Attachment #89868|0 |1 is obsolete|| --- Comment #9 from Liz Rea --- Created attachment 89870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89870=edit Bug 22905: Fix update of suggestion's status if branchcode filter is 'all' Because of the "Library" filter on the left of the "Suggestions management" screen, there is something wrong happening: 1. Create a suggestion from library A, login from library B 2. Go to Home › Acquisitions › Suggestions management => The suggestion does not appear - OK 3. In the filter on the left, select "all library" => The suggestion appears on the pending tab - KO 4. Select the suggestion and mark is as 'Accepted' => The suggestion still appears on the pending tab - Failure The log says: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`suggestions`, CONSTRAINT `suggestions_ibfk_branchcode` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE SET NULL ON UPDATE CASCADE) [for Statement "UPDATE `suggestions` SET `accepteddate` = ?, `branchcode` = ?, `currency` = ?, `manageddate` = ?, `price` = ?, `reason` = ?, `suggesteddate` = ?, `total` = ? WHERE ( `suggestionid` = ? )" with ParamValues: 0='2019-05-14T15:48:18', 1="", 2="CAD", 3='2019-05-14T15:48:18', 4="0.00", 5="", 6='2019-05-14T00:00:00', 7="0.00", 8=3] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. Let forget what could have happened earlier in the script and do it the regular way, from $input. Then call ModSuggestion with only what we need. Test plan: Confirm that the steps described before work as expected once this patch is applied Signed-off-by: Liz Rea https://bugs.koha-community.org/show_bug.cgi?id=22907 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Cannot upate the status of suggestions if the branchcode filter is set to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 --- Comment #10 from Liz Rea --- Created attachment 89871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89871=edit Bug 22905: (QA follow-up) remove bad warn Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Cannot upate the status of suggestions if the branchcode filter is set to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Cannot upate the status of suggestions if the branchcode filter is set to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Cannot upate the status of suggestions if the branchcode filter is set to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 Jonathan Druart changed: What|Removed |Added Attachment #89828|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 89868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89868=edit Bug 22905: Fix update of suggestion's status if branchcode filter is 'all' Because of the "Library" filter on the left of the "Suggestions management" screen, there is something wrong happening: 1. Create a suggestion from library A, login from library B 2. Go to Home › Acquisitions › Suggestions management => The suggestion does not appear - OK 3. In the filter on the left, select "all library" => The suggestion appears on the pending tab - KO 4. Select the suggestion and mark is as 'Accepted' => The suggestion still appears on the pending tab - Failure The log says: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`suggestions`, CONSTRAINT `suggestions_ibfk_branchcode` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE SET NULL ON UPDATE CASCADE) [for Statement "UPDATE `suggestions` SET `accepteddate` = ?, `branchcode` = ?, `currency` = ?, `manageddate` = ?, `price` = ?, `reason` = ?, `suggesteddate` = ?, `total` = ? WHERE ( `suggestionid` = ? )" with ParamValues: 0='2019-05-14T15:48:18', 1="", 2="CAD", 3='2019-05-14T15:48:18', 4="0.00", 5="", 6='2019-05-14T00:00:00', 7="0.00", 8=3] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. Let forget what could have happened earlier in the script and do it the regular way, from $input. Then call ModSuggestion with only what we need. Test plan: Confirm that the steps described before work as expected once this patch is applied -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Cannot upate the status of suggestions if the branchcode filter is set to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 Jonathan Druart changed: What|Removed |Added Summary|Edit suggestions - wrong|Cannot upate the status of |branchcode behavior |suggestions if the ||branchcode filter is set to ||all -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
