[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2020-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18895

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2020-01-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

--- Comment #22 from Aleisha Amohia  ---
I have opened Bug 24474 depending on this one to fix the bug that this has
caused.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2020-01-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||24474


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474
[Bug 24474] Lost items that are checked out are always returned
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2020-01-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

--- Comment #21 from Aleisha Amohia  ---
Hey all, this patch is causing problems for some of our libraries because it's
been assumed that lost items with no attached charge should automatically be
returned. 

This is not always the desired behaviour - we have one case where the library
wants to keep lost items on a patron's record, and another case where a checked
out lost item will be renewed, but the amount outstanding is zero, so the item
gets returned.

These are edge cases, but the assumptions in this patch do not consider them,
and are causing problems. Is there a workaround? Or perhaps a better way of
doing this patch that can allow for the cases of 'renewing a lost item' or
'wanting to keep a lost item on the checkouts record'? A solution that avoids
doing circulation actions in the accounts modules as this patch does would be
ideal.

Aleisha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-06-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Fridolin SOMERS  changed:

   What|Removed |Added

 Version(s)|19.11.00|19.11.00,19.05.01
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to Master|Pushed to Stable

--- Comment #20 from Fridolin SOMERS  ---
Pushed to 19.05.x for 19.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-06-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||22563


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563
[Bug 22563] Convert lost handling to use 'status' instead of multiple
accounttypes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-06-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Martin Renvoize  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=22563   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-06-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-06-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

--- Comment #19 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-06-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

--- Comment #18 from Martin Renvoize  ---
Note to self.. this will conflict quietly with 22563 when it is pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-06-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22563

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-06-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #17 from Martin Renvoize  ---
I'm pretty happy with this one now, it all works for me, passes QA scripts and
I can't see any regressions.

Thanks Kyle, Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-06-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|tomasco...@gmail.com|martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-06-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #90243|0   |1
is obsolete||

--- Comment #14 from Martin Renvoize  ---
Created attachment 90327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90327=edit
Bug 22982: Paying lost fee does not always remove lost item from checkouts

Depending on how a lost fee is paid, it may or may not be removed from the
patrons current checkouts. The current expected behavior is for the lost
item to be removed from the patrons checkouts when the lost fee is paid in
full.

This is due to the subroutine for handling of lost fees being included in
the 'pay specific lines' code but not in the 'pay by amount' code.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Account.t

Signed-off-by: Liz Rea 
Signed-off-by: Nadine Pierre 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-06-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #90245|0   |1
is obsolete||

--- Comment #16 from Martin Renvoize  ---
Created attachment 90329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90329=edit
Bug 22982: (QA follow-up) Add behavior to Koha::Account::Line::apply and unit
test

Signed-off-by: Nadine Pierre 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-06-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #90244|0   |1
is obsolete||

--- Comment #15 from Martin Renvoize  ---
Created attachment 90328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90328=edit
Bug 22982: Add unit tests

Signed-off-by: Liz Rea 
Signed-off-by: Nadine Pierre 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-06-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19919

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Nadine Pierre  changed:

   What|Removed |Added

 CC||nadine.pie...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Nadine Pierre  changed:

   What|Removed |Added

  Attachment #90050|0   |1
is obsolete||

--- Comment #11 from Nadine Pierre  ---
Created attachment 90243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90243=edit
Bug 22982: Paying lost fee does not always remove lost item from checkouts

Depending on how a lost fee is paid, it may or may not be removed from the
patrons current checkouts. The current expected behavior is for the lost item
to be removed from the patrons checkouts when the lost fee is paid in full.

This is due to the subroutine for handling of lost fees being included in the
'pay specific lines' code but not in the 'pay by amount' code.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Account.t

Signed-off-by: Liz Rea 
Signed-off-by: Nadine Pierre 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Nadine Pierre  changed:

   What|Removed |Added

  Attachment #90051|0   |1
is obsolete||

--- Comment #12 from Nadine Pierre  ---
Created attachment 90244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90244=edit
Bug 22982: Add unit tests

Signed-off-by: Liz Rea 
Signed-off-by: Nadine Pierre 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Nadine Pierre  changed:

   What|Removed |Added

  Attachment #90152|0   |1
is obsolete||

--- Comment #13 from Nadine Pierre  ---
Created attachment 90245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90245=edit
Bug 22982: (QA follow-up) Add behavior to Koha::Account::Line::apply and unit
test

Signed-off-by: Nadine Pierre 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #10 from Kyle M Hall  ---
> I am having some doubts too on cases where $fine->amountoutstanding >
> $balance_remaining in the first edit. $new_amountoutstanding may not be zero.

In cases where $new_amountoutstanding is not zero, we should *not* remove the
item from the patron's checkouts. We should only do so once the entire fee is
paid off. If you feel otherwise please give specific details that I can act on.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Failed QA

--- Comment #9 from Marcel de Rooy  ---
(In reply to Martin Renvoize from comment #5)
> This doesn't feel like it'll catch all cases.. especially as some things
> have already started to move to using the ->apply routines.
> 
> I should probably help to fold this into the rest of the accounts tree
> that's been growing again of late.

Martin: Please have another look too.
I am having some doubts too on cases where $fine->amountoutstanding >
$balance_remaining in the first edit. $new_amountoutstanding may not be zero.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

--- Comment #8 from Kyle M Hall  ---
Created attachment 90152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90152=edit
Bug 22982: (QA follow-up) Add behavior to Koha::Account::Line::apply and unit
test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Kyle M Hall  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #7 from Kyle M Hall  ---
*** Bug 21042 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Andrew  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #6 from Andrew  ---
Is this a dupe of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21042?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

--- Comment #5 from Martin Renvoize  ---
This doesn't feel like it'll catch all cases.. especially as some things have
already started to move to using the ->apply routines.

I should probably help to fold this into the rest of the accounts tree that's
been growing again of late.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com, tomasco...@gmail.com
 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Tomás Cohen Arazi  changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

--- Comment #4 from Liz Rea  ---
Created attachment 90051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90051=edit
Bug 22982: Add unit tests

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Liz Rea  changed:

   What|Removed |Added

  Attachment #90046|0   |1
is obsolete||
  Attachment #90047|0   |1
is obsolete||

--- Comment #3 from Liz Rea  ---
Created attachment 90050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90050=edit
Bug 22982: Paying lost fee does not always remove lost item from checkouts

Depending on how a lost fee is paid, it may or may not be removed from the
patrons current checkouts. The current expected behavior is for the lost item
to be removed from the patrons checkouts when the lost fee is paid in full.

This is due to the subroutine for handling of lost fees being included in the
'pay specific lines' code but not in the 'pay by amount' code.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Account.t

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

rkui...@roundrocktexas.gov changed:

   What|Removed |Added

 CC||rkui...@roundrocktexas.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

--- Comment #2 from Kyle M Hall  ---
Created attachment 90047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90047=edit
Bug 22982: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

--- Comment #1 from Kyle M Hall  ---
Created attachment 90046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90046=edit
Bug 22982: Paying lost fee does not always remove lost item from checkouts

Depending on how a lost fee is paid, it may or may not be removed from the
patrons current checkouts. The current expected behavior is for the lost item
to be removed from the patrons checkouts when the lost fee is paid in full.

This is due to the subroutine for handling of lost fees being included in the
'pay specific lines' code but not in the 'pay by amount' code.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Account.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost item from checkouts

2019-05-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/