[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable --- Comment #13 from Lucas Gass --- backported to 18.11.x for 18.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 Fridolin SOMERS changed: What|Removed |Added Version(s)|19.11.00|19.11.00,19.05.05 released in|| Status|Pushed to master|Pushed to stable --- Comment #12 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 --- Comment #11 from Katrin Fischer --- Thx a lot, Frido! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 --- Comment #9 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #10 from Martin Renvoize --- Followup pushed, thanks Fridolin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 --- Comment #8 from Fridolin SOMERS --- Created attachment 93864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93864=edit Bug 23101: (follow-up) use NoSort class in datatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 --- Comment #7 from Fridolin SOMERS --- Confirmed on irc, we need to use a class for no-sorting. I'm on a patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101
Fridolin SOMERS changed:
What|Removed |Added
CC||fridolin.som...@biblibre.co
||m
--- Comment #6 from Fridolin SOMERS ---
I'm sure about :
+[% IF CAN_user_acquisition_contracts_manage %]
{ "aTargets": [ -1 ], "bSortable": false, "bSearchable":
false },
+[% ELSE %]
+{ "bSortable": false, "bSearchable": false },
+[% END %]
{ "sType": "title-string", "aTargets" : [ "title-string" ]
}
Shouldn't we remove the all line instead of only "aTargets" ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 Marcel de Rooy changed: What|Removed |Added Attachment #93053|0 |1 is obsolete|| --- Comment #4 from Marcel de Rooy --- Created attachment 93185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93185=edit Bug 23101: Hide action buttons on contracts if user lacks permission When the user doesn't have superlibrarian, full acq or contracts_manage permission, don't show buttons for editing and deleting contracts. To test: - Create a vendor with a few contracts - Create a staff user with - superlibrarian = can view edit/delete contracts - full acq perms = same - without manage_contracts = can view, but action buttons are gone - Make sure the sorting of the contracts table works in all cases Signed-off-by: hc Signed-off-by: Bouzid Fergani Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 Bouzid Fergani changed: What|Removed |Added Attachment #92729|0 |1 is obsolete|| --- Comment #3 from Bouzid Fergani --- Created attachment 93053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93053=edit Bug 23101: Hide action buttons on contracts if user lacks permission When the user doesn't have superlibrarian, full acq or contracts_manage permission, don't show buttons for editing and deleting contracts. To test: - Create a vendor with a few contracts - Create a staff user with - superlibrarian = can view edit/delete contracts - full acq perms = same - without manage_contracts = can view, but action buttons are gone - Make sure the sorting of the contracts table works in all cases Signed-off-by: hc Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 Holly changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||h...@interleaf.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 ByWater Sandboxes changed: What|Removed |Added Attachment #91510|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 92729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92729=edit Bug 23101: Hide action buttons on contracts if user lacks permission When the user doesn't have superlibrarian, full acq or contracts_manage permission, don't show buttons for editing and deleting contracts. To test: - Create a vendor with a few contracts - Create a staff user with - superlibrarian = can view edit/delete contracts - full acq perms = same - without manage_contracts = can view, but action buttons are gone - Make sure the sorting of the contracts table works in all cases Signed-off-by: hc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 Katrin Fischer changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 --- Comment #1 from Katrin Fischer --- Created attachment 91510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91510=edit Bug 23101: Hide action buttons on contracts if user lacks permission When the user doesn't have superlibrarian, full acq or contracts_manage permission, don't show buttons for editing and deleting contracts. To test: - Create a vendor with a few contracts - Create a staff user with - superlibrarian = can view edit/delete contracts - full acq perms = same - without manage_contracts = can view, but action buttons are gone - Make sure the sorting of the contracts table works in all cases -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 Katrin Fischer changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | CC||katrin.fisc...@bsz-bw.de Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 Mohamad Barham changed: What|Removed |Added CC||mbar...@birzeit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
