[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Nick Clemens changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #87 from Joy Nelson --- new feature not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #86 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Nick Clemens changed: What|Removed |Added Attachment #100225|0 |1 is obsolete|| --- Comment #84 from Nick Clemens --- Created attachment 100262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100262=edit Bug 23112: (follow-up) Unit test fixes As requested by Nick, fixes unit tests and added a test for the new Koha::Illrequest::biblio method Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Nick Clemens changed: What|Removed |Added Attachment #100108|0 |1 is obsolete|| --- Comment #82 from Nick Clemens --- Created attachment 100260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100260=edit Bug 23112: (QA follow-up) Fix database update, add filters, remove tabs Looks like the atomicupdate and sysprefs.sql changes were lost at some point. Don't forget to run QA tools on your patches before submitting Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Nick Clemens changed: What|Removed |Added Attachment #100224|0 |1 is obsolete|| --- Comment #83 from Nick Clemens --- Created attachment 100261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100261=edit Bug 23112: (follow-up) Conditionally prevent checkout As mentioned by Nick in comment #69, the checkout button displays even for requests without a biblio attached (such as chapters). This patch fixes that. https://bugs.koha-community.org/show_bug.cgi?id=23112 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #85 from Nick Clemens --- Created attachment 100263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100263=edit Bug 23112: (QA follow-up) Clean up tests, catch warnings Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Nick Clemens changed: What|Removed |Added Attachment #100107|0 |1 is obsolete|| --- Comment #81 from Nick Clemens --- Created attachment 100259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100259=edit Bug 23112: (follow-up) Fix test as per feedback As per comment #48 https://bugs.koha-community.org/show_bug.cgi?id=23113 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Nick Clemens changed: What|Removed |Added Attachment #100105|0 |1 is obsolete|| --- Comment #79 from Nick Clemens --- Created attachment 100257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100257=edit Bug 23112: (follow-up) Call C4::Koha::GetAuthorisedValues In response to the problem Magnus was experiencing in comment #28 & #29 we now call GetAuthorisedValues by it's full path Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Nick Clemens changed: What|Removed |Added Attachment #100104|0 |1 is obsolete|| --- Comment #78 from Nick Clemens --- Created attachment 100256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100256=edit Bug 23112: Add unit tests This patch adds unit test for the new Koha::Illrequest::check_out method Sponsored-by: Loughborough University Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Nick Clemens changed: What|Removed |Added Attachment #100102|0 |1 is obsolete|| --- Comment #76 from Nick Clemens --- Created attachment 100254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100254=edit Bug 23112: Add permission checks We only want the ILL circulation functionality to be available if the appropriate syspref and perm are available, this patch adds those checks. Sponsored-by: Loughborough University Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Nick Clemens changed: What|Removed |Added Attachment #100103|0 |1 is obsolete|| --- Comment #77 from Nick Clemens --- Created attachment 100255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100255=edit Bug 23112: Update request status on return This patch updates a request's status to RET upon return Sponsored-by: Loughborough University Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Nick Clemens changed: What|Removed |Added Attachment #100106|0 |1 is obsolete|| --- Comment #80 from Nick Clemens --- Created attachment 100258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100258=edit Bug 23112: (follow-up) Address QA feedback As per comment #46 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Nick Clemens changed: What|Removed |Added Attachment #100100|0 |1 is obsolete|| --- Comment #74 from Nick Clemens --- Created attachment 100252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100252=edit Bug 23112: Add CirculateILL syspref Sponsored-by: Loughborough University Signed-off-by: Chris Walton https://bugs.koha-community.org/show_bug.cgi?id=23112 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Nick Clemens changed: What|Removed |Added Attachment #100101|0 |1 is obsolete|| --- Comment #75 from Nick Clemens --- Created attachment 100253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100253=edit Bug 23112: Add circulation to ILL requests This patch adds the ability to circulate ILL requests. Once a request has a suitable status, a "Check out" button is displayed on the "Manage request" toolbar. Clicking this will enable the user to check out the item either to the user who made the request or an in-house statistical user. A due date can be specified, but if not circ rules are used. Prior to the check out, an item is created which is attached to the biblio record that was created when the request was added This development has been carried out according to the originally stated requirements of the customer that sponsored it, detailed here: https://wiki.koha-community.org/wiki/ILL_Circulation_RFC Test plan: 1. Ensure the FreeForm ILL backend is available 2. Enable the "CirculateILL" syspref 3. Ensure you have a statistical patron category defined (patron category type "Statistical") 4. Ensure you have at least one patron in your statistical patron category 5. Create a new FreeForm request (make a note of the library you select when creating it) 6. Mark the new request as confirmed by clicking the "Confirm request" button on the "Manage ILL request" page 7. TEST: Observe that a "Check out" button is now displayed in the request toolbar 8. Click the "Check out" button in the "Manage ILL request" page 9. In the "Issue requested item to..." screen: a. Do not select a statistical patron at this time b. You can at this point choose an item type, this will determine the type of the item that will be created for this request c. TEST: Observe that the default selected "Library" matches that that was defined when creating the request d. Do not select a due date at this time 10. Click "Submit" 11. TEST: Observe that the "Item checked out" screen displays, issued to the requesting patron with a due date corresponding to appropriate circ rules 12. Click "Return to request" 13. TEST: Observe that the request's status is now "Checked out" 14. Click the "Bibliographic record ID" link 15. TEST: Observe that the bibliographic record now has one item attached to it which is checked out 16. TEST: Observe that the item barcode is "ILL-" + the ILL request ID 17. Return to step 5., however, this time select a statistical patron and test that the item use is recorded and the item is not issued 18. Return to step 5., however, this time manually select a due date and test that the item's due date is set correctly on check out 19. Check in the item 20. TEST: Observe that the request's status is updated to "Returned to library" 21. Now implement a restriction on the patron (perhaps a fine) which would prevent them from checking out an item 22. Return to step 5. follow the instructions to step 10. 23. TEST: Observe that a banner is displayed at the top of the screen informing you that there was a problem checking the item out, containing a link to the patron's account page 24. Resolve the problem with the patron's account 25. Return to step 8. 26. TEST: Observe that the item is now successfully checked out 27. Disable the "CirculateILL" syspref 28. Return to step 5. at step 7. Observe that the "Check out" button is NOT displayed Sponsored-by: Loughborough University Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #100169|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #73 from Andrew Isherwood --- Created attachment 100225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100225=edit Bug 23112: (follow-up) Unit test fixes As requested by Nick, fixes unit tests and added a test for the new Koha::Illrequest::biblio method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #72 from Andrew Isherwood --- Created attachment 100224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100224=edit Bug 23112: (follow-up) Conditionally prevent checkout As mentioned by Nick in comment #69, the checkout button displays even for requests without a biblio attached (such as chapters). This patch fixes that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #71 from Andrew Isherwood --- Created attachment 100169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100169=edit Bug 23051: (follow-up) Conditionally prevent checkout As mentioned by Nick in comment #69, the checkout button displays even for requests without a biblio attached (such as chapters). This patch fixes that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #70 from Andrew Isherwood --- Thanks for this Nick, it is much appreciated. Many thanks for the follow up, I do wish my editor would not randomly switch to tabs sometimes! Good point about the Checkout button, I'll create a follow up shortly and re-submit :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #68 from Nick Clemens --- Created attachment 100108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100108=edit Bug 23112: (QA follow-up) Fix database update, add filters, remove tabs Looks like the atomicupdate and sysprefs.sql changes were lost at some point. Don't forget to run QA tools on your patches before submitting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #66 from Nick Clemens --- Created attachment 100106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100106=edit Bug 23112: (follow-up) Address QA feedback As per comment #46 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #69 from Nick Clemens --- This all works as expected and is a great enhancement. I added a follow-up to address a few minor issues. The one complaint I have is that if I create a 'chapter' request there is no biblio created but I still get a 'checkout' button on the request, but have no way to attach/create a biblio - we should not show the button in this case -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #67 from Nick Clemens --- Created attachment 100107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100107=edit Bug 23112: (follow-up) Fix test as per feedback As per comment #48 https://bugs.koha-community.org/show_bug.cgi?id=23113 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #64 from Nick Clemens --- Created attachment 100104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100104=edit Bug 23112: Add unit tests This patch adds unit test for the new Koha::Illrequest::check_out method Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #65 from Nick Clemens --- Created attachment 100105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100105=edit Bug 23112: (follow-up) Call C4::Koha::GetAuthorisedValues In response to the problem Magnus was experiencing in comment #28 & #29 we now call GetAuthorisedValues by it's full path -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #61 from Nick Clemens --- Created attachment 100101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100101=edit Bug 23112: Add circulation to ILL requests This patch adds the ability to circulate ILL requests. Once a request has a suitable status, a "Check out" button is displayed on the "Manage request" toolbar. Clicking this will enable the user to check out the item either to the user who made the request or an in-house statistical user. A due date can be specified, but if not circ rules are used. Prior to the check out, an item is created which is attached to the biblio record that was created when the request was added This development has been carried out according to the originally stated requirements of the customer that sponsored it, detailed here: https://wiki.koha-community.org/wiki/ILL_Circulation_RFC Test plan: 1. Ensure the FreeForm ILL backend is available 2. Enable the "CirculateILL" syspref 3. Ensure you have a statistical patron category defined (patron category type "Statistical") 4. Ensure you have at least one patron in your statistical patron category 5. Create a new FreeForm request (make a note of the library you select when creating it) 6. Mark the new request as confirmed by clicking the "Confirm request" button on the "Manage ILL request" page 7. TEST: Observe that a "Check out" button is now displayed in the request toolbar 8. Click the "Check out" button in the "Manage ILL request" page 9. In the "Issue requested item to..." screen: a. Do not select a statistical patron at this time b. You can at this point choose an item type, this will determine the type of the item that will be created for this request c. TEST: Observe that the default selected "Library" matches that that was defined when creating the request d. Do not select a due date at this time 10. Click "Submit" 11. TEST: Observe that the "Item checked out" screen displays, issued to the requesting patron with a due date corresponding to appropriate circ rules 12. Click "Return to request" 13. TEST: Observe that the request's status is now "Checked out" 14. Click the "Bibliographic record ID" link 15. TEST: Observe that the bibliographic record now has one item attached to it which is checked out 16. TEST: Observe that the item barcode is "ILL-" + the ILL request ID 17. Return to step 5., however, this time select a statistical patron and test that the item use is recorded and the item is not issued 18. Return to step 5., however, this time manually select a due date and test that the item's due date is set correctly on check out 19. Check in the item 20. TEST: Observe that the request's status is updated to "Returned to library" 21. Now implement a restriction on the patron (perhaps a fine) which would prevent them from checking out an item 22. Return to step 5. follow the instructions to step 10. 23. TEST: Observe that a banner is displayed at the top of the screen informing you that there was a problem checking the item out, containing a link to the patron's account page 24. Resolve the problem with the patron's account 25. Return to step 8. 26. TEST: Observe that the item is now successfully checked out 27. Disable the "CirculateILL" syspref 28. Return to step 5. at step 7. Observe that the "Check out" button is NOT displayed Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #63 from Nick Clemens --- Created attachment 100103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100103=edit Bug 23112: Update request status on return This patch updates a request's status to RET upon return Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #62 from Nick Clemens --- Created attachment 100102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100102=edit Bug 23112: Add permission checks We only want the ILL circulation functionality to be available if the appropriate syspref and perm are available, this patch adds those checks. Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Nick Clemens changed: What|Removed |Added Attachment #99910|0 |1 is obsolete|| Attachment #99911|0 |1 is obsolete|| Attachment #99912|0 |1 is obsolete|| Attachment #99913|0 |1 is obsolete|| Attachment #99914|0 |1 is obsolete|| Attachment #99915|0 |1 is obsolete|| Attachment #99916|0 |1 is obsolete|| Attachment #99917|0 |1 is obsolete|| --- Comment #60 from Nick Clemens --- Created attachment 100100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100100=edit Bug 23112: Add CirculateILL syspref Sponsored-by: Loughborough University Signed-off-by: Chris Walton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #59 from Andrew Isherwood --- Needed rebase due to dependent patch in bug 23384 changing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #96834|0 |1 is obsolete|| --- Comment #57 from Andrew Isherwood --- Created attachment 99916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99916=edit Bug 23112: (follow-up) Address QA feedback As per comment #46 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #95567|0 |1 is obsolete|| --- Comment #53 from Andrew Isherwood --- Created attachment 99912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99912=edit Bug 23112: Add permission checks We only want the ILL circulation functionality to be available if the appropriate syspref and perm are available, this patch adds those checks. Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #96870|0 |1 is obsolete|| --- Comment #58 from Andrew Isherwood --- Created attachment 99917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99917=edit Bug 23112: (follow-up) Fix test as per feedback As per comment #48 https://bugs.koha-community.org/show_bug.cgi?id=23113 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #95570|0 |1 is obsolete|| --- Comment #56 from Andrew Isherwood --- Created attachment 99915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99915=edit Bug 23112: (follow-up) Call C4::Koha::GetAuthorisedValues In response to the problem Magnus was experiencing in comment #28 & #29 we now call GetAuthorisedValues by it's full path -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #95568|0 |1 is obsolete|| --- Comment #54 from Andrew Isherwood --- Created attachment 99913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99913=edit Bug 23112: Update request status on return This patch updates a request's status to RET upon return Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #95569|0 |1 is obsolete|| --- Comment #55 from Andrew Isherwood --- Created attachment 99914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99914=edit Bug 23112: Add unit tests This patch adds unit test for the new Koha::Illrequest::check_out method Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #95565|0 |1 is obsolete|| --- Comment #51 from Andrew Isherwood --- Created attachment 99910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99910=edit Bug 23112: Add CirculateILL syspref Sponsored-by: Loughborough University Signed-off-by: Chris Walton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #95566|0 |1 is obsolete|| --- Comment #52 from Andrew Isherwood --- Created attachment 99911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99911=edit Bug 23112: Add circulation to ILL requests This patch adds the ability to circulate ILL requests. Once a request has a suitable status, a "Check out" button is displayed on the "Manage request" toolbar. Clicking this will enable the user to check out the item either to the user who made the request or an in-house statistical user. A due date can be specified, but if not circ rules are used. Prior to the check out, an item is created which is attached to the biblio record that was created when the request was added Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #50 from Andrew Isherwood ---
(In reply to Jonathan Druart from comment #48)
> (In reply to Andrew Isherwood from comment #46)
> > > ::: Koha/Illrequest.pm
> > > @@ +1211,5 @@
> > > > +# For some reason, AddIssue requires an unblessed Patron
> > > > +$issue_args[0] = $patron->unblessed;
> > > > +my $issue = C4::Circulation::AddIssue(@issue_args);
> > > > +
> > > > +if ($issue && %{$issue}) {
> > >
> > > AddIssue return a Koha::Checkout object. The test will work but I think
> > > it's
> > > confusing.
> >
> > Do you mean the variable name $issue is confusing? If so, I thought it made
> > sense since the function returning it is called AddIssue and, internally,
> > AddIssue also calls the returned value $issue.
>
> You should only test for $issue, the "&& %$issue" does not make sense to me.
I've now attached a patch to address this. I'm puzzled why I did this extra
test, it seems like the sort of thing that would be deliberate. Looking at
AddIssue, I can't see a case where an empty hashref could be returned, so I'm
not sure why I would have added this extra test. Anyway, thanks for pointing it
out Jonathan.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #49 from Andrew Isherwood --- Created attachment 96870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96870=edit Bug 23112: (follow-up) Fix test as per feedback As per comment #48 https://bugs.koha-community.org/show_bug.cgi?id=23113 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #48 from Jonathan Druart
---
(In reply to Andrew Isherwood from comment #46)
> > ::: Koha/Illrequest.pm
> > @@ +1211,5 @@
> > > +# For some reason, AddIssue requires an unblessed Patron
> > > +$issue_args[0] = $patron->unblessed;
> > > +my $issue = C4::Circulation::AddIssue(@issue_args);
> > > +
> > > +if ($issue && %{$issue}) {
> >
> > AddIssue return a Koha::Checkout object. The test will work but I think it's
> > confusing.
>
> Do you mean the variable name $issue is confusing? If so, I thought it made
> sense since the function returning it is called AddIssue and, internally,
> AddIssue also calls the returned value $issue.
You should only test for $issue, the "&& %$issue" does not make sense to me.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #46 from Andrew Isherwood ---
(In reply to Jonathan Druart from comment #45)
> Comment on attachment 95566 [details] [review]
> Bug 23112: Add circulation to ILL requests
>
> Review of attachment 95566 [details] [review]:
> -
>
> Also, I think you should use patron-title.inc to display patron's info.
Aha, good spot, thanks! I'm about to add a patch to address that.
>
> ::: Koha/Illrequest.pm
> @@ +1211,5 @@
> > +# For some reason, AddIssue requires an unblessed Patron
> > +$issue_args[0] = $patron->unblessed;
> > +my $issue = C4::Circulation::AddIssue(@issue_args);
> > +
> > +if ($issue && %{$issue}) {
>
> AddIssue return a Koha::Checkout object. The test will work but I think it's
> confusing.
Do you mean the variable name $issue is confusing? If so, I thought it made
sense since the function returning it is called AddIssue and, internally,
AddIssue also calls the returned value $issue.
>
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
> @@ +704,4 @@
> >
> > [% INCLUDE 'ill-list-table-strings.inc' %]
> > [% Asset.js("js/ill-list-table.js") | $raw %]
> > +[% Asset.js("js/ill-check-out.js") | $raw %]
>
> Where does this file come from?
Another good spot, this include was leftover junk from an earlier attempt at
this bug. About to attach a patch that removes this include.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #47 from Andrew Isherwood --- Created attachment 96834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96834=edit Bug 23112: (follow-up) Address QA feedback As per comment #46 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #45 from Jonathan Druart
---
Comment on attachment 95566
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95566
Bug 23112: Add circulation to ILL requests
Review of attachment 95566:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=23112=95566)
-
Also, I think you should use patron-title.inc to display patron's info.
::: Koha/Illrequest.pm
@@ +1211,5 @@
> +# For some reason, AddIssue requires an unblessed Patron
> +$issue_args[0] = $patron->unblessed;
> +my $issue = C4::Circulation::AddIssue(@issue_args);
> +
> +if ($issue && %{$issue}) {
AddIssue return a Koha::Checkout object. The test will work but I think it's
confusing.
::: koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
@@ +704,4 @@
>
> [% INCLUDE 'ill-list-table-strings.inc' %]
> [% Asset.js("js/ill-list-table.js") | $raw %]
> +[% Asset.js("js/ill-check-out.js") | $raw %]
Where does this file come from?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #94268|0 |1 is obsolete|| --- Comment #43 from Andrew Isherwood --- Created attachment 95569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95569=edit Bug 23112: Add unit tests This patch adds unit test for the new Koha::Illrequest::check_out method Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #94267|0 |1 is obsolete|| --- Comment #42 from Andrew Isherwood --- Created attachment 95568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95568=edit Bug 23112: Update request status on return This patch updates a request's status to RET upon return Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #94269|0 |1 is obsolete|| --- Comment #44 from Andrew Isherwood --- Created attachment 95570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95570=edit Bug 23112: (follow-up) Call C4::Koha::GetAuthorisedValues In response to the problem Magnus was experiencing in comment #28 & #29 we now call GetAuthorisedValues by it's full path -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #94266|0 |1 is obsolete|| --- Comment #41 from Andrew Isherwood --- Created attachment 95567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95567=edit Bug 23112: Add permission checks We only want the ILL circulation functionality to be available if the appropriate syspref and perm are available, this patch adds those checks. Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #94264|0 |1 is obsolete|| --- Comment #39 from Andrew Isherwood --- Created attachment 95565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95565=edit Bug 23112: Add CirculateILL syspref Sponsored-by: Loughborough University Signed-off-by: Chris Walton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #94265|0 |1 is obsolete|| --- Comment #40 from Andrew Isherwood --- Created attachment 95566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95566=edit Bug 23112: Add circulation to ILL requests This patch adds the ability to circulate ILL requests. Once a request has a suitable status, a "Check out" button is displayed on the "Manage request" toolbar. Clicking this will enable the user to check out the item either to the user who made the request or an in-house statistical user. A due date can be specified, but if not circ rules are used. Prior to the check out, an item is created which is attached to the biblio record that was created when the request was added Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #93534|0 |1 is obsolete|| --- Comment #37 from Andrew Isherwood --- Created attachment 94268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94268=edit Bug 23112: Add unit tests This patch adds unit test for the new Koha::Illrequest::check_out method Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #93958|0 |1 is obsolete|| --- Comment #38 from Andrew Isherwood --- Created attachment 94269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94269=edit Bug 23112: (follow-up) Call C4::Koha::GetAuthorisedValues In response to the problem Magnus was experiencing in comment #28 & #29 we now call GetAuthorisedValues by it's full path -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #93531|0 |1 is obsolete|| --- Comment #34 from Andrew Isherwood --- Created attachment 94265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94265=edit Bug 23112: Add circulation to ILL requests This patch adds the ability to circulate ILL requests. Once a request has a suitable status, a "Check out" button is displayed on the "Manage request" toolbar. Clicking this will enable the user to check out the item either to the user who made the request or an in-house statistical user. A due date can be specified, but if not circ rules are used. Prior to the check out, an item is created which is attached to the biblio record that was created when the request was added Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #93533|0 |1 is obsolete|| --- Comment #36 from Andrew Isherwood --- Created attachment 94267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94267=edit Bug 23112: Update request status on return This patch updates a request's status to RET upon return Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #93530|0 |1 is obsolete|| --- Comment #33 from Andrew Isherwood --- Created attachment 94264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94264=edit Bug 23112: Add CirculateILL syspref Sponsored-by: Loughborough University Signed-off-by: Chris Walton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #93532|0 |1 is obsolete|| --- Comment #35 from Andrew Isherwood --- Created attachment 94266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94266=edit Bug 23112: Add permission checks We only want the ILL circulation functionality to be available if the appropriate syspref and perm are available, this patch adds those checks. Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #32 from Andrew Isherwood --- Created attachment 93958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93958=edit Bug 23112: (follow-up) Call C4::Koha::GetAuthorisedValues In response to the problem Magnus was experiencing in comment #28 & #29 we now call GetAuthorisedValues by it's full path -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #31 from Andrew Isherwood --- Hi Magnus I just managed to replicate this on one of our test instances which is running plack, so I'm wondering if it's a plack thing. I've learnt the hard way not to try and understand why plack does what it does, so I'm just going to create a patch now which will just explicity import GetAuthorisedValues and hope that'll keep plack happy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #30 from Andrew Isherwood --- Hi Magnus I've just applied this bug on current master and cannot replicate either of these problems, I've just run through the whole test plan without a problem. The error you're seeing is weird, it's not aware that GetAuthorisedValues should be coming from C4::Koha, it's trying to find it in Illrequest::Logger. I'm "use"ing C4::Koha, but not explicitly importing GetAuthorisedValues, which shouldn't be necessary since it's exported by C4::Koha. This is done all over the place in Koha, so you should be seeing this problem everywhere. Explicitly importing GetAuthorisedValues would fix it, but that feels like a hack, I'd rather know why it's not being imported by default. Any chance you could try again? It could I suppose have been a merge problem, I'd like to eliminate that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Magnus Enger changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #29 from Magnus Enger --- Same thing happes when I go to "View ILL requests" an then click on "Manage request": Template process failed: undef error - Undefined subroutine ::Illrequest::Logger::GetAuthorisedValues called at /home/vagrant/kohaclone/Koha/Illrequest/Logger.pm line 213. at /home/vagrant/kohaclone/C4/Templates.pm line 122 Again, it does not happen on master without the current patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #28 from Magnus Enger --- Thanks for fixing the number the applicability! Sorry, I get an error on step 5: "Create a new FreeForm request": Template process failed: undef error - Undefined subroutine ::Illrequest::Logger::GetAuthorisedValues called at /home/vagrant/kohaclone/Koha/Illrequest/Logger.pm line 213. at /home/vagrant/kohaclone/C4/Templates.pm line 122 This happens when I click on "New ILL request", fill in the form an click on "Create". It does not happen on current master. It does seem weird though, since the patches on the current bug do not seem to touch Koha/Illrequest/Logger.pm? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #27 from Andrew Isherwood --- Thanks for that Magnus, the bug number is now fixed, as it the failure to apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #92004|0 |1 is obsolete|| --- Comment #26 from Andrew Isherwood --- Created attachment 93534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93534=edit Bug 23112: Add unit tests This patch adds unit test for the new Koha::Illrequest::check_out method Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #92002|0 |1 is obsolete|| --- Comment #24 from Andrew Isherwood --- Created attachment 93532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93532=edit Bug 23112: Add permission checks We only want the ILL circulation functionality to be available if the appropriate syspref and perm are available, this patch adds those checks. Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #92003|0 |1 is obsolete|| --- Comment #25 from Andrew Isherwood --- Created attachment 93533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93533=edit Bug 23112: Update request status on return This patch updates a request's status to RET upon return Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #92000|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #92001|0 |1 is obsolete|| --- Comment #23 from Andrew Isherwood --- Created attachment 93531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93531=edit Bug 23112: Add circulation to ILL requests This patch adds the ability to circulate ILL requests. Once a request has a suitable status, a "Check out" button is displayed on the "Manage request" toolbar. Clicking this will enable the user to check out the item either to the user who made the request or an in-house statistical user. A due date can be specified, but if not circ rules are used. Prior to the check out, an item is created which is attached to the biblio record that was created when the request was added Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #22 from Andrew Isherwood --- Created attachment 93530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93530=edit Bug 23112: Add CirculateILL syspref Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #21 from Magnus Enger --- (In reply to Magnus Enger from comment #20) > (In reply to Andrew Isherwood from comment #15) > > Created attachment 92000 [details] [review] [review] > > Bug 23122: Add CirculateILL syspref > > > > Sponsored-by: Loughborough University > > There is a typo in the bug number. It should be 23112, not 23122. Never mind, looks like I can fix it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #20 from Magnus Enger --- (In reply to Andrew Isherwood from comment #15) > Created attachment 92000 [details] [review] > Bug 23122: Add CirculateILL syspref > > Sponsored-by: Loughborough University There is a typo in the bug number. It should be 23112, not 23122. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Christopher Davis changed: What|Removed |Added CC||cgda...@uintah.utah.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #91991|0 |1 is obsolete|| --- Comment #19 from Andrew Isherwood --- Created attachment 92004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92004=edit Bug 23112: Add unit tests This patch adds unit test for the new Koha::Illrequest::check_out method Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #91989|0 |1 is obsolete|| --- Comment #17 from Andrew Isherwood --- Created attachment 92002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92002=edit Bug 23112: Add permission checks We only want the ILL circulation functionality to be available if the appropriate syspref and perm are available, this patch adds those checks. Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #91990|0 |1 is obsolete|| --- Comment #18 from Andrew Isherwood --- Created attachment 92003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92003=edit Bug 23112: Update request status on return This patch updates a request's status to RET upon return Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #91988|0 |1 is obsolete|| --- Comment #16 from Andrew Isherwood --- Created attachment 92001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92001=edit Bug 23112: Add circulation to ILL requests This patch adds the ability to circulate ILL requests. Once a request has a suitable status, a "Check out" button is displayed on the "Manage request" toolbar. Clicking this will enable the user to check out the item either to the user who made the request or an in-house statistical user. A due date can be specified, but if not circ rules are used. Prior to the check out, an item is created which is attached to the biblio record that was created when the request was added Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Attachment #91987|0 |1 is obsolete|| --- Comment #15 from Andrew Isherwood --- Created attachment 92000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92000=edit Bug 23122: Add CirculateILL syspref Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #14 from Andrew Isherwood --- This development has been carried out according to the originally stated requirements of the customer that sponsored it, detailed here: https://wiki.koha-community.org/wiki/ILL_Circulation_RFC Test plan: 1. Ensure the FreeForm ILL backend is available 2. Enable the "CirculateILL" syspref 3. Ensure you have a statistical patron category defined (patron category type "Statistical") 4. Ensure you have at least one patron in your statistical patron category 5. Create a new FreeForm request (make a note of the library you select when creating it) 6. Mark the new request as confirmed by clicking the "Confirm request" button on the "Manage ILL request" page 7. TEST: Observe that a "Check out" button is now displayed in the request toolbar 8. Click the "Check out" button in the "Manage ILL request" page 9. In the "Issue requested item to..." screen: a. Do not select a statistical patron at this time b. You can at this point choose an item type, this will determine the type of the item that will be created for this request c. TEST: Observe that the default selected "Library" matches that that was defined when creating the request d. Do not select a due date at this time 10. Click "Submit" 11. TEST: Observe that the "Item checked out" screen displays, issued to the requesting patron with a due date corresponding to appropriate circ rules 12. Click "Return to request" 13. TEST: Observe that the request's status is now "Checked out" 14. Click the "Bibliographic record ID" link 15. TEST: Observe that the bibliographic record now has one item attached to it which is checked out 16. TEST: Observe that the item barcode is "ILL-" + the ILL request ID 17. Return to step 5., however, this time select a statistical patron and test that the item use is recorded and the item is not issued 18. Return to step 5., however, this time manually select a due date and test that the item's due date is set correctly on check out 19. Check in the item 20. TEST: Observe that the request's status is updated to "Returned to library" 21. Now implement a restriction on the patron (perhaps a fine) which would prevent them from checking out an item 22. Return to step 5. follow the instructions to step 10. 23. TEST: Observe that a banner is displayed at the top of the screen informing you that there was a problem checking the item out, containing a link to the patron's account page 24. Resolve the problem with the patron's account 25. Return to step 8. 26. TEST: Observe that the item is now successfully checked out 27. Disable the "CirculateILL" syspref 28. Return to step 5. at step 7. Observe that the "Check out" button is NOT displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #10 from Andrew Isherwood --- Created attachment 91988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91988=edit Bug 23112: Add circulation to ILL requests This patch adds the ability to circulate ILL requests. Once a request has a suitable status, a "Check out" button is displayed on the "Manage request" toolbar. Clicking this will enable the user to check out the item either to the user who made the request or an in-house statistical user. A due date can be specified, but if not circ rules are used. Prior to the check out, an item is created which is attached to the biblio record that was created when the request was added -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #9 from Andrew Isherwood --- Created attachment 91987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91987=edit Bug 23122: Add CirculateILL syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #11 from Andrew Isherwood --- Created attachment 91989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91989=edit Bug 23112: Add permission checks We only want the ILL circulation functionality to be available if the appropriate syspref and perm are available, this patch adds those checks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #12 from Andrew Isherwood --- Created attachment 91990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91990=edit Bug 23112: Update request status on return This patch updates a request's status to RET upon return -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #13 from Andrew Isherwood --- Created attachment 91991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91991=edit Bug 23112: Add unit tests This patch adds unit test for the new Koha::Illrequest::check_out method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Depends on||23384 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384 [Bug 23384] Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Depends on|22818 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 [Bug 22818] ILL should be able to send notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Depends on|23336 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 [Bug 23336] Add an API endpoint for issuing an item to a patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What|Removed |Added Depends on||22818, 23336 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 [Bug 22818] ILL should be able to send notices https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 [Bug 23336] Add an API endpoint for issuing an item to a patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #8 from Martin Renvoize --- It's on the wiki -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer --- Can the alternative be shared? There seemed to be agreement on this one (see dicussion on wiki and comments here) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #6 from Martin Renvoize --- An alternative specification has been sent to the customer and agreed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Martin Renvoize changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Niamh changed: What|Removed |Added CC||niamh.walker-headon@it-tall ||aght.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Jonathan Field changed: What|Removed |Added CC||jonathan.field@ptfs-europe. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #5 from Lisette Scheer --- (In reply to Martin Renvoize from comment #3) > (In reply to Lisette Scheer from comment #1) > > In the Step: Places a hold on the item for the patron and marks it ready for > > collection, I'd like to recommend a preference if it marks it as available > > for pickup. > > Happy to add a preference, though I do wonder how the item is then meant to > get to 'ready for collection'? > If a hold is still placed for the patron, the hold could be captured by checking the item in, perhaps a place hold and marks it ready for collection button and a separate place hold button where they would have to scan it in again to mark the hold ready? That would solve both issues I brought up in my comment. Lisette -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
