[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415
--- Comment #97 from Emmi Takkinen ---
(In reply to Martin Renvoize from comment #96)
> This is really close.. but.. May I ask why you chose to handle this at the
> controller level rather than adding/moving the check into CanBookBeRenewed?
>
> I see you do handle it in the _CanBookBeAutoRenewed version, but I think I
> am confused that it's not there in parent function.
Hmm, do you mean why there is a line my
>$fine_no_renewals = C4::Context->preference("FineNoRenewals");
(and everything after that line) in _CanBookBeAutoRenewed? Those have been
added in different bug, I just renamed syspref from "OPACFineNoRenewals" ->
"FineNoRenewals".
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31427 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #96 from Martin Renvoize --- This is really close.. but.. May I ask why you chose to handle this at the controller level rather than adding/moving the check into CanBookBeRenewed? I see you do handle it in the _CanBookBeAutoRenewed version, but I think I am confused that it's not there in parent function. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #95 from Martin Renvoize --- Created attachment 162180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162180=edit Bug 23415: (QA follow-up) Fix rebase code re-introduction Looks like some code was re-introduced during rebases, this patch switches it back to calling the newly introduced 'renew' function rather than doing the post inline. I also compared the two posts and updated the function to match the updated post from upstream. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #94 from Martin Renvoize --- Created attachment 162179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162179=edit Bug 23415: (QA follow-up) Spelling and price formatting Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #93 from Martin Renvoize --- Created attachment 162178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162178=edit Bug 23415: Tidy template parameters block Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #92 from Martin Renvoize --- Created attachment 162177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162177=edit Bug 23415: (QA follow-up) Remove OPACFineNoRenewals from syspres.sql Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize changed: What|Removed |Added Attachment #161969|0 |1 is obsolete|| --- Comment #91 from Martin Renvoize --- Created attachment 162176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162176=edit Bug 23415: Add fine formatting To test: 1. Find patron with checkouts and fines over allowed limit. 2. Renew checkouts either from renew page or checkout list. => Confirm that fines are formated correctly e.g. "The patron has a debt of 20.00" not like "The patron has a debt of 20." Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize changed: What|Removed |Added Attachment #161968|0 |1 is obsolete|| --- Comment #90 from Martin Renvoize --- Created attachment 162175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162175=edit Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize changed: What|Removed |Added Attachment #161967|0 |1 is obsolete|| --- Comment #89 from Martin Renvoize --- Created attachment 162174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162174=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin Signed-off-by: Petro Vashchuk Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize changed: What|Removed |Added Attachment #161966|0 |1 is obsolete|| --- Comment #88 from Martin Renvoize --- Created attachment 162173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162173=edit Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Signed-off-by: Petro Vashchuk Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize changed: What|Removed |Added Attachment #161965|0 |1 is obsolete|| --- Comment #87 from Martin Renvoize --- Created attachment 162172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162172=edit Bug 23415: Add missing filters Signed-off-by: Kelly McElligott Signed-off-by: Petro Vashchuk Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize changed: What|Removed |Added Attachment #161964|0 |1 is obsolete|| --- Comment #86 from Martin Renvoize --- Created attachment 162171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162171=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman Signed-off-by: Kelly McElligott Signed-off-by: Petro Vashchuk Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #85 from Emmi Takkinen --- Rebased patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #158307|0 |1 is obsolete|| --- Comment #84 from Emmi Takkinen --- Created attachment 161969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161969=edit Bug 23415: Add fine formatting To test: 1. Find patron with checkouts and fines over allowed limit. 2. Renew checkouts either from renew page or checkout list. => Confirm that fines are formated correctly e.g. "The patron has a debt of 20.00" not like "The patron has a debt of 20." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #158306|0 |1 is obsolete|| --- Comment #83 from Emmi Takkinen --- Created attachment 161968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161968=edit Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #158305|0 |1 is obsolete|| --- Comment #82 from Emmi Takkinen --- Created attachment 161967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161967=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #158304|0 |1 is obsolete|| --- Comment #81 from Emmi Takkinen --- Created attachment 161966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161966=edit Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #158303|0 |1 is obsolete|| --- Comment #80 from Emmi Takkinen --- Created attachment 161965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161965=edit Bug 23415: Add missing filters Signed-off-by: Kelly McElligott Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #158302|0 |1 is obsolete|| --- Comment #79 from Emmi Takkinen --- Created attachment 161964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161964=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman Signed-off-by: Kelly McElligott Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #78 from Kyle M Hall --- Applying: Bug 23415: Rename OPACFineNoRenewals error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref). error: could not build fake ancestor Patch failed at 0001 Bug 23415: Rename OPACFineNoRenewals -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #77 from Emmi Takkinen --- Rebased patches. Setting this back to "Signed Off". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #154600|0 |1 is obsolete|| --- Comment #76 from Emmi Takkinen --- Created attachment 158307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158307=edit Bug 23415: Add fine formatting To test: 1. Find patron with checkouts and fines over allowed limit. 2. Renew checkouts either from renew page or checkout list. => Confirm that fines are formated correctly e.g. "The patron has a debt of 20.00" not like "The patron has a debt of 20." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #154599|0 |1 is obsolete|| --- Comment #75 from Emmi Takkinen --- Created attachment 158306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158306=edit Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #154598|0 |1 is obsolete|| --- Comment #74 from Emmi Takkinen --- Created attachment 158305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158305=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #154597|0 |1 is obsolete|| --- Comment #73 from Emmi Takkinen --- Created attachment 158304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158304=edit Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #154596|0 |1 is obsolete|| --- Comment #72 from Emmi Takkinen --- Created attachment 158303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158303=edit Bug 23415: Add missing filters Signed-off-by: Kelly McElligott Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #154595|0 |1 is obsolete|| --- Comment #71 from Emmi Takkinen --- Created attachment 158302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158302=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman Signed-off-by: Kelly McElligott Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||martin.renvoize@ptfs-europe ||.com --- Comment #70 from Martin Renvoize --- Sorry guys, came to QA but we need a rebase first. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Veli-Matti Häkkinen changed: What|Removed |Added CC||veli-matti.hakki...@jyu.fi Status|Needs Signoff |Signed Off --- Comment #69 from Veli-Matti Häkkinen --- Tested and works as planned. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Biblibre Sandboxes changed: What|Removed |Added Attachment #152781|0 |1 is obsolete|| --- Comment #68 from Biblibre Sandboxes --- Created attachment 154600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154600=edit Bug 23415: Add fine formatting To test: 1. Find patron with checkouts and fines over allowed limit. 2. Renew checkouts either from renew page or checkout list. => Confirm that fines are formated correctly e.g. "The patron has a debt of 20.00" not like "The patron has a debt of 20." Signed-off-by: Veli-Matti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Biblibre Sandboxes changed: What|Removed |Added Attachment #152780|0 |1 is obsolete|| --- Comment #67 from Biblibre Sandboxes --- Created attachment 154599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154599=edit Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t Signed-off-by: Veli-Matti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Biblibre Sandboxes changed: What|Removed |Added Attachment #152779|0 |1 is obsolete|| --- Comment #66 from Biblibre Sandboxes --- Created attachment 154598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154598=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin Signed-off-by: Petro Vashchuk Signed-off-by: Veli-Matti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Biblibre Sandboxes changed: What|Removed |Added Attachment #152778|0 |1 is obsolete|| --- Comment #65 from Biblibre Sandboxes --- Created attachment 154597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154597=edit Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Signed-off-by: Petro Vashchuk Signed-off-by: Veli-Matti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Biblibre Sandboxes changed: What|Removed |Added Attachment #152777|0 |1 is obsolete|| --- Comment #64 from Biblibre Sandboxes --- Created attachment 154596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154596=edit Bug 23415: Add missing filters Signed-off-by: Kelly McElligott Signed-off-by: Petro Vashchuk Signed-off-by: Veli-Matti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Biblibre Sandboxes changed: What|Removed |Added Attachment #152776|0 |1 is obsolete|| --- Comment #63 from Biblibre Sandboxes --- Created attachment 154595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154595=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman Signed-off-by: Kelly McElligott Signed-off-by: Petro Vashchuk Signed-off-by: Veli-Matti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #62 from Emmi Takkinen --- Rebased patches. (In reply to Sally from comment #54) > Works as described; it shows for me as FineNoRenewals. I've signed off > because all of the functionality is fine. > > There were a couple of formatting issues around the currency in the pop-up > box: > > 1) The trailing full stop / period feels a bit odd when it's currency: > Shows: The patron has a debt of 3.21. > Perhaps: The patron has a debt of 3.21 > > 2) If it's a round number, then pennies/cents aren't shown - it looks a bit > odd: > Shows: The patron has a debt of 3. > Perhaps: The patron has a debt of 3.00 > These have been added in new patch. > 3) Is there any scope for adding the appropriate currency symbol? > Shows: The patron has a debt of 3.21 > Perhaps: The patron has a debt of £3.21 > And: The patron has a debt of $3.21 > And: The patron has a debt of €3.21 > This isn't currently possible so I left this out. > The other query was system preferences. > > OPACFineNoRenewals has been renamed to FineNoRenewals. > There are two other system preferences: OPACFineNoRenewalsBlockAutoRenew > and OPACFineNoRenewalsIncludeCredits > > The descriptions (values) of these have been updated by this bug to refer to > FineNoRenewals, but should we also consider renaming the system preferences > themselves to: FineNoRenewalsBlockAutoRenew and > FineNoRenewalsIncludeCredits ? > > I realise this last point might be out of scope of the bug. Hmm, I'm not sure if these are still used just in OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #61 from Emmi Takkinen --- Created attachment 152781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152781=edit Bug 23415: Add fine formatting To test: 1. Find patron with checkouts and fines over allowed limit. 2. Renew checkouts either from renew page or checkout list. => Confirm that fines are formated correctly e.g. "The patron has a debt of 20.00" not like "The patron has a debt of 20." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #148202|0 |1 is obsolete|| --- Comment #60 from Emmi Takkinen --- Created attachment 152780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152780=edit Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #148201|0 |1 is obsolete|| --- Comment #59 from Emmi Takkinen --- Created attachment 152779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152779=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #148200|0 |1 is obsolete|| --- Comment #58 from Emmi Takkinen --- Created attachment 152778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152778=edit Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #148199|0 |1 is obsolete|| --- Comment #57 from Emmi Takkinen --- Created attachment 152777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152777=edit Bug 23415: Add missing filters Signed-off-by: Kelly McElligott Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #148198|0 |1 is obsolete|| --- Comment #56 from Emmi Takkinen --- Created attachment 152776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152776=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman Signed-off-by: Kelly McElligott Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Katrin Fischer changed: What|Removed |Added QA Contact|k...@bywatersolutions.com |testo...@bugs.koha-communit ||y.org Status|Signed Off |Patch doesn't apply --- Comment #55 from Katrin Fischer --- Can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23415: Notify patron fines when renewing Applying: Bug 23415: Add missing filters Applying: Bug 23415: Use OPACFineNoRenewals instead of noissuecharge error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt). error: could not build fake ancestor Patch failed at 0001 Bug 23415: Use OPACFineNoRenewals instead of noissuecharge hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-23415-Use-OPACFineNoRenewals-instead-of-noissu-dlItcl.patch Please also check the fine formatting as noted by Sally in comment#54. There is now also a way to format in JS afaik. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk Status|Needs Signoff |Signed Off --- Comment #54 from Sally --- Works as described; it shows for me as FineNoRenewals. I've signed off because all of the functionality is fine. There were a couple of formatting issues around the currency in the pop-up box: 1) The trailing full stop / period feels a bit odd when it's currency: Shows: The patron has a debt of 3.21. Perhaps: The patron has a debt of 3.21 2) If it's a round number, then pennies/cents aren't shown - it looks a bit odd: Shows: The patron has a debt of 3. Perhaps: The patron has a debt of 3.00 3) Is there any scope for adding the appropriate currency symbol? Shows: The patron has a debt of 3.21 Perhaps: The patron has a debt of £3.21 And: The patron has a debt of $3.21 And: The patron has a debt of €3.21 The other query was system preferences. OPACFineNoRenewals has been renamed to FineNoRenewals. There are two other system preferences: OPACFineNoRenewalsBlockAutoRenew and OPACFineNoRenewalsIncludeCredits The descriptions (values) of these have been updated by this bug to refer to FineNoRenewals, but should we also consider renaming the system preferences themselves to: FineNoRenewalsBlockAutoRenew and FineNoRenewalsIncludeCredits ? I realise this last point might be out of scope of the bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 ByWater Sandboxes changed: What|Removed |Added Attachment #146415|0 |1 is obsolete|| --- Comment #53 from ByWater Sandboxes --- Created attachment 148202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148202=edit Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 ByWater Sandboxes changed: What|Removed |Added Attachment #139673|0 |1 is obsolete|| --- Comment #52 from ByWater Sandboxes --- Created attachment 148201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148201=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin Signed-off-by: Petro Vashchuk Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 ByWater Sandboxes changed: What|Removed |Added Attachment #139672|0 |1 is obsolete|| --- Comment #51 from ByWater Sandboxes --- Created attachment 148200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148200=edit Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Signed-off-by: Petro Vashchuk Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 ByWater Sandboxes changed: What|Removed |Added Attachment #139671|0 |1 is obsolete|| --- Comment #50 from ByWater Sandboxes --- Created attachment 148199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148199=edit Bug 23415: Add missing filters Signed-off-by: Kelly McElligott Signed-off-by: Petro Vashchuk Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 ByWater Sandboxes changed: What|Removed |Added Attachment #139670|0 |1 is obsolete|| --- Comment #49 from ByWater Sandboxes --- Created attachment 148198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148198=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman Signed-off-by: Kelly McElligott Signed-off-by: Petro Vashchuk Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #48 from Emmi Takkinen --- (In reply to Laura Escamilla from comment #46) > The test plan still works but OPACFineNoRenewals is still showing as > OPACFineNoRenewals and not FineNoRenewals. > > > > (In reply to Emmi Takkinen from comment #45) > > Created attachment 139674 [details] [review] [review] > > Bug 23415: Rename OPACFineNoRenewals > > > > OPACFineNoRenewals no longer applies just to OPAC. > > To avoid confusion rename it as FineNoRenewals and > > also rename all occurences in code. > > > > To test, confirm everything works as described in > > previous test plans. > > > > Also prove t/db_dependent/Circulation.t I rebased patch and added new atomicupdate file. Could it be that patch didn't previously apply? Was syspref still named as OPACFineNoRenewals in systempreference page or was it still OPACFineNoRenewals in database and code? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #139674|0 |1 is obsolete|| --- Comment #47 from Emmi Takkinen --- Created attachment 146415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146415=edit Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Laura changed: What|Removed |Added CC||Laura.escamilla@bywatersolu ||tions.com --- Comment #46 from Laura --- The test plan still works but OPACFineNoRenewals is still showing as OPACFineNoRenewals and not FineNoRenewals. (In reply to Emmi Takkinen from comment #45) > Created attachment 139674 [details] [review] > Bug 23415: Rename OPACFineNoRenewals > > OPACFineNoRenewals no longer applies just to OPAC. > To avoid confusion rename it as FineNoRenewals and > also rename all occurences in code. > > To test, confirm everything works as described in > previous test plans. > > Also prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #121472|0 |1 is obsolete|| --- Comment #45 from Emmi Takkinen --- Created attachment 139674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139674=edit Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #119303|0 |1 is obsolete|| --- Comment #44 from Emmi Takkinen --- Created attachment 139673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139673=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #119302|0 |1 is obsolete|| --- Comment #43 from Emmi Takkinen --- Created attachment 139672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139672=edit Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #119301|0 |1 is obsolete|| --- Comment #42 from Emmi Takkinen --- Created attachment 139671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139671=edit Bug 23415: Add missing filters Signed-off-by: Kelly McElligott Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #119300|0 |1 is obsolete|| --- Comment #41 from Emmi Takkinen --- Created attachment 139670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139670=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman Signed-off-by: Kelly McElligott Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Danyon Sewell changed: What|Removed |Added CC||danyonsew...@catalyst.net.n ||z Status|Needs Signoff |Patch doesn't apply --- Comment #40 from Danyon Sewell --- Patch doesn't apply. Please rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #39 from Emmi Takkinen --- Created attachment 121472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121472=edit Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #38 from Emmi Takkinen --- (In reply to Kyle M Hall from comment #37) > I think OPACFineNoRenewals needs to be renamed to FineNoRenewals or > something along those lines to prevent confusion in the future. Makes sense...maybe it should also be moved from OPAC preferences to Circulation preferences. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA CC||k...@bywatersolutions.com --- Comment #37 from Kyle M Hall --- I think OPACFineNoRenewals needs to be renamed to FineNoRenewals or something along those lines to prevent confusion in the future. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #118177|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Peter Vashchuk changed: What|Removed |Added Attachment #118183|0 |1 is obsolete|| --- Comment #36 from Peter Vashchuk --- Created attachment 119303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119303=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #35 from Peter Vashchuk --- Created attachment 119302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119302=edit Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Peter Vashchuk changed: What|Removed |Added Attachment #118176|0 |1 is obsolete|| --- Comment #34 from Peter Vashchuk --- Created attachment 119301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119301=edit Bug 23415: Add missing filters Signed-off-by: Kelly McElligott Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Peter Vashchuk changed: What|Removed |Added Attachment #118175|0 |1 is obsolete|| --- Comment #33 from Peter Vashchuk --- Created attachment 119300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119300=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman Signed-off-by: Kelly McElligott Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Stina Hallin changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Lund University Sandbox changed: What|Removed |Added Attachment #118178|0 |1 is obsolete|| --- Comment #32 from Lund University Sandbox --- Created attachment 118183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118183=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #116922|0 |1 is obsolete|| --- Comment #31 from Emmi Takkinen --- Created attachment 118178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118178=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #116921|0 |1 is obsolete|| --- Comment #30 from Emmi Takkinen --- Created attachment 118177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118177=edit Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #116920|0 |1 is obsolete|| --- Comment #29 from Emmi Takkinen --- Created attachment 118176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118176=edit Bug 23415: Add missing filters Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #116919|0 |1 is obsolete|| --- Comment #28 from Emmi Takkinen --- Created attachment 118175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118175=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Stina Hallin changed: What|Removed |Added CC||stina.hal...@ub.lu.se Status|Needs Signoff |Patch doesn't apply --- Comment #27 from Stina Hallin --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/checkouts.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #109880|0 |1 is obsolete|| --- Comment #26 from Emmi Takkinen --- Created attachment 116922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116922=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #109876|0 |1 is obsolete|| --- Comment #25 from Emmi Takkinen --- Created attachment 116921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116921=edit Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #109872|0 |1 is obsolete|| --- Comment #24 from Emmi Takkinen --- Created attachment 116920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116920=edit Bug 23415: Add missing filters Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #109871|0 |1 is obsolete|| --- Comment #23 from Emmi Takkinen --- Created attachment 116919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116919=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Victoria Faafia changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||vfaafi...@gmail.com --- Comment #22 from Victoria Faafia --- Applying: Bug 23415: Notify patron fines when renewing Using index info to reconstruct a base tree... M circ/circulation.pl M circ/renew.pl M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt M koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt M koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt M koha-tmpl/intranet-tmpl/prog/js/checkouts.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/checkouts.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/checkouts.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging circ/renew.pl Auto-merging circ/circulation.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 23415: Notify patron fines when renewing The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-23415-Notify-patron-fines-when-renewing-AHlD9r.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #21 from Emmi Takkinen --- Rebased patches against current master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #108392|0 |1 is obsolete|| --- Comment #20 from Emmi Takkinen --- Created attachment 109880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109880=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #105893|0 |1 is obsolete|| --- Comment #19 from Emmi Takkinen --- Created attachment 109876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109876=edit Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #98997|0 |1 is obsolete|| --- Comment #18 from Emmi Takkinen --- Created attachment 109872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109872=edit Bug 23415: Add missing filters Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #98996|0 |1 is obsolete|| --- Comment #17 from Emmi Takkinen --- Created attachment 109871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109871=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #105894|0 |1 is obsolete|| --- Comment #16 from Emmi Takkinen --- Created attachment 108392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108392=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #15 from Emmi Takkinen --- Created attachment 105894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105894=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple holds and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has holds. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple holds (at least two) 2. Renew all holds from checkout list 3. Confirmation pop-up is displayed for every hold 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #14 from Emmi Takkinen --- Created attachment 105893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105893=edit Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #13 from Katrin Fischer ---
I am wondering if noissuecharge is the right value here.
We got:
OPACFineNoRenewals = fine limit for renewals in the OPAC, but nothing for staff
specifically.
noissuecharge = fine limit for checkouts (as name says). It's used in this
patch set, but there are other complications with this one:
noissuescharge
Prevent patrons from checking out books if they have more than EUR in fines.
HoldsInNoissuesCharge
[Don't include|Include] hold charges when summing up charges for
noissuescharge.
ManInvInNoissuesCharge
[Don't include|Include] custom debit type charges when summing up charges for
noissuescharge.
RentalsInNoissuesCharge
[Don't include|Include] rental charges when summing up charges for
noissuescharge.
NoIssuesChargeGuarantees
Prevent a patron from checking out if the patron has guarantees owing in total
more than EUR in fines.
So I think this is not covering it:
+ my $amountlimit = C4::Context->preference("noissuescharge");
+ var fines = "[% fines | html %]
We'd need the amount calculated taking all noissues* prefs into account.
I think I'd prefer not using noissuecharge here, as it only speaks of checkouts
and we have a distinct one for renewals. Using OPACFineNoRenewals would make
sense to me, as you can still override in the staff interface. So having a
'hint' there would work.
Also a little worried that this adds a confirm step - but as none of the
testers complained, I think it's probably ok :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Kelly McElligott changed: What|Removed |Added CC||ke...@bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 ByWater Sandboxes changed: What|Removed |Added Attachment #98634|0 |1 is obsolete|| --- Comment #12 from ByWater Sandboxes --- Created attachment 98997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98997=edit Bug 23415: Add missing filters Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
