[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Jonathan Druart changed: What|Removed |Added Blocks||29321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29321 [Bug 29321] Remove a last without loop context -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Martin Renvoize changed: What|Removed |Added Text to go in the|This enhancement allows a |This enhancement allows a release notes|library to configure the|library to configure the |visibility of the input |visibility of the input |fields on the OPAC |fields on the OPAC |suggestion form. |suggestion form. | | |**New |**New |system preference**:|system preference**: |`SuggestionsUnwantedFields` |`OPACSuggestionUnwantedFiel |**Removed system|ds` |preference**: |**Removed system |`AllowPurchaseSuggestionBra |preference**: |nchChoice` |`AllowPurchaseSuggestionBra ||nchChoice` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Martin Renvoize changed: What|Removed |Added Text to go in the|This enhancement allows a |This enhancement allows a release notes|library to configure the|library to configure the |visibility of the input |visibility of the input |fields on the OPAC |fields on the OPAC |suggestion form. |suggestion form. | | |New |**New |system preference: |system preference**: |`SuggestionsUnwantedFields` |`SuggestionsUnwantedFields` |Removed system preference: |**Removed system |`AllowPurchaseSuggestionBra |preference**: |nchChoice` |`AllowPurchaseSuggestionBra ||nchChoice` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Martin Renvoize changed: What|Removed |Added Text to go in the|This enhancement allows the |This enhancement allows a release notes|library to configure the|library to configure the |visibility of the input |visibility of the input |fields on the OPAC |fields on the OPAC |suggestion form. |suggestion form. | | |New |New |system preference: |system preference: |`SuggestionsUnwantedFields` |`SuggestionsUnwantedFields` |Removed system preference: |Removed system preference: |`AllowPurchaseSuggestionBra |`AllowPurchaseSuggestionBra |nchChoice` |nchChoice` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Text to go in the|The new system preference |This enhancement allows the release notes|SuggestionsUnwantedFields |library to configure the |allows you to configure the |visibility of the input |visibility of the input |fields on the OPAC |fields on the OPAC |suggestion form. |suggestion form. It | |replaces the|New |AllowPurchaseSuggestionBran |system preference: |chChoice system preference. |`SuggestionsUnwantedFields` ||Removed system preference: ||`AllowPurchaseSuggestionBra ||nchChoice` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #30 from Lucas Gass --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 David Nind changed: What|Removed |Added Text to go in the|The new system preference |The new system preference release notes|SuggestionsUnwantedFields |SuggestionsUnwantedFields |allows to configure the |allows you to configure the |visibility of the input |visibility of the input |fields on the suggestion|fields on the OPAC |form in the OPAC. It|suggestion form. It |replaces the|replaces the |AllowPurchaseSuggestionBran |AllowPurchaseSuggestionBran |chChoice system preference. |chChoice system preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #29 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #28 from Lucas Gass --- Created attachment 111254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111254=edit Bug 23420: (QA follow-up) Remove more AllowPurchaseSuggestionBranchChoice code Test plan: 1. git grep -i AllowPurchaseSuggestionBranchChoice **/*.pm **/*.pl **/*.t 2. There should no longer be any code related to the old sys pref AllowPurchaseSuggestionBranchChoice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
--- Comment #27 from Jonathan Druart
---
The pref is still used
% git grep -i AllowPurchaseSuggestionBranchChoice **/*.pm **/*.pl **/*.t
C4/UsageStats.pm:AllowPurchaseSuggestionBranchChoice
installer/data/mysql/updatedatabase.pl:$dbh->do("INSERT INTO
systempreferences (variable,value,explanation,options,type) VALUES
('AllowPurchaseSuggestionBranchChoice', 0, 'Allow user to choose branch when
making a purchase suggestion','1','YesNo')");
opac/opac-suggestions.pl:if (
C4::Context->preference("AllowPurchaseSuggestionBranchChoice") ) {
t/db_dependent/UsageStats.t:AllowPurchaseSuggestionBranchChoice
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Katrin Fischer changed: What|Removed |Added Text to go in the||The new system preference release notes||SuggestionsUnwantedFields ||allows to configure the ||visibility of the input ||fields on the suggestion ||form in the OPAC. It ||replaces the ||AllowPurchaseSuggestionBran ||chChoice system preference. --- Comment #26 from Katrin Fischer --- Thx for the follow-up, Lucas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Katrin Fischer changed: What|Removed |Added Attachment #110671|0 |1 is obsolete|| --- Comment #25 from Katrin Fischer --- Created attachment 110689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110689=edit Bug 23420: (QA follow-up) Remove AllowPurchaseSuggestionBranchChoice syspref Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Katrin Fischer changed: What|Removed |Added Attachment #110419|0 |1 is obsolete|| --- Comment #24 from Katrin Fischer --- Created attachment 110688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110688=edit Bug 23420: Add OPACSuggestionUnwantedFields system pref To test: -Apply patch -Check OPACSuggestionUnwantedFields -Check some fields as unwanted -Go to the OPAC suggestion page and make sure these correct fields are hidden -Turn on the system preference AllowPurchaseSuggestionBranchChoice to see the branch choice on the form -Make sure you can correctly hide this one and still submit the purchase suggestion for without error. -Go through each option and make sure it hides properly. Note: You will only see the patron reason field when there are authorised values in the OPAC_SUG category Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #23 from Lucas Gass --- Created attachment 110671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110671=edit Bug 23420: (QA follow-up) Remove AllowPurchaseSuggestionBranchChoice syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #22 from Katrin Fischer --- Hi Lucas, I feel like having 2 switches for the same thing (visibility of library ) can be confusing. Is there a reason we should not take the chance here to remove AllowPurchaseSuggestionBranchChoice in favor of the new pref? We could add a line to the databaseupdate to make the branch invisible if AllowPurchaseSuggestionBranchChoice is set to don't allow now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #21 from David Nind --- Thanks Lucas! I have retested and signed off. Everything works as expected now with AllowPurchaseSuggestionBranchChoice enabled. David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 David Nind changed: What|Removed |Added Attachment #110418|0 |1 is obsolete|| --- Comment #20 from David Nind --- Created attachment 110419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110419=edit Bug 23420: Add OPACSuggestionUnwantedFields system pref To test: -Apply patch -Check OPACSuggestionUnwantedFields -Check some fields as unwanted -Go to the OPAC suggestion page and make sure these correct fields are hidden -Turn on the system preference AllowPurchaseSuggestionBranchChoice to see the branch choice on the form -Make sure you can correctly hide this one and still submit the purchase suggestion for without error. -Go through each option and make sure it hides properly. Note: You will only see the patron reason field when there are authorised values in the OPAC_SUG category Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #19 from Lucas Gass --- I submitted a new patch with an updated test plan so I am switching this back to Needs Sign-off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Attachment #110414|0 |1 is obsolete|| --- Comment #18 from Lucas Gass --- Created attachment 110418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110418=edit Bug 23420: Add OPACSuggestionUnwantedFields system pref To test: -Apply patch -Check OPACSuggestionUnwantedFields -Check some fields as unwanted -Go to the OPAC suggestion page and make sure these correct fields are hidden -Turn on the system preference AllowPurchaseSuggestionBranchChoice to see the branch choice on the form -Make sure you can correctly hide this one and still submit the purchase suggestion for without error. -Go through each option and make sure it hides properly. Note: You will only see the patron reason field when there are authorised values in the OPAC_SUG category -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #17 from Lucas Gass --- (In reply to David Nind from comment #16) > The 'Library or branch' field doesn't seem to display at all. > > If no unwanted fields are selected, it doesn't display. > > When just it is unselected, it doesn't display either. > > All other fields can be displayed or not displayed. Hi David, Thanks for testing. The branch/library selection field will not show on the purchase suggestions form unless the system preference 'AllowPurchaseSuggestionBranchChoice' is set to allow. Also worth noting, the 'Patron Reason' field will only display when there are authorized values in the OPAC_SUG category. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Failed QA --- Comment #16 from David Nind --- The 'Library or branch' field doesn't seem to display at all. If no unwanted fields are selected, it doesn't display. When just it is unselected, it doesn't display either. All other fields can be displayed or not displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Attachment #108429|0 |1 is obsolete|| Attachment #108430|0 |1 is obsolete|| Attachment #109299|0 |1 is obsolete|| --- Comment #15 from Lucas Gass --- Created attachment 110414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110414=edit Bug 23420: Add OPACSuggestionUnwantedFields system pref To test: -Apply patch -Check OPACSuggestionUnwantedFields -Check some fields as unwanted -Go to the OPAC suggestion page and make sure these correct fields are hidden -Go through each option and make sure it hides properly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #14 from Lucas Gass --- this no longer clean applies, will rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #13 from Lucas Gass --- Created attachment 109299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109299=edit Bug 23420: (follow-up) remove title -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Owen Leonard changed: What|Removed |Added Blocks||26296 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 [Bug 26296] Use new table column selection modal for OPAC suggestion fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #12 from Owen Leonard --- Title is a mandatory field even if it isn't selected by OPACSuggestionMandatoryFields. I think that means it should be excluded from this preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #11 from Lucas Gass --- Probably this is a separate bug but OPACSuggestionMandatoryFields doesn't seem to have a spot in syspref.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #10 from Lucas Gass --- Also added a note with the sys pref to remind not to makeOPACSuggestionMandatoryFields unwanted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #9 from Lucas Gass --- Created attachment 108430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108430=edit Bug 23420: (QA follow-up) fix DB update and add syspref.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Attachment #107662|0 |1 is obsolete|| --- Comment #8 from Lucas Gass --- Created attachment 108429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108429=edit Bug 23420: Add OPACSuggestionUnwantedFields option To test: -Apply patch -Check OPACSuggestionUnwantedFields -Check some fields as unwanted -Go to the OPAC suggestion page and make sure these correct fields are hidden -Go through each option and make sure it hides properly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Attachment #108426|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Attachment #107662|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #7 from Katrin Fischer --- Usually the best way is adding a second patch was (QA follow-up) - then you can also switch back to signed off, because it makes it easy to see the additional changes. If there are too many, QA could send it back to Needs signoff, but in this case it would be fine. It also means the sign-off remains 'untouched' as the signed patch hasn't changed. (hope that makes sense, it's late!) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #6 from Lucas Gass --- Thanks Cait, I added a new patch, kept Lisette's sign-off, but reset the status to 'Needs Signoff'. Not sure what's appropriate here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Attachment #107787|0 |1 is obsolete|| --- Comment #5 from Lucas Gass --- Created attachment 108426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108426=edit Bug 23420: Add OPACSuggestionUnwantedFields option To test: -Apply patch -Check OPACSuggestionUnwantedFields -Check some fields as unwanted -Go to the OPAC suggestion page and make sure these correct fields are hidden -Go through each option and make sure it hides properly Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- Really like this, but 2 problems: - patch set is missing the change to sysprefs.sql - after updatedatabase is run, the title is hidden by default. The statement needs to be corrected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Katrin Fischer changed: What|Removed |Added Summary|Add |Add |"SuggestionsUnwantedFields" |"SuggestionsUnwantedFields" ||to hide fields from the ||suggestions form -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Lisette Scheer --- Worked great! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 ByWater Sandboxes changed: What|Removed |Added Attachment #107662|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 107787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107787=edit Bug 23420: Add OPACSuggestionUnwantedFields option To test: -Apply patch -Check OPACSuggestionUnwantedFields -Check some fields as unwanted -Go to the OPAC suggestion page and make sure these correct fields are hidden -Go through each option and make sure it hides properly Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #1 from Lucas Gass --- Created attachment 107662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107662=edit Bug 23420: Add OPACSuggestionUnwantedFields option To test: -Apply patch -Check OPACSuggestionUnwantedFields -Check some fields as unwanted -Go to the OPAC suggestion page and make sure these correct fields are hidden -Go through each option and make sure it hides properly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21329 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
