[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #89 from Jonathan Druart --- Created attachment 100804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100804=edit Bug 23590: Create a separate template notice NOTIFY_MANAGER To separate the two feature we want to create a distinct template notice. A new NOTIFY_MANAGER notice is added. A follow-up patch will be added for other languages, when this one will be approved by QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #86 from Jonathan Druart --- Created attachment 100801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100801=edit Bug 23590: remove unused variable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #88 from Jonathan Druart --- Created attachment 100803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100803=edit Bug 23590: Fix ergonomic issue if last modification by is empty -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #84 from Jonathan Druart --- Created attachment 100799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100799=edit Bug 23590: (QA follow-up) Add missing filters and drop script type Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #85 from Jonathan Druart --- Created attachment 100800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100800=edit Bug 23590: (QA follow-up) Fix some problems created by recent changes and updatedatabase statement - Ensure that the sequence of columns will be the same for new and updated installations (add AFTER ...) - Fix permissions (see bug 22868) - Fix column configuration (see 16784) - Remove '- ' displying before the date -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #87 from Jonathan Druart --- Created attachment 100802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100802=edit Bug 23590: Update new fields with relevant values We are filling lastmodificationdate and lastmodificationby depending on the max dates between manageddate, accepteddate and rejecteddate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #83 from Jonathan Druart --- Created attachment 100798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100798=edit Bug 23590: DBIC Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #79 from Jonathan Druart --- Created attachment 100794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100794=edit Bug 23590: Add lastmodification by and date columns No tests are provided for the changes made to SearchSuggestion. It is going to be remove very soon as it is super ugly... Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #81 from Jonathan Druart --- Created attachment 100796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100796=edit Bug 23590: Remove JS error on the suggestion list The notify option is only available from the edit view Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #82 from Jonathan Druart --- Created attachment 100797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100797=edit Bug 23590: Fix select manager on list for all tabs Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #80 from Jonathan Druart --- Created attachment 100795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100795=edit Bug 23590: Add atomic update file Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #78 from Jonathan Druart --- Created attachment 100793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100793=edit Bug 23590: Add the ability to notify a new manager Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #77 from Jonathan Druart --- Created attachment 100792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100792=edit Bug 23590: Only return patrons that have the suggestions_manage permission Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #76 from Jonathan Druart --- Created attachment 100791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100791=edit Bug 23590: Batch update manager for suggestions Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #75 from Jonathan Druart --- Created attachment 100790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100790=edit Bug 23590: Cleaning - Remove op_* vars Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart changed: What|Removed |Added Attachment #98119|0 |1 is obsolete|| Attachment #98120|0 |1 is obsolete|| Attachment #98121|0 |1 is obsolete|| Attachment #98122|0 |1 is obsolete|| Attachment #98123|0 |1 is obsolete|| Attachment #98124|0 |1 is obsolete|| Attachment #98126|0 |1 is obsolete|| Attachment #98127|0 |1 is obsolete|| Attachment #98128|0 |1 is obsolete|| Attachment #98129|0 |1 is obsolete|| Attachment #98130|0 |1 is obsolete|| Attachment #98131|0 |1 is obsolete|| Attachment #98240|0 |1 is obsolete|| Attachment #98268|0 |1 is obsolete|| Attachment #98279|0 |1 is obsolete|| --- Comment #73 from Jonathan Druart --- Created attachment 100788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100788=edit Bug 23590: Add ability to edit the manager of a suggestion Prior to this patch there was an hidden behavior that set the manager to the logged in user when a suggestion was edited. This patch proposes to let the librarian pick another manager. Other small adjustements will be added to polish this new behavior: * Create 2 new DB columns: suggestions.lastmodificationby and suggestion.lastmodificationdate * Choose a manager when editing a suggestion * Batch modify suggestions and set a manager for them * Let notify the new manager using the TO_PROCESS letter * Display the manageddate, lastmodificationby and lastmodificationdate info where appropriate This first patch adds a new "Select manager" link when editing a suggestion. Test plan for the whole patchset: 0/ a. Execute the update DB entry, generate the new DBIC file and restart all b. Create at least 2 patrons with the suggestions_manage permission 1/ Submit a new suggestion (OPAC or staff, not important) 2/ Accept it 3/ Edit it => "Last modification by" is empty => You see that you are the manager of this suggestion 4/ Click "Select manager" and search for a new manager => The patron search will only display patrons with the suggestions_manage permission 5/ Save 6/ Edit again => The manager is set to you, but there is a note saying that previously it was the patron you picked => The "Last modification by" is set to you 7/ Click "Keep existing manager" => The manager is now set to the previous manager 8/ Select another manager (which has a valid email address defined) 9/ Click the "notify" checkbox 10/ Save 11/ Confirm that a TO_PROCESS notice has been generated into the message_queue table 12/ Create at least one other suggestion 13/ List the suggestions => There is a 4th action column to assign a manager to several suggestions in one go. 14/ Use this new button and confirm that it works as expected 15/ Go to your purchase suggestion list (OPAC and staff) => You see the "managed date" displayed in a new column Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #74 from Jonathan Druart --- Created attachment 100789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100789=edit Bug 23590: Clean TT variables for patrons Just a bit of cleaning Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Bug 23590 depends on bug 23594, which changed state. Bug 23594 Summary: Batch modification for itemtypes on suggestions page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #72 from Jonathan Druart --- Created attachment 98279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98279=edit Bug 23590: remove unused variable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590
--- Comment #71 from Jonathan Druart
---
(In reply to Katrin Fischer from comment #69)
> Notes & questions
>
> 1) We might want to modify the bug title a little - in addition to allow
> changing the manager, this will also store the last person to change and
> date. Also gives a checkbox for TO_PROCESS. We really needs some release
> notes :)
Any suggestions? :)
> 2) lastmodificationdate and lastmodificationby are quite long. It might be
> nicer to used something more readable like: last_modified_on and
> last_modified_by. Not blocker for me, but putting the thought out there.
I followed the existing pattern As there were already 4 of those I thought it
was better to keep names consistent.
> 3) Is there a reason why we don't let the db update thelastmodificationdate?
We can pick the max date of suggesteddate, manageddate, accepteddate,
rejecteddate, is that was you have in mind?
> 4) Please check my follow-up
They look good, thanks!
> Blockers
>
> 1) When I change the manager, the lastmodification* are not updated.
That was expected (I think). The field lastmodification* are only updated when
the suggestion is edited via the edit form. If we want to update it whenever
the table is updated, the change must be moved to ModSuggestion.
Séverine, can you confirm the behavior you expect?
> 2) The TO_PROCESS email goes to the fund owner - this patch is reusing it
> for the manager. I believe this should be handled separately. ( Bug 13014:
> Notify budget owner on new suggestion - cronjob)
That was part of the original specification.
It makes sense to have 2 different notice templates. Something to suggest?
UPDATE_MANAGER, SUGGEST_MANAGER, TO_PROCESS_MANAGER?
> 3)
> +if ( $notify ) {
> +my $patron = Koha::Patrons->find(
> $suggestion_only->{managedby} );
> +my $email_address = $patron->notice_email_address;
> +if ($patron->notice_email_address) {
> +my $budget = C4::Budgets::GetBudget(
> $suggestion_only->{budgetid} );
> $budget appears not to be used - possibly a copy because of 2).
Indeed, follow-up coming.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #70 from Katrin Fischer --- I think it would have been nice to split this: - Add last modification* - Add ability to change manager - Add ability to notify - last bit could still be pulled out maybe -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590
--- Comment #69 from Katrin Fischer ---
Notes & questions
1) We might want to modify the bug title a little - in addition to allow
changing the manager, this will also store the last person to change and date.
Also gives a checkbox for TO_PROCESS. We really needs some release notes :)
2) lastmodificationdate and lastmodificationby are quite long. It might be
nicer to used something more readable like: last_modified_on and
last_modified_by. Not blocker for me, but putting the thought out there.
3) Is there a reason why we don't let the db update thelastmodificationdate?
4) Please check my follow-up
Blockers
1) When I change the manager, the lastmodification* are not updated.
2) The TO_PROCESS email goes to the fund owner - this patch is reusing it for
the manager. I believe this should be handled separately. ( Bug 13014: Notify
budget owner on new suggestion - cronjob)
3)
+if ( $notify ) {
+my $patron = Koha::Patrons->find(
$suggestion_only->{managedby} );
+my $email_address = $patron->notice_email_address;
+if ($patron->notice_email_address) {
+my $budget = C4::Budgets::GetBudget(
$suggestion_only->{budgetid} );
$budget appears not to be used - possibly a copy because of 2).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Attachment #98267|0 |1 is obsolete|| --- Comment #68 from Katrin Fischer --- Created attachment 98268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98268=edit Bug 23590: (QA follow-up) Fix some problems created by recent changes and updatedatabase statement - Ensure that the sequence of columns will be the same for new and updated installations (add AFTER ...) - Fix permissions (see bug 22868) - Fix column configuration (see 16784) - Remove '- ' displying before the date -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #67 from Katrin Fischer --- Created attachment 98267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98267=edit Bug 23590: (QA follow-up) Fix some problems created by recent changes and updatedatabase statement - Ensure that the sequence of columns will be the same for new and updated installations (add AFTER ...) - Fix permissions (see bug 22868) - Fix column configuration (see 16784) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | --- Comment #66 from Martin Renvoize --- Looks like Katrin is on the case here.. so just uploading a followup to silence the warning from the QA scripts and leaving Katrin to finish :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #65 from Martin Renvoize --- Created attachment 98240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98240=edit Bug 23590: (QA follow-up) Add missing filters and drop script type Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_target CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #63 from Jonathan Druart --- Created attachment 98130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98130=edit Bug 23590: Fix select manager on list for all tabs Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #64 from Jonathan Druart --- Created attachment 98131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98131=edit Bug 23590: DBIC Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #62 from Jonathan Druart --- Created attachment 98129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98129=edit Bug 23590: Remove JS error on the suggestion list The notify option is only available from the edit view Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #60 from Jonathan Druart --- Created attachment 98127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98127=edit Bug 23590: Add lastmodification by and date columns No tests are provided for the changes made to SearchSuggestion. It is going to be remove very soon as it is super ugly... Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #59 from Jonathan Druart --- Created attachment 98126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98126=edit Bug 23590: Display managed date in 'Your purchase suggestions' Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #61 from Jonathan Druart --- Created attachment 98128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98128=edit Bug 23590: Add atomic update file Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #58 from Jonathan Druart --- Created attachment 98124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98124=edit Bug 23590: Add the ability to notify a new manager Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #55 from Jonathan Druart --- Created attachment 98121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98121=edit Bug 23590: Cleaning - Remove op_* vars Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #57 from Jonathan Druart --- Created attachment 98123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98123=edit Bug 23590: Only return patrons that have the suggestions_manage permission Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #56 from Jonathan Druart --- Created attachment 98122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98122=edit Bug 23590: Batch update manager for suggestions Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #54 from Jonathan Druart --- Created attachment 98120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98120=edit Bug 23590: Clean TT variables for patrons Just a bit of cleaning Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart changed: What|Removed |Added Attachment #95487|0 |1 is obsolete|| Attachment #95488|0 |1 is obsolete|| Attachment #95489|0 |1 is obsolete|| Attachment #95490|0 |1 is obsolete|| Attachment #95491|0 |1 is obsolete|| Attachment #95492|0 |1 is obsolete|| Attachment #95493|0 |1 is obsolete|| Attachment #95494|0 |1 is obsolete|| Attachment #95495|0 |1 is obsolete|| Attachment #95496|0 |1 is obsolete|| Attachment #95497|0 |1 is obsolete|| Attachment #95498|0 |1 is obsolete|| --- Comment #53 from Jonathan Druart --- Created attachment 98119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98119=edit Bug 23590: Add ability to edit the manager of a suggestion Prior to this patch there was an hidden behavior that set the manager to the logged in user when a suggestion was edited. This patch proposes to let the librarian pick another manager. Other small adjustements will be added to polish this new behavior: * Create 2 new DB columns: suggestions.lastmodificationby and suggestion.lastmodificationdate * Choose a manager when editing a suggestion * Batch modify suggestions and set a manager for them * Let notify the new manager using the TO_PROCESS letter * Display the manageddate, lastmodificationby and lastmodificationdate info where appropriate This first patch adds a new "Select manager" link when editing a suggestion. Test plan for the whole patchset: 0/ a. Execute the update DB entry, generate the new DBIC file and restart all b. Create at least 2 patrons with the suggestions_manage permission 1/ Submit a new suggestion (OPAC or staff, not important) 2/ Accept it 3/ Edit it => "Last modification by" is empty => You see that you are the manager of this suggestion 4/ Click "Select manager" and search for a new manager => The patron search will only display patrons with the suggestions_manage permission 5/ Save 6/ Edit again => The manager is set to you, but there is a note saying that previously it was the patron you picked => The "Last modification by" is set to you 7/ Click "Keep existing manager" => The manager is now set to the previous manager 8/ Select another manager (which has a valid email address defined) 9/ Click the "notify" checkbox 10/ Save 11/ Confirm that a TO_PROCESS notice has been generated into the message_queue table 12/ Create at least one other suggestion 13/ List the suggestions => There is a 4th action column to assign a manager to several suggestions in one go. 14/ Use this new button and confirm that it works as expected 15/ Go to your purchase suggestion list (OPAC and staff) => You see the "managed date" displayed in a new column Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||katrin.fisc...@bsz-bw.de --- Comment #52 from Katrin Fischer --- Onto the next one... Jonathan, can you please rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Bug 23590 depends on bug 14963, which changed state. Bug 14963 Summary: Add the ability to suggest purchase from existing titles https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #51 from Liz Rea --- This still applies, QA? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart changed: What|Removed |Added Blocks||22784 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 [Bug 22784] Archiving Purchase Suggestions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #49 from Jonathan Druart --- Created attachment 95497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95497=edit Bug 23590: Fix select manager on list for all tabs Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #50 from Jonathan Druart --- Created attachment 95498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95498=edit Bug 23590: DBIC Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #48 from Jonathan Druart --- Created attachment 95496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95496=edit Bug 23590: Remove JS error on the suggestion list The notify option is only available from the edit view Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #45 from Jonathan Druart --- Created attachment 95493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95493=edit Bug 23590: Display managed date in 'Your purchase suggestions' Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #43 from Jonathan Druart --- Created attachment 95491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95491=edit Bug 23590: Only return patrons that have the suggestions_manage permission Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #46 from Jonathan Druart --- Created attachment 95494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95494=edit Bug 23590: Add lastmodification by and date columns No tests are provided for the changes made to SearchSuggestion. It is going to be remove very soon as it is super ugly... Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #44 from Jonathan Druart --- Created attachment 95492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95492=edit Bug 23590: Add the ability to notify a new manager Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #42 from Jonathan Druart --- Created attachment 95490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95490=edit Bug 23590: Batch update manager for suggestions Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #47 from Jonathan Druart --- Created attachment 95495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95495=edit Bug 23590: Add atomic update file Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #41 from Jonathan Druart --- Created attachment 95489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95489=edit Bug 23590: Cleaning - Remove op_* vars Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart changed: What|Removed |Added Attachment #95398|0 |1 is obsolete|| Attachment #95421|0 |1 is obsolete|| Attachment #95422|0 |1 is obsolete|| Attachment #95423|0 |1 is obsolete|| Attachment #95424|0 |1 is obsolete|| Attachment #95425|0 |1 is obsolete|| Attachment #95426|0 |1 is obsolete|| Attachment #95427|0 |1 is obsolete|| Attachment #95428|0 |1 is obsolete|| Attachment #95429|0 |1 is obsolete|| Attachment #95430|0 |1 is obsolete|| Attachment #95431|0 |1 is obsolete|| --- Comment #39 from Jonathan Druart --- Created attachment 95487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95487=edit Bug 23590: Add ability to edit the manager of a suggestion Prior to this patch there was an hidden behavior that set the manager to the logged in user when a suggestion was edited. This patch proposes to let the librarian pick another manager. Other small adjustements will be added to polish this new behavior: * Create 2 new DB columns: suggestions.lastmodificationby and suggestion.lastmodificationdate * Choose a manager when editing a suggestion * Batch modify suggestions and set a manager for them * Let notify the new manager using the TO_PROCESS letter * Display the manageddate, lastmodificationby and lastmodificationdate info where appropriate This first patch adds a new "Select manager" link when editing a suggestion. Test plan for the whole patchset: 0/ a. Execute the update DB entry, generate the new DBIC file and restart all b. Create at least 2 patrons with the suggestions_manage permission 1/ Submit a new suggestion (OPAC or staff, not important) 2/ Accept it 3/ Edit it => "Last modification by" is empty => You see that you are the manager of this suggestion 4/ Click "Select manager" and search for a new manager => The patron search will only display patrons with the suggestions_manage permission 5/ Save 6/ Edit again => The manager is set to you, but there is a note saying that previously it was the patron you picked => The "Last modification by" is set to you 7/ Click "Keep existing manager" => The manager is now set to the previous manager 8/ Select another manager (which has a valid email address defined) 9/ Click the "notify" checkbox 10/ Save 11/ Confirm that a TO_PROCESS notice has been generated into the message_queue table 12/ Create at least one other suggestion 13/ List the suggestions => There is a 4th action column to assign a manager to several suggestions in one go. 14/ Use this new button and confirm that it works as expected 15/ Go to your purchase suggestion list (OPAC and staff) => You see the "managed date" displayed in a new column Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #40 from Jonathan Druart --- Created attachment 95488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95488=edit Bug 23590: Clean TT variables for patrons Just a bit of cleaning Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #19 from Séverine Queune --- Hi Jonathan, After I apply the patches, none of my suggestions are displayed. Do you know where it can come from ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #21 from Jonathan Druart --- Created attachment 95399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95399=edit Bug 23590: Remove JS error on the suggestion list The notify option is only available from the edit view -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #26 from Jonathan Druart --- Created attachment 95420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95420=edit Bug 23590: DBIC Changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #22 from Séverine Queune --- On step 8-9 : when I select a new manager, the checkbox to notify stays disabled even if there is a valid email (I didn't notice that point on my first tests and I correctly received an email at that moment, but I can't reproduce it on my second tests) On step 14 : the pop-up to select the new manager for several suggestions only works on the first "Accepted" tab On step 15 : I don't see the "managed date" on OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune changed: What|Removed |Added Attachment #95408|0 |1 is obsolete|| --- Comment #36 from Séverine Queune --- Created attachment 95430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95430=edit Bug 23590: Fix select manager on list for all tabs Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune changed: What|Removed |Added Attachment #95317|0 |1 is obsolete|| --- Comment #27 from Séverine Queune --- Created attachment 95421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95421=edit Bug 23590: Add ability to edit the manager of a suggestion Prior to this patch there was an hidden behavior that set the manager to the logged in user when a suggestion was edited. This patch proposes to let the librarian pick another manager. Other small adjustements will be added to polish this new behavior: * Create 2 new DB columns: suggestions.lastmodificationby and suggestion.lastmodificationdate * Choose a manager when editing a suggestion * Batch modify suggestions and set a manager for them * Let notify the new manager using the TO_PROCESS letter * Display the manageddate, lastmodificationby and lastmodificationdate info where appropriate This first patch adds a new "Select manager" link when editing a suggestion. Test plan for the whole patchset: 0/ a. Execute the update DB entry, generate the new DBIC file and restart all b. Create at least 2 patrons with the suggestions_manage permission 1/ Submit a new suggestion (OPAC or staff, not important) 2/ Accept it 3/ Edit it => "Last modification by" is empty => You see that you are the manager of this suggestion 4/ Click "Select manager" and search for a new manager => The patron search will only display patrons with the suggestions_manage permission 5/ Save 6/ Edit again => The manager is set to you, but there is a note saying that previously it was the patron you picked => The "Last modification by" is set to you 7/ Click "Keep existing manager" => The manager is now set to the previous manager 8/ Select another manager (which has a valid email address defined) 9/ Click the "notify" checkbox 10/ Save 11/ Confirm that a TO_PROCESS notice has been generated into the message_queue table 12/ Create at least one other suggestion 13/ List the suggestions => There is a 4th action column to assign a manager to several suggestions in one go. 14/ Use this new button and confirm that it works as expected 15/ Go to your purchase suggestion list (OPAC and staff) => You see the "managed date" displayed in a new column Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune changed: What|Removed |Added Attachment #95322|0 |1 is obsolete|| --- Comment #32 from Séverine Queune --- Created attachment 95426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95426=edit Bug 23590: Add the ability to notify a new manager Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune changed: What|Removed |Added Attachment #95323|0 |1 is obsolete|| --- Comment #33 from Séverine Queune --- Created attachment 95427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95427=edit Bug 23590: Display managed date in 'Your purchase suggestions' Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune changed: What|Removed |Added Attachment #95321|0 |1 is obsolete|| --- Comment #31 from Séverine Queune --- Created attachment 95425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95425=edit Bug 23590: Only return patrons that have the suggestions_manage permission Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune changed: What|Removed |Added Attachment #95407|0 |1 is obsolete|| --- Comment #35 from Séverine Queune --- Created attachment 95429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95429=edit Bug 23590: Remove JS error on the suggestion list The notify option is only available from the edit view Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune changed: What|Removed |Added Attachment #95420|0 |1 is obsolete|| --- Comment #37 from Séverine Queune --- Created attachment 95431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95431=edit Bug 23590: DBIC Changes Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune changed: What|Removed |Added Attachment #95320|0 |1 is obsolete|| --- Comment #30 from Séverine Queune --- Created attachment 95424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95424=edit Bug 23590: Batch update manager for suggestions Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart changed: What|Removed |Added Attachment #95399|0 |1 is obsolete|| --- Comment #23 from Jonathan Druart --- Created attachment 95407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95407=edit Bug 23590: Remove JS error on the suggestion list The notify option is only available from the edit view -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #24 from Jonathan Druart --- Created attachment 95408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95408=edit Bug 23590: Fix select manager on list for all tabs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune changed: What|Removed |Added Attachment #95324|0 |1 is obsolete|| --- Comment #34 from Séverine Queune --- Created attachment 95428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95428=edit Bug 23590: Add lastmodification by and date columns No tests are provided for the changes made to SearchSuggestion. It is going to be remove very soon as it is super ugly... Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune changed: What|Removed |Added Attachment #95319|0 |1 is obsolete|| --- Comment #29 from Séverine Queune --- Created attachment 95423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95423=edit Bug 23590: Cleaning - Remove op_* vars Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #25 from Jonathan Druart --- (In reply to Séverine Queune from comment #22) > On step 8-9 : when I select a new manager, the checkbox to notify stays > disabled even if there is a valid email (I didn't notice that point on my > first tests and I correctly received an email at that moment, but I can't > reproduce it on my second tests) Fixed > On step 14 : the pop-up to select the new manager for several suggestions > only works on the first "Accepted" tab And fixed! > On step 15 : I don't see the "managed date" on OPAC Looks ok for me: https://snipboard.io/KZ9bQS.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #38 from Séverine Queune --- Great development, thanks a lot Jonathan ! (In reply to Jonathan Druart from comment #25) > > On step 15 : I don't see the "managed date" on OPAC > > Looks ok for me: https://snipboard.io/KZ9bQS.jpg My bad, OpacSuggestionManagedBy needs to be enabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune changed: What|Removed |Added Attachment #95318|0 |1 is obsolete|| --- Comment #28 from Séverine Queune --- Created attachment 95422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95422=edit Bug 23590: Clean TT variables for patrons Just a bit of cleaning Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #20 from Jonathan Druart --- Created attachment 95398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95398=edit Bug 23590: Add atomic update file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #17 from Jonathan Druart --- Created attachment 95323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95323=edit Bug 23590: Display managed date in 'Your purchase suggestions' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #15 from Jonathan Druart --- Created attachment 95321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95321=edit Bug 23590: Only return patrons that have the suggestions_manage permission -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #16 from Jonathan Druart --- Created attachment 95322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95322=edit Bug 23590: Add the ability to notify a new manager -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #18 from Jonathan Druart --- Created attachment 95324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95324=edit Bug 23590: Add lastmodification by and date columns No tests are provided for the changes made to SearchSuggestion. It is going to be remove very soon as it is super ugly... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #13 from Jonathan Druart --- Created attachment 95319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95319=edit Bug 23590: Cleaning - Remove op_* vars -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #12 from Jonathan Druart --- Created attachment 95318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95318=edit Bug 23590: Clean TT variables for patrons Just a bit of cleaning -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #14 from Jonathan Druart --- Created attachment 95320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95320=edit Bug 23590: Batch update manager for suggestions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart changed: What|Removed |Added Attachment #95162|0 |1 is obsolete|| Attachment #95163|0 |1 is obsolete|| Attachment #95164|0 |1 is obsolete|| Attachment #95165|0 |1 is obsolete|| Attachment #95166|0 |1 is obsolete|| Attachment #95167|0 |1 is obsolete|| Attachment #95168|0 |1 is obsolete|| Attachment #95169|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 95317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95317=edit Bug 23590: Add ability to edit the manager of a suggestion Prior to this patch there was an hidden behavior that set the manager to the logged in user when a suggestion was edited. This patch proposes to let the librarian pick another manager. Other small adjustements will be added to polish this new behavior: * Create 2 new DB columns: suggestions.lastmodificationby and suggestion.lastmodificationdate * Choose a manager when editing a suggestion * Batch modify suggestions and set a manager for them * Let notify the new manager using the TO_PROCESS letter * Display the manageddate, lastmodificationby and lastmodificationdate info where appropriate This first patch adds a new "Select manager" link when editing a suggestion. Test plan for the whole patchset: 0/ a. Execute the update DB entry, generate the new DBIC file and restart all b. Create at least 2 patrons with the suggestions_manage permission 1/ Submit a new suggestion (OPAC or staff, not important) 2/ Accept it 3/ Edit it => "Last modification by" is empty => You see that you are the manager of this suggestion 4/ Click "Select manager" and search for a new manager => The patron search will only display patrons with the suggestions_manage permission 5/ Save 6/ Edit again => The manager is set to you, but there is a note saying that previously it was the patron you picked => The "Last modification by" is set to you 7/ Click "Keep existing manager" => The manager is now set to the previous manager 8/ Select another manager (which has a valid email address defined) 9/ Click the "notify" checkbox 10/ Save 11/ Confirm that a TO_PROCESS notice has been generated into the message_queue table 12/ Create at least one other suggestion 13/ List the suggestions => There is a 4th action column to assign a manager to several suggestions in one go. 14/ Use this new button and confirm that it works as expected 15/ Go to your purchase suggestion list (OPAC and staff) => You see the "managed date" displayed in a new column -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff URL||https://gitlab.com/joubu/Ko ||ha/commits/bug_23590 --- Comment #10 from Jonathan Druart --- The patches need to be applied in the following (reverse) order: Bug 23590: Add lastmodification by and date columns Bug 23590: Display managed date in 'Your purchase suggestions' Bug 23590: Add the ability to notify a new manager Bug 23590: Only return patrons that have the suggestions_manage permission Bug 23590: Batch update manager for suggestions Bug 23590: Cleaning - Remove op_* vars Bug 23590: Clean TT variables for patrons Bug 23590: Add ability to edit the manager of a suggestion Bug 14963: Set status=ORDERED for suggestions created from existing record Bug 14963: Add the ability to suggest purchase on existing title Bug 23854: Fix failure on dates when editing a suggestion Bug 23594: Restore previous view after delete or update itemtype Bug 23594: Fix [un]checkall links Bug 23594: Batch modification for itemtypes on suggestions page Bug 14973: Add missing filters in templates Bug 14973: Remove double declaration of suggestions_loop Bug 14973: Remove double textarea for notes Bug 14973: Do not skip validation step when submiting a suggestion - OPAC Bug 14973: Check existing biblio when submitting a purchase suggestion (staff side) Bug 14973: Check existing biblio when submitting a purchase suggestion (opac side) If it can help, I have pushed a branch with all the patches applied: https://gitlab.com/joubu/Koha/commits/bug_23590 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Séverine Queune --- Patch failed on both sandbox and devbox. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23590: Add ability to edit the manager of a suggestion fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 23590: Add ability to edit the manager of a suggestion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart changed: What|Removed |Added Blocks||23991 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 [Bug 23991] Move SearchSuggestion to Koha::Suggestions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #8 from Jonathan Druart --- Created attachment 95169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95169=edit Bug 23590: Add lastmodification by and date columns No tests are provided for the changes made to SearchSuggestion. It is going to be remove very soon as it is super ugly... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #6 from Jonathan Druart --- Created attachment 95167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95167=edit Bug 23590: Add the ability to notify a new manager -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #7 from Jonathan Druart --- Created attachment 95168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95168=edit Bug 23590: Display managed date in 'Your purchase suggestions' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #3 from Jonathan Druart --- Created attachment 95164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95164=edit Bug 23590: Cleaning - Remove op_* vars -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #4 from Jonathan Druart --- Created attachment 95165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95165=edit Bug 23590: Batch update manager for suggestions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #5 from Jonathan Druart --- Created attachment 95166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95166=edit Bug 23590: Only return patrons that have the suggestions_manage permission -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #2 from Jonathan Druart --- Created attachment 95163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95163=edit Bug 23590: Clean TT variables for patrons Just a bit of cleaning -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #1 from Jonathan Druart --- Created attachment 95162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95162=edit Bug 23590: Add ability to edit the manager of a suggestion Prior to this patch there was an hidden behavior that set the manager to the logged in user when a suggestion was edited. This patch proposes to let the librarian pick another manager. Other small adjustements will be added to polish this new behavior: * Create 2 new DB columns: suggestions.lastmodificationby and suggestion.lastmodificationdate * Choose a manager when editing a suggestion * Batch modify suggestions and set a manager for them * Let notify the new manager using the TO_PROCESS letter * Display the manageddate, lastmodificationby and lastmodificationdate info where appropriate This first patch adds a new "Select manager" link when editing a suggestion. Test plan for the whole patchset: 0/ a. Execute the update DB entry, generate the new DBIC file and restart all b. Create at least 2 patrons with the suggestions_manage permission 1/ Submit a new suggestion (OPAC or staff, not important) 2/ Accept it 3/ Edit it => "Last modification by" is empty => You see that you are the manager of this suggestion 4/ Click "Select manager" and search for a new manager => The patron search will only display patrons with the suggestions_manage permission 5/ Save 6/ Edit again => The manager is set to you, but there is a note saying that previously it was the patron you picked => The "Last modification by" is set to you 7/ Click "Keep existing manager" => The manager is now set to the previous manager 8/ Select another manager (which has a valid email address defined) 9/ Click the "notify" checkbox 10/ Save 11/ Confirm that a TO_PROCESS notice has been generated into the message_queue table 12/ Create at least one other suggestion 13/ List the suggestions => There is a 4th action column to assign a manager to several suggestions in one go. 14/ Use this new button and confirm that it works as expected 15/ Go to your purchase suggestion list (OPAC and staff) => You see the "managed date" displayed in a new column -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart changed: What|Removed |Added Depends on||14963, 23594, 23854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 [Bug 14963] Ability to suggest purchase on existing catalogue record https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 [Bug 23594] Batch modification for itemtypes on suggestions page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 [Bug 23854] Cannot edit a suggestion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
