[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 --- Comment #13 from Katrin Fischer --- (In reply to David Cook from comment #12) > Hmm I don't know if this is working in newer versions... I've filed a new bug report after testing this in master: Bug 31294 - Article requests: Mandatory subfields in OPAC don't show they are required The visual is missing, bit it complains when saving. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #12 from David Cook --- Hmm I don't know if this is working in newer versions... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable --- Comment #11 from Lucas Gass --- backported to 18.11.x for 18.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||fridolin.som...@biblibre.co ||m Version(s)|19.11.00|19.11.00,19.05.05 released in|| --- Comment #10 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 --- Comment #9 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 Marcel de Rooy changed: What|Removed |Added Attachment #92924|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 93183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93183=edit Bug 23625: Make new 'required' attributes match the currently used syntax in other templates Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 Marcel de Rooy changed: What|Removed |Added Attachment #92923|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 93182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93182=edit Bug 23625: ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required Test plan: 1. Enable article requests ( syspref: ArticleRequests => Enable, Circ and fine rules ALL/ALL (or a given category/itemtype): Article requests => Yes ) 2. Set one or more fields to require in the ArticleRequestsMandatoryFields, ArticleRequestsMandatoryFieldsItemOnly, and/or ArticleRequestsMandatoryFieldsRecordOnly settings (all these settings are affected in the same manner) 3. Search for a title and select the "Request Article" button from the OPAC search results 4. Authenticate as a patron 5. Neglect to fill out at least one of the mandatory fields 6. Select the "Place Request" button at the bottom of the form 7. The form submits despite the empty mandatory fields 8. Apply patch 9. Repeat steps 3, 5, & 6 10 . The form should refuse to submit, show a browser-native message about the missing required fields. Sponsored-by: California College of the Arts Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |ephettepl...@cca.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 --- Comment #6 from Kyle M Hall --- Created attachment 92924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92924=edit Bug 23625: Make new 'required' attributes match the currently used syntax in other templates Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 Kyle M Hall changed: What|Removed |Added Attachment #92922|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 92923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92923=edit Bug 23625: ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required Test plan: 1. Enable article requests ( syspref: ArticleRequests => Enable, Circ and fine rules ALL/ALL (or a given category/itemtype): Article requests => Yes ) 2. Set one or more fields to require in the ArticleRequestsMandatoryFields, ArticleRequestsMandatoryFieldsItemOnly, and/or ArticleRequestsMandatoryFieldsRecordOnly settings (all these settings are affected in the same manner) 3. Search for a title and select the "Request Article" button from the OPAC search results 4. Authenticate as a patron 5. Neglect to fill out at least one of the mandatory fields 6. Select the "Place Request" button at the bottom of the form 7. The form submits despite the empty mandatory fields 8. Apply patch 9. Repeat steps 3, 5, & 6 10 . The form should refuse to submit, show a browser-native message about the missing required fields. Sponsored-by: California College of the Arts Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 Kyle M Hall changed: What|Removed |Added Attachment #92846|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 92922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92922=edit Bug 23625: Make new 'required' attributes match the currently used syntax in other templates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 --- Comment #3 from Eric Phetteplace --- I created a patch sticking closely to what the template already looked like. But I do wonder if incredibly repetitive templating like this isn't better as a loop: [% FOREACH field IN ['title', 'author', 'volume', 'issue', 'date', 'pages' , 'chapters'] %] [% IF mandatory_fields.search(field) %] [% field FILTER ucfirst %]: [% ELSE %] [% field FILTER ucfirst %]: [% END %] [% END %] Is there a reason that pattern isn't used here? Does it not play well with internationalization? I don't know template toolkit that well so forgive me if it doesn't work, I'm just speculating based on reading some documentation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 Eric Phetteplace changed: What|Removed |Added Change sponsored?|--- |Sponsored Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 --- Comment #2 from Eric Phetteplace --- Created attachment 92846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92846=edit Bug 23625: ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625
--- Comment #1 from Eric Phetteplace ---
If it's useful for others, we're using the following snippet in OPACUserJS to
work around this bug:
https://github.com/cca/koha_snippets/blob/master/catalog-js/opac-request-article.js
// fields made mandatory in settings only have with a "required" class
// we need to make their corresponding inputs required, too
if (location.pathname.match('/cgi-bin/koha/opac-request-article.pl')) {
$('#place-article-request label.required').each((idx, el) => {
let input = $(el).attr('for')
$(`#${input}`).prop('required', true)
})
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
