[Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|19.11.00|19.11.00,19.05.05 released in|| --- Comment #13 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822
--- Comment #12 from Jonathan Druart
---
(In reply to Fridolin SOMERS from comment #11)
> Shouldn't we also fix the other line :
> if ( $op eq 'delete_confirm' or $countissues > 0 or $charges or
> $is_guarantor ) {
Maybe, we are going to follow-up on bug 24008 anyway.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822
--- Comment #11 from Fridolin SOMERS ---
Shouldn't we also fix the other line :
if ( $op eq 'delete_confirm' or $countissues > 0 or $charges or $is_guarantor )
{
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 --- Comment #10 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Katrin Fischer changed: What|Removed |Added Attachment #95327|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 95388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95388=edit Bug 23822: Fix deletion of patrons with credit There are bugs in both master and 19.05, but different. Anyway we should have this check to make sure a negative value will have the same behavior: trigger the confirmation message (instead of a blank page). If we want to reject the deletion of a patron with credit we should handle it on a separate bug report (behavior change) Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #8 from Martin Renvoize --- A simple patch that restores the original behaviour... Signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Martin Renvoize changed: What|Removed |Added Attachment #95254|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 95327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95327=edit Bug 23822: Fix deletion of patrons with credit There are bugs in both master and 19.05, but different. Anyway we should have this check to make sure a negative value will have the same behavior: trigger the confirmation message (instead of a blank page). If we want to reject the deletion of a patron with credit we should handle it on a separate bug report (behavior change) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Martin Renvoize changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 --- Comment #6 from Martin Renvoize --- Updated the bug title to reflect the impact of the change and Jonathans bugfix.. Cloned the original bug to bug 24008 to record the enhancement request to add blocking of patron deletions if outstanding credits are found and additional warnings as this is an additional workflow that needs implementing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Martin Renvoize changed: What|Removed |Added Summary|No warning is produced when |Regression: As of 19.05.04 |trying to delete a patron |deletion of patrons with |with credit (patron is not |outstanding credits is |deleted)|silently blocked -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
